| openstackgerrit | zhongshengping proposed openstack/puppet-placement master: Fix FIXME https://review.openstack.org/625463 | 02:40 |
|---|---|---|
| openstackgerrit | Merged openstack/puppet-placement master: Fix FIXME https://review.openstack.org/625463 | 02:57 |
| openstackgerrit | zhongshengping proposed openstack/puppet-glare master: Fix the port of endpoint https://review.openstack.org/625468 | 03:33 |
| *** PagliaccisCloud has quit IRC | 03:37 | |
| *** ykarel has joined #puppet-openstack | 03:43 | |
| openstackgerrit | zhongshengping proposed openstack/puppet-senlin master: Fix the port of endpoint https://review.openstack.org/625470 | 03:43 |
| openstackgerrit | zhongshengping proposed openstack/puppet-aodh master: Fix service_type annotation https://review.openstack.org/625472 | 03:45 |
| openstackgerrit | zhongshengping proposed openstack/puppet-cloudkitty master: Fix serivce_type annotation https://review.openstack.org/625473 | 03:47 |
| openstackgerrit | zhongshengping proposed openstack/puppet-gnocchi master: Fix service_type annotation https://review.openstack.org/625474 | 03:47 |
| openstackgerrit | zhongshengping proposed openstack/puppet-panko master: Fix service_type annotation https://review.openstack.org/625475 | 03:48 |
| openstackgerrit | zhongshengping proposed openstack/puppet-watcher master: Fix service_type annotation https://review.openstack.org/625476 | 03:49 |
| *** ykarel has quit IRC | 04:40 | |
| *** PagliaccisCloud has joined #puppet-openstack | 04:48 | |
| *** ykarel has joined #puppet-openstack | 05:01 | |
| *** ykarel has quit IRC | 05:10 | |
| *** ykarel has joined #puppet-openstack | 05:12 | |
| *** janki has joined #puppet-openstack | 05:36 | |
| *** rcernin has joined #puppet-openstack | 05:46 | |
| *** markvoelker has joined #puppet-openstack | 05:47 | |
| *** rcernin has quit IRC | 05:47 | |
| *** markvoelker has quit IRC | 05:51 | |
| *** rcernin has joined #puppet-openstack | 06:09 | |
| *** rcernin has quit IRC | 06:09 | |
| *** rcernin has joined #puppet-openstack | 06:09 | |
| *** rcernin has quit IRC | 06:09 | |
| openstackgerrit | zhongshengping proposed openstack/puppet-aodh master: keystone/auth: make service description configurable https://review.openstack.org/625490 | 06:12 |
| openstackgerrit | zhongshengping proposed openstack/puppet-barbican master: keystone/auth: make service description configurable https://review.openstack.org/625492 | 06:18 |
| openstackgerrit | zhongshengping proposed openstack/puppet-heat master: keystone/auth: make service description configurable https://review.openstack.org/625494 | 06:22 |
| openstackgerrit | zhongshengping proposed openstack/puppet-magnum master: keystone/auth: make service description configurable https://review.openstack.org/625496 | 06:26 |
| openstackgerrit | zhongshengping proposed openstack/puppet-octavia master: keystone/auth: make service description configurable https://review.openstack.org/625497 | 06:28 |
| openstackgerrit | zhongshengping proposed openstack/puppet-vitrage master: keystone/auth: make service description configurable https://review.openstack.org/625498 | 06:32 |
| *** agurenko has joined #puppet-openstack | 06:41 | |
| *** mschuppert has joined #puppet-openstack | 07:12 | |
| *** dpawlik has joined #puppet-openstack | 07:26 | |
| *** jtomasek has joined #puppet-openstack | 07:33 | |
| *** jpena|off is now known as jpena | 07:42 | |
| *** pgaxatte has joined #puppet-openstack | 07:44 | |
| *** markvoelker has joined #puppet-openstack | 07:48 | |
| *** ykarel is now known as ykarel|lunch | 07:58 | |
| *** rpittau has joined #puppet-openstack | 07:58 | |
| *** skramaja has joined #puppet-openstack | 08:04 | |
| *** jpena is now known as jpena|away | 08:21 | |
| *** gfidente has joined #puppet-openstack | 08:38 | |
| *** ykarel|lunch is now known as ykarel | 08:39 | |
| *** agurenko has quit IRC | 08:50 | |
| *** skramaja_ has joined #puppet-openstack | 08:53 | |
| *** skramaja has quit IRC | 08:53 | |
| *** agurenko has joined #puppet-openstack | 09:00 | |
| *** agurenko has quit IRC | 09:01 | |
| *** shardy has joined #puppet-openstack | 09:04 | |
| *** skramaja_ is now known as skramaja | 09:13 | |
| *** agurenko has joined #puppet-openstack | 09:17 | |
| *** owalsh_ is now known as owalsh | 09:24 | |
| *** chem has joined #puppet-openstack | 09:26 | |
| *** derekh has joined #puppet-openstack | 09:58 | |
| *** PagliaccisCloud has quit IRC | 10:02 | |
| *** PagliaccisCloud has joined #puppet-openstack | 10:10 | |
| *** jpena|away is now known as jpena | 10:12 | |
| *** PagliaccisCloud has quit IRC | 10:21 | |
| *** salmankhan has joined #puppet-openstack | 10:25 | |
| janki | Hi. Can I get some reviews for cherry-pick https://review.openstack.org/#/c/620013/ | 10:36 |
| *** derekh has quit IRC | 10:46 | |
| *** derekh has joined #puppet-openstack | 10:47 | |
| *** salmankhan1 has joined #puppet-openstack | 10:52 | |
| *** salmankhan has quit IRC | 10:54 | |
| *** salmankhan1 is now known as salmankhan | 10:54 | |
| openstackgerrit | Merged openstack/puppet-neutron master: Deprecate pki related options https://review.openstack.org/619426 | 11:07 |
| *** tobias-urdin has joined #puppet-openstack | 11:32 | |
| *** PagliaccisCloud has joined #puppet-openstack | 11:33 | |
| *** rpittau is now known as rpittau|lunch | 12:09 | |
| *** PagliaccisCloud has quit IRC | 12:23 | |
| *** jpena is now known as jpena|lunch | 12:30 | |
| *** janki has quit IRC | 12:31 | |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-neutron master: Remove auth_uri https://review.openstack.org/620744 | 12:43 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-neutron master: Add www_authenticate_uri to plumgrid plugin https://review.openstack.org/620894 | 12:43 |
| *** vnogin has joined #puppet-openstack | 12:49 | |
| *** agurenko has quit IRC | 12:57 | |
| *** janki has joined #puppet-openstack | 12:59 | |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: Fix ironic lint https://review.openstack.org/625587 | 13:01 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: Fix lint jobs not reporting error https://review.openstack.org/624989 | 13:02 |
| *** markvoelker has quit IRC | 13:05 | |
| *** rpittau|lunch is now known as rpittau | 13:11 | |
| *** jpena|lunch is now known as jpena | 13:27 | |
| *** vnogin has quit IRC | 13:39 | |
| *** skramaja has quit IRC | 14:02 | |
| *** vnogin has joined #puppet-openstack | 14:02 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/puppet-manila master: Updating nova and neutron configuration https://review.openstack.org/616698 | 14:18 |
| *** mmethot has joined #puppet-openstack | 14:22 | |
| openstackgerrit | yatin proposed openstack/puppet-openstack-integration master: [DNM] Test scenarios with Fedora ssl disabled https://review.openstack.org/625613 | 14:38 |
| *** beekneemech is now known as bnemec | 15:00 | |
| *** vnogin has quit IRC | 15:05 | |
| *** vnogin has joined #puppet-openstack | 15:05 | |
| *** dpawlik has quit IRC | 15:17 | |
| *** dpawlik has joined #puppet-openstack | 15:18 | |
| *** dpawlik has quit IRC | 15:18 | |
| *** derekh has quit IRC | 15:24 | |
| *** ykarel is now known as ykarel|away | 15:26 | |
| openstackgerrit | yatin proposed openstack/puppet-openstack-integration master: [DNM] Test scenarios with Fedora ssl disabled https://review.openstack.org/625613 | 15:27 |
| *** derekh has joined #puppet-openstack | 15:27 | |
| *** ykarel|away has quit IRC | 15:35 | |
| *** andreww has joined #puppet-openstack | 15:39 | |
| mwhahaha | looks like nova unit tesst are broken | 15:39 |
| mwhahaha | will have to look into that | 15:39 |
| *** xarses_ has quit IRC | 15:42 | |
| tobias-urdin | mwhahaha: saw the same for neutron, seems like the PKI token removal in keystone::auth/authtoken passed testing but broke tests after merge | 15:43 |
| mwhahaha | it's likely that we're testing the keystone settings in those modules | 15:44 |
| mwhahaha | rather than the calling | 15:44 |
| *** ykarel|away has joined #puppet-openstack | 15:52 | |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-keystone master: Remove auth_uri https://review.openstack.org/620740 | 15:57 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-sahara master: Remove deprecated parameters https://review.openstack.org/620808 | 16:00 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-sahara master: Deprecate ZeroMQ https://review.openstack.org/621568 | 16:00 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-keystone master: Remove port 35357 deployment https://review.openstack.org/619257 | 16:04 |
| *** janki has quit IRC | 16:05 | |
| *** ykarel|away is now known as ykarel | 16:12 | |
| tobias-urdin | mwhahaha: yeah that should be fixed now, just recheck that stuff, the pki change in keystone is merged and if the associated pki change is merged in nova module just recheck | 16:28 |
| mwhahaha | probably needs a rebase | 16:28 |
| tobias-urdin | yeah | 16:28 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-neutron master: Use puppet4 functions-api https://review.openstack.org/614246 | 16:29 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-nova master: Use puppet4 functions-api https://review.openstack.org/614241 | 16:30 |
| tobias-urdin | mwhahaha: could you go through when you have time, and i'll make sure they get merged | 16:34 |
| tobias-urdin | https://review.openstack.org/#/q/project:%255Eopenstack/puppet%255C-.*+is:open+owner:%22Tobias+Urdin%22+label:Verified%253E0+label:Workflow%253D0 | 16:35 |
| mwhahaha | sure | 16:35 |
| mwhahaha | i'm not really sure we should be removing the <class>::logging from init | 16:36 |
| mwhahaha | i'm torn on that | 16:36 |
| mwhahaha | i'm pretty sure that's going to trash all of the tripleo logging | 16:36 |
| tobias-urdin | hm, the include only imposes the <SERVICE DEFAULT> for everything and sets the log_dir and log_file (which is always the same as default in the default config for the projects) | 16:38 |
| mwhahaha | which is fine | 16:38 |
| tobias-urdin | since all pick's behavior is removed it's required to define that to get "debug" etc | 16:39 |
| mwhahaha | but if you're using heiradata, you're basically disabling any of our logging | 16:39 |
| mwhahaha | the issue is the missing inclusion of the logging class | 16:39 |
| mwhahaha | unless there's a conflict, we shouldn't care if it's always getting included | 16:39 |
| mwhahaha | this is a change in they way the modules have operated for a very long time | 16:40 |
| tobias-urdin | hm how do you mean, that change by itself shouldn't disable any logging but only not manage the logging parameters which are not managed now anyway | 16:40 |
| mwhahaha | it does if we aren't including ::nova::logging in our composition classes | 16:40 |
| mwhahaha | which we aren't | 16:40 |
| mwhahaha | but we do set nova::loging::debug | 16:40 |
| mwhahaha | so by removing the include, that no longer works | 16:40 |
| tobias-urdin | ah now i understood, so this would enforce a "include nova::logging" in your manifests to make sure it even reads nova::logging::debug | 16:42 |
| mwhahaha | yes | 16:42 |
| mwhahaha | so it's fine to remove the depreacated params | 16:42 |
| mwhahaha | but don't remove the include <class>::logging | 16:42 |
| mwhahaha | example, https://review.openstack.org/#/c/620373/2/puppet/services/cinder-base.yaml | 16:43 |
| mwhahaha | we use <class>::logging::debug everywhere | 16:43 |
| mwhahaha | but we don't include <class>::logging anywhere | 16:43 |
| * mwhahaha pads his stats :D | 16:45 | |
| tobias-urdin | hm, tried browsing but couldn't find where the entry point for those is | 16:47 |
| tobias-urdin | how much pain is to add that? i mean since that's how we were talking about doing with database_connection as well | 16:47 |
| tobias-urdin | otherwise i can revert the changes that deprecated params *and* remove logging include and just propose the deprecations | 16:48 |
| mwhahaha | very much so | 16:49 |
| mwhahaha | i mean i can try and add it into puppet tripleo everywhere | 16:49 |
| mwhahaha | but it's so many class | 16:49 |
| mwhahaha | or just add it back in | 16:49 |
| mwhahaha | i do think this is not a good change in functionality | 16:50 |
| mwhahaha | also for the db stuff, i think you can remove the params but don't remove in the includes | 16:52 |
| mwhahaha | we actually want to force people to configure the db bit either via hiera or in their composition so we need to fail if they don't provide it | 16:52 |
| tobias-urdin | i was hoping that we could decouple everything to fix the issue with resources having to be defined in specific orders, as per the coding style policy | 16:53 |
| mwhahaha | i can look to add the logging bits in our classes, but i'd still prefer that we leave it in place in the init | 16:53 |
| tobias-urdin | but i guess it's more a long time goal | 16:53 |
| tobias-urdin | i can revert all the "include" stuff and leave the deprecation removals | 16:53 |
| mwhahaha | how much of it has landed | 16:54 |
| tobias-urdin | https://review.openstack.org/#/q/project:%255Eopenstack/puppet%255C-.*+is:closed+message:logging+owner:%22Tobias+Urdin%22 | 16:54 |
| mwhahaha | meh | 16:54 |
| mwhahaha | i blame EmilienM while he's traveling so he can't explain himself :D | 16:54 |
| tobias-urdin | hehe | 16:55 |
| mwhahaha | alright let me add ::logging everywhere | 16:56 |
| mwhahaha | but i think we need to warn people before removing it | 16:56 |
| *** pgaxatte has quit IRC | 16:56 | |
| mwhahaha | maybe throw a warning for this cycle and remove next | 16:56 |
| mwhahaha | similar thing for db if you want to decouple it | 16:56 |
| mwhahaha | we'll need to update all the tripleo bits in a similar fashion | 16:57 |
| tobias-urdin | yea, if you investigate the effort and let me know | 16:58 |
| tobias-urdin | otherwise i'll revert it since it's mostly my fault, should be some 10 patches to fix and the rest can be fully reverted (the commits that only removed the include) | 16:58 |
| tobias-urdin | a heads up though, some modules has multiple logging classes, for example ironic::logging ironic::inspector::logging and glance has glance::api::logging and glance::registry::logging (and maybe glance::cache::logging as well not sure) | 16:59 |
| mwhahaha | yea | 17:00 |
| tobias-urdin | just let me know what you decide and i'll get it done, i have some GDPR (yay super fun....) stuff to do right now :p | 17:01 |
| openstackgerrit | Merged openstack/puppet-openstack-cookiecutter master: Update default year to 2019 https://review.openstack.org/624700 | 17:01 |
| *** vnogin has quit IRC | 17:04 | |
| *** derekh has quit IRC | 17:21 | |
| *** jtomasek has quit IRC | 17:21 | |
| *** trown is now known as trown|lunch | 17:25 | |
| *** vnogin has joined #puppet-openstack | 17:28 | |
| mwhahaha | https://review.openstack.org/#/c/625673/ i think that's the stuff for tripleo, will need to double check | 17:30 |
| *** vnogin has quit IRC | 17:32 | |
| *** ykarel is now known as ykarel|away | 17:37 | |
| openstackgerrit | Merged openstack/puppet-oslo master: Deprecate ZeroMQ https://review.openstack.org/621557 | 17:46 |
| tobias-urdin | mwhahaha: ack ty | 17:47 |
| *** PagliaccisCloud has joined #puppet-openstack | 17:50 | |
| *** PagliaccisCloud has quit IRC | 17:55 | |
| *** PagliaccisCloud has joined #puppet-openstack | 18:03 | |
| *** salmankhan has quit IRC | 18:09 | |
| *** jpena is now known as jpena|off | 18:14 | |
| *** rpittau has quit IRC | 18:16 | |
| *** ykarel|away has quit IRC | 18:25 | |
| *** dpawlik has joined #puppet-openstack | 18:32 | |
| *** trown|lunch is now known as trown | 18:41 | |
| openstackgerrit | Merged openstack/puppet-swift master: Deprecate auth_uri in swift::proxy::authtoken https://review.openstack.org/621138 | 18:43 |
| *** shardy has quit IRC | 18:58 | |
| *** dpawlik has quit IRC | 19:01 | |
| *** dpawlik has joined #puppet-openstack | 19:01 | |
| *** PagliaccisCloud has quit IRC | 19:44 | |
| openstackgerrit | Merged openstack/puppet-openstack-integration master: Fix ironic lint https://review.openstack.org/625587 | 19:47 |
| openstackgerrit | Rajini Karthik proposed openstack/puppet-cinder master: PowerMax driver - rebranding VMAX to PowerMax https://review.openstack.org/625716 | 21:01 |
| *** gouthamr has quit IRC | 21:06 | |
| openstackgerrit | Merged openstack/puppet-cloudkitty master: Fix serivce_type annotation https://review.openstack.org/625473 | 21:11 |
| openstackgerrit | Merged openstack/puppet-openstack-cookiecutter master: Allow .bundled_gems to persist between runs of prepare_environment https://review.openstack.org/624169 | 21:17 |
| *** rcernin has joined #puppet-openstack | 21:28 | |
| *** gouthamr_ has joined #puppet-openstack | 21:30 | |
| *** gouthamr_ has quit IRC | 21:37 | |
| *** gouthamr_ has joined #puppet-openstack | 21:41 | |
| *** gouthamr_ has quit IRC | 21:46 | |
| *** dpawlik has quit IRC | 21:50 | |
| openstackgerrit | Merged openstack/puppet-gnocchi master: Fix service_type annotation https://review.openstack.org/625474 | 21:51 |
| *** gouthamr_ has joined #puppet-openstack | 21:51 | |
| *** gouthamr_ has quit IRC | 21:56 | |
| *** trown is now known as trown|outtypewww | 21:58 | |
| openstackgerrit | Merged openstack/puppet-panko master: Fix service_type annotation https://review.openstack.org/625475 | 22:14 |
| openstackgerrit | Merged openstack/puppet-watcher master: Fix service_type annotation https://review.openstack.org/625476 | 22:38 |
| openstackgerrit | Merged openstack/puppet-openstack-integration master: Fix lint jobs not reporting error https://review.openstack.org/624989 | 22:42 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-nova master: Deprecate PKI parameters in novajoin https://review.openstack.org/625735 | 23:20 |
| tobias-urdin | mwhahaha: ^ nova fix | 23:21 |
| mwhahaha | k | 23:21 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-nova master: Use puppet4 functions-api https://review.openstack.org/614241 | 23:22 |
| *** gfidente has quit IRC | 23:30 | |
| mwhahaha | oops the fixing of the lint job broke puppet-tripleo :D | 23:49 |
| mwhahaha | oh well | 23:50 |
| * mwhahaha fixes all the lint things | 23:50 | |
| mwhahaha | clearly this has been broken for a while | 23:50 |
| *** PagliaccisCloud has joined #puppet-openstack | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!