*** jaosorior has quit IRC | 00:05 | |
*** tosky has quit IRC | 00:13 | |
openstackgerrit | Merged openstack/puppet-cinder master: Add ability to configure cinder-volume for active-active https://review.openstack.org/618574 | 00:48 |
---|---|---|
*** chem has quit IRC | 01:01 | |
*** sai_p has quit IRC | 02:23 | |
*** mschuppert has quit IRC | 02:25 | |
*** ykarel|away has joined #puppet-openstack | 03:55 | |
*** ykarel|away has quit IRC | 05:16 | |
*** ykarel|away has joined #puppet-openstack | 05:31 | |
*** ykarel|away is now known as ykarel | 05:31 | |
*** jaosorior has joined #puppet-openstack | 06:36 | |
*** hjensas has quit IRC | 06:40 | |
*** rcernin has quit IRC | 06:57 | |
*** skramaja has joined #puppet-openstack | 07:15 | |
*** dpawlik has joined #puppet-openstack | 07:16 | |
*** dpawlik has quit IRC | 07:20 | |
*** dpawlik has joined #puppet-openstack | 07:24 | |
*** mschuppert has joined #puppet-openstack | 07:29 | |
*** ykarel is now known as ykarel|lunch | 07:41 | |
*** hjensas has joined #puppet-openstack | 07:53 | |
*** agurenko has joined #puppet-openstack | 08:00 | |
*** rpittau has joined #puppet-openstack | 08:01 | |
pgaxatte | mwhahaha, tobias-urdin: i can't use the mistral::db variables in hiera right now. We are migrating to puppet5 and the way our profiles are made we rely too much on the class parameters | 08:03 |
amorin | hi all | 08:03 |
*** jtomasek has joined #puppet-openstack | 08:07 | |
*** rpittau_ has joined #puppet-openstack | 08:31 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: Move debug to <module>::logging class https://review.openstack.org/620415 | 08:33 |
*** rpittau has quit IRC | 08:33 | |
tobias-urdin | pgaxatte: can you give an example and maybe we can help out or we can figure out a solution that works for everyone | 08:34 |
*** rpittau_ is now known as rpittau | 08:35 | |
pgaxatte | the database_settings I'm trying to pass to mistral db are global and used all across our environment | 08:35 |
pgaxatte | in the same environment we configure everything from db to nova, rabbits, .... | 08:36 |
pgaxatte | everywhere else in our profiles we use the database parameters in the openstack main classes | 08:36 |
pgaxatte | the only where I can't do this is in mistral because they are missing | 08:37 |
pgaxatte | only place* | 08:37 |
tobias-urdin | could you give a code example, i think i understand what you mean but i might have misunderstood | 08:38 |
pgaxatte | and we cannot move everything to hiera yet because we are still in puppet3 and it doesn't know how to properly merge hieras | 08:38 |
pgaxatte | tobias-urdin: let me clean some code and show you | 08:39 |
tobias-urdin | thanks! | 08:39 |
*** rpittau_ has joined #puppet-openstack | 08:40 | |
*** rpittau has quit IRC | 08:40 | |
*** agurenko has quit IRC | 08:41 | |
*** rpittau_ is now known as rpittau | 08:49 | |
*** tosky has joined #puppet-openstack | 08:51 | |
openstackgerrit | Alfredo Moralejo proposed openstack/puppet-manila master: Replace ::keystone:python by ::keystone:client https://review.openstack.org/620535 | 08:53 |
*** chem has joined #puppet-openstack | 08:57 | |
*** jpena|off is now known as jpena | 08:57 | |
*** shardy has joined #puppet-openstack | 09:10 | |
*** owalsh_ is now known as owalsh | 09:12 | |
pgaxatte | tobias-urdin: http://paste.openstack.org/show/SPmfqXYxipFO5nby6kcv/ | 09:18 |
pgaxatte | this is what it looks like for the profile I use | 09:18 |
pgaxatte | my role (mistral-api) is only calling the profile profiles::mistral::api | 09:18 |
tobias-urdin | ok, so what is wrong with the example? that's the way it should be mistral::db is it's own resource and mistral::<db params> was only to keep backward compatible with picks in mistral::db | 09:24 |
tobias-urdin | is the https://review.openstack.org/#/c/620333/ fix to fix cosmetics/consistency or are you having an issue with using mistral::db? | 09:27 |
tobias-urdin | so you are using it the way it should be used, we can merge that change to make sure nothing is wrong | 09:30 |
tobias-urdin | but then again those will be deprecated this or next release, so you shouldn't start using them | 09:30 |
tobias-urdin | mwhahaha: lets merge https://review.openstack.org/#/c/620333 because the feature itself is broken, we can just fix that to keep backward compatibility for now | 09:31 |
tobias-urdin | but we are essentially adding those just to deprecate them right away if we move forward with deprecation of all database options that is not in <module>::db classes | 09:31 |
tobias-urdin | so i mean, it's kind of bad, but we backport that fix and then later deprecate it in master | 09:32 |
tobias-urdin | so we are not broken on earlier releases for that use case | 09:32 |
tobias-urdin | pgaxatte: sounds fair? lets see if other sign off on that approach | 09:33 |
*** rpittau has quit IRC | 09:34 | |
*** devurandom has quit IRC | 09:36 | |
*** ykarel|lunch is now known as ykarel | 09:39 | |
*** devurandom has joined #puppet-openstack | 09:39 | |
pgaxatte | what's wrong is that puppet3 does not like that at all :D | 09:39 |
tobias-urdin | :) | 09:39 |
tobias-urdin | what does it say? | 09:40 |
pgaxatte | if I move the class { '::mistral::db': } after class { '::mistral': }, it throws an error :D | 09:40 |
pgaxatte | that strongly suggests something is fucky | 09:41 |
amorin | that's because the class is duplicated | 09:41 |
pgaxatte | yep | 09:41 |
pgaxatte | it's called in my profile AND in the main mistral class | 09:41 |
tobias-urdin | that is common, since there is the "include ::mistral::db" include in mistral init.pp | 09:42 |
tobias-urdin | same for all puppet versions | 09:42 |
tobias-urdin | so yes, you need to define mistral::db before ::mistral | 09:42 |
pgaxatte | and I have to call it in my profile because the main class lacks some parameters :) | 09:42 |
tobias-urdin | and that is solely because of the backward compatibility thing, which is why we want to move away from it and decrease the amount of dependencies between classes | 09:43 |
pgaxatte | of course | 09:43 |
amorin | but if you add tje params to the init.pp, you're saved | 09:43 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: Move debug to <module>::logging class https://review.openstack.org/620415 | 09:44 |
*** agurenko has joined #puppet-openstack | 09:46 | |
*** agurenko has quit IRC | 10:06 | |
*** tobias-urdin has quit IRC | 10:10 | |
*** derekh has joined #puppet-openstack | 10:12 | |
*** tobias-urdin has joined #puppet-openstack | 10:14 | |
*** jistr is now known as jistr|mtg | 10:34 | |
*** salmankhan has joined #puppet-openstack | 10:35 | |
*** salmankhan has quit IRC | 10:45 | |
*** vnogin has joined #puppet-openstack | 10:47 | |
*** salmankhan has joined #puppet-openstack | 10:53 | |
openstackgerrit | yatin proposed openstack/puppet-openstack-integration master: [DNM][py3 scenario] Test glance without SSL https://review.openstack.org/620561 | 11:08 |
*** vnogin has quit IRC | 11:21 | |
*** jpena is now known as jpena|lunch | 12:02 | |
*** hjensas has quit IRC | 12:02 | |
*** beagles is now known as beagles_mtgs | 12:55 | |
*** jpena|lunch is now known as jpena | 13:02 | |
*** morazi has quit IRC | 13:04 | |
*** morazi has joined #puppet-openstack | 13:06 | |
*** trown|outtypewww is now known as trown | 13:12 | |
*** jistr|mtg is now known as jistr | 13:21 | |
*** ykarel has quit IRC | 13:29 | |
*** salmankhan1 has joined #puppet-openstack | 13:42 | |
*** salmankhan has quit IRC | 13:43 | |
*** salmankhan1 is now known as salmankhan | 13:43 | |
*** ykarel has joined #puppet-openstack | 13:46 | |
*** salmankhan has quit IRC | 13:47 | |
*** skramaja has quit IRC | 13:49 | |
*** salmankhan has joined #puppet-openstack | 14:06 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: Move debug to <module>::logging class https://review.openstack.org/620415 | 14:33 |
*** vnogin has joined #puppet-openstack | 14:43 | |
openstackgerrit | Thomas Goirand proposed openstack/puppet-cinder master: Add File.expand_path to cinder.rb https://review.openstack.org/620618 | 14:56 |
zigo | tobias-urdin: ^ As we discussed earlier. | 14:56 |
zigo | Funny thing is that it's an intermitent issue for me ... | 14:56 |
mwhahaha | tobias-urdin: i'm trying to track down where we even dropped those params. since the parameter comments are still there and they weren't deprecated i'm not sure how they got removed | 14:58 |
tobias-urdin | they were never dropped EmilienM's refactor just missed them | 14:58 |
EmilienM | hey | 14:59 |
EmilienM | what did I miss? | 14:59 |
mwhahaha | in mistral the datbase_* params got dropped from init | 14:59 |
tobias-urdin | https://github.com/openstack/puppet-mistral/commit/9f19d11c16532b6caa79b68ffc99f5a03210238c | 14:59 |
mwhahaha | but that's from 2 years ago | 14:59 |
tobias-urdin | this 3 years ago, some comments about database_* was added but never the parameters to the class | 15:00 |
mwhahaha | meaning they were never used | 15:00 |
tobias-urdin | yup | 15:00 |
mwhahaha | but they are in stable/queens and stable/rocky | 15:00 |
mwhahaha | so something else dorked it up | 15:00 |
mwhahaha | oh no the comment was | 15:00 |
mwhahaha | so i'm not sure saying the feature is broken is correct | 15:01 |
mwhahaha | it's never been there | 15:01 |
mwhahaha | i disagree that we should add them | 15:01 |
mwhahaha | pgaxatte needs to fix their classes | 15:01 |
tobias-urdin | yeah, they just want it to be consistent, i mean since the picks are there we could add them in and them deprecate them again with the behavior change to force users to <module>::db | 15:01 |
tobias-urdin | but yeah they are using it the correct way right now, but want to move to the wrong way which i pointed out | 15:01 |
mwhahaha | so they shouldn't continue down that path | 15:02 |
mwhahaha | we shouldn't help with with that on this module | 15:02 |
pgaxatte | the problem is that the "wrong way" is provided everywhere but not in mistral | 15:04 |
mwhahaha | because historical reasons | 15:04 |
pgaxatte | and we're still in newton :D | 15:05 |
mwhahaha | which isn't supported :D | 15:05 |
pgaxatte | so historical platform | 15:05 |
*** hjensas has joined #puppet-openstack | 15:05 | |
pgaxatte | oh come one | 15:05 |
pgaxatte | :D | 15:05 |
mwhahaha | so patch it in newton and migrate when you upgrade | 15:05 |
mwhahaha | this is a problem of a lack of contributors to help out with 2 year old tech debt | 15:06 |
pgaxatte | I'll prove you wrong mwhahaha: https://github.com/openstack/puppet-mistral/tree/stable/newton :D | 15:06 |
pgaxatte | "stable/newton" :D | 15:06 |
tobias-urdin | pffft :D | 15:06 |
mwhahaha | just because it exists doesn't mean it's supported | 15:06 |
tobias-urdin | those are dropped soon btw | 15:06 |
tobias-urdin | might be good to know | 15:06 |
tobias-urdin | mwhahaha: getting there though, we've got rid of a lot of crap ^^ | 15:07 |
mwhahaha | https://releases.openstack.org/ | 15:07 |
mwhahaha | newton was EOL 2017-10-25 | 15:07 |
pgaxatte | i'm kidding mwhahaha :) | 15:07 |
tobias-urdin | i should get bonus points, i even updated https://docs.openstack.org/puppet-openstack-guide/latest/install/releases.html#releases-summary | 15:07 |
mwhahaha | yea i'm still supporting liberty code so i don't really want to continue these shenanigans | 15:08 |
*** vnogin has quit IRC | 15:12 | |
*** dpawlik has quit IRC | 15:16 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-nova master: Update python packaging version for RHEL8 https://review.openstack.org/620149 | 15:30 |
*** beagles_mtgs is now known as beagles | 15:37 | |
*** ykarel is now known as ykarel|away | 15:41 | |
cgoncalves | tobias-urdin, hi. could you please +A https://review.openstack.org/#/c/620147/ ? thanks | 15:42 |
tobias-urdin | do we intend to backport that? because that is a behavior change | 15:45 |
tobias-urdin | it was only included in octavia::api before right? | 15:45 |
openstackgerrit | Alex Schultz proposed openstack/puppet-manila master: Remove keystone::python https://review.openstack.org/620638 | 15:46 |
mwhahaha | tobias-urdin: -^ to un-break manila ci | 15:46 |
tobias-urdin | mwhahaha: https://review.openstack.org/#/c/620535/ | 15:47 |
mwhahaha | ah | 15:47 |
mwhahaha | too bad beakers broken on ubuntu it looks like | 15:47 |
tobias-urdin | just rubygem mirror timeouts | 15:47 |
tobias-urdin | has been a lot of them today for some reason, maybe they have had issues | 15:48 |
tobias-urdin | mwhahaha: do you think we should remove the auth_uri stuff we deprecated (moved to www_authenticate_uri) in rocky? | 15:53 |
mwhahaha | no | 15:53 |
mwhahaha | oh wait, yes | 15:53 |
mwhahaha | i thought you mean backport the removal | 15:53 |
mwhahaha | it broke the world in rocky anyway | 15:53 |
mwhahaha | so it really doesn't work | 15:53 |
tobias-urdin | so yes? :D | 15:55 |
tobias-urdin | jaosorior: who could help drive this https://review.openstack.org/#/c/619257/ i added unit tests for passing [35357, 5000] to bind_port so the migration should | 15:59 |
tobias-urdin | be pretty straight forward | 15:59 |
tobias-urdin | in tripleo that is | 15:59 |
tobias-urdin | packstack should work out of the box unless you want 35357 there as well then it just needs an bind_port added to keystone::wsgi::apache | 16:01 |
tobias-urdin | (given all port 35357 references is removed) | 16:02 |
*** dpawlik has joined #puppet-openstack | 16:24 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-nova master: Convert to rspec-puppet-facts https://review.openstack.org/620653 | 16:35 |
*** dpawlik has quit IRC | 16:42 | |
*** janki has joined #puppet-openstack | 16:50 | |
janki | Hi. I have a patch https://review.openstack.org/#/c/620013/ having a failure http://logs.openstack.org/13/620013/2/check/puppet-openstack-unit-4.8-centos-7/fc67b9b/job-output.txt.gz#_2018-11-27_05_32_09_737184 but neutron class has enable_ipv6 defined https://review.openstack.org/#/c/618718/2/manifests/plugins/ovs/opendaylight.pp and I have rebased puppet-tripleo patch on top of it | 16:50 |
*** dpawlik has joined #puppet-openstack | 17:03 | |
*** dpawlik has quit IRC | 17:07 | |
EmilienM | janki: I'll look after lunch if nobody helped before | 17:12 |
janki | EmilienM, Tim replied to use change-id for Depends-on. Wasnt there a communication to use patch url rather than change-id? | 17:13 |
mwhahaha | janki: so the problem is if you use the url, you have to updated it for teh correct patch when backporting | 17:32 |
mwhahaha | janki: since your backport was referencing the master patch it didn't get picked up for testing | 17:32 |
mwhahaha | janki: this is one of those things where the change-id is better than the url. | 17:32 |
openstackgerrit | Merged openstack/puppet-tempest master: Convert to rspec-puppet-facts https://review.openstack.org/619895 | 17:33 |
janki | mwhahaha, I had rebased it on top of the "depends-on" patch and yet it failed. Changing to comit-id for Rocky too | 17:37 |
mwhahaha | doesn't matter because the unit test didn't get the proper branched version because you had Depends-On https://review.openstack.org/#/c/584740/ | 17:38 |
mwhahaha | which was the master patch | 17:38 |
janki | ohk. changed it to change-id. will ask you for reviews once jenkins verifies :P | 17:39 |
*** janki has quit IRC | 17:41 | |
*** trown is now known as trown|lunch | 17:48 | |
*** jpena is now known as jpena|off | 18:09 | |
*** shardy has quit IRC | 18:11 | |
openstackgerrit | Dan Radez proposed openstack/puppet-neutron stable/queens: Add networking-ansible ml2 plugin support https://review.openstack.org/620672 | 18:18 |
*** salmankhan has quit IRC | 18:26 | |
*** trown|lunch is now known as trown | 18:59 | |
*** ykarel|away has quit IRC | 19:03 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-neutron master: Convert to rspec-puppet-facts https://review.openstack.org/620684 | 19:31 |
openstackgerrit | Rajini Karthik proposed openstack/puppet-cinder stable/queens: Dell EMC SC: Add use_multipath_for_image_xfer https://review.openstack.org/614619 | 20:07 |
openstackgerrit | Rajini Karthik proposed openstack/puppet-cinder stable/queens: Dell EMC SC: Add use_multipath_for_image_xfer https://review.openstack.org/614619 | 20:08 |
openstackgerrit | Rajini Karthik proposed openstack/puppet-cinder stable/rocky: Dell EMC SC: Add use_multipath_for_image_xfer https://review.openstack.org/614618 | 20:11 |
*** openstackgerrit has quit IRC | 20:36 | |
*** rcernin has joined #puppet-openstack | 21:50 | |
*** rcernin has quit IRC | 22:03 | |
*** openstackgerrit has joined #puppet-openstack | 22:06 | |
openstackgerrit | Merged openstack/puppet-manila master: Replace ::keystone:python by ::keystone:client https://review.openstack.org/620535 | 22:06 |
*** rcernin has joined #puppet-openstack | 22:12 | |
*** trown is now known as trown|outtypewww | 22:14 | |
*** derekh has quit IRC | 22:43 | |
*** derekh has joined #puppet-openstack | 22:44 | |
*** derekh has quit IRC | 22:44 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-aodh master: Remove auth_uri https://review.openstack.org/620719 | 22:52 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-barbican master: Remove auth_uri https://review.openstack.org/620720 | 22:53 |
*** trown|outtypewww has quit IRC | 22:54 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-congress master: Remove auth_uri https://review.openstack.org/620721 | 22:54 |
*** trown has joined #puppet-openstack | 22:55 | |
openstackgerrit | Tobias Urdin proposed openstack/puppet-murano master: Remove auth_uri https://review.openstack.org/620722 | 22:56 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-freezer master: Remove auth_uri https://review.openstack.org/620723 | 22:57 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-ec2api master: Remove auth_uri https://review.openstack.org/620725 | 22:58 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-watcher master: Remove auth_uri https://review.openstack.org/620726 | 22:59 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-tacker master: Remove auth_uri https://review.openstack.org/620727 | 23:00 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-ironic master: Remove auth_uri https://review.openstack.org/620728 | 23:03 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-octavia master: Remove auth_uri https://review.openstack.org/620729 | 23:04 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-vitrage master: Remove auth_uri https://review.openstack.org/620730 | 23:05 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-ceilometer master: Remove auth_uri https://review.openstack.org/620731 | 23:07 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-cinder master: Remove auth_uri https://review.openstack.org/620732 | 23:08 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-cloudkitty master: Remove auth_uri https://review.openstack.org/620733 | 23:09 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-designate master: Remove auth_uri https://review.openstack.org/620734 | 23:10 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-glance master: Remove auth_uri https://review.openstack.org/620735 | 23:12 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-glare master: Remove auth_uri https://review.openstack.org/620736 | 23:13 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-gnocchi master: Remove auth_uri https://review.openstack.org/620737 | 23:14 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-heat master: Remove auth_uri https://review.openstack.org/620739 | 23:17 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-keystone master: Remove auth_uri https://review.openstack.org/620740 | 23:20 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-magnum master: Remove auth_uri https://review.openstack.org/620741 | 23:21 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-manila master: Remove auth_uri https://review.openstack.org/620742 | 23:22 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-mistral master: Remove auth_uri https://review.openstack.org/620743 | 23:23 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-neutron master: Remove auth_uri https://review.openstack.org/620744 | 23:25 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-nova master: Remove auth_uri https://review.openstack.org/620745 | 23:27 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-panko master: Remove auth_uri https://review.openstack.org/620746 | 23:28 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-sahara master: Remove auth_uri https://review.openstack.org/620747 | 23:30 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-trove master: Remove auth_uri https://review.openstack.org/620748 | 23:32 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-zaqar master: Remove auth_uri https://review.openstack.org/620749 | 23:33 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-guide master: Class structure and dependencies https://review.openstack.org/620751 | 23:49 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-guide master: Class structure and dependencies https://review.openstack.org/620751 | 23:53 |
openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-guide master: Class structure and dependencies https://review.openstack.org/620751 | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!