Tuesday, 2018-11-06

openstackgerritBob Fournier proposed openstack/puppet-ironic master: For ironic-pxe use syslinux-tftpboot package instead of syslinux  https://review.openstack.org/61570902:10
openstackgerritBob Fournier proposed openstack/puppet-ironic master: For ironic-pxe use syslinux-tftpboot package instead of syslinux  https://review.openstack.org/61570902:21
openstackgerritBob Fournier proposed openstack/puppet-ironic master: For ironic-pxe use syslinux-tftpboot package instead of syslinux  https://review.openstack.org/61570902:23
openstackgerritBob Fournier proposed openstack/puppet-ironic master: For ironic-pxe use syslinux-tftpboot package instead of syslinux  https://review.openstack.org/61570903:09
*** ykarel has joined #puppet-openstack04:20
*** jtomasek has joined #puppet-openstack05:14
*** rascasoft has quit IRC05:32
*** rascasoft has joined #puppet-openstack05:35
*** jtomasek has quit IRC06:39
*** agurenko has joined #puppet-openstack06:40
openstackgerritzhongshengping proposed openstack/puppet-nova master: Fix syntax error  https://review.openstack.org/61573606:47
openstackgerritChandan Kumar proposed openstack/puppet-openstack-integration master: Use blacklist_file for skipping tests in Ubuntu/Debian  https://review.openstack.org/61551406:50
*** mkarpin has joined #puppet-openstack07:07
*** mkarpin has left #puppet-openstack07:08
*** dpawlik has joined #puppet-openstack07:17
*** mschuppert has joined #puppet-openstack07:19
*** iurygregory|home is now known as iurygregory07:19
iurygregorygood morning07:25
iurygregorytobias-urdin, you around? if you have time https://review.openstack.org/#/c/615709/ o/07:34
iurygregorynot sure about your time zone XD07:34
*** ade_lee has quit IRC07:52
*** iurygregory is now known as iurygregory|mtg08:01
*** ykarel_ has joined #puppet-openstack08:19
*** ykarel has quit IRC08:22
chandankumarzigo: tobias-urdin Need help here https://review.openstack.org/#/c/615514/6/run_tests.sh@3808:24
chandankumarcomparison is not happening08:24
chandankumarzigo: regarding debian tempest packages it is also older version 17.0.2 http://logs.openstack.org/14/615514/6/check/puppet-openstack-integration-4-scenario003-tempest-debian-stable/786c1db/job-output.txt.gz#_2018-11-06_07_33_17_56886308:26
ykarel_chandankumar, syntax seems wrong for bash08:27
ykarel_no space [08:27
zigochandankumar: I do have a newer version for Rocky available.08:27
zigochandankumar: This version does work for Queens.08:27
zigochandankumar: All will be updated when I'm done fixing all in Rocky.08:27
chandankumarzigo: till then Will I switch to source then?08:27
zigochandankumar: No.08:28
chandankumarzigo: ack08:28
zigochandankumar: This version of tempest matches Queens, there's no need to use anotherone.08:28
zigo17.2 is very much fine.08:28
*** dpawlik has quit IRC08:28
chandankumartempest -18 got lots of nice improvements in tempest run08:29
*** dpawlik has joined #puppet-openstack08:29
chandankumarzigo: in RDO side, we have tempest-18 https://github.com/redhat-openstack/rdoinfo/blob/master/rdo.yml#L577008:29
chandankumarfor queens08:30
chandankumarlet me take a look at ostestr if that helps we will be good08:30
*** dpawlik has quit IRC08:33
*** dpawlik has joined #puppet-openstack08:35
*** jtomasek has joined #puppet-openstack08:41
*** dpawlik has quit IRC08:42
*** dpawlik has joined #puppet-openstack08:43
openstackgerritMerged openstack/puppet-nova master: Fix syntax error  https://review.openstack.org/61573608:46
*** jpena|off is now known as jpena08:47
openstackgerritChandan Kumar proposed openstack/puppet-openstack-integration master: Use blacklist_file for skipping tests in Ubuntu/Debian  https://review.openstack.org/61551408:51
zigochandankumar: I can try to push more for switching to Rocky then.08:52
chandankumarzigo: I am added some tweak to use ostestr in above patch let see08:52
openstackgerritThomas Goirand proposed openstack/puppet-barbican master: Add a barbican_secret provider  https://review.openstack.org/61556408:59
zigoThis is the first really working version of my barbican_secret type ...08:59
zigoI'll add more parameters to the class now.08:59
zigoThen unit tests, and then it will be ready.08:59
tobias-urdinmorning o/09:06
tobias-urdiniurygregory|mtg: ack09:07
*** ykarel__ has joined #puppet-openstack09:11
*** ykarel_ has quit IRC09:12
*** ykarel__ is now known as ykarel09:19
*** gfidente has joined #puppet-openstack09:20
mschupperttobias-urdin: thx a lot for moving https://review.openstack.org/614083 forward while I was out sick last week.09:38
*** derekh has joined #puppet-openstack09:39
tobias-urdinmschuppert: np09:39
*** chem has joined #puppet-openstack09:43
openstackgerritQuique Llorente proposed openstack/puppet-designate master: Install python3-keystoneclient in Fedora or RedHat > 7  https://review.openstack.org/61523510:05
openstackgerritQuique Llorente proposed openstack/puppet-designate master: Install python3-designateclient in Fedora or RedHat > 7  https://review.openstack.org/61523510:05
*** ykarel is now known as ykarel|lunch10:12
openstackgerritQuique Llorente proposed openstack/puppet-sahara master: Install python3-saharaclient in Fedora or RedHat > 7  https://review.openstack.org/61581210:19
*** iurygregory|mtg is now known as iurygregory10:20
*** gfidente has quit IRC10:21
openstackgerritQuique Llorente proposed openstack/puppet-sahara master: Install python3-saharaclient in Fedora or RedHat > 7  https://review.openstack.org/61581210:22
*** salmankhan has joined #puppet-openstack10:32
*** ykarel|lunch is now known as ykarel10:33
*** iurygregory is now known as iury|lunch10:41
openstackgerrityatin proposed openstack/puppet-openstack-integration master: Add some more services in scenario-py3  https://review.openstack.org/61328210:53
openstackgerritChandan Kumar proposed openstack/puppet-openstack-integration master: Use blacklist_file for skipping tests in Ubuntu/Debian  https://review.openstack.org/61551411:02
*** iury|lunch is now known as iurygregory11:11
*** gfidente has joined #puppet-openstack11:18
*** dtantsur|afk is now known as dtantsur11:33
*** dpawlik has quit IRC12:12
openstackgerritThomas Goirand proposed openstack/puppet-barbican master: Add a barbican_secret provider  https://review.openstack.org/61556412:12
*** dpawlik has joined #puppet-openstack12:12
openstackgerritThomas Goirand proposed openstack/puppet-barbican master: Add a barbican_secret provider  https://review.openstack.org/61556412:13
*** dpawlik has quit IRC12:16
openstackgerritThomas Goirand proposed openstack/puppet-barbican master: Add a barbican_secret provider  https://review.openstack.org/61556412:18
zigotobias-urdin: I'm really not sure about unit testing of new puppet types, could you have a look?12:18
zigo(or point me to a better example than what I found...)12:19
*** gfidente has quit IRC12:26
*** markvoelker has joined #puppet-openstack12:27
openstackgerritQuique Llorente proposed openstack/puppet-sahara master: Install python3-saharaclient in Fedora or RedHat > 7  https://review.openstack.org/61581212:28
*** jpena is now known as jpena|lunch12:38
*** gfidente has joined #puppet-openstack12:45
openstackgerritQuique Llorente proposed openstack/puppet-sahara master: Install python3-saharaclient in Fedora or RedHat > 7  https://review.openstack.org/61581212:54
openstackgerritThomas Goirand proposed openstack/puppet-swift master: Add mount_type to storage:disk  https://review.openstack.org/61585813:01
openstackgerritChandan Kumar proposed openstack/puppet-openstack-integration master: Use blacklist_file for skipping tests in Ubuntu/Debian  https://review.openstack.org/61551413:05
openstackgerritThomas Goirand proposed openstack/puppet-swift master: Fix default signing_dir for Debian  https://review.openstack.org/61263813:06
*** dpawlik has joined #puppet-openstack13:07
*** dpawlik has quit IRC13:07
*** dpawlik has joined #puppet-openstack13:08
*** ykarel_ has joined #puppet-openstack13:11
*** ykarel has quit IRC13:14
openstackgerritLee Yarwood proposed openstack/puppet-placement master: WIP Add missing Red Hat params and generic service  https://review.openstack.org/61556313:14
*** markvoelker has quit IRC13:21
*** ykarel_ is now known as ykarel13:21
*** jpena|lunch is now known as jpena13:28
tobias-urdinzigo: you'll probably have to look around at all other unit testing for providers in other openstack modules13:34
tobias-urdini've been stuggling with it as well recently with all puppet 4 functions testing, i have some WIP here for providers https://review.openstack.org/#/c/579369/13:35
tobias-urdinbut since you use openstack cli you probably need to look around in the other modules13:35
*** iurygregory has quit IRC13:41
*** ykarel has quit IRC13:42
*** iurygregory has joined #puppet-openstack13:42
zigotobias-urdin: Nice, a ceph_pool object will definitively be very useful !13:48
openstackgerritLee Yarwood proposed openstack/puppet-placement master: WIP Add missing Red Hat params and generic service  https://review.openstack.org/61556313:51
zigotobias-urdin: Now that I have created a barbican_secret, which I invoke in my controller, I need to get the key_id from within the swift proxy. How can I do that?14:01
zigoDo I need another provider just to fetch it?14:03
*** ykarel has joined #puppet-openstack14:03
tobias-urdinim unsure if you can even retrieve values from resource collected by a provider14:05
tobias-urdini dont think so, atleast i haven't seen anybody do it14:05
tobias-urdinyou'd have to do your own exec or something i think, perhaps14:06
tobias-urdinmwhahaha: knows14:06
openstackgerritLee Yarwood proposed openstack/puppet-openstack-integration master: WIP Extract the Placement service from Nova  https://review.openstack.org/61556814:08
mwhahahaYou can't14:10
zigomwhahaha: How can I then get the key_id for the kms_keymaster in Swift? With Exec?14:22
zigohttps://review.openstack.org/612638 <--- This fixes scenario002 in Debian.14:23
zigoLooks like it passes all tests already... :)14:23
tobias-urdinwoho nice work, when we have all debian passing it will be much more comfortable having it there and nobody breaks it14:24
tobias-urdinneed to move it to puppet5 and rocky though as well14:24
*** higgins has quit IRC14:25
zigotobias-urdin: I've tested my swift setup in Debian Sid (ie: puppet 5) and it worked for me.14:25
zigotobias-urdin: It looks like a contributor broke couples of stuff by tweaking the defaults in Neutron and Nova packages though, so I'll have to check it out.14:26
mwhahahazigo: you can't really. Is a problem with this kind of dynamic data and puppet14:26
zigomwhahaha: What's the solution for using kms_keymaster then?14:26
zigoI can't hard-code the key_id, can I?14:27
mwhahahaYou can't do it in a single puppet run14:27
zigo:/14:27
tobias-urdinyou'd have to pass it as a parameter, it sucks hard for stuff that doesn't have names instead of ids14:27
mwhahahaI've also raised the issue with some swift folks14:27
tobias-urdinfor example in octavia you cannot specify network by name but only list of uuids14:28
mwhahahaThis type of config in openstack is terrible14:28
zigotobias-urdin: Well, I do have a name for the barbican secret...14:28
*** higgins has joined #puppet-openstack14:28
tobias-urdinyeah, i'm just saying uuids in configs suck and i'm very much against them :)14:28
zigoIt *can* match multiple secret IDs, but in my case, it simply doesn't.14:28
mwhahahaThis stuff needs to be more dynamic14:28
openstackgerritQuique Llorente proposed openstack/puppet-sahara master: Install python3-saharaclient in Fedora or RedHat > 7  https://review.openstack.org/61581214:28
mwhahahaOr auto discoverable14:28
zigoHum... that's the case for a patch in Swift, then?14:29
* mwhahaha shrugs14:29
mwhahahaWe solve in in tripleo because we have multiple runs14:29
zigoThe thing is, Barbican secret names aren't a unic identifyer.14:29
zigomwhahaha: Deos trippleO handle swift encryption with kms_keymaster?14:30
mwhahahaI think it's supported14:30
mwhahahaBut we use a mix of a bunch of things to accomplish it14:31
mwhahahaI'll have to look later14:31
tobias-urdinmwhahaha: arghhh did i mess up the versioncmp? https://review.openstack.org/#/c/615627/2/manifests/defaults.pp14:31
mwhahahaYeah I think so14:32
mwhahahaI think you want 5.0.014:32
tobias-urdinomg i'm stupid haha14:34
openstackgerritTobias Urdin proposed openstack/puppet-openstacklib master: Deprecate Puppet 4  https://review.openstack.org/61562714:36
tobias-urdinthat should do it, mwhahaha thx ^^14:36
*** ade_lee has joined #puppet-openstack14:40
openstackgerritTobias Urdin proposed openstack/puppet-cinder master: Convert spec testing to use rspec-puppet-facts  https://review.openstack.org/61564814:41
mwhahahatobias-urdin, EmilienM: https://review.openstack.org/#/c/615235/ when you get a chance14:46
EmilienMack14:47
tobias-urdin+w :)14:48
tobias-urdina heads up that i'll start pushing moving all puppet openstack tracking to storyboard and getting rid of stable/newton branches as soon as i have some time away from our internal projects14:56
tobias-urdinjust a fyi if anybody wondered why i might have failed a bit on those goals for a while now14:57
tobias-urdinowalsh: if you have time would you mind checking this function that you implemented a while ago, this converts it to a puppet 4 function and introduces spec testing, could you please verify that the spec testing tests all the scenarios and that the possible bug found is actually a bug15:22
tobias-urdinhttps://review.openstack.org/#/c/614241/15:22
tobias-urdinfor comparison i pushed the spec tests to stable/rocky as well and as you can see there is some difference in behaviour https://review.openstack.org/#/c/615426/15:22
*** ykarel is now known as ykarel|away15:22
*** dpawlik has quit IRC15:33
*** ykarel|away has quit IRC15:43
openstackgerritMerged openstack/puppet-designate master: Install python3-designateclient in Fedora or RedHat > 7  https://review.openstack.org/61523515:51
chandankumartobias-urdin: mwhahaha EmilienM https://review.openstack.org/615514 I need some help on puppet debian ubuntu tempest stuff15:56
EmilienMchandankumar: looking15:57
EmilienMzigo: ^ can you help also, it's on debian15:57
owalshtobias-urdin: sorry, was afk... looking now16:06
zigoEmilienM: https://review.openstack.org/#/c/612638/ <--- This fixes scenario002 in Debian, but there's a trippleO pb, should I just do a recheck?16:06
zigochandankumar: For some reasons, on Debian, your stuff is trying to use Python2, when it really should be using Python 3.16:08
zigochandankumar: Look here, there's a mix of py2 and py3, that's kind of weird... http://logs.openstack.org/14/615514/9/check/puppet-openstack-integration-4-scenario001-tempest-debian-stable-luminous/cdcb8af/job-output.txt.gz#_2018-11-06_13_49_50_70946716:08
zigochandankumar: In Debian, there's a wrapper for running unit tests. you can probably use it.16:09
owalshtobias-urdin: trying to recall the context... but wouldn't _array_of_hash() fail on an array of strings?16:09
zigotempest_debian_shell_wrapper16:09
chandankumarzigo: I am not sure is this causing the stuff https://github.com/openstack/puppet-openstack-integration/blob/master/run_tests.sh#L261?16:09
zigochandankumar: That's not the problem.16:11
*** agurenko has quit IRC16:12
tobias-urdinowalsh: i feel like it should but it doesn't add up in my head16:12
openstackgerritMerged openstack/puppet-qdr master: Add a broker connector configuration  https://review.openstack.org/61399216:12
chandankumarwhere tempest_debian_shell_wrapper where it is defined?16:12
owalshtobias-urdin: just taking a look at the consumer - think this was for the nova pci params...16:13
tobias-urdinyeah it was introduced in some pci change that also added validation for pci passthrough data16:13
zigochandankumar: You probably should run /usr/bin/python3-tempest and not just /usr/bin/tempest16:14
zigochandankumar: tempest_debian_shell_wrapper is only packaged in Debian.16:14
zigo(in /usr/bin)16:14
zigoIt's just a helper ...16:14
chandankumarlet me try that16:14
zigochandankumar: https://salsa.debian.org/openstack-team/libs/tempest/blob/debian/rocky/debian/tempest_shell_wrapper16:15
owalshtobias-urdin: yea, spec/classes/nova_pci_spec.rb and spec/classes/nova_compute_pci_spec.rb should cover the required behaviour16:16
tobias-urdinim not confident that we have enough coverage to ensure it doesn't break anything16:18
tobias-urdinhm16:18
owalshtobias-urdin: that's the only consumers of the function, and it was convoluted to handle the string of escaped json which we could drop now16:18
tobias-urdinbased on some of the result in https://review.openstack.org/#/c/615426/16:19
tobias-urdinsome of those are expected to fail, but some of them shouldn't which indicate behaviour change16:19
tobias-urdini did fix one bug in the new change in master though16:19
tobias-urdinbut are you can see integers passed through16:19
tobias-urdinmight be because of this change though https://review.openstack.org/#/c/613445/16:19
tobias-urdinthat broke when moving away from the array_of_hashes? function, so it never returns true16:20
owalshtobias-urdin: yea, could be that. Should accept either an array of hashes, or the deprecated string of escaped json... nothing else16:22
openstackgerritMerged openstack/puppet-octavia master: Set common configuration options across services  https://review.openstack.org/61239516:26
openstackgerritQuique Llorente proposed openstack/puppet-aodh master: Install python3-aodh in Fedora or RedHat > 7  https://review.openstack.org/61592916:30
openstackgerritQuique Llorente proposed openstack/puppet-barbican master: Install python3-barbican in Fedora or RedHat > 7  https://review.openstack.org/61593016:31
openstackgerritQuique Llorente proposed openstack/puppet-gnocchi master: Install python3-gnocchi in Fedora or RedHat > 7  https://review.openstack.org/61593116:32
openstackgerritQuique Llorente proposed openstack/puppet-manila master: Install python3-manila in Fedora or RedHat > 7  https://review.openstack.org/61593216:33
openstackgerritQuique Llorente proposed openstack/puppet-swift master: Install python3-swift in Fedora or RedHat > 7  https://review.openstack.org/61593316:33
tobias-urdinowalsh: thanks for clearing it up, i'll go through it again later16:37
*** cgoncalves has joined #puppet-openstack16:37
cgoncalvestobias-urdin, hi. is https://review.openstack.org/#/c/612395/ backportable? significant changes but I believe it kept backward compatibility puppet-octavia doesn't assert on stable:follows-policy16:40
tobias-urdinif we can test to ensure that it doesn't break the usage of the puppet interface and doesn't change any default values it's probably ok16:44
cgoncalvestobias-urdin, spec/classes/octavia_worker_spec.rb has a good test coverage and wasn't touched by the patch so should be easy to spot in case my patch breaks something16:50
tobias-urdinlooks like it didn't change any overall usage either right, because of that change in include in init.pp16:51
tobias-urdinif no default values are changed, it's prob safe16:51
cgoncalvestobias-urdin, right. ok, so I'll be cherry-picking to rocky and queens and wait for CI16:52
cgoncalvesthanks16:52
openstackgerritChandan Kumar proposed openstack/puppet-openstack-integration master: Use blacklist_file for skipping tests in Ubuntu/Debian  https://review.openstack.org/61551416:52
chandankumarzigo: ^^16:52
tobias-urdincgoncalves: no worries, thanks for fixing it up :)16:52
*** chandankumar is now known as chkumar|pto16:59
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/rocky: Do not set inexistent haproxy_amphora/key_path  https://review.openstack.org/61594617:05
openstackgerritMerged openstack/puppet-barbican master: Add HSM related parameters  https://review.openstack.org/60833917:06
openstackgerritMerged openstack/puppet-openstack-integration master: Add trailing slash to fernet key_repository  https://review.openstack.org/61551317:12
openstackgerritMerged openstack/puppet-designate master: Only designate-central and mdns require database access  https://review.openstack.org/61245517:14
*** vnogin has joined #puppet-openstack17:53
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/rocky: Add posibilities to set default values for timeouts  https://review.openstack.org/61595718:01
*** derekh has quit IRC18:01
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/rocky: Do not set inexistent haproxy_amphora/key_path  https://review.openstack.org/61594618:01
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/rocky: Set common configuration options across services  https://review.openstack.org/61595818:02
*** jpena is now known as jpena|off18:05
*** dtantsur is now known as dtantsur|afk18:06
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/queens: Add posibilities to set default values for timeouts  https://review.openstack.org/61596218:07
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/queens: Do not set inexistent haproxy_amphora/key_path  https://review.openstack.org/61596318:08
openstackgerritCarlos Goncalves proposed openstack/puppet-octavia stable/queens: Set common configuration options across services  https://review.openstack.org/61596418:08
*** salmankhan has quit IRC18:08
*** jtomasek has quit IRC18:18
*** dpawlik has joined #puppet-openstack18:21
*** gfidente is now known as gfidente|afk18:21
*** markvoelker has joined #puppet-openstack18:31
*** dpawlik has quit IRC18:45
*** shardy has quit IRC19:00
*** salmankhan has joined #puppet-openstack19:43
*** salmankhan has quit IRC19:47
zigoEmilienM: mwhahaha: What can I do with https://review.openstack.org/#/c/612638/ ? It looks like it's stuck on an unrelated trippleO problem ...20:05
zigoAre you aware of it?20:05
openstackgerritDan Radez proposed openstack/puppet-neutron master: Adding support for networking-ansible's mac parameter  https://review.openstack.org/61598620:09
openstackgerritMerged openstack/puppet-neutron master: CiscoNexus: Update and Remove deprecated vars  https://review.openstack.org/60695720:11
*** jtomasek has joined #puppet-openstack20:21
*** jtomasek has quit IRC20:24
*** vnogin has quit IRC20:26
mwhahahazigo everything is green?21:38
*** salmankhan has joined #puppet-openstack21:39
*** salmankhan has quit IRC21:44
*** salmankhan has joined #puppet-openstack21:54
*** vnogin has joined #puppet-openstack22:27
*** vnogin has quit IRC22:31
openstackgerritMerged openstack/puppet-ironic master: For ironic-pxe use syslinux-tftpboot package instead of syslinux  https://review.openstack.org/61570922:45
openstackgerritAlex Schultz proposed openstack/puppet-barbican master: Update dogtag test  https://review.openstack.org/61602523:08
openstackgerritBob Fournier proposed openstack/puppet-ironic stable/rocky: For ironic-pxe use syslinux-tftpboot package instead of syslinux  https://review.openstack.org/61602623:08
openstackgerritAlex Schultz proposed openstack/puppet-barbican master: Install python3-barbican in Fedora or RedHat > 7  https://review.openstack.org/61593023:08
openstackgerritAlex Schultz proposed openstack/puppet-gnocchi master: Fix db spec test  https://review.openstack.org/61602823:13
openstackgerritAlex Schultz proposed openstack/puppet-gnocchi master: Install python3-gnocchi in Fedora or RedHat > 7  https://review.openstack.org/61593123:14
mwhahahaugh we never added rspec-puppet-facts to puppet-manilla23:29
* mwhahaha dredges up ~3 year old patches to apply23:29
mwhahahaoh maybe we did. meh updating all the tests :/23:31

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!