| *** dpawlik has quit IRC | 00:01 | |
| *** openstackgerrit has quit IRC | 00:09 | |
| *** mschuppert has quit IRC | 01:44 | |
| *** ykarel has joined #puppet-openstack | 03:31 | |
| *** skramaja has joined #puppet-openstack | 03:37 | |
| *** dpawlik has joined #puppet-openstack | 03:57 | |
| *** dpawlik has quit IRC | 04:02 | |
| *** openstackgerrit has joined #puppet-openstack | 04:30 | |
| openstackgerrit | Merged openstack/puppet-ironic master: Provide more useful fail message https://review.openstack.org/602842 | 04:30 |
|---|---|---|
| *** ykarel has quit IRC | 05:22 | |
| *** jtomasek has joined #puppet-openstack | 05:34 | |
| *** ykarel has joined #puppet-openstack | 05:42 | |
| *** jtomasek has quit IRC | 05:44 | |
| *** jtomasek has joined #puppet-openstack | 05:45 | |
| *** mschuppert has joined #puppet-openstack | 06:03 | |
| *** agurenko has joined #puppet-openstack | 06:04 | |
| *** dpawlik has joined #puppet-openstack | 06:07 | |
| dpawlik | tobias-urdin: it shouldn't | 06:10 |
| dpawlik | tobias-urdin: write to me on priv :) | 06:11 |
| *** rnoriega has quit IRC | 06:17 | |
| *** rnoriega has joined #puppet-openstack | 06:20 | |
| *** pma78 has joined #puppet-openstack | 06:23 | |
| *** hjensas has joined #puppet-openstack | 06:40 | |
| *** rcernin has quit IRC | 07:11 | |
| *** amoralej has joined #puppet-openstack | 07:11 | |
| *** shardy has joined #puppet-openstack | 07:15 | |
| tobias-urdin | dpawlik: if somebody has declared octavia::db after ::octavia in their manifests there will be a redeclaration | 07:37 |
| tobias-urdin | so people must move the class ordering in their manifests | 07:37 |
| tobias-urdin | mwhahaha: EmilienM should we make an exception? | 07:38 |
| tobias-urdin | i guess we could vote about it, but at the same time it's a breakage if used in the wrong way :) | 07:38 |
| dpawlik | tobias-urdin: | 07:42 |
| dpawlik | tobias-urdin: so IMHO we need to refactor the octavia module. It doesn't include properly octavia::db and octavia::logging class | 07:42 |
| dpawlik | I don't want to overwrite values in hiera | 07:42 |
| dpawlik | and using current version, I can't change values in db and logging | 07:43 |
| dpawlik | becuase of "duplication" | 07:43 |
| tobias-urdin | how do you mean? | 07:43 |
| tobias-urdin | the issue is the "include oslo::db" in init.pp | 07:43 |
| tobias-urdin | if oslo::db is already defined, it will be a "proper" include otherwise it will declare that class as new | 07:43 |
| tobias-urdin | s/oslo/octavia/g | 07:43 |
| tobias-urdin | if somebody then declare octavia::db themselves it will be a redeclaration error | 07:44 |
| dpawlik | tobias-urdin: | 07:44 |
| *** ykarel is now known as ykarel|lunch | 07:45 | |
| dpawlik | tobias-urdin: so IMHO include octavia::db params should be in init file instead of including it in api class https://github.com/openstack/puppet-octavia/blob/master/manifests/api.pp#L75 | 07:45 |
| dpawlik | tobias-urdin: how you want to change values for octavia::db in queens/rocky? | 07:46 |
| dpawlik | do you have some example | 07:46 |
| dpawlik | ? | 07:46 |
| tobias-urdin | it's kind of hard to achieve, i guess we maybe could add some logic when the octavia::db should be included | 07:48 |
| dpawlik | +1 | 07:49 |
| tobias-urdin | then there is the issue that we are not purely backporting but changing features in a stable branch, which also is not really good | 07:49 |
| dpawlik | as I see right now (but I didn't dig to much in octavia), api just require connection to DB, workers doesn't require | 07:49 |
| dpawlik | so maybe the params that I added into init should be moved to api class | 07:49 |
| dpawlik | and it can be also cherry-picked to queens and rocky | 07:50 |
| tobias-urdin | no i think we should always have the database connection in init.pp, that's how almost all modules does it (other than some old modules which nobody has cleaned up) | 07:50 |
| *** jpena|off is now known as jpena | 07:50 | |
| dpawlik | tobias-urdin: agree | 07:51 |
| tobias-urdin | there isn't a super strict guideline but there is one, https://docs.openstack.org/puppet-openstack-guide/latest/contributor/backporting.html | 07:51 |
| dpawlik | I will check soon | 07:51 |
| tobias-urdin | need to gather some input from the cores as well | 07:51 |
| *** rpittau has joined #puppet-openstack | 08:23 | |
| *** tosky has joined #puppet-openstack | 08:41 | |
| openstackgerrit | Alexandre arents proposed openstack/puppet-cinder master: Add cinder QOS support https://review.openstack.org/603052 | 08:42 |
| zigo | tobias-urdin: Hi there! Would you know if it's possible to use puppet-swift without puppetdb? | 09:01 |
| *** mschuppert has quit IRC | 09:02 | |
| *** mschuppert has joined #puppet-openstack | 09:03 | |
| tobias-urdin | zigo: dont know, where does it assume puppetdb is available? | 09:05 |
| zigo | tobias-urdin: It's in the doc of puppet-swift. It says it needs external resources, and for that, one needs puppetdb... | 09:05 |
| zigo | tobias-urdin: The @@ring_object_device thing, for example. | 09:06 |
| *** ykarel|lunch is now known as ykarel | 09:12 | |
| tobias-urdin | didn't know, can't really help but i assume it would be possible in another way with some hacking | 09:14 |
| tobias-urdin | if you have ceph i would refrain from using swift storage part and just plug in ceph with the swift compatible api | 09:14 |
| tobias-urdin | but thats my personal opinion | 09:14 |
| *** owalsh_ is now known as owalsh | 09:18 | |
| *** gfidente has joined #puppet-openstack | 09:28 | |
| openstackgerrit | Merged openstack/puppet-openstack-guide master: Update openstack releases in guide https://review.openstack.org/602620 | 10:09 |
| *** dtantsur|afk is now known as dtantsur | 10:18 | |
| openstackgerrit | Martin Schuppert proposed openstack/puppet-openstack-integration master: Enable nova metadata via httpd wsgi https://review.openstack.org/594247 | 10:21 |
| *** jpena is now known as jpena|lunch | 11:20 | |
| *** amoralej is now known as amoralej|lunch | 11:47 | |
| *** trown|outtypewww is now known as trown | 12:06 | |
| *** skramaja has quit IRC | 12:13 | |
| *** jpena|lunch is now known as jpena | 12:22 | |
| *** amoralej|lunch is now known as amoralej | 12:58 | |
| *** morazi has joined #puppet-openstack | 13:06 | |
| openstackgerrit | Merged openstack/puppet-nova stable/rocky: Remove unused osapi_volume_listen parameter https://review.openstack.org/601919 | 13:29 |
| openstackgerrit | Merged openstack/puppet-magnum stable/queens: add oslo_messaging_rabbit/amqp_durable_queues option https://review.openstack.org/602888 | 13:43 |
| mwhahaha | dpawlik: tobias-urdin: so historicaly we've just required <whatever>::db needed to be included prior to the init. that's just what we've done | 13:46 |
| *** ade_lee has joined #puppet-openstack | 13:51 | |
| tobias-urdin | okok, what do you think about backporting so that database_connection is in <class>::init which includes <class>::db? | 13:52 |
| tobias-urdin | my only opinion is that it breaks people not following that right now | 13:52 |
| tobias-urdin | (for a module that has never followed the database_connection in init before) | 13:53 |
| openstackgerrit | Merged openstack/puppet-octavia master: Fix the duplicated vars defined https://review.openstack.org/602658 | 13:55 |
| tobias-urdin | mwhahaha: ^ | 13:59 |
| mwhahaha | yea probably not the best idea. we could just release note it but i'm not sure why we need to backport anyof this because you should just be using heira to set <whatever>::db::* | 14:00 |
| mwhahaha | i actually dislike the use of db params on init | 14:01 |
| mwhahaha | because for services where there might be more than one service (i'm looking at you nova), it may not make sense | 14:01 |
| dpawlik | Im also don't like include it in init, so maybe for octavia (if only octavia api uses db connection) I will move the param to the api class instead of putting it in init ? | 14:02 |
| dpawlik | sorry for my patch... As I see right now it was not "thought out" | 14:02 |
| dpawlik | mwhahaha: | 14:03 |
| dpawlik | https://review.openstack.org/#/c/601551/ | 14:03 |
| dpawlik | im talking about this patch ^^ | 14:03 |
| mwhahaha | yea that one | 14:04 |
| mwhahaha | of course i'm not sure anyone is using the puppet-octavia stuff | 14:04 |
| dpawlik | Im using :D | 14:05 |
| mwhahaha | you and probably only you :D | 14:05 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-openstack-integration master: Use noninteractive frontend for Debian upgrade https://review.openstack.org/603142 | 14:06 |
| dpawlik | mwhahaha: thats a sad news. I want to create manifest for puppet-openstack-integration xD | 14:06 |
| mwhahaha | that's fine if you can get it integrated | 14:06 |
| dpawlik | BTW guys, why we create https://github.com/openstack/puppet-nova/blob/master/manifests/cell_v2/simple_setup.pp#L45 "default" cell instead of creating "cell_1" ? | 14:07 |
| * mwhahaha shrugs | 14:07 | |
| openstackgerrit | Merged openstack/puppet-murano master: Optimise the client vars defined https://review.openstack.org/602671 | 14:07 |
| mwhahaha | its just a name | 14:07 |
| dpawlik | on queens I have duplicated service names xD | 14:07 |
| mwhahaha | and that's what we did back in ocata or whatever when they sprung it on us | 14:08 |
| mwhahaha | you shouldn't really use simple setup | 14:08 |
| mwhahaha | it was a puppet version of their generic setup process | 14:08 |
| dpawlik | mwhahaha: thats what I would like to hear | 14:08 |
| mwhahaha | it was fine for like ocata/pike | 14:09 |
| mwhahaha | but beyond that since they now support multiple cells, it's best not to use it if you know what you're doing | 14:09 |
| dpawlik | ack | 14:11 |
| openstackgerrit | Merged openstack/puppet-ironic stable/pike: Remove non-voting job from gate https://review.openstack.org/601934 | 14:19 |
| *** ykarel is now known as ykarel|away | 14:33 | |
| openstackgerrit | Merged openstack/puppet-cinder stable/rocky: Deprecate parameters that have been removed from cinder https://review.openstack.org/600592 | 14:52 |
| *** ykarel|away has quit IRC | 14:53 | |
| *** bnemec has joined #puppet-openstack | 14:59 | |
| *** agurenko has quit IRC | 15:00 | |
| tobias-urdin | i actually started using puppet-octavia as well | 15:07 |
| tobias-urdin | but haven't got it working | 15:07 |
| tobias-urdin | dpawlik: just out of curiosity you got octavia working? i'm stuck on this stupid certifikate issue when talking to the amphora | 15:07 |
| tobias-urdin | dpawlik: oh and https://review.openstack.org/#/c/597600/ https://review.openstack.org/#/c/598170/ https://review.openstack.org/#/c/597725/ | 15:08 |
| tobias-urdin | :D | 15:08 |
| tobias-urdin | mwhahaha: yeah it's prob kind of messy to have db in init if there is multiple services that has different dbs | 15:09 |
| tobias-urdin | but since all other modules has that, it's kind of clean tho | 15:09 |
| mwhahaha | so the having to class { <whatever>::db {} prior to an init is a long standing issue if you aren't just using hiera | 15:10 |
| openstackgerrit | Merged openstack/puppet-nova stable/rocky: Make ironic password a secret https://review.openstack.org/601197 | 15:12 |
| *** morazi has quit IRC | 15:15 | |
| openstackgerrit | Merged openstack/puppet-nova stable/rocky: Deprecate unused image_service parameter https://review.openstack.org/601920 | 15:20 |
| openstackgerrit | Merged openstack/puppet-mistral master: Debian is using python3-mistralclient https://review.openstack.org/602663 | 15:31 |
| tobias-urdin | zigo: shouldn't this have solved it for debian? https://review.openstack.org/#/c/603142/ | 15:43 |
| tobias-urdin | trying to bypass that question popping up for apt upgrade | 15:44 |
| zigo | tobias-urdin: Yeah, this will help ! | 15:45 |
| tobias-urdin | didn't work though :( | 15:45 |
| *** morazi has joined #puppet-openstack | 15:57 | |
| *** ykarel has joined #puppet-openstack | 15:59 | |
| openstackgerrit | Merged openstack/puppet-neutron stable/rocky: Make vlan_transparent in neutron.conf configurable https://review.openstack.org/602453 | 16:27 |
| *** ykarel is now known as ykarel|away | 16:50 | |
| *** dtantsur is now known as dtantsur|afk | 16:54 | |
| *** amoralej is now known as amoralej|off | 17:10 | |
| *** jpena is now known as jpena|off | 17:11 | |
| *** trown is now known as trown|lunch | 17:18 | |
| *** tbarron_ is now known as tbarron | 17:41 | |
| *** shardy has quit IRC | 17:46 | |
| *** openstackgerrit has quit IRC | 18:10 | |
| *** trown|lunch is now known as trown | 18:32 | |
| *** ykarel|away has quit IRC | 18:53 | |
| *** jtomasek has quit IRC | 19:17 | |
| *** jtomasek has joined #puppet-openstack | 19:20 | |
| *** jtomasek has quit IRC | 19:37 | |
| *** jtomasek has joined #puppet-openstack | 19:40 | |
| *** jtomasek has quit IRC | 20:22 | |
| *** trown is now known as trown|outtypewww | 21:07 | |
| *** gfidente has quit IRC | 21:57 | |
| *** rcernin has joined #puppet-openstack | 22:08 | |
| *** tosky has quit IRC | 23:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!