Monday, 2018-04-30

*** dpawlik has joined #puppet-openstack00:06
*** dpawlik has quit IRC00:10
*** dpawlik has joined #puppet-openstack00:11
*** dpawlik has quit IRC00:21
*** dpawlik has joined #puppet-openstack00:26
*** dpawlik has quit IRC00:50
*** dpawlik has joined #puppet-openstack00:51
*** dtantsur|afk has quit IRC01:08
*** dtantsur has joined #puppet-openstack01:08
*** dpawlik has quit IRC01:10
*** dpawlik has joined #puppet-openstack01:11
*** dpawlik has quit IRC01:15
*** dpawlik has joined #puppet-openstack01:21
*** dpawlik has quit IRC01:25
*** dpawlik has joined #puppet-openstack01:26
openstackgerritMerged openstack/puppet-cloudkitty master: fix error url  https://review.openstack.org/56498701:43
*** ilbot3 has quit IRC01:46
*** dpawlik has quit IRC01:50
*** dpawlik has joined #puppet-openstack01:56
*** ilbot3 has joined #puppet-openstack01:56
*** dpawlik has quit IRC02:00
*** dpawlik has joined #puppet-openstack02:01
*** dpawlik has quit IRC02:10
*** dpawlik has joined #puppet-openstack02:11
*** skramaja has joined #puppet-openstack02:21
*** xarses has quit IRC02:25
*** xarses has joined #puppet-openstack02:25
*** dpawlik has quit IRC02:25
*** dpawlik has joined #puppet-openstack02:26
*** dpawlik has quit IRC02:30
*** dpawlik has joined #puppet-openstack02:31
*** dpawlik has quit IRC02:40
*** dpawlik has joined #puppet-openstack02:41
*** armaan has joined #puppet-openstack03:00
*** dpawlik has quit IRC03:00
*** dpawlik has joined #puppet-openstack03:01
*** dpawlik has quit IRC03:30
*** dpawlik has joined #puppet-openstack03:31
*** dpawlik has quit IRC03:41
*** dpawlik has joined #puppet-openstack03:41
*** dpawlik has quit IRC03:50
*** dpawlik has joined #puppet-openstack03:56
*** dpawlik has quit IRC04:00
*** dpawlik has joined #puppet-openstack04:01
*** dpawlik has quit IRC04:05
*** armaan has quit IRC04:05
*** dpawlik has joined #puppet-openstack04:06
*** ykarel_ has joined #puppet-openstack04:22
*** ykarel_ is now known as ykarel04:22
*** dpawlik has quit IRC04:25
*** dpawlik has joined #puppet-openstack04:26
*** dpawlik has quit IRC04:35
*** dpawlik has joined #puppet-openstack04:36
*** dpawlik has quit IRC04:40
*** dpawlik has joined #puppet-openstack04:41
*** dpawlik has quit IRC04:45
*** dpawlik has joined #puppet-openstack04:46
*** dpawlik has quit IRC04:50
*** dpawlik has joined #puppet-openstack04:51
*** dpawlik has quit IRC05:00
*** dpawlik has joined #puppet-openstack05:01
*** dpawlik has quit IRC05:10
*** jaosorior has joined #puppet-openstack05:12
*** dpawlik has joined #puppet-openstack05:16
*** dpawlik has quit IRC05:20
*** dpawlik has joined #puppet-openstack05:21
*** jaganathan has joined #puppet-openstack05:23
*** jaganathan has quit IRC05:23
*** jaganathan has joined #puppet-openstack05:24
*** dpawlik has quit IRC05:25
*** dpawlik has joined #puppet-openstack05:26
*** agurenko has joined #puppet-openstack05:42
*** dpawlik has quit IRC05:45
*** dpawlik has joined #puppet-openstack06:11
*** dpawlik has quit IRC06:36
*** dpawlik has joined #puppet-openstack06:41
*** dpawlik has quit IRC06:45
*** dpawlik has joined #puppet-openstack06:46
*** dpawlik has quit IRC06:50
*** dpawlik has joined #puppet-openstack06:51
*** armaan has joined #puppet-openstack06:59
*** tosky has joined #puppet-openstack07:03
*** Guest1988 has joined #puppet-openstack07:12
*** shardy has joined #puppet-openstack07:14
*** Guest1988 has quit IRC07:17
*** amoralej|off is now known as amoralej07:38
*** agurenko has quit IRC08:00
*** ykarel is now known as ykarel|lunch08:20
*** derekh has joined #puppet-openstack08:29
*** nmathew has joined #puppet-openstack08:41
zigotobasco: Around?08:49
tobascoyea08:50
zigotobasco: I believe I know how to use reno, the command line, that's not the issue.08:50
zigoWhat I don't, is how to make it meaningful.08:50
zigoAfter the editor is poped-up there's loads of sections to edit.08:50
zigoIn which one do I put my comment?08:51
zigoShould I remove the other sections, or just make them empty?08:51
tobascowell, since you have done a breaking change for the usage of spice_enabled parameter you need to inform, imo it's unnecessary to change behaviour08:53
tobascoso you need to explain what needs to be changed in the "upgrade" section, but I think we need to deprecate before you can do such a change i.e support both behaviours for 1 release08:54
tobascothe easiest thing would be, dont touch spice_enabled, there is no need to move the config of nova::spicehtml5proxy::enabled to nova::compute_spice_enabled08:55
zigoOk, so no need for a release note, then?08:55
tobascoyou need a note, you change the default value for nova::spicehtml5proxy::enabled from true to false by settings nova::compute::spice_enabled to false08:57
tobascoI would suggest tou do the logic to make spice proxy work for debian but don't touch structural changes or default values08:58
tobascoif somebody sets nova::spicehtml5proxy::enabled to false, it will not be set config spice/enabled properly for example08:59
zigoThe issue is, by default, [spice]/enabled was not set, which is why I was setting it in puppet.08:59
zigoBecause you can't have both vnc and spice enabled at the same time.08:59
zigoIt didn't show in puppet, because the default is false in Ubuntu by default.09:00
zigoIt is a problem in Debian, because in Debian, I have vnc/enabled to false by default, and spice/enabled to true by default.09:00
zigoDoes this info changes your reasoning?09:01
tobascohm, well on debian if you set nova::compute::vnc_enabled: false and include nova::spicehtml5proxy you should get vnc disabled and spice enabled09:03
tobascoso you only need to fix debian logic in nova::spicehtml5proxy right or am I missing something, instead of changing default behaviour for current deployments, vncproxy is default so enabling spice would be required to use debian09:04
tobascoah I see where my logic is wrong, you need spice_enabled set on the compute node, and might not neccesarly run spicehtml5proxy on that node09:09
zigoThat's not what I was saying, I was saying that without this patch, Debian ended with both VNC and SPICE enabled, which couldn't work.09:09
*** ykarel|lunch is now known as ykarel09:10
tobascoyeah i c what u mean now09:11
zigotobasco: Would this be ok? http://paste.openstack.org/show/720116/09:11
tobascoThink it should be other way around though, "Now supports VNC and SPICE, deployments that wants SPICE needs to disable VNC and enable SPICE..."09:15
tobascocurrent deployments should not be affected since we want to keep spice disabled by default09:15
zigoOk.09:15
zigoI think I got you! :)09:16
zigotobasco: http://paste.openstack.org/show/720117/09:18
zigoI didn't even realized I was breaking old users of SPICE, now I do.09:18
tobascoyeah, so we need to inform an upgrade about that or just dont change the default value would be easiest09:18
tobasco(change back default value)09:19
zigotobasco: Here: https://review.openstack.org/#/c/564328/10/manifests/spicehtml5proxy.pp09:22
zigoIf you're telling me to re-add spice/enabled, then shouldn't I also set vnc/enabled to false?09:22
tobascoif you force set vnc/enabled to false there but vnc_enabled is still true in nova::compute the second puppet run will not be idempotent09:24
tobascothe config value will be flapping (set from two places)09:24
zigotobasco: I was thinking about something like this: http://paste.openstack.org/show/720119/09:26
tobascothink like this, usually nova::spicehtml5proxy and nova::compute is used on two different nodes, if I use nova::spicehtml5proxy on a separate node I will never get spice/enabled set by puppet09:26
zigoAnd do the same in the spice side.09:26
tobascoon debian that would probably be fine, since it's default09:26
tobascosec, let me check09:26
zigoI mean, opposite way.09:26
zigoI get it, now ! :)09:26
tobascook, I think you should refrain from touching any vnc options in the spicehtml5proxy class09:29
tobascoadd your changes to spicehtml5proxy and vncproxy classes to support debian, then deployments will choose which one of those to use based on "vnc or spice"09:29
*** nmathew has quit IRC09:29
tobascoand then deployments set either vnc_enabled or spice_enabled in nova::compute09:29
tobascoand no default behaviour is changed :)09:30
*** owalsh_ is now known as owalsh09:33
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Fix VNC console in Debian  https://review.openstack.org/56432809:33
zigotobasco: There you go!09:33
zigo:)09:33
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Debian: make placement-api run on uwsgi  https://review.openstack.org/56136209:39
zigoThis one too...09:39
tobascosome feedback on the above one09:46
zigotobasco: What do you mean by "Missing param docs for service_name here" in manifests/placement.pp ?09:57
tobascoadd some comments in that list about the service_name param09:58
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Debian: make placement-api run on uwsgi  https://review.openstack.org/56136210:00
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Fix VNC console in Debian  https://review.openstack.org/56432810:05
tobascoposted a lot of feedback on your last PS on above10:09
zigoThanks a lot.10:10
*** tobasco is now known as tobasco-afk10:11
*** armaan has quit IRC10:12
*** armaan has joined #puppet-openstack10:12
*** armaan has quit IRC10:12
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Debian: make placement-api run on uwsgi  https://review.openstack.org/56136210:13
zigoLet's now see what the CI says ... :P10:15
zigotobasco-afk: Now unit tests are failing: http://logs.openstack.org/28/564328/12/check/puppet-openstack-unit-4.8-centos-7/954e851/job-output.txt.gz#_2018-04-30_10_29_17_78017810:40
*** atoth has quit IRC10:56
openstackgerritTobias Urdin proposed openstack/puppet-nova master: Debian: make placement-api run on uwsgi  https://review.openstack.org/56136210:58
*** tobasco-afk is now known as tobasco10:58
tobascozigo: Duplicate declaration: Nova_config[vnc/enabled] is already declared in file10:59
tobascoalready declared in file /etc/puppetlabs/code/modules/nova/manifests/compute.pp:272; cannot redeclare at /etc/puppetlabs/code/modules/nova/manifests/vncproxy.pp:8310:59
*** armaan has joined #puppet-openstack11:09
openstackgerritRajesh Tailor proposed openstack/puppet-nova master: Allow configuration of NFS backend for Nova  https://review.openstack.org/56417711:32
zigotobasco: IMO, the [spice] or [vnc] enabled directive is only needed in the compute case, proxies wont care.11:40
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Fix VNC console in Debian  https://review.openstack.org/56432811:41
*** amoralej is now known as amoralej|lunch11:55
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Debian: make placement-api run on uwsgi  https://review.openstack.org/56136212:10
*** atoth has joined #puppet-openstack12:10
*** trown|outtypewww is now known as trown12:18
*** morazi has joined #puppet-openstack12:29
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Fix VNC console in Debian  https://review.openstack.org/56432812:36
*** amoralej|lunch is now known as amoralej12:36
*** jaosorior has quit IRC12:43
openstackgerritThomas Goirand proposed openstack/puppet-keystone master: Debian is using python 3  https://review.openstack.org/56399912:53
amoralejmnaser, mwhahaha any plan to push a pre-release version to puppet modules in master?12:54
amoraleji think we did it in queens12:54
amoralejwith -dev or something12:54
mwhahahaamoralej: we did release m112:54
amoralejok12:54
amoralejgood12:54
mwhahahaamoralej: so, there's that12:54
amoralejthanks12:55
openstackgerritThomas Goirand proposed openstack/puppet-horizon master: Debian is using python3-memcache  https://review.openstack.org/55942113:02
*** atoth has quit IRC13:08
trozetmnaser, mwhahaha: can you guys please review https://review.openstack.org/#/c/564353/13:10
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Fix VNC console in Debian  https://review.openstack.org/56432813:12
*** rmart04 has joined #puppet-openstack13:20
*** atoth has joined #puppet-openstack13:23
openstackgerritOliver Walsh proposed openstack/puppet-nova master: Expose rx/tx_queue_size  https://review.openstack.org/56522013:25
openstackgerritOliver Walsh proposed openstack/puppet-nova master: Expose rx/tx_queue_size  https://review.openstack.org/56522013:27
*** armaan has quit IRC13:31
*** armaan has joined #puppet-openstack13:31
*** skramaja has quit IRC13:33
*** armaan has quit IRC13:39
*** armaan has joined #puppet-openstack13:39
*** armaan has quit IRC13:39
*** armaan has joined #puppet-openstack13:40
*** armaan has quit IRC13:55
*** armaan has joined #puppet-openstack13:56
*** ykarel is now known as ykarel|away13:56
*** xarses has quit IRC14:03
*** atoth has quit IRC14:08
*** ykarel|away has quit IRC14:11
*** atoth has joined #puppet-openstack14:22
*** rajinir has joined #puppet-openstack14:28
*** armaan has quit IRC14:30
*** armaan has joined #puppet-openstack14:31
*** dpawlik has quit IRC14:35
*** armaan has quit IRC14:35
*** ykarel|away has joined #puppet-openstack14:50
*** vnogin has joined #puppet-openstack14:55
*** vnogin has quit IRC14:58
*** beekneemech is now known as bnemec15:00
*** vinsh has joined #puppet-openstack15:01
*** jaganathan has quit IRC15:04
zigomnaser: Thanks for your comment, it's fixed, hopefully, now it's going to work ! :)15:08
*** rmart04 has quit IRC15:15
openstackgerritOliver Walsh proposed openstack/puppet-nova master: Expose rx/tx_queue_size  https://review.openstack.org/56522015:15
*** ykarel|away has quit IRC15:16
*** dpawlik has joined #puppet-openstack15:20
*** armaan has joined #puppet-openstack15:23
*** armaan has quit IRC15:24
*** armaan has joined #puppet-openstack15:24
*** dpawlik has quit IRC15:24
*** dpawlik has joined #puppet-openstack15:26
*** dpawlik has quit IRC15:26
*** dpawlik has joined #puppet-openstack15:27
*** dpawlik has quit IRC15:27
openstackgerritMerged openstack/puppet-ceph master: Update links in README  https://review.openstack.org/56498215:39
openstackgerritMerged openstack/puppet-panko master: fix error url  https://review.openstack.org/56501715:41
openstackgerritMerged openstack/puppet-rally master: fix error url  https://review.openstack.org/56502015:41
openstackgerritRajesh Tailor proposed openstack/puppet-nova master: Allow configuration of NFS backend for Nova  https://review.openstack.org/56417715:43
openstackgerritMerged openstack/puppet-glare master: fix error url  https://review.openstack.org/56500915:43
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Debian: make placement-api run on uwsgi  https://review.openstack.org/56136215:43
openstackgerritMerged openstack/puppet-openstack_extras master: fix error url  https://review.openstack.org/56501515:44
openstackgerritMerged openstack/puppet-openstack-specs master: Update links in README  https://review.openstack.org/56501415:45
openstackgerritThomas Goirand proposed openstack/puppet-horizon master: Debian is using python3-memcache  https://review.openstack.org/55942115:45
openstackgerritMerged openstack/puppet-modulesync-configs master: Update links in README  https://review.openstack.org/56499815:46
openstackgerritMerged openstack/puppet-qdr master: Update links in README  https://review.openstack.org/56502215:46
zigoI probably got the Horizon patch right this time. :P15:46
openstackgerritMerged openstack/puppet-vitrage master: fix error url  https://review.openstack.org/56502115:46
zigoie s/platform_param/platform_params/ (with s)15:46
openstackgerritMerged openstack/puppet-openstack-cookiecutter master: fix error url  https://review.openstack.org/56500615:48
*** dtantsur is now known as dtantsur|afk16:02
*** trown is now known as trown|lunch16:11
*** armaan has quit IRC16:22
openstackgerritMerged openstack/puppet-keystone master: Remove deprecated service_provider parameter  https://review.openstack.org/56468816:48
*** ykarel has joined #puppet-openstack16:52
*** armaan has joined #puppet-openstack16:57
zigoEmilienM: mnaser: mwhahaha: This one finally passes unit tests and all: https://review.openstack.org/#/c/561362/16:57
zigoRemaining is this one, but I can't make my head around fixing unit tests: https://review.openstack.org/#/c/564328/16:57
* zigo heads to Geneva now...16:57
openstackgerritMerged openstack/puppet-keystone master: Debian is using python 3  https://review.openstack.org/56399916:59
*** derekh has quit IRC17:02
*** trown|lunch is now known as trown17:34
openstackgerritRajesh Tailor proposed openstack/puppet-nova master: Allow configuration of NFS backend for Nova  https://review.openstack.org/56417717:35
*** ykarel is now known as ykarel|away17:37
*** amoralej is now known as amoralej|off17:40
*** shardy is now known as shardy_afk17:45
openstackgerritMerged openstack/puppet-nova master: Expose rx/tx_queue_size  https://review.openstack.org/56522017:58
*** armaan has quit IRC17:58
*** ykarel|away has quit IRC18:02
openstackgerritRajesh Tailor proposed openstack/puppet-nova master: Allow configuration of NFS backend for Nova  https://review.openstack.org/56417718:06
LarsErikPquestion; when do you plan to discontinue the stable/newton branches in the various repositories?18:30
EmilienMLarsErikP: very soon, probably next month18:53
*** atoth has quit IRC19:00
openstackgerritMerged openstack/puppet-neutron master: Fixes ODL OVS to add certs to every node  https://review.openstack.org/56435319:03
openstackgerritTim Rozet proposed openstack/puppet-neutron stable/queens: Fixes ODL OVS to add certs to every node  https://review.openstack.org/56528119:05
LarsErikPEmilienM: :O19:05
LarsErikPnext month as in.. tomorrow? :P19:05
EmilienMLarsErikP: why do you ask?19:08
EmilienMI can help if you tell me why you ask19:08
EmilienMwe can postpone it19:08
EmilienMwe had no feedback that we needed to keep it longer19:09
LarsErikPwell; just asking because we've planned to do the newton -> queens upgrades in our environment mid-june19:09
LarsErikPbut I guess we can just configure the r10k config with a commit id, rather than the branch name19:10
EmilienMand how the stable/newton branch removal can block you?19:10
EmilienMwe'll provide an newton-eol tag19:10
LarsErikPah, so that will be eual to stable/newton?19:10
LarsErikPequal*19:10
EmilienMwhich r10k config are you talking about?19:11
LarsErikPour own ;)19:11
EmilienMso yes, replace that by newton-eol tag19:11
EmilienMand you're good19:11
LarsErikPnice. no worries then :)19:11
zigoEmilienM: Is this a non-deterministic test? Why did it fail? http://logs.openstack.org/62/561362/16/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/a78bd9e/job-output.txt.gz#_2018-04-30_17_02_04_97141319:12
zigoShould I attempt a recheck?19:12
EmilienMI have no idea19:12
* EmilienM puts finger in the air19:12
EmilienMyes! do recheck (wind was strong)19:13
* EmilienM uses mwhahaha's method19:13
mwhahahashould probably go poke the designate folks on the accuracy of the test :D19:13
LarsErikPthanks EmilienM :)19:14
mwhahahawe deployment specialists assume all tests are non-deterministic these days19:14
EmilienMwe should tweet that19:16
openstackgerritThiago da Silva proposed openstack/puppet-swift master: Update s3api configuration  https://review.openstack.org/49856719:18
zigo:)19:25
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Fix VNC console in Debian  https://review.openstack.org/56432819:25
zigoEmilienM: I really wish it's just a non-deterministic test, and that I'll really be done with this patch, cause it's taking really too long to my taste.19:26
*** armaan has joined #puppet-openstack19:48
*** vnogin has joined #puppet-openstack19:59
*** vnogin has quit IRC20:03
*** rmart04 has joined #puppet-openstack20:06
*** rmart04 has quit IRC20:18
*** rmart04 has joined #puppet-openstack20:23
*** rmart04 has quit IRC20:28
zigoGreat, after waiting for the CI result, I have ... A DIFFERENT FAILURE !20:42
zigo:)20:42
zigoSo yeah... quite not very much deterministic indeed ...20:42
zigo:P20:42
trozetmwhahaha: can you please review this cherry-pick? https://review.openstack.org/#/c/565281/20:59
trozetmnaser, EmilienM: if you could please also^21:01
mnasertrozet: look good21:01
trozetmnaser: ty21:01
*** trown is now known as trown|outtypewww21:10
*** armaan has quit IRC21:10
*** armaan has joined #puppet-openstack21:11
*** armaan_ has joined #puppet-openstack21:12
*** armaan has quit IRC21:12
*** morazi has quit IRC21:18
*** armaan_ has quit IRC21:22
openstackgerritMerged openstack/puppet-openstack-integration master: Get more details for debugging tempest errors  https://review.openstack.org/56439121:25
*** colonwq has quit IRC21:34
*** colonwq has joined #puppet-openstack21:46
zigomnaser: mwhahaha: EmilienM: It passes tests after 2 rechecks: https://review.openstack.org/56136221:50
zigoI believe this one is in good enough shape.21:51
zigoCheers ! :)21:51
openstackgerritThiago da Silva proposed openstack/puppet-swift master: Update s3api configuration  https://review.openstack.org/49856721:59
openstackgerritOliver Walsh proposed openstack/puppet-nova stable/queens: Expose rx/tx_queue_size  https://review.openstack.org/56535422:03
*** rcernin has joined #puppet-openstack22:13
*** rajinir has quit IRC23:08
*** xarses has joined #puppet-openstack23:20
*** chem has quit IRC23:20
openstackgerritMerged openstack/puppet-neutron stable/queens: Fixes ODL OVS to add certs to every node  https://review.openstack.org/56528123:41

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!