Wednesday, 2018-04-04

*** sai_p has quit IRC00:03
*** atoth has quit IRC00:53
openstackgerritMerged openstack/puppet-ganesha master: Retire the project  https://review.openstack.org/55677100:58
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55841901:06
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834401:07
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55836101:08
*** armaan has quit IRC01:09
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55841901:12
*** gyan__ has joined #puppet-openstack01:13
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834401:15
*** armaan has joined #puppet-openstack01:35
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55841901:39
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834401:40
*** ilbot3 has quit IRC01:44
*** ilbot3 has joined #puppet-openstack01:57
*** ykarel|afk has joined #puppet-openstack02:16
*** ykarel|afk has quit IRC02:29
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834402:31
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Add puppet-openstack-integration-jobs-all job to the repo  https://review.openstack.org/55867402:36
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55836102:42
*** armaan has quit IRC02:43
*** armaan has joined #puppet-openstack02:43
openstackgerritzhongshengping proposed openstack/puppet-openstack-integration master: Move puppet5 jobs into check pipeline as non-voting  https://review.openstack.org/55634102:46
openstackgerritMerged openstack/puppet-openstack-integration master: Use Debian's repo when using Debian  https://review.openstack.org/55848502:49
openstackgerritMerged openstack/puppet-openstack-integration master: Fixed puppet repo & key in Debian  https://review.openstack.org/55845702:49
*** ykarel|afk has joined #puppet-openstack04:09
*** ykarel|afk is now known as ykarel04:10
*** asilenkov has quit IRC04:12
*** asilenkov has joined #puppet-openstack04:13
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55836104:33
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Add puppet-openstack-integration-jobs-all job to the repo  https://review.openstack.org/55867404:34
*** tonyb has quit IRC04:45
*** jtomasek has joined #puppet-openstack05:39
*** PagliaccisCloud has quit IRC05:40
*** PagliaccisCloud has joined #puppet-openstack05:45
*** agurenko has joined #puppet-openstack05:50
openstackgerritzhongshengping proposed openstack/puppet-ec2api master: Configure metadata_proxy_shared_secret as secret  https://review.openstack.org/55869705:55
openstackgerritOpenStack Proposal Bot proposed openstack/puppet-openstack-integration master: Updated from Puppet OpenStack modules constraints  https://review.openstack.org/55870206:09
*** jaosorior has quit IRC06:25
*** shardy has quit IRC06:36
*** shardy has joined #puppet-openstack06:36
openstackgerritMerged openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834406:42
*** jaosorior has joined #puppet-openstack06:58
openstackgerritSulaiman Radwan proposed openstack/puppet-cinder master: Deprecate iscsi praramters in cider backend  https://review.openstack.org/55871406:59
*** armaan has quit IRC07:12
*** armaan has joined #puppet-openstack07:12
*** skramaja has joined #puppet-openstack07:22
*** rcernin has quit IRC07:23
*** tesseract has joined #puppet-openstack07:26
*** amoralej|off is now known as amoralej07:34
*** shardy has quit IRC07:45
*** shardy has joined #puppet-openstack07:45
*** jpena|off is now known as jpena07:46
openstackgerritMerged openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55836107:57
openstackgerritzhongshengping proposed openstack/puppet-aodh master: Deprecate auth_uri option  https://review.openstack.org/55834008:08
*** agurenko has quit IRC08:09
openstackgerritThomas Goirand proposed openstack/puppet-neutron master: WIP: ACK Debian's switch to Python 3 for Neutron  https://review.openstack.org/55873308:10
*** agurenko has joined #puppet-openstack08:12
openstackgerritzhongshengping proposed openstack/puppet-ceilometer master: Deprecate auth_uri option  https://review.openstack.org/55845408:15
*** gfidente has joined #puppet-openstack08:42
*** gfidente has quit IRC08:42
*** gfidente has joined #puppet-openstack08:42
*** vnogin has joined #puppet-openstack09:07
zigoAny idea what's going on in the gate? Everything is failing now, with this error:09:11
zigo"Puppet (err): Failed to apply catalog: File: /etc/neutron/neutron.conf does not contain all required sections.  Neutron types will not work if neutron is not correctly configured."09:11
zigoIt doesn't feel right, as I inspected neutron.conf from the logs, and it seemed correct. So there's something else going on.09:11
zigohttps://review.openstack.org/#/c/55848309:11
*** vnogin has quit IRC09:11
*** ykarel_ has joined #puppet-openstack09:14
*** ykarel has quit IRC09:17
openstackgerritMerged openstack/puppet-keystone master: Add puppet-openstack-integration-jobs-all job to the repo  https://review.openstack.org/55867409:17
*** vnogin has joined #puppet-openstack09:28
*** salmankhan has joined #puppet-openstack09:28
*** ykarel__ has joined #puppet-openstack09:39
*** ykarel_ has quit IRC09:43
*** dtantsur|afk is now known as dtantsur09:54
openstackgerritSulaiman Radwan proposed openstack/puppet-cinder master: Deprecate iscsi praramters in cinder backend  https://review.openstack.org/55871409:54
openstackgerritTobias Urdin proposed openstack/puppet-glance master: Fix README to use api and registry classes  https://review.openstack.org/55877409:58
*** jaganathan has quit IRC10:05
*** HW_Peter has joined #puppet-openstack10:06
*** jtomasek_ has joined #puppet-openstack10:06
*** vnogin_ has joined #puppet-openstack10:07
*** armaan_ has joined #puppet-openstack10:07
*** beekneemech has joined #puppet-openstack10:10
*** tdb_ has joined #puppet-openstack10:11
*** jgrassle1 has joined #puppet-openstack10:11
*** m3ntat has joined #puppet-openstack10:13
*** gfidente^2nd has joined #puppet-openstack10:14
*** gfidente has quit IRC10:15
*** jtomasek has quit IRC10:15
*** owalsh has quit IRC10:15
*** mentat has quit IRC10:15
*** bnemec has quit IRC10:15
*** vnogin has quit IRC10:15
*** armaan has quit IRC10:15
*** cgfbee has quit IRC10:15
*** HW-Peter has quit IRC10:15
*** mkarpin has quit IRC10:15
*** tdb has quit IRC10:15
*** dmsimard has quit IRC10:15
*** jgrassler has quit IRC10:15
*** owalsh has joined #puppet-openstack10:17
*** mkarpin has joined #puppet-openstack10:18
*** cgfbee has joined #puppet-openstack10:18
*** dmsimard has joined #puppet-openstack10:18
*** salmankhan has quit IRC10:28
*** salmankhan has joined #puppet-openstack10:32
*** rcernin has joined #puppet-openstack10:44
openstackgerritMerged openstack/puppet-ironic master: Deprecate auth_uri option  https://review.openstack.org/55845010:47
*** gfidente^2nd has quit IRC11:11
*** vnogin_ has quit IRC11:20
*** gfidente has joined #puppet-openstack11:22
*** gfidente has quit IRC11:22
*** gfidente has joined #puppet-openstack11:22
*** gyan__ has quit IRC11:38
*** ykarel__ has quit IRC11:43
*** vnogin has joined #puppet-openstack11:45
*** ykarel has joined #puppet-openstack11:50
*** jpena is now known as jpena|lunch11:53
*** dprince has joined #puppet-openstack11:55
*** vnogin has quit IRC11:57
*** alee has joined #puppet-openstack12:10
*** atoth has joined #puppet-openstack12:13
*** amoralej is now known as amoralej|lunch12:29
openstackgerritAlex Schultz proposed openstack/puppet-neutron master: Revert "Deprecate auth_uri parameter"  https://review.openstack.org/55880312:38
mwhahahaI think -^ broke the gate12:40
mwhahahawe'll see12:40
*** vnogin has joined #puppet-openstack12:41
*** trown|outtypewww is now known as trown12:43
*** colonwq has quit IRC12:44
*** jpena|lunch is now known as jpena12:53
*** shardy is now known as shardy_mtg12:58
jpenamwhahaha: the initial issue is https://review.openstack.org/558344. That changed auth_uri to www_authenticate_uri, and several providers seem to depend on that13:08
mwhahahaYea that's what I figured13:10
jpenawe've seen that in Packstack jobs, too13:11
*** morazi has joined #puppet-openstack13:12
*** salmankhan has quit IRC13:15
*** ykarel has quit IRC13:21
*** amoralej|lunch is now known as amoralej13:21
*** armaan_ has quit IRC13:22
*** colonwq has joined #puppet-openstack13:23
*** armaan has joined #puppet-openstack13:23
*** salmankhan has joined #puppet-openstack13:37
*** vnogin has quit IRC13:45
*** vnogin has joined #puppet-openstack13:45
mwhahahahmm my revert fails ci now13:48
mwhahahai wonder if we're not testing something13:48
*** armaan has quit IRC13:49
*** armaan has joined #puppet-openstack13:49
*** ykarel has joined #puppet-openstack13:49
openstackgerritTobias Urdin proposed openstack/puppet-glance master: Add proxy support to glance_image resource  https://review.openstack.org/55882513:51
mwhahahaok so the keystone change needs to be modified to set both13:53
mwhahahauntil we clean all of them up13:53
* mwhahaha will propose a fix13:53
EmilienMmwhahaha: why did he auto approve? https://review.openstack.org/#/c/558361/13:54
EmilienMsame for https://review.openstack.org/#/c/558344/13:54
openstackgerritAlex Schultz proposed openstack/puppet-keystone master: Continue to define auth_uri  https://review.openstack.org/55882713:55
* mwhahaha shrugs13:55
EmilienMmwhahaha: also why did he remove p-o-i jobs in puppet-keystone??13:56
mwhahahado i look like a mind reader?13:56
EmilienMand he's not on IRC AFIK13:56
EmilienMI'll send an email13:56
jaosoriormwhahaha: you kinda do. It's the beard.13:56
jaosorior:P13:57
mwhahahaಠ_ಠ13:57
mwhahahaat the moment, http://i0.kym-cdn.com/photos/images/original/000/282/392/b8f.jpg would be very accurate if i drank coffee13:58
jaosoriorhahaha daaamn13:58
jaosoriorgonna use that gif myself13:58
*** hamdyk has joined #puppet-openstack14:16
zigomwhahaha: Hi there! Any idea what's going on with testing at https://review.openstack.org/#/c/558483/ ?14:16
zigoSome tests passed this morning, but now none of them do even after a few rechecks... :(14:17
mwhahahayes we're aware14:17
mwhahahastuffs broke14:17
mwhahahaworking on it14:17
zigoAh ok ! :)14:17
zigoThanks.14:17
zigoIf you remember, ping me when fixed...14:17
zigoOh, I see in the backlog ... :P14:18
hamdykHi all, how can I use a not yet merged patch from puppet-cinder in puppet-tripleo ?14:19
hamdykI need to use resources from my patch in puppet-cinder14:20
hamdykin a new patch in puppet-tripleo14:20
mwhahahahamdyk: you should be able to depends-on14:20
hamdykunit testing fails because there is no such resource in master puppet-cinder14:20
mwhahahahamdyk: locally?14:21
mwhahahaor in ci14:21
hamdyklocally14:21
mwhahahayou'd have to manually pull that in14:21
mwhahahayou can do bundle exec rake spec_prep14:21
mwhahahathen manually update the fixtures/modules/cinder to have your fix14:22
hamdykahaa14:22
hamdykI see, thank you14:22
hamdykI'll try that now14:22
mwhahahathen test with bundle exec rake spec_standalone14:22
mwhahahaif you do that it won't cleanup the modules14:22
mwhahahaso you can just iterate on it14:22
mwhahahabundle exec rake spec includes the prep/testing/cleanup14:23
mwhahahabut you can manually do those phases14:23
mwhahahahidden unit testing tricks :D14:23
hamdykactually I'm using PDK to run tests but I got your idea14:23
*** armaan has quit IRC14:25
openstackgerritAlex Schultz proposed openstack/puppet-keystone master: Continue to define auth_uri  https://review.openstack.org/55882714:31
hamdyk1234514:31
*** rcernin has quit IRC14:32
*** vnogin has quit IRC14:47
*** vnogin has joined #puppet-openstack14:48
*** vnogin has quit IRC14:53
*** morazi has quit IRC14:55
*** ChanServ sets mode: +o mwhahaha15:01
*** mwhahaha changes topic to "CI Status: RED | Puppet OpenStack modules https://docs.openstack.org/puppet-openstack-guide/latest/"15:01
*** hamdyk has quit IRC15:08
*** vnogin has joined #puppet-openstack15:09
*** morazi_onsite has joined #puppet-openstack15:10
*** morazi_onsite is now known as morazi15:11
EmilienMmnaser: if you around: https://review.openstack.org/#/c/558827/15:23
*** salmankhan has quit IRC15:25
*** salmankhan has joined #puppet-openstack15:25
mnaserEmilienM: checking15:34
*** jaganathan has joined #puppet-openstack15:35
EmilienMmnaser: I'm really unhappy with his self approving thing on that one.15:35
mnaserEmilienM: i agree, but i think that we kinda have to set an example, we've self approved things in the past too, so we have to all set an example :\15:36
mnaseri know sometimes that we're pressed on time but yeah, this is pretty critical15:36
mnasermistakes happen and he's put a lot of good work in the past but it has to be clear that this should *not* happen15:36
mnaserEmilienM, mwhahaha: so just to follow up, the issue is that providers are broken right now because they pulled auth_uri to run the api requests, correct?15:38
*** tesseract has quit IRC15:38
mwhahahathey look for it in the config15:38
mwhahahayea15:38
*** dtantsur is now known as dtantsur|brb15:38
mwhahahaif it's not provided that's how it's getting pulled out for auth in the providers15:39
mnasergotcha15:39
mnaserand this wasn't caught because integration tests were removed15:39
mwhahahawe need to continue to declare it until it's been cleaned up everywhere15:39
mwhahahayea it seems that way15:39
mwhahahaeither way, when those renames happen there's also package promotion problems as well15:40
mwhahahawe're still using queens ubuntu things15:40
mnaserokay, well this fix helps unblock things15:40
mwhahahaso in this case it shouldn't have been approved/merged so quickly15:40
mwhahahawe needed to keep some sort of backwards compatibility in place15:40
mnaseryeah it affects downstream a bunch15:40
*** tesseract has joined #puppet-openstack15:41
mnasermwhahaha: i left a comment on the bug, +W'd (it looks like the change is almost done so itll get right into gate)15:42
EmilienMmnaser: I agree with you, we have done the same thing in the past, but we also kind of maintain our CI (and not only puppet but also tripleo etc), so...15:42
EmilienMmnaser: anyway, I hope my email was nice :)15:42
mnaseri will ask him if he can push the appropriate changes to all the providers to use either auth_url or www_authenticate_uri with fallback15:42
mwhahahathere are changes for the www_authenticate_uri15:43
mwhahahawe just needed this auth_uri bit a bit longer15:43
* mnaser is in the middle of a meeting so i'll try to digest this when im done15:43
mwhahahayea we'll get it sorted today :D15:43
mnaserEmilienM: it was clear and nice :)15:43
*** agurenko has quit IRC15:44
*** armaan has joined #puppet-openstack15:46
*** skramaja has quit IRC15:50
*** salmankhan has quit IRC15:56
*** vnogin has quit IRC15:57
*** atoth has quit IRC16:00
*** salmankhan has joined #puppet-openstack16:03
*** jaganathan has quit IRC16:10
*** trown is now known as trown|lunch16:14
*** atoth has joined #puppet-openstack16:15
*** beekneemech is now known as bnemec16:42
*** dprince has quit IRC16:59
EmilienMI think https://review.openstack.org/#/c/558827/ failed on horizon :(16:59
mwhahahastupid horizon17:10
*** salmankhan has quit IRC17:13
*** jpena is now known as jpena|off17:19
*** trown|lunch is now known as trown17:26
*** dprince has joined #puppet-openstack17:26
*** tdb_ has quit IRC17:31
*** tdb has joined #puppet-openstack17:31
*** agurenko has joined #puppet-openstack17:40
*** gfidente is now known as gfidente|afk17:42
*** vnogin has joined #puppet-openstack17:44
*** sai_p has joined #puppet-openstack17:44
*** atoth has quit IRC17:56
*** shardy_mtg has quit IRC18:06
*** vnogin has quit IRC18:08
*** atoth has joined #puppet-openstack18:10
*** tesseract has quit IRC18:14
*** armaan has quit IRC18:16
openstackgerritTobias Urdin proposed openstack/puppet-keystone master: Use openstacklib::wsgi::apache for keystone wsgi  https://review.openstack.org/55888718:16
*** vnogin has joined #puppet-openstack18:24
*** vnogin has quit IRC18:28
*** dtantsur|brb is now known as dtantsur18:29
*** armaan has joined #puppet-openstack18:30
*** armaan has quit IRC18:35
*** armaan has joined #puppet-openstack18:36
*** amoralej is now known as amoralej|off18:51
*** dtantsur is now known as dtantsur|afk18:52
*** gfidente|afk has quit IRC18:56
*** agurenko has quit IRC19:11
*** atoth has quit IRC19:16
*** armaan has quit IRC19:31
openstackgerritMerged openstack/puppet-keystone master: Continue to define auth_uri  https://review.openstack.org/55882719:34
*** vnogin has joined #puppet-openstack19:34
*** ykarel is now known as ykarel|away19:35
*** armaan has joined #puppet-openstack19:38
mwhahahayay it's finally merged19:43
*** alee has quit IRC19:51
*** armaan has quit IRC19:54
*** colonwq has quit IRC20:05
*** alee has joined #puppet-openstack20:08
*** colonwq has joined #puppet-openstack20:20
*** vnogin has quit IRC20:21
*** ykarel|away has quit IRC20:25
*** vnogin has joined #puppet-openstack20:25
*** colonwq has quit IRC20:35
openstackgerritTobias Urdin proposed openstack/puppet-nova master: Deprecate auth_uri option  https://review.openstack.org/55845120:35
*** vnogin has quit IRC20:35
openstackgerritTobias Urdin proposed openstack/puppet-keystone master: Use openstacklib::wsgi::apache for keystone wsgi  https://review.openstack.org/55888720:42
*** jtomasek_ has quit IRC20:44
zigomwhahaha: Thanks for the work! :)20:48
* zigo does a recheck.20:48
zigoThat's one full day of work wasted because of this ... :/20:48
zigoOh, it passes ! :)20:48
zigoWhat's zhongshengping's IRC name?20:49
zigoThanks for the recheck man.20:49
zigoI'd appreciate a +2 ... :P20:49
zigoEmilienM: https://review.openstack.org/#/c/558483/ would you mind?20:49
zigoThen I can try again the openstack-integration's ./all-in-one.sh script in my VM.20:50
zigo(once this one is merged)20:50
EmilienMthere is a comment from mwhahaha https://review.openstack.org/#/c/558483/7/manifests/repo/debian/params.pp20:50
mwhahahaEmilienM: well i made the change :D just a thought20:50
mwhahahawe don't have to remove it20:50
mwhahahabut we could20:50
openstackgerritTobias Urdin proposed openstack/puppet-glance master: Add proxy support to glance_image resource  https://review.openstack.org/55882520:51
zigoEmilienM: I intend to fix this in a better way after it's fixed, because I do want to keep $deb_location in params.pp20:51
zigoie: still continue to make it possible to override the default mirror.20:51
zigo(which currently defaults to stretch-queens.debian.net)20:52
EmilienM+220:52
EmilienMzigo: are you using Puppet?20:52
mwhahahazigo: actually the params.pp is unnecessary because https://review.openstack.org/#/c/558483/7/manifests/repo/debian/debian.pp@5020:52
mwhahahawe don't actually use that var which was my comment20:53
zigoEmilienM: Yeah, I'm currently working on building Infomaniak's public network with Stretch + Queens + puppet-openstack.20:54
zigoEmilienM: So far, the ./all-in-one.sh can install quite a lot of things, but fails because some stuff needs to use python3- instead of python-.20:55
zigoIt shouldn't be hard to patch, and it's easy to test for me by tweaking the Puppetfile with the proposed patches.20:55
zigo(ie: not use master but ref/xxx/yyy)20:55
zigoAnd so far, it's been a lot of fun for me to learn puppet ! :)20:56
zigoAfter all these years, I finally have the opportunity to do it.20:56
EmilienMcool20:56
EmilienMyeah the modules are awesome20:56
EmilienMand I don't say it because... you know20:56
zigoQuite, indeed.20:56
EmilienMbut really they are stable20:56
EmilienMpeople don't complain much20:56
EmilienMthey do their job20:56
EmilienMand cost us low maintenance AFICT20:56
zigoI don't think they need a lot of work to make it all working.20:57
zigoHow about upgrades? Is it smooth?20:57
zigoIs it gated?20:57
mwhahahawe don't really cover upgrades20:57
mwhahahasince a bunch of that is specific to the environment20:57
mwhahahabut upgrading the modules is pretty simple20:58
mwhahahasince we try to maintain backwards compatibility20:58
mwhahahafor at least one release20:58
zigoI have packaged all the modules in Debian, I don't know if you're aware of that.20:58
zigoTo setup a puppet-master, I just "apt-get install openstack-puppet-modules", and it's done.20:58
zigo:)20:59
EmilienMwhy upgrading? it's cloud20:59
openstackgerritTobias Urdin proposed openstack/puppet-openstack-integration master: Refactor package installations to bindep.txt  https://review.openstack.org/51168720:59
EmilienMjust re-install20:59
* EmilienM leaves20:59
zigoWhat I intend to do is to also provide hiera roles.20:59
zigoJust bundle everything, then people will just have to define hostnames and roles, start a script to generate passwords, then the cluster will automatically get installed.21:00
zigoThat's my current plan, at least.21:00
zigoHopefully, I'll get there.21:00
*** rcernin has joined #puppet-openstack21:00
mwhahahamagic :D21:01
zigo:P21:01
zigoEmilienM: Why upgrading: because it's a public cloud with already existing workload, Pushing customers to move from one cloud to another is too painful.21:02
zigoBut probably we'll do that, yeah.21:02
EmilienMI was joking.21:02
zigoEmilienM: Yeah, though I still don't have an answer to my question: is upgrading from one release to the next is gated in infra?21:04
zigoWe'll end up doing upgrade tests on our dev cloud before doing the production upgrade, of course, but still...21:05
zigoSo, what's zhongshengping's IRC nick? :)21:06
openstackgerritTobias Urdin proposed openstack/puppet-openstack-integration master: Drop unnecessary clean-ups for Puppet  https://review.openstack.org/51065121:11
openstackgerritTobias Urdin proposed openstack/puppet-openstack-integration master: Drop unnecessary clean-ups for Puppet  https://review.openstack.org/51065121:17
openstackgerritTobias Urdin proposed openstack/puppet-openstack-integration master: Fix MANAGE_REPOS for Debian-based OS  https://review.openstack.org/51065221:17
zigomwhahaha: How do I fix this? http://logs.openstack.org/33/558733/1/check/puppet-openstack-unit-4.8-centos-7/20d6f3f/job-output.txt.gz#_2018-04-04_08_23_19_25977121:26
zigoie: how do I make facts available from the unit test?21:26
mwhahahadepends on the test21:27
zigoIs it the topmost: require 'spec_helper' ?21:27
zigomwhahaha: spec/classes/horizon_init_spec.rb in puppet-neutron21:27
zigoSorry, no.21:28
zigospec/classes/neutron_db_spec.rb in puppet-neutron21:28
mwhahahaso debian is not part of our default tests21:28
zigoie: https://review.openstack.org/#/c/558733/1/spec/classes/neutron_db_spec.rb21:28
mwhahahaline 96-9921:29
mwhahahathose are where the facts come in21:29
mwhahahabut what you're attempting to do isn't going to work in the structure of those tests21:29
mwhahahamany of those tests need to get updated to our newer syntax21:29
*** rcernin has quit IRC21:29
zigoHum...21:29
mwhahahahttps://review.openstack.org/#/c/558733/1/spec/classes/neutron_plugins_ml2_bagpipe_spec.rb@5121:29
mwhahahawe use rspec puppet facts to automatically populate the tests21:30
zigomwhahaha: The important bit is this: https://review.openstack.org/#/c/558733/1/manifests/params.pp21:30
mwhahahaand run through the rhel/ubuntu tests21:30
zigoI was scared it would break if I just push that.21:30
mwhahahayou'd need to include debian in the supported os21:30
mwhahahawell if the tests work, you wouldn't be breaking anything21:30
mwhahaha:D21:30
zigoRight.21:31
mwhahahahowever i think you are improperly changing things21:31
zigoSo, I'll revert these changes21:31
mwhahahawe won't have os_package_type == debian under redhat21:31
zigoYou'll have os_package_type == rpm21:32
zigoWhich is fine.21:32
mwhahahai'll comment on the review21:32
zigoThis was discussed and done in the Hongkong summit.21:32
mwhahaharight21:32
mwhahahabut there's already an os family block21:32
zigoThis makes it possible to run Debian packages on top of Ubuntu.21:32
* mwhahaha is commenting21:32
mwhahahayou just have a single bad change in that21:32
zigoAh...21:33
openstackgerritTobias Urdin proposed openstack/puppet-keystone master: Use openstacklib::wsgi::apache for keystone wsgi  https://review.openstack.org/55888721:33
* zigo re-read the change21:33
mwhahahacommented21:34
mwhahahaat least on params21:34
mwhahahanow for the tests i think you'd need to actually rewrite a bunch of the tests to properly test the debian/ubuntu changes21:35
mwhahahawe might have some logic for the ml2 stuff previously21:35
mwhahahathat you could try and reuse21:35
openstackgerritTobias Urdin proposed openstack/puppet-keystone master: Use openstacklib::wsgi::apache for keystone wsgi  https://review.openstack.org/55888721:36
zigomwhahaha: Actually, I have just uploaded networking-baremetal to Sid ! :)21:36
zigoBecause I tried Ironic, and it is now required.21:36
zigoIt's sitting in the ftpmaster NEW queue for review.21:36
zigomwhahaha: And also, there's currently no way Ironic can work in Ubuntu (like... at all !!!).21:36
mwhahaha:(21:36
zigoBionic will simply not have support for it.21:37
zigoThey do MaaS you know...21:37
mwhahahanot sure we test it under ubuntu21:37
zigoThey don't care about Ironic.21:37
zigoImpossible that you do.21:37
zigoThere's just no package that would support it.21:37
zigoI checked for that last week.21:37
zigoAnd fixed so many things for Ironic to work in Debian.21:38
zigoUnfortunately, you can't ask Ubuntu to just "sync from Sid", because I've switched all to Python 3.21:38
zigoAlso, Biionic will be out in a few weeks...21:38
zigoSad story...21:39
openstackgerritTobias Urdin proposed openstack/puppet-keystone master: Use openstacklib::wsgi::apache for keystone wsgi  https://review.openstack.org/55888721:41
*** colonwq has joined #puppet-openstack21:44
openstackgerritThomas Goirand proposed openstack/puppet-neutron master: WIP: ACK Debian's switch to Python 3 for Neutron  https://review.openstack.org/55873321:46
*** alee has quit IRC21:50
zigoOh, sorry, just understood your comment about networking-baremetal21:51
zigo:)21:51
mwhahahai think you still missed it, let me comment again21:52
mwhahaha106-110 shouldn't be there21:52
openstackgerritThomas Goirand proposed openstack/puppet-neutron master: WIP: ACK Debian's switch to Python 3 for Neutron  https://review.openstack.org/55873321:54
mwhahahai posted an alternative on ps221:57
*** morazi has quit IRC22:02
zigomwhahaha: I very much like your idea of the $ver_mod thing, that will make everything so much easier to read.22:08
mwhahahayea22:08
mwhahahait's also something we might need to do for python3 under fedora as well at some point22:08
* zigo scraps his parrams.pp and restarts from scratch.22:10
zigomwhahaha: Wouldn't it be nicer to just have a $pyvers variable set globally as a fact? ie: ${::pyvers}.22:15
zigoOr something like that ...22:16
mwhahahaehhhh not necessarily22:16
mwhahahabut that could work as well22:16
zigoIn openstacklib or something.22:16
mwhahahathe problem is that it's not 100%22:16
zigomwhahaha: Well, neutron is the first one that I'm fixing, but there will be others.22:16
mwhahahayea22:16
mwhahahai'm sure22:16
mwhahahawe went through and actually removed the version from the package a while back22:16
mwhahahaanyway22:17
* mwhahaha wanders off22:17
zigomwhahaha: I can first try like you suggested, see how it goes with neutron (which was failing the openstack-integration script), and then attempt a more global thing...22:17
zigoThis wont go away in Debian.22:17
zigoNot before Py2 is killed.22:17
zigoAnd that will be ... in 3 decades? :)22:17
zigo(hopefully, not...)22:17
*** alee has joined #puppet-openstack22:24
openstackgerritThomas Goirand proposed openstack/puppet-neutron master: WIP: ACK Debian's switch to Python 3 for Neutron  https://review.openstack.org/55873322:30
* zigo goes to sleep22:31
*** vnogin has joined #puppet-openstack22:36
*** vnogin has quit IRC22:41
*** rcernin has joined #puppet-openstack22:45
*** colonwq has quit IRC23:47

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!