Monday, 2016-10-03

openstackgerritEmilien Macchi proposed openstack/puppet-tripleo: CI test  https://review.openstack.org/38088000:04
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: Enable TestEncryptedCinderVolumes tests (for real)  https://review.openstack.org/38037400:06
*** rstarmer has quit IRC00:27
openstackgerritMerged openstack/puppet-ceilometer: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38050800:37
openstackgerritMerged openstack/puppet-zaqar: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38054900:37
openstackgerritMerged openstack/puppet-barbican: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38050700:37
openstackgerritMerged openstack/puppet-sahara: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38053700:37
openstackgerritMerged openstack/puppet-mistral: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38052500:37
openstackgerritMerged openstack/puppet-openstack_extras: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38053000:37
openstackgerritMerged openstack/puppet-gnocchi: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38051600:37
openstackgerritMerged openstack/puppet-oslo: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38053200:37
openstackgerritMerged openstack/puppet-swift: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38053800:37
openstackgerritMerged openstack/puppet-neutron: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38052700:37
openstackgerritMerged openstack/puppet-glance: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38051400:38
openstackgerritMerged openstack/puppet-ironic: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38052000:38
*** ducttape_ has joined #puppet-openstack00:46
*** johnmilton has joined #puppet-openstack01:08
*** AnarchyAo has joined #puppet-openstack01:22
colonwqEmilienM, dmsimard patch 377158 (cinder backup to rbd) is successful with ipv4 by fails with ipv6. I am manually repeating the settings and test01:28
EmilienMcolonwq: looking01:29
EmilienMcolonwq: mhh ok01:30
colonwqEmilienM, I can resubmit the patch with ipv6=false if you want to see it in CI.01:30
EmilienMcolonwq: it would be great to test cinder backup with rbd backend of scenario001 and swift backend on scenario00201:30
EmilienMcolonwq: no01:30
EmilienMcolonwq: I dropped a comment also01:32
colonwqEmilienM, Ok01:32
colonwqEmilienM, I'll make the suggested change. Thanks.01:35
openstackgerritKeith Schincke proposed openstack/puppet-openstack-integration: Add cinder::backup test to scenario0001  https://review.openstack.org/37715801:42
colonwqEmilienM, Can I -2 my own patch until it is ship shape?01:44
*** ilbot3 has quit IRC01:45
*** ilbot3 has joined #puppet-openstack01:48
*** bfg9000 has quit IRC01:49
*** johnmilton has quit IRC02:12
openstackgerritMatt Fischer proposed openstack/puppet-nova: Allow to set allow_resize_to_same_host in nova-api  https://review.openstack.org/37364802:12
EmilienMcolonwq: I have -2 on it, don't worry it won't merge ;-)02:24
*** johnmilton has joined #puppet-openstack02:34
openstackgerritMerged openstack/puppet-nova: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38052803:11
openstackgerritMerged openstack/puppet-cinder: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38051003:40
openstackgerritMerged openstack/puppet-keystone: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38052203:40
openstackgerritMerged openstack/puppet-horizon: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38051903:40
openstackgerritMerged openstack/puppet-designate: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38051203:40
openstackgerritMerged openstack/puppet-tempest: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38054003:40
openstackgerritMerged openstack/puppet-openstack-integration: Pin Ubuntu repositories to stable Newton packaging  https://review.openstack.org/38087403:40
openstackgerritMerged openstack/puppet-openstack-integration: Revert "Disable Telemetry testing on Ubuntu"  https://review.openstack.org/38087503:40
openstackgerritMerged openstack/puppet-trove: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38054103:40
openstackgerritMerged openstack/puppet-heat: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38051704:52
*** skramaja has joined #puppet-openstack05:03
*** jaosorior has joined #puppet-openstack05:04
*** jaosorior has quit IRC05:31
*** jaosorior has joined #puppet-openstack05:32
openstackgerritJuan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable TLS in the internal network for gnocchi  https://review.openstack.org/37764505:32
openstackgerritJuan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable TLS in the internal network for ceilometer  https://review.openstack.org/37764405:32
openstackgerritJuan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable TLS in the internal network for aodh  https://review.openstack.org/36545705:32
openstackgerritJuan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable TLS in the internal network for keystone  https://review.openstack.org/32702905:32
openstackgerritJuan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable internal TLS for MySQL  https://review.openstack.org/37847105:32
openstackgerritJuan Antonio Osorio Robles proposed openstack/puppet-tripleo: Fetch internal certificates for HAProxy based on network  https://review.openstack.org/36654805:32
*** ccamacho has joined #puppet-openstack05:35
*** richm has quit IRC05:40
*** rcernin has joined #puppet-openstack06:04
*** dgurtner has joined #puppet-openstack06:07
*** leanderthal|afk is now known as leanderthal06:19
openstackgerritSharat Sharma proposed openstack/puppet-designate: Added the options to be configured for designate-central service  https://review.openstack.org/37995006:27
openstackgerritMerged openstack/puppet-tripleo: Added X-Forwarded-Proto headers for horizon  https://review.openstack.org/35951906:30
*** jtomasek has joined #puppet-openstack06:44
*** hjensas has quit IRC06:56
*** tesseract- has joined #puppet-openstack07:03
*** jpena|off is now known as jpena07:20
*** amoralej|off is now known as amoralej07:22
*** dgurtner has quit IRC07:28
*** danpawlik has joined #puppet-openstack07:38
*** zigo has quit IRC07:39
*** zigo has joined #puppet-openstack07:42
*** zigo is now known as Guest2475607:42
*** jpich has joined #puppet-openstack07:43
openstackgerritMerged openstack/puppet-tripleo: Cinder: Add iSCSI protocol parameter  https://review.openstack.org/36754207:49
*** hjensas has joined #puppet-openstack07:55
*** shardy has joined #puppet-openstack07:58
openstackgerritOpenStack Proposal Bot proposed openstack/puppet-openstack-integration: Promote RDO repository to latest consistent URL  https://review.openstack.org/38096708:02
*** saneax-_-|AFK is now known as saneax08:07
*** jperry has quit IRC08:27
*** paramite has joined #puppet-openstack08:28
*** dgurtner has joined #puppet-openstack08:31
*** dtantsur|afk is now known as dtantsur08:37
*** dgurtner has quit IRC08:42
*** spredzy has quit IRC08:47
*** derekh has joined #puppet-openstack08:47
*** spredzy has joined #puppet-openstack08:48
*** _degorenko|afk is now known as degorenko08:52
*** Guest24756 is now known as zigo08:54
*** spredzy has quit IRC08:56
*** spredzy has joined #puppet-openstack08:59
*** spredzy has quit IRC09:20
*** spredzy has joined #puppet-openstack09:22
*** gfidente has joined #puppet-openstack09:23
*** jaosorior is now known as jaosorior_lunch09:25
*** igajsin has joined #puppet-openstack09:27
openstackgerritSharat Sharma proposed openstack/puppet-designate: Added the options to be configured for designate-central service  https://review.openstack.org/37995009:50
openstackgerritMerged openstack/puppet-openstack-integration: Promote RDO repository to latest consistent URL  https://review.openstack.org/38096709:50
*** mkarpin has left #puppet-openstack09:56
*** jaosorior_lunch is now known as jaosorior10:01
*** richm has joined #puppet-openstack10:09
*** openstackgerrit has quit IRC10:48
*** openstackgerrit has joined #puppet-openstack10:49
*** cdelatte has joined #puppet-openstack10:55
openstackgerritKeith Schincke proposed openstack/puppet-openstack-integration: Add cinder::backup test to scenario0001  https://review.openstack.org/37715810:55
*** mkarpin has joined #puppet-openstack11:01
openstackgerritJulie Pichon proposed openstack/puppet-tripleo: Clean out UI httpd configuration file  https://review.openstack.org/38015211:14
*** psanchez has joined #puppet-openstack11:21
*** lucas-afk is now known as lucasagomes11:26
openstackgerritPeter Zhurba proposed openstack/puppet-glare: Add hooks for external install & svc management  https://review.openstack.org/38002611:27
EmilienMhello11:37
*** johnmilton has quit IRC11:38
openstackgerritPeter Zhurba proposed openstack/puppet-glare: Add posibility install glare from pip  https://review.openstack.org/37380511:54
*** dprince has joined #puppet-openstack11:56
*** johnmilton has joined #puppet-openstack12:04
*** johnmilton has quit IRC12:04
*** johnmilton has joined #puppet-openstack12:05
*** trown|outtypewww is now known as trown12:07
*** pradk has joined #puppet-openstack12:14
*** jayg|g0n3 is now known as jayg12:30
openstackgerritKeith Schincke proposed openstack/puppet-openstack-integration: Add cinder backup to scenario002  https://review.openstack.org/38108312:34
*** dgurtner has joined #puppet-openstack12:36
dtantsurhey EmilienM12:41
*** moravec has quit IRC12:42
*** jpena is now known as jpena|lunch12:43
iurygregorygood morning12:45
*** fultonj has joined #puppet-openstack12:55
*** degorenko is now known as _degorenko|afk12:58
*** dtantsur is now known as dtantsur|brb13:07
*** ducttape_ has quit IRC13:12
*** morazi has joined #puppet-openstack13:17
*** jperry has joined #puppet-openstack13:17
*** jperry has quit IRC13:18
*** dfisher has joined #puppet-openstack13:29
*** jaosorior has quit IRC13:31
*** jaosorior has joined #puppet-openstack13:32
*** imcsk8 has joined #puppet-openstack13:34
*** ducttape_ has joined #puppet-openstack13:39
*** jpena|lunch is now known as jpena13:42
*** moravec has joined #puppet-openstack13:43
*** jperry has joined #puppet-openstack13:43
*** moravec has quit IRC14:00
EmilienMiurygregory: can you review https://review.openstack.org/#/c/380492/ ?14:02
*** moravec has joined #puppet-openstack14:02
iurygregoryEmilienM, ack14:02
openstackgerritPeter Zhurba proposed openstack/puppet-glare: Add hooks for external install & svc management  https://review.openstack.org/38002614:03
openstackgerritPeter Zhurba proposed openstack/puppet-glare: Add posibility install glare from pip  https://review.openstack.org/37380514:06
openstackgerritMerged openstack/puppet-modulesync-configs: Update managed module list  https://review.openstack.org/38049214:10
*** saneax is now known as saneax-_-|AFK14:12
*** andreww has quit IRC14:13
*** beekneemech is now known as bnemec14:18
*** dtantsur|brb is now known as dtantsur14:20
*** _degorenko|afk is now known as degorenko14:22
*** moravec has quit IRC14:31
colonwqEmilienM, I'll add the tempest check to 381083 after I have it working in the local test environment.14:34
*** sharatss has joined #puppet-openstack14:36
*** dgurtner has quit IRC14:37
*** andreww has joined #puppet-openstack14:37
sharatsshttps://bugs.launchpad.net/puppet-glare/+bug/162987614:39
openstackLaunchpad bug 1629876 in puppet-zaqar "Change the link to home-page" [Undecided,New] - Assigned to Sharat Sharma (sharat-sharma)14:39
sharatssplease check this bug14:40
iurygregoryNote: This bug is under discussion. Once a decision is taken, it will be fixed14:41
iurygregorynot sure where is the discussion .-.14:41
degorenkosharatss: what's exactly you want to change? Overview section pointing to openstack?14:42
sharatssiurygregory, i just changed the description before pinging here14:42
sharatssdegerenko, all the openstack projects point to their respective developer docs in setup.cfg14:43
sharatssin puppet we are still pointing it to openstack.org14:43
degorenkoah14:44
degorenkolooks like you can do it, yeah14:44
sharatssyes14:44
degorenkoEmilienM: iurygregory mwhahaha ^ ?14:44
sharatssi thought it should point here: http://docs.openstack.org/developer/puppet-openstack-guide14:45
iurygregoryi'm fine with the change but i don't see the need because all readme have the link to puppet-openstack-guide14:45
mwhahahai thought there was some history as to why we pointed to openstack.org but i'm not against updating it14:45
*** moravec has joined #puppet-openstack14:48
sharatssi saw the same changes going to few other components, so i raised this issue14:48
openstackgerritEmilien Macchi proposed openstack/puppet-tripleo: Fix the timeout for pacemaker systemd resources  https://review.openstack.org/38066514:56
*** moravec has quit IRC14:57
*** mkarpin has quit IRC14:59
sharatssdegorenko: iurygregory mwhahaha are we going to fix this?15:03
degorenkono objections from my side15:03
sharatssdegorenko: thank u15:04
iurygregoryi have no objections too, but not sure what are the benefits =)15:04
mwhahahaconsistency i guess :D15:05
dmsimardI'm just going to leave this here http://lists.openstack.org/pipermail/openstack-dev/2016-September/104173.html15:06
* dmsimard hides15:06
mwhahahai don't think we need to fix it necessarily because we're not a python project15:06
mwhahahaso we don't actually use the setup.cfg for anything other than for the reno stuff15:06
dmsimardmwhahaha: what, you mean the puppet modules aren't published to pypi ?15:07
dmsimardpip install puppet-nova15:07
* dmsimard moans15:07
mwhahahaಠ_ಠ15:07
dmsimardwell I mean15:08
dmsimardthere's xstatic stuff on pypi15:08
dmsimardso there's a precedent15:08
*** dtantsur is now known as dtantsur|mtg15:08
* iurygregory lunch time15:12
*** mkarpin has joined #puppet-openstack15:13
openstackgerritMykyta Karpin proposed openstack/puppet-nova: [WIP] Add class for migration options configuration in qemu.conf  https://review.openstack.org/37875415:17
EmilienMmwhahaha: do you remember why we don't need to include ::stdlib in the manifests to use functions?15:19
*** andreww is now known as xarses15:19
*** rcernin has quit IRC15:19
mwhahahanope15:20
mwhahahaother than i thought they just worked15:20
*** danpawlik has quit IRC15:21
EmilienMsame :)15:21
dmsimardEmilienM: afaik things like functions, facts and providers/types are loaded automatically when the catalog is compiled15:22
mwhahahamaybe back in like the 0.26 days you needed to include stdlib :D15:22
dmsimardjust needs to be in /etc/puppet/modules15:22
EmilienMmhh ok15:22
mwhahahaif you wanted to use the stages from stdlib you needed to do an include stdlib15:23
mwhahahabut not the functions15:23
mwhahahahttps://forge.puppet.com/puppetlabs/stdlib#usage15:23
*** haplo37__ has joined #puppet-openstack15:29
*** saneax-_-|AFK is now known as saneax15:31
openstackgerritMichele Baldessari proposed openstack/puppet-tripleo: Change rabbitmq queues HA mode from ha-all to ha-exactly  https://review.openstack.org/37958615:31
*** leanderthal is now known as leanderthal|afk15:34
*** AnarchyAo has quit IRC15:35
*** jtomasek_ has joined #puppet-openstack15:41
*** moravec has joined #puppet-openstack15:41
*** dprince has quit IRC15:42
*** mfisch` is now known as mfisch15:43
*** mfisch is now known as Guest722315:43
*** moravec1 has joined #puppet-openstack15:45
*** sharatss has quit IRC15:46
*** moravec has quit IRC15:48
*** Guest7223 is now known as mfisch15:49
*** mfisch has quit IRC15:49
*** mfisch has joined #puppet-openstack15:49
*** tesseract- has quit IRC15:56
*** jtomasek_ has quit IRC15:58
*** moravec1 has quit IRC15:58
*** shardy has quit IRC16:00
mfischEmilienM: In 10 years you will be Norweigan actor Vegar Hoel: http://images-mds.staticskynet.be/NewsFolder/w-600_h-450_s-1/occupied_thomas_eriksen_20160105041850.jpg16:00
*** moravec has joined #puppet-openstack16:01
mfischI saw that watching a show this weekend, I think its you16:01
EmilienMlol16:01
EmilienMbecayse of my beard?16:02
mfischI think he just looks similar but the beard helps16:02
EmilienMinteresting16:03
EmilienMyou know it's hard to say when it's about yourself.16:03
*** hjensas has quit IRC16:03
mfischmaybe he needs a stunt double16:03
*** dtantsur|mtg is now known as dtantsur16:05
*** chem has quit IRC16:08
*** dprince has joined #puppet-openstack16:17
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122816:27
*** jpich has quit IRC16:28
*** moravec has quit IRC16:30
*** trown is now known as trown|lunch16:34
openstackgerritMerged openstack/puppet-vswitch: Move rspec-puppet-facts to spec helper  https://review.openstack.org/38054516:39
openstackgerritMerged openstack/puppet-tripleo: Add swift proxy for ceilometer middleware  https://review.openstack.org/37159116:40
openstackgerritMerged openstack/puppet-tripleo: telemetry: normalize coordination_url  https://review.openstack.org/38054716:40
openstackgerritMerged openstack/puppet-neutron: Change worker defaults to ::os_workers  https://review.openstack.org/38028616:41
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122816:44
*** derekh has quit IRC16:55
openstackgerritPradeep Kilambi proposed openstack/puppet-tripleo: Add swift proxy for ceilometer middleware  https://review.openstack.org/38125017:06
*** saneax is now known as saneax-_-|AFK17:07
*** saneax-_-|AFK is now known as saneax17:07
*** moravec has joined #puppet-openstack17:07
*** AnarchyAo has joined #puppet-openstack17:12
*** trown|lunch is now known as trown17:21
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Replace proxy concat/template with ini provider  https://review.openstack.org/37895017:23
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122817:23
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Replace proxy concat/template with ini provider  https://review.openstack.org/37895017:27
*** _ducttape_ has joined #puppet-openstack17:29
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122817:30
*** ducttape_ has quit IRC17:32
*** degorenko is now known as _degorenko|afk17:36
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-guide: new-module: document launchpad project  https://review.openstack.org/37893917:43
*** jpena is now known as jpena|away17:46
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122817:49
*** amoralej is now known as amoralej|off17:54
openstackgerritEmilien Macchi proposed openstack/puppet-tripleo: firewall: do not exclude empty services  https://review.openstack.org/38126617:57
*** dtantsur is now known as dtantsur|afk18:02
*** jaosorior has quit IRC18:07
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122818:11
openstackgerritKeith Schincke proposed openstack/puppet-openstack-integration: Add cinder backup to scenario002  https://review.openstack.org/38108318:13
openstackgerritGiulio Fidente proposed openstack/puppet-ceph: Split installed packages per role  https://review.openstack.org/38122818:15
*** gfidente has quit IRC18:19
*** _ducttape_ has quit IRC18:20
*** ducttape_ has joined #puppet-openstack18:21
openstackgerritMerged openstack/puppet-openstack-guide: new-module: document launchpad project  https://review.openstack.org/37893918:27
openstackgerritEmilien Macchi proposed openstack/puppet-tripleo: Fix the timeout for pacemaker systemd resources  https://review.openstack.org/38066518:27
*** rcernin has joined #puppet-openstack18:31
*** ducttape_ has quit IRC18:38
*** xarses has quit IRC18:39
*** moravec has quit IRC18:39
openstackgerritEmilien Macchi proposed openstack/puppet-tripleo: Clean out UI httpd configuration file  https://review.openstack.org/38015218:46
*** ducttape_ has joined #puppet-openstack18:57
openstackgerritMichele Baldessari proposed openstack/puppet-tripleo: Change rabbitmq queues HA mode from ha-all to ha-exactly  https://review.openstack.org/37958619:05
*** haplo37__ has quit IRC19:06
*** AnarchyAo has quit IRC19:10
openstackgerritMerged openstack/puppet-tripleo: Use FallbackResource instead of Rewrite for UI  https://review.openstack.org/37857119:16
*** johnmilton has quit IRC19:21
openstackgerritEmilien Macchi proposed openstack/puppet-tripleo: Use FallbackResource instead of Rewrite for UI  https://review.openstack.org/38127619:24
*** paramite has quit IRC19:32
*** johnmilton has joined #puppet-openstack19:35
*** johnmilton has quit IRC19:39
*** johnmilton has joined #puppet-openstack19:41
mfischEmilienM: we have an issue in puppet-nova with regions19:41
mfischclayton found it19:41
claytonit appears that openstacklib's openstack provider doesn't actually have any region support19:41
mwhahahaorly19:42
claytonam I just missing it?19:42
iurygregoryo.o19:42
mwhahahaif you set OS_REGION it should take it19:42
mwhahahahttps://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack/auth.rb#L45-L5019:42
EmilienMthat's unfortunate but possible19:42
mwhahahaor OS_REGION_NAME or whatever it is19:44
claytonsure, but to do this properly, it needs to be added to the KEYS arrays here, right? https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack/credentials.rb19:44
claytonand then the nova provider code changed to pass that through?19:44
claytonthe nova provider code already has the region, it's just not being passed along19:44
mwhahahayea that might be the missing case19:45
mfischmight also need domain there19:46
claytonthere are separate lists for v2 and v319:48
mfischpuppet's been using v3 for a long time I thought19:49
mwhahahanot all of them19:51
mwhahahanova still has a bunch that use v2 i think19:51
*** dgurtner has joined #puppet-openstack19:51
mwhahahawe've not been consistent in going back and updating the modules when we make changes like that19:51
mfischwe were on an older puppet-nova until this week19:53
mfischis mitaka final?19:53
EmilienMmitaka?19:53
iurygregorywe are in newton19:54
EmilienMwe released newton19:54
mfischyeah I meant that19:54
EmilienMand yes, it's a final release19:54
mfischits just that he's such a bad quarterback I cant say his name sorry19:54
EmilienMwell, we accept backports to stable/newton for bug fixes I guess19:54
mfischyeah we'll need it once we figure out the rix19:54
mfischthe fix even19:55
claytonEmilienM: it's broken in mitaka also19:55
mwhahahadid it ever work?19:55
claytonnot since the change to make nova use openstacklib for auth19:55
mwhahahacause i don't think we've ever properly tested the region19:55
mfischI dont think so19:55
claytonopenstacklib has never worked properly with regions19:55
claytonthe code just isn't there19:55
mwhahahano i meant did it work for nova at all19:56
claytonyes, it did, we fixed it :)19:56
mfischI fixed it I think19:56
EmilienMcan you file a bug?19:56
mwhahahahttps://bugs.launchpad.net/puppet-nova/+bug/1517220 or i guess we could reopen it :D19:57
openstackLaunchpad bug 1517220 in puppet-nova "provider code doesn't account for regions" [High,Fix released] - Assigned to Matt Fischer (mfisch)19:57
claytonthe fix is fairly straightforward19:57
mfischand host aggs is the same way we found it today19:58
mfischWest puppet trying to add to East host agg19:58
EmilienMwhat would we do without your feedback? :)19:59
mwhahahabe blissfully region free20:00
openstackgerritClayton O'Neill proposed openstack/puppet-openstacklib: Add region support to credentials  https://review.openstack.org/38128820:01
iurygregorythis the change to fix? ^ O.o20:02
mwhahahaat least it's a minor fix in a single spot20:02
claytonthat is the openstacklib change, there is a puppet-nova change to go with it20:03
claytonlooking at what tests need to be updated20:03
*** jpena|away is now known as jpena20:05
claytonwell, I put that bug in the commit, someone can reopen it if they want20:06
claytonthis is basically a regression20:07
claytonoh, this is the best part20:08
claytonmfisch reported and fixed this bug in code that was no longer being used20:08
claytonbecause it was already switched over to using the broken openstacklib code20:08
mfischbut our branch was so old we just pulled my commit in I guess20:09
claytonit worked for us because we cherry-picked it internally on to an older module that didn't use openstacklib yet20:09
mfischyep20:09
mfischclayton: should you make the test something other than Region1 becuase thats default?20:10
mfischor will it still catch the failure20:10
claytonI don't think it matters, it's not actually reading it out of a config file or anything20:10
mwhahahaRegionOne is techincally the default not Region1 but it should be ok20:10
mfischah20:11
mfischyeah you're right thats fine20:11
*** moravec has joined #puppet-openstack20:11
claytonactually, mfisch your fix probably did fix some code.  it appears that not all of the nova providers are using openstacklib20:11
*** jtomasek is now known as jtomasek|afk20:12
mwhahahayea thats why i said i didn't think nova was using the new stuff20:12
mwhahahanova has never really been properly migrated20:12
claytonthe ones here are: https://github.com/openstack/puppet-nova/commit/08ee5866a6c6440f9202eddbb8f7ae4ec24a1fca#diff-6f83046f529e571b086e130bb0a63c8720:13
colonwqdmsimard, How do I get clone a specific in review version of p-o-i? I want to clone 381083 and use run_tests.sh.20:17
*** dprince has quit IRC20:18
dmsimardcolonwq: not sure what you mean, git fetch https://git.openstack.org/openstack/puppet-openstack-integration refs/changes/83/381083/2 && git checkout FETCH_HEAD ?20:18
dmsimardcolonwq: or do you mean with weirdo ?20:18
mfischclayton: ^20:18
mfischsorry wrong window20:19
*** lucasagomes is now known as lucas-afk20:19
*** jpena is now known as jpena|off20:22
colonwqdmsimard, maybe. I am poking with your commands.20:22
dmsimardcolonwq: click the download button in gerrit at the top right20:22
dmsimardcolonwq: it gives you a command to check out the review20:22
dmsimardcolonwq: the one I gave you is the first one20:22
colonwqdmsimard, When did that button appear? Thanks.20:23
dmsimardcolonwq: it moved there when gerrit was updated a few months ago :/20:23
dmsimardbefore that it was in-line, somewhat close to the CI results.. I sort of forget20:23
openstackgerritMichele Baldessari proposed openstack/puppet-tripleo: Change rabbitmq queues HA mode from ha-all to ha-exactly  https://review.openstack.org/37958620:24
openstackgerritClayton O'Neill proposed openstack/puppet-nova: Fix region support for nova providers  https://review.openstack.org/38129520:25
mfischclayton: formatting is screwed up in the tests for that one ^20:26
claytonk, I'll fix.20:26
claytonah, right, I see.  it didnt' cherry-pick cleanly, that's probably why20:27
colonwqdmsimard, I got it to work. Thanks for the help.20:27
openstackgerritClayton O'Neill proposed openstack/puppet-nova: Fix region support for nova providers  https://review.openstack.org/38129520:27
*** jayg is now known as jayg|g0n320:27
dmsimardcolonwq: neat20:28
iurygregoryclayton, can you send other patch with release notes for 381288 and 381295?  or just upload a new patch in each one20:42
claytonsure20:44
iurygregorytks =D20:44
openstackgerritClayton O'Neill proposed openstack/puppet-openstacklib: Add region support to credentials  https://review.openstack.org/38128820:49
openstackgerritClayton O'Neill proposed openstack/puppet-nova: Fix region support for nova providers  https://review.openstack.org/38129520:52
*** dgurtner has quit IRC21:03
*** trown is now known as trown|outtypewww21:06
*** openstackgerrit has quit IRC21:19
*** openstackgerrit has joined #puppet-openstack21:19
*** ducttape_ has quit IRC21:49
openstackgerritAlex Schultz proposed openstack/puppet-openstack_spec_helper: Remove add_custom_fact for puppet version  https://review.openstack.org/38132821:58
*** jperry has quit IRC22:02
*** rcernin has quit IRC22:25
*** dfisher has quit IRC23:03
*** hjensas has joined #puppet-openstack23:13
*** hjensas has joined #puppet-openstack23:13
*** markvoelker has quit IRC23:29

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!