*** davideagle has quit IRC | 00:15 | |
*** saneax is now known as saneax_AFK | 00:17 | |
EmilienM | skolekonov: cool thanks for your patches, appreciated | 00:22 |
---|---|---|
*** xingchao has joined #puppet-openstack | 00:24 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy RabbitMQ with SSL https://review.openstack.org/285586 | 00:24 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy RabbitMQ with IPv6 binding https://review.openstack.org/285600 | 00:26 |
*** saneax_AFK is now known as saneax | 00:28 | |
*** xingchao has quit IRC | 00:29 | |
*** beekneemech has quit IRC | 00:29 | |
*** bnemec has joined #puppet-openstack | 00:31 | |
*** dgurtner has quit IRC | 00:38 | |
*** markvoelker has joined #puppet-openstack | 00:43 | |
*** markvoelker has quit IRC | 00:47 | |
*** fedexo has joined #puppet-openstack | 00:47 | |
*** xingchao has joined #puppet-openstack | 01:25 | |
*** xingchao has quit IRC | 01:30 | |
*** markvoelker has joined #puppet-openstack | 01:44 | |
*** markvoelker has quit IRC | 01:48 | |
*** ducttape_ has joined #puppet-openstack | 01:53 | |
*** ducttape_ has quit IRC | 02:05 | |
*** xingchao has joined #puppet-openstack | 02:14 | |
*** johnmilton has quit IRC | 02:31 | |
*** aimon_ has quit IRC | 02:33 | |
*** xingchao has quit IRC | 02:34 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-ceph: Allow setting of public_addr from ::profile::mon and ::mon https://review.openstack.org/280351 | 02:34 |
*** xingchao has joined #puppet-openstack | 02:39 | |
*** saneax is now known as saneax_AFK | 02:40 | |
*** markvoelker has joined #puppet-openstack | 02:44 | |
*** ilbot3 has quit IRC | 02:46 | |
*** mdavidson has quit IRC | 02:46 | |
*** _joes_ has quit IRC | 02:46 | |
*** richm has quit IRC | 02:47 | |
*** _joes_ has joined #puppet-openstack | 02:48 | |
*** ilbot3 has joined #puppet-openstack | 02:48 | |
*** markvoelker has quit IRC | 02:49 | |
*** richm has joined #puppet-openstack | 02:49 | |
*** mdavidson has joined #puppet-openstack | 02:50 | |
openstackgerrit | Merged openstack/puppet-ceph: fix collectors: Ceph_Config -> Ceph_config https://review.openstack.org/285510 | 03:34 |
*** xingchao has quit IRC | 03:44 | |
*** xingchao has joined #puppet-openstack | 03:47 | |
*** xingchao has quit IRC | 04:24 | |
*** xingchao has joined #puppet-openstack | 04:27 | |
*** markvoelker has joined #puppet-openstack | 04:45 | |
*** markvoelker has quit IRC | 04:50 | |
*** xingchao has quit IRC | 04:50 | |
*** saneax_AFK is now known as saneax | 04:51 | |
*** xingchao has joined #puppet-openstack | 05:40 | |
*** richm has quit IRC | 06:36 | |
*** saneax is now known as saneax_AFK | 06:44 | |
*** rcernin has joined #puppet-openstack | 06:44 | |
*** markvoelker has joined #puppet-openstack | 06:46 | |
*** rcernin has quit IRC | 06:49 | |
*** markvoelker has quit IRC | 06:50 | |
*** fedexo has quit IRC | 06:59 | |
*** jaosorior has joined #puppet-openstack | 07:01 | |
*** yolanda has joined #puppet-openstack | 07:08 | |
*** magicboiz has joined #puppet-openstack | 07:11 | |
*** magicboiz has quit IRC | 07:12 | |
*** rcernin has joined #puppet-openstack | 07:24 | |
*** hjensas has joined #puppet-openstack | 07:43 | |
*** saneax_AFK is now known as saneax | 07:48 | |
*** leanderthal|afk is now known as leanderthal | 07:53 | |
*** pasquier-s_ has quit IRC | 08:03 | |
*** mattymo has quit IRC | 08:03 | |
*** dkaigarodsev has quit IRC | 08:04 | |
*** dkaigarodsev has joined #puppet-openstack | 08:05 | |
*** pasquier-s has joined #puppet-openstack | 08:05 | |
*** foxhunt_away is now known as foxhunt72 | 08:05 | |
*** mattymo has joined #puppet-openstack | 08:05 | |
*** jtomasek has joined #puppet-openstack | 08:07 | |
*** jpena has joined #puppet-openstack | 08:25 | |
*** dgurtner has joined #puppet-openstack | 08:28 | |
*** dgurtner has quit IRC | 08:28 | |
*** dgurtner has joined #puppet-openstack | 08:28 | |
*** finchd has quit IRC | 08:29 | |
*** rcernin has quit IRC | 08:29 | |
*** rcernin has joined #puppet-openstack | 08:37 | |
*** markvoelker has joined #puppet-openstack | 08:47 | |
*** markvoelker has quit IRC | 08:51 | |
*** paramite has joined #puppet-openstack | 08:57 | |
*** finchd has joined #puppet-openstack | 08:57 | |
*** _degorenko|afk is now known as degorenko | 09:10 | |
*** finchd has quit IRC | 09:10 | |
*** finchd has joined #puppet-openstack | 09:12 | |
openstackgerrit | Denis Egorenko proposed openstack/puppet-openstack-integration: scenario003: enable application catalog service https://review.openstack.org/250436 | 09:18 |
*** jistr has joined #puppet-openstack | 09:20 | |
*** derekh has joined #puppet-openstack | 09:21 | |
*** davideagle has joined #puppet-openstack | 09:23 | |
*** patrickeast has quit IRC | 09:24 | |
*** patrickeast has joined #puppet-openstack | 09:25 | |
*** gfidente has joined #puppet-openstack | 09:28 | |
*** davideagle has quit IRC | 09:37 | |
*** davideagle has joined #puppet-openstack | 09:38 | |
*** xingchao has quit IRC | 09:42 | |
*** xingchao has joined #puppet-openstack | 09:45 | |
*** chem has joined #puppet-openstack | 09:59 | |
*** davideagle has quit IRC | 10:03 | |
openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 10:16 |
openstackgerrit | Merged openstack/puppet-openstack-integration: Update the README about the third scenario https://review.openstack.org/285523 | 10:17 |
*** davideagle has joined #puppet-openstack | 10:18 | |
*** dgurtner has quit IRC | 10:18 | |
*** cgfbee has quit IRC | 10:31 | |
*** cgfbee has joined #puppet-openstack | 10:32 | |
*** IvanBerezovskiy has joined #puppet-openstack | 10:34 | |
*** imcsk8 has quit IRC | 10:43 | |
*** imcsk8 has joined #puppet-openstack | 10:43 | |
*** zerda has joined #puppet-openstack | 10:46 | |
*** markvoelker has joined #puppet-openstack | 10:47 | |
*** markvoelker has quit IRC | 10:52 | |
*** richm has joined #puppet-openstack | 11:04 | |
openstackgerrit | Giulio Fidente proposed openstack/puppet-ceph: Allow setting of public_addr from ::profile::mon and ::mon https://review.openstack.org/280351 | 11:08 |
*** furlongm has quit IRC | 11:14 | |
*** dgurtner has joined #puppet-openstack | 11:16 | |
*** davideagle has quit IRC | 11:25 | |
*** davideagle has joined #puppet-openstack | 11:27 | |
*** Guest22888 is now known as beagles | 11:33 | |
*** _nick is now known as yankcrime | 11:42 | |
openstackgerrit | Nikolay Starodubtsev proposed openstack/puppet-murano: Switch murano to use keystone API v3 by default https://review.openstack.org/279444 | 11:46 |
*** xingchao has quit IRC | 11:56 | |
openstackgerrit | Babu Shanmugam proposed openstack/puppet-vswitch: Added custom type vs_config and OVS provider for it https://review.openstack.org/285996 | 11:59 |
*** skolekonov_ has joined #puppet-openstack | 12:00 | |
*** davideagle has quit IRC | 12:00 | |
-openstackstatus- NOTICE: Infra currently has a long backlog. Please be patient and where possible avoid rechecks while it catches up. | 12:07 | |
*** zerda has quit IRC | 12:11 | |
EmilienM | good morning | 12:14 |
*** johnmilton has joined #puppet-openstack | 12:19 | |
*** khappone has quit IRC | 12:21 | |
*** khappone has joined #puppet-openstack | 12:21 | |
*** dmburmistrov_ has quit IRC | 12:21 | |
skolekonov_ | morning | 12:30 |
*** jaosorior has quit IRC | 12:33 | |
*** jaosorior has joined #puppet-openstack | 12:34 | |
degorenko | morning :) | 12:36 |
*** davideagle has joined #puppet-openstack | 12:40 | |
*** markvoelker has joined #puppet-openstack | 12:48 | |
*** markvoelker has quit IRC | 12:53 | |
*** davideagle has quit IRC | 13:08 | |
*** jayg|g0n3 is now known as jayg | 13:17 | |
openstackgerrit | Sergey Kolekonov proposed openstack/puppet-neutron: Add support for modern auth to neutron providers https://review.openstack.org/281227 | 13:19 |
*** dprince has joined #puppet-openstack | 13:23 | |
*** davideagle has joined #puppet-openstack | 13:26 | |
*** skolekonov_ has quit IRC | 13:26 | |
*** jtomasek_ has joined #puppet-openstack | 13:35 | |
*** markvoelker has joined #puppet-openstack | 13:47 | |
*** jpena is now known as jpena|lunch | 13:52 | |
*** jtomasek_ has quit IRC | 13:55 | |
*** davideagle has quit IRC | 13:55 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy RabbitMQ with SSL https://review.openstack.org/285586 | 14:06 |
*** davideagle has joined #puppet-openstack | 14:06 | |
openstackgerrit | Denis Egorenko proposed openstack/puppet-openstack-integration: Use swift backend for glance in scenario002 jobs https://review.openstack.org/284771 | 14:15 |
*** saneax is now known as saneax_AFK | 14:18 | |
*** cdelatte has joined #puppet-openstack | 14:21 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-keystone: use stevedore names when possible and cleanup ldap testing https://review.openstack.org/285345 | 14:26 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-keystone: Run keystone-manage bootstrap https://review.openstack.org/284876 | 14:26 |
*** dhollinger has joined #puppet-openstack | 14:36 | |
*** xingchao has joined #puppet-openstack | 14:39 | |
EmilienM | gate is very busy today, maybe because it's OpenStack feature freeze week :-/ | 14:40 |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-openstack_spec_helper: Add method to tests manifest in tests directory. https://review.openstack.org/281369 | 14:50 |
*** ducttape_ has joined #puppet-openstack | 14:53 | |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-openstack_spec_helper: Add matchers include_regexp and have_array_of_instances_hash. https://review.openstack.org/286092 | 14:53 |
*** xingchao has quit IRC | 15:00 | |
*** dfisher has joined #puppet-openstack | 15:02 | |
*** xingchao has joined #puppet-openstack | 15:07 | |
*** jpena|lunch is now known as jpena | 15:08 | |
*** davideagle has quit IRC | 15:08 | |
*** xarses has quit IRC | 15:12 | |
openstackgerrit | Trevor McCasland proposed openstack/puppet-neutron: Neutron subnet will now be able to update https://review.openstack.org/285518 | 15:17 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy RabbitMQ with SSL https://review.openstack.org/285586 | 15:22 |
openstackgerrit | Trevor McCasland proposed openstack/puppet-neutron: Neutron subnet will now be able to update https://review.openstack.org/285518 | 15:23 |
*** xingchao has quit IRC | 15:26 | |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-openstack_spec_helper: Add method to tests manifest in tests directory. https://review.openstack.org/281369 | 15:28 |
*** xingchao has joined #puppet-openstack | 15:32 | |
*** davideagle has joined #puppet-openstack | 15:33 | |
*** xingchao has quit IRC | 15:34 | |
*** xarses has joined #puppet-openstack | 15:36 | |
*** jaosorior is now known as jaosorior_away | 15:37 | |
*** mdorman has joined #puppet-openstack | 15:39 | |
*** jprs is now known as samuelson | 15:40 | |
dmsimard | colonwq, dgurtner: civetweb merged | 15:41 |
dmsimard | congrats :) | 15:41 |
EmilienM | nice | 15:42 |
colonwq | dmsimard, Hooray. | 15:42 |
openstackgerrit | Trevor McCasland proposed openstack/puppet-neutron: Neutron subnet will now be able to update https://review.openstack.org/285518 | 15:48 |
*** davideagle has quit IRC | 15:52 | |
*** davideagle has joined #puppet-openstack | 15:54 | |
*** haplo37 has joined #puppet-openstack | 15:54 | |
*** angdraug has joined #puppet-openstack | 15:57 | |
gfidente | guys, do you have ideas on what is best syntax to ensure -> absent an entire file config stanza? | 16:07 |
gfidente | maybe stanza_name/ ? | 16:07 |
gfidente | nah that won't pass the regexp either /\S+\/\S+/ | 16:09 |
EmilienM | gfidente: https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L821 | 16:13 |
gfidente | EmilienM, yeah but I need to remove the entire ini stanzs | 16:13 |
gfidente | (the part in [] in the ini file) | 16:14 |
EmilienM | gfidente: oh | 16:15 |
EmilienM | I have no idea | 16:15 |
gfidente | EmilienM, if I leave it empty | 16:15 |
gfidente | the output is not identical | 16:15 |
EmilienM | ceph fails? | 16:15 |
gfidente | yeah I got to bottom of it | 16:15 |
openstackgerrit | Alex Schultz proposed openstack/puppet-glance: Switch glance to rspec-puppet-facts https://review.openstack.org/282182 | 16:16 |
*** rcernin has quit IRC | 16:16 | |
gfidente | EmilienM, see this line https://github.com/openstack/puppet-ceph/blob/master/spec/acceptance/ceph_usecases_spec.rb#L101 | 16:16 |
gfidente | that's not the output which the command gives | 16:16 |
gfidente | if the [mon.$id] stanza still exists in the config file | 16:16 |
gfidente | so I need to remove it | 16:16 |
*** dhollinger has quit IRC | 16:18 | |
*** dhollinger has joined #puppet-openstack | 16:22 | |
openstackgerrit | Merged openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 16:22 |
*** jtomasek_ has joined #puppet-openstack | 16:32 | |
*** jtomasek has quit IRC | 16:34 | |
openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: Fix documentation duplicate in rgw.pp https://review.openstack.org/286143 | 16:34 |
openstackgerrit | Denis Egorenko proposed openstack/puppet-openstack-integration: tempest: run tox with -eall-plugin https://review.openstack.org/283786 | 16:34 |
*** xingchao has joined #puppet-openstack | 16:34 | |
openstackgerrit | Denis Egorenko proposed openstack/puppet-openstack-integration: scenario003: enable application catalog service https://review.openstack.org/250436 | 16:36 |
*** xingchao has quit IRC | 16:40 | |
*** foxhunt72 is now known as foxhunt_away | 16:43 | |
*** asilenkov_ has joined #puppet-openstack | 16:46 | |
*** asilenkov has quit IRC | 16:46 | |
*** igajsin1 has joined #puppet-openstack | 16:53 | |
*** paramite is now known as paramite|afk | 16:55 | |
*** davideagle has quit IRC | 16:56 | |
*** paramite|afk is now known as paramite | 16:58 | |
*** paramite is now known as paramite|afk | 17:00 | |
*** jaosorior_away is now known as jaosorior | 17:08 | |
*** paramite|afk is now known as paramite | 17:11 | |
*** openstackgerrit has quit IRC | 17:18 | |
*** openstackgerrit has joined #puppet-openstack | 17:18 | |
*** trown has joined #puppet-openstack | 17:19 | |
trown | could another core take a peak at https://review.openstack.org/#/c/284876/ | 17:20 |
trown | has 1x +2 and is blocking TripleO from working with master | 17:20 |
EmilienM | trown: I'll +A today it's on my radar | 17:20 |
EmilienM | trown: I just want to see CI passing | 17:21 |
trown | EmilienM: awesome thanks! | 17:21 |
EmilienM | sure thing | 17:21 |
*** ayoung has quit IRC | 17:23 | |
dgurtner | colonwq: congrats :) | 17:24 |
*** trown is now known as trown|lunch | 17:25 | |
colonwq | dgurtner, thanks. It's almost like winning an oscar. It is a good way to start a week. | 17:25 |
dgurtner | lol | 17:26 |
*** jistr has quit IRC | 17:26 | |
EmilienM | colonwq: it's like Leo? you waited here so long ? :-) | 17:28 |
colonwq | EmilienM, It was a long and rough road on this one. At least I did not have to get attacked by a bear, | 17:29 |
EmilienM | :) | 17:31 |
EmilienM | crinkle: just fyi - got ssl & ipv6 working on scenario002 (for rabbitmq only now) - thanks for your manifests in infracloud, I re-used most of the bits | 17:32 |
*** dgurtner has quit IRC | 17:33 | |
*** degorenko is now known as _degorenko|afk | 17:33 | |
*** mwhahaha sets mode: +o EmilienM | 17:34 | |
*** EmilienM sets mode: +o crinkle | 17:34 | |
*** EmilienM sets mode: +o _degorenko|afk | 17:35 | |
*** EmilienM sets mode: +o _ody__ | 17:35 | |
*** EmilienM sets mode: +o sbadia | 17:35 | |
*** EmilienM sets mode: +o spredzy | 17:35 | |
*** rahulait has joined #puppet-openstack | 17:35 | |
*** xingchao has joined #puppet-openstack | 17:36 | |
*** baker has joined #puppet-openstack | 17:39 | |
*** xingchao has quit IRC | 17:41 | |
crinkle | EmilienM: cool | 17:52 |
*** derekh has quit IRC | 17:53 | |
openstackgerrit | Giulio Fidente proposed openstack/puppet-ceph: Allow setting of public_addr from ::profile::mon and ::mon https://review.openstack.org/280351 | 17:54 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-glance: Supports IPv6 in vnc proxy. https://review.openstack.org/286183 | 17:57 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-glance: Supports IPv6 in registry_host https://review.openstack.org/286183 | 17:58 |
EmilienM | gfidente: about https://review.openstack.org/#/c/280351/8/manifests/mon.pp | 18:08 |
EmilienM | gfidente: we need to investigate in puppetlabs-inifile | 18:08 |
gfidente | yeah that has some 'section = $name, ensure = absent' | 18:08 |
gfidente | but we can't use it from ceph_config | 18:09 |
gfidente | which creates named resources | 18:09 |
EmilienM | gfidente: or maybe another way is to purge the config before running the provider | 18:09 |
EmilienM | puppet-nova does that, let me find it | 18:09 |
EmilienM | gfidente: it does not do it anymore | 18:10 |
EmilienM | gfidente: nothing destroys the section: https://github.com/puppetlabs/puppetlabs-inifile/blob/master/lib/puppet/provider/ini_setting/ruby.rb#L50-L54 | 18:12 |
EmilienM | or maybe https://github.com/puppetlabs/puppetlabs-inifile/blob/master/lib/puppet/util/ini_file.rb#L111 ? | 18:13 |
EmilienM | gfidente: I have a durty idea. | 18:17 |
EmilienM | gfidente: purging the resource completely | 18:17 |
EmilienM | it does not delete the section neither | 18:19 |
EmilienM | Hunner: do you have an idea? | 18:22 |
*** Guest63721 is now known as mfisch | 18:24 | |
*** mfisch is now known as Guest2004 | 18:25 | |
Guest2004 | EmilienM: morning | 18:25 |
Guest2004 | looks like keystone ci is passing | 18:25 |
Guest2004 | can you WF+1 this one again https://review.openstack.org/#/c/282073/ | 18:25 |
Hunner | oh boy. /me reading | 18:25 |
EmilienM | Hunner: tl;dr; using puppetfile-inifile, we want to be able to drop a section name, not only the settings | 18:26 |
EmilienM | Hunner: ex: if creatng [section] foo = bar, we also want to be able to drop [section] line | 18:26 |
Hunner | because you can't ensure => absent on a section? | 18:26 |
EmilienM | no | 18:27 |
EmilienM | I tried | 18:27 |
EmilienM | and there is no way to do that but I mmight be wrong | 18:27 |
EmilienM | Guest2004: +2. Are you skiing? | 18:27 |
EmilienM | Guest2004: +A I mean | 18:27 |
Hunner | I think you are correct; let me see how adding it would work | 18:27 |
Guest2004 | dang it | 18:27 |
EmilienM | Hunner: thanks | 18:28 |
*** Guest2004 is now known as mfisch | 18:28 | |
*** mfisch has quit IRC | 18:28 | |
*** mfisch has joined #puppet-openstack | 18:28 | |
mfisch | I live | 18:28 |
*** EmilienM sets mode: +o mfisch | 18:28 | |
mfisch | skiing all dnoe | 18:28 |
EmilienM | mfisch: we'll need to land https://review.openstack.org/#/c/285345/ and https://review.openstack.org/#/c/284876 asap | 18:29 |
mfisch | looking | 18:29 |
openstackgerrit | Merged openstack/puppet-keystone: Fix rabbitmq ssl logic https://review.openstack.org/280462 | 18:30 |
mfisch | why did you drop the cred/assigment stuff? | 18:30 |
mfisch | EmilienM: ^ | 18:30 |
EmilienM | mfisch: please read the commit message | 18:30 |
EmilienM | and also the history on Gerrit, Steve wrote why | 18:30 |
mfisch | it just says "setting wrong" | 18:31 |
mfisch | ah reading from Steve | 18:31 |
Hunner | EmilienM: So having an empty section in a config file breaks something? Or are you asking about how to delete all settings inside one section? | 18:31 |
EmilienM | Hunner: in Ceph, having a [mon.something] without setting seems to break | 18:32 |
openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Deprecate python.pp and fix client tags https://review.openstack.org/282065 | 18:32 |
EmilienM | gfidente: ^ | 18:33 |
gfidente | Hunner, both are true | 18:33 |
gfidente | having a mon.section empty fools the centos script into trying to start it instead or just returning 'not found' | 18:34 |
openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: WIP Keystone hooks support https://review.openstack.org/283898 | 18:34 |
gfidente | so I'd like to remove it entirely | 18:34 |
gfidente | and thanks for helping :) | 18:34 |
Hunner | EmilienM: Okay. So for inifile we could update the `destroy` method so that if `ini_setting { 'foo': ensure => absent, section => 'mon.something', setting => 'aoeu', }` runs, if the aoeu setting is the last setting removed then it also removes the section. That would not have a way to remove the section also, though. It would be a breaking change to remove the specified section if there is no | 18:37 |
Hunner | setting of that name | 18:37 |
*** xingchao has joined #puppet-openstack | 18:37 | |
Hunner | Perhaps if no setting is passed, then that could be the indication that it should remove the entire section. What should it do in that case if a section has settings? Just error? | 18:37 |
EmilienM | right | 18:37 |
EmilienM | maybe add a parameter false by default so we can drop it? | 18:38 |
EmilienM | it would be backward compatible | 18:38 |
Hunner | Maybe the latter idea should be put in an ini_section resource, but I don't think anyone would want to write ANOTHER custom resource for every config file :P | 18:38 |
Hunner | As a work-around, file_line from stdlib can remove lines | 18:38 |
Hunner | So could remove the section line, though that might goof stuff up because any present sections would become joined with the remaining section | 18:38 |
Hunner | So I'd probably -1 that as a solution | 18:39 |
Hunner | EmilienM: Would it work if the destroy method removed the section if the last setting is removed? | 18:39 |
Hunner | Or do you need to remove sections that start empty? | 18:40 |
*** paramite has quit IRC | 18:40 | |
EmilienM | Hunner: file_line could work as a workaround | 18:41 |
EmilienM | Hunner: just remove the section if the last setting is removed | 18:41 |
*** jpena has quit IRC | 18:43 | |
*** xingchao has quit IRC | 18:43 | |
*** angdraug has quit IRC | 18:45 | |
EmilienM | chem: can you look https://review.openstack.org/#/c/285345/ please ? | 18:45 |
gfidente | Hunner, remove section if last setting is removed also works for me | 18:46 |
*** trown|lunch is now known as trown | 18:50 | |
*** jaosorior has quit IRC | 18:54 | |
Hunner | k. Looking at a PR for that | 18:58 |
*** jaosorior has joined #puppet-openstack | 18:58 | |
Hunner | err, writing | 18:58 |
EmilienM | nice thanks! | 18:58 |
*** delattec has joined #puppet-openstack | 19:00 | |
*** delattec has quit IRC | 19:00 | |
*** cdelatte has quit IRC | 19:03 | |
*** jaosorior has quit IRC | 19:07 | |
Hunner | Hmm. It handles commented settings fairly extensively. What should it do if the last setting in a section is removed, but there are commented lines in the section? | 19:08 |
Hunner | Comment the section (lots of extra work), delete the section and leave the comments (easiest), delete the comments too (medium), fail (easy), or nothing (easy)? | 19:09 |
EmilienM | Hunner: delete the section is ok for me | 19:12 |
mwhahaha | sounds like ceph should be fixed | 19:12 |
mwhahaha | normally ini files can have whatever and the application just ignores the extra sections that are not used or something | 19:13 |
*** angdraug has joined #puppet-openstack | 19:13 | |
Hunner | Yeah, normally. | 19:14 |
Hunner | But "normal" is very loose for ini files, since there is only convention, not standards :P | 19:14 |
mwhahaha | yea but removing headers because one app can't deal seems like a bad idea | 19:14 |
Hunner | Leading to inifile parsing things like https://github.com/puppetlabs/puppetlabs-inifile/blob/master/spec/unit/puppet/provider/ini_setting/ruby_spec.rb#L153-L172 | 19:15 |
gfidente | mwhahaha, I agree but the test itself relies on the output of a command | 19:15 |
Hunner | mwhahaha: I think being able to remove empty sections sounds like a nice feature anyway | 19:15 |
gfidente | and the command has different exit code when the stanza exits because it tries to do things differently | 19:15 |
gfidente | but yeah I think removing a section if no options are in it makes sense | 19:16 |
* mwhahaha shrugs | 19:16 | |
gfidente | maybe not if it has comments actually | 19:16 |
mwhahaha | if it's full of comments i wouldn't remove it | 19:16 |
gfidente | exactly | 19:16 |
mwhahaha | only if it's truely empty | 19:16 |
gfidente | maybe if there are comments I wouldn't remove it | 19:16 |
*** ducttape_ has quit IRC | 19:16 | |
gfidente | only if the stanza is actually empty | 19:16 |
Hunner | gfidente: I came up with 5 options for when sections have only comments in them. What do you think? (above) | 19:16 |
gfidente | Hunner, if there are comments, nothing | 19:17 |
gfidente | last of your five | 19:17 |
Hunner | so last option; k | 19:17 |
openstackgerrit | Merged openstack/puppet-openstack-integration: Use swift backend for glance in scenario002 jobs https://review.openstack.org/284771 | 19:21 |
openstackgerrit | Merged openstack/puppet-keystone: Remove deprecated tenant_ LDAP parameters https://review.openstack.org/282073 | 19:21 |
*** cdelatte has joined #puppet-openstack | 19:22 | |
openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: stop managing files that the package makes https://review.openstack.org/283308 | 19:23 |
*** ducttape_ has joined #puppet-openstack | 19:23 | |
openstackgerrit | Leon Zachery proposed openstack/puppet-neutron: Cisco nexus config manifest - obsolete parameter (switch_replay_count). https://review.openstack.org/286243 | 19:32 |
EmilienM | mwhahaha: any chance to look https://review.openstack.org/#/c/285345/ asap please? | 19:32 |
mwhahaha | sure | 19:32 |
EmilienM | mwhahaha: thanks a lot | 19:36 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy RabbitMQ with IPv6 binding https://review.openstack.org/285600 | 19:39 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy RabbitMQ with SSL https://review.openstack.org/285586 | 19:39 |
openstackgerrit | Merged openstack/puppet-neutron: Add support for modern auth to neutron providers https://review.openstack.org/281227 | 19:44 |
Hunner | EmilienM: gfidente: https://github.com/puppetlabs/puppetlabs-inifile/pull/199 | 19:49 |
EmilienM | omg that was fast | 19:49 |
* EmilienM reading | 19:49 | |
* Hunner waits on travis | 19:49 | |
Hunner | Deleting the section entries from the hash & section_names means that the `save` method will not write them out when the provider is flushed | 19:50 |
openstackgerrit | Merged openstack/puppet-openstack-integration: Update manifests to clean-up warnings https://review.openstack.org/280919 | 19:55 |
EmilienM | I was thinking at a script that would automatically look at the modules repos that we have in Puppetfile, look for new releases and submit a patch in puppet-openstack-integration automatically | 19:56 |
EmilienM | so we keep our CI up-to-date from our deps | 19:56 |
EmilienM | the only thing is that we currently violate real dependencies in metadata.json since we prepare modules dir with git, instead of `puppet module install` | 19:57 |
EmilienM | but it's not a big deal to me | 19:57 |
EmilienM | since we provider early feedback to Puppet community | 19:58 |
bkero | That seems like a lot of effort. Is it harder to source in those dependencies from elsewhere? | 19:59 |
bkero | or is that potentially unstable? | 20:00 |
EmilienM | bkero: like master? | 20:01 |
EmilienM | our current Puppetfile is on latest (or almost latest) releases | 20:01 |
EmilienM | I update it very frequently | 20:01 |
EmilienM | but I was thinking at writting a script about that | 20:01 |
*** davideagle has joined #puppet-openstack | 20:03 | |
dmsimard | EmilienM: your puppetfile is already using master | 20:09 |
dmsimard | you mean the non-openstack modules ? | 20:09 |
EmilienM | dmsimard: yeah | 20:09 |
EmilienM | rabbitmq, mysql, etc | 20:09 |
EmilienM | I like seeing our CI on the edge | 20:09 |
EmilienM | to break fast, fail fast | 20:09 |
EmilienM | though I don't think "master" would be nice, it would break too much imho | 20:10 |
EmilienM | err break fast, fix fast :-P | 20:10 |
*** rahulait has quit IRC | 20:10 | |
*** angdraug has quit IRC | 20:11 | |
openstackgerrit | Merged openstack/puppet-keystone: use stevedore names when possible and cleanup ldap testing https://review.openstack.org/285345 | 20:18 |
openstackgerrit | Merged openstack/puppet-keystone: Run keystone-manage bootstrap https://review.openstack.org/284876 | 20:26 |
EmilienM | dprince, trown ^ | 20:27 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Bump RDO repo to February 29th trunk https://review.openstack.org/286258 | 20:28 |
dprince | EmilienM: thanks | 20:28 |
EmilienM | dprince: it was a bit long to merge because Ubuntu CI jobs but now some of them don't vote until things got stable again | 20:29 |
dprince | EmilienM: np, I don't think it was that long | 20:38 |
*** dprince has quit IRC | 20:45 | |
*** ducttape_ has quit IRC | 20:50 | |
*** leanderthal is now known as leanderthal|afk | 20:55 | |
*** angdraug has joined #puppet-openstack | 20:59 | |
*** ducttape_ has joined #puppet-openstack | 21:02 | |
gfidente | Hunner, thanks :) | 21:10 |
Hunner | gfidente: Still working on it. The way I did testing ended up screwing with things, since -nonstandard- section isn't detected as empty when I moved it up | 21:16 |
*** foxhunt_away is now known as foxhunt72 | 21:16 | |
*** ayoung has joined #puppet-openstack | 21:17 | |
gfidente | yeah I saw the failures so I had to thank you for working on it | 21:17 |
*** cdelatte has quit IRC | 21:33 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-heat: Implement crontab to purge deleted data https://review.openstack.org/286290 | 21:35 |
*** johnmilton has quit IRC | 21:39 | |
*** xingchao has joined #puppet-openstack | 21:41 | |
*** cdelatte has joined #puppet-openstack | 21:42 | |
*** xingchao has quit IRC | 21:46 | |
*** davideagle has quit IRC | 21:48 | |
*** davideagle has joined #puppet-openstack | 21:49 | |
*** cdelatte has quit IRC | 21:52 | |
*** cdelatte has joined #puppet-openstack | 21:53 | |
*** cdelatte has quit IRC | 21:54 | |
*** haplo37 has quit IRC | 21:54 | |
*** foxhunt72 is now known as foxhunt_away | 21:55 | |
*** haplo37 has joined #puppet-openstack | 21:58 | |
*** davideagle has quit IRC | 21:59 | |
*** jayg is now known as jayg|g0n3 | 22:12 | |
_ody__ | EmilienM: Was anything ran against https://review.openstack.org/286258? I don't see any downstream changes dependent on the change-id. | 22:14 |
*** _ody__ is now known as _ody | 22:14 | |
EmilienM | _ody: it's just a bump | 22:16 |
EmilienM | _ody: as we do every week lately | 22:16 |
EmilienM | there is no depends-on | 22:16 |
EmilienM | _ody: can you look https://review.openstack.org/#/c/286183/ please , | 22:16 |
*** trown is now known as trown|lunch | 22:21 | |
*** trown|lunch is now known as trown|outtypewww | 22:21 | |
_ody | EmilienM: Ok. Was just checking to see if it was important to validate if new package builds would cause CI failures before merging. A depends-on is the only way I know to do that without openstack/puppet-openstack-integration running the scenerios. | 22:27 |
*** haplo37 has quit IRC | 22:48 | |
*** davideagle has joined #puppet-openstack | 22:50 | |
*** dhollinger has quit IRC | 22:54 | |
*** davideagle has quit IRC | 23:07 | |
*** gfidente has quit IRC | 23:11 | |
*** sbadia has quit IRC | 23:13 | |
*** sbadia has joined #puppet-openstack | 23:14 | |
*** mdorman has quit IRC | 23:14 | |
openstackgerrit | Merged openstack/puppet-keystone: Deprecate python.pp and fix client tags https://review.openstack.org/282065 | 23:19 |
*** saneax_AFK is now known as saneax | 23:20 | |
openstackgerrit | Merged openstack/puppet-glance: Supports IPv6 in registry_host https://review.openstack.org/286183 | 23:29 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-glance: Supports IPv6 in registry_host https://review.openstack.org/286319 | 23:31 |
*** baker has quit IRC | 23:33 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-glance: Switch glance to rspec-puppet-facts https://review.openstack.org/282182 | 23:36 |
*** hjensas has quit IRC | 23:37 | |
*** dfisher has quit IRC | 23:37 | |
*** jtomasek_ has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!