richm | ayoung: you should be able to exercise self.instances with puppet resource | 00:01 |
---|---|---|
*** johnmilton has joined #puppet-openstack | 00:01 | |
ayoung | richm, got the syntax for that? | 00:02 |
richm | puppet resource --help | 00:03 |
richm | ayoung: it's been too long since I did this, and I blew away my test VMs :P | 00:05 |
richm | I think the argument to modulepath is the _parent_ directory, and the directory name must be 'keystone' not 'puppet-keystone' | 00:06 |
richm | That is, if you have --modulepath=/some/path | 00:06 |
richm | then /some/path must contain 'keystone', 'openstacklib', etc. etc. | 00:06 |
richm | you can have multiple modulepath | 00:06 |
richm | you can either use --modulepath=/usr/share/openstack-puppet/module:/path/to/my/local/one | 00:07 |
richm | or use --modulepath=/usr/share/openstack-puppet/module --modulepath /path/to/my/local/one | 00:07 |
richm | I can't remember which | 00:07 |
richm | then - puppet resource --modulepath=something keystone_federation_protocol | 00:08 |
richm | and | 00:08 |
richm | puppet resource --modulepath=something keystone_federation_protocol somename | 00:08 |
richm | that should exercise self.instances | 00:08 |
richm | or maybe it's capital K - Keystone_federation_protocol | 00:09 |
*** alee has joined #puppet-openstack | 00:13 | |
openstackgerrit | Merged openstack/puppet-nova: Properly document deprecated parameter https://review.openstack.org/281538 | 00:15 |
*** nlahouti1 has joined #puppet-openstack | 00:28 | |
*** nlahouti has quit IRC | 00:28 | |
ayoung | richm, was not able to find an incantation that worked | 00:32 |
ayoung | I have the original code in /etc/puppet | 00:32 |
ayoung | so | 00:32 |
ayoung | puppet resource keystone_federation_protocol | 00:32 |
ayoung | should work but gets Error: Could not run: Could not find type keystone_federation_protocol | 00:32 |
richm | ayoung: try puppet resource keystone_user | 00:33 |
richm | then try puppet resource Keystone_user | 00:34 |
ayoung | nope for all | 00:34 |
ayoung | richm, lets cut it here for now. | 00:34 |
ayoung | Too much trial and error, not enough progress to warrant | 00:35 |
ayoung | I'm going to look in to EmilienM 's recommendation | 00:35 |
richm | http://specs.openstack.org/openstack/puppet-openstack-specs/specs/kilo/auth-restructure.html | 00:35 |
richm | puppet resource keystone_user foo email=foo@example.com password=test” | 00:35 |
ayoung | http://my1.fr/blog/puppet-module-functional-testing-with-vagrant-openstack-and-beaker/ | 00:35 |
richm | ayoung: what do you have under /etc/puppet ? | 00:35 |
ayoung | richm, pretty much everything: | 00:36 |
ayoung | richm, http://paste.openstack.org/show/487517/ | 00:36 |
ayoung | and a lot below each of those: find is acting wonky here | 00:36 |
richm | I guess the modules were moved from /usr/share/openstack-puppet . . . | 00:37 |
ayoung | http://paste.openstack.org/show/487518/ | 00:37 |
ayoung | richm, I think that happens when they deploy the controller. They are not intalled via RPM I think | 00:38 |
richm | ok | 00:38 |
ayoung | richm, it might be a tripleoism...I see | 00:38 |
ayoung | /etc/puppet/modules/keystone/.git | 00:38 |
richm | If puppet resource keystone_user is not working . . . then I don't know | 00:38 |
richm | are you logged in as root? | 00:39 |
richm | and is there an /etc/keystone/keystone.conf with admin_token set? | 00:39 |
richm | otherwise, I don't know what credentials it is using | 00:39 |
*** johnmilton has quit IRC | 00:40 | |
*** gildub has quit IRC | 00:40 | |
*** gildub has joined #puppet-openstack | 00:40 | |
openstackgerrit | James Slagle proposed openstack/puppet-cinder: Revert "Allow customization of DEFAULT/host" https://review.openstack.org/282098 | 00:40 |
richm | puppet resource is the fastest, easiest way I know to test self.instances | 00:41 |
*** xarses has quit IRC | 00:41 | |
openstackgerrit | James Slagle proposed openstack/puppet-cinder: Revert "Allow customization of DEFAULT/host" https://review.openstack.org/282098 | 00:42 |
*** xarses has joined #puppet-openstack | 01:06 | |
*** ducttape_ has quit IRC | 01:06 | |
*** social has quit IRC | 01:08 | |
*** social has joined #puppet-openstack | 01:08 | |
*** johnmilton has joined #puppet-openstack | 01:12 | |
*** cwolferh has quit IRC | 01:34 | |
*** cwolferh has joined #puppet-openstack | 01:35 | |
*** nlahouti1 has quit IRC | 01:39 | |
*** cwolferh has quit IRC | 01:42 | |
*** cwolferh has joined #puppet-openstack | 01:42 | |
*** rahulait has joined #puppet-openstack | 01:44 | |
openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Remove deprecated tenant_ LDAP parameters https://review.openstack.org/282073 | 01:50 |
*** kindjal has joined #puppet-openstack | 01:53 | |
*** morazi has quit IRC | 01:55 | |
*** rstarmer has joined #puppet-openstack | 02:01 | |
*** cwolferh has quit IRC | 02:02 | |
*** johnmilton has quit IRC | 02:20 | |
*** markvoelker_ has quit IRC | 02:34 | |
*** ducttape_ has joined #puppet-openstack | 02:34 | |
*** ilbot3 has quit IRC | 02:45 | |
*** ilbot3 has joined #puppet-openstack | 02:48 | |
openstackgerrit | Xingchao Yu proposed openstack/puppet-glance: Use stores to replace known_stores https://review.openstack.org/265846 | 02:51 |
openstackgerrit | Xingchao Yu proposed openstack/puppet-oslo: Add define oslo::messaging::amqp https://review.openstack.org/274764 | 02:54 |
*** alee has quit IRC | 03:06 | |
*** kindjal has quit IRC | 03:09 | |
*** ducttape_ has quit IRC | 03:12 | |
*** alee has joined #puppet-openstack | 03:19 | |
*** ducttape_ has joined #puppet-openstack | 03:20 | |
*** ducttape_ has quit IRC | 03:21 | |
*** nlahouti has joined #puppet-openstack | 03:30 | |
*** richm has quit IRC | 03:33 | |
*** nlahouti has quit IRC | 03:33 | |
*** nlahouti has joined #puppet-openstack | 03:33 | |
*** ducttape_ has joined #puppet-openstack | 03:34 | |
*** markvoelker has joined #puppet-openstack | 03:34 | |
*** markvoelker has quit IRC | 03:39 | |
*** v1k0d3n has quit IRC | 03:41 | |
*** v1k0d3n_ has joined #puppet-openstack | 03:41 | |
*** ducttape_ has quit IRC | 03:51 | |
*** nlahouti1 has joined #puppet-openstack | 03:55 | |
*** nlahouti has quit IRC | 03:57 | |
*** cwolferh has joined #puppet-openstack | 03:58 | |
*** rahulait has quit IRC | 04:18 | |
openstackgerrit | Merged openstack/puppet-sahara: Add the capability to configure api-paste.ini with config.pp https://review.openstack.org/281756 | 04:22 |
*** saneax_AFK is now known as saneax | 04:25 | |
openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 04:26 |
openstackgerrit | Alex Schultz proposed openstack/puppet-zaqar: Switch zaqar to use rspec-puppet-facts https://review.openstack.org/282165 | 04:35 |
*** markvoelker has joined #puppet-openstack | 05:36 | |
openstackgerrit | Merged openstack/puppet-vswitch: Remove duplicate loading of constants https://review.openstack.org/280937 | 05:36 |
*** rcernin has joined #puppet-openstack | 05:37 | |
*** markvoelker has quit IRC | 05:40 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-glance: Switch glance to rspec-puppet-facts https://review.openstack.org/282182 | 06:00 |
*** rstarmer has quit IRC | 06:12 | |
*** jaosorior has joined #puppet-openstack | 06:48 | |
*** gildub has quit IRC | 06:58 | |
*** jtomasek has joined #puppet-openstack | 07:02 | |
*** nlahouti1 has quit IRC | 07:09 | |
*** markvoelker has joined #puppet-openstack | 07:36 | |
*** markvoelker has quit IRC | 07:40 | |
*** andybotting has joined #puppet-openstack | 07:55 | |
*** dgurtner has joined #puppet-openstack | 08:02 | |
*** dgurtner has quit IRC | 08:02 | |
*** dgurtner has joined #puppet-openstack | 08:02 | |
*** foxhunt_away is now known as foxhunt72 | 08:23 | |
*** jpena has joined #puppet-openstack | 08:37 | |
*** blkperl has quit IRC | 08:40 | |
*** Hunner has quit IRC | 08:40 | |
*** mentat has quit IRC | 08:40 | |
*** bmjen has quit IRC | 08:40 | |
*** davideagle_ has joined #puppet-openstack | 08:52 | |
*** gfidente has joined #puppet-openstack | 09:09 | |
openstackgerrit | Sergey Kolekonov proposed openstack/puppet-neutron: Add support for modern auth to neutron providers https://review.openstack.org/281227 | 09:12 |
*** gildub has joined #puppet-openstack | 09:12 | |
openstackgerrit | Giulio Fidente proposed openstack/puppet-cinder: Allow customization of DEFAULT/host https://review.openstack.org/281998 | 09:16 |
*** derekh has joined #puppet-openstack | 09:18 | |
*** furlongm has quit IRC | 09:21 | |
*** hjensas has joined #puppet-openstack | 09:35 | |
*** markvoelker has joined #puppet-openstack | 09:37 | |
*** markvoelker has quit IRC | 09:42 | |
*** davideagle_ has quit IRC | 10:01 | |
*** _degorenko|afk is now known as degorenko | 10:07 | |
*** davideagle_ has joined #puppet-openstack | 10:09 | |
openstackgerrit | Ivan Berezovskiy proposed openstack/puppet-ceilometer: Deprecate ceilometer alarm classes https://review.openstack.org/282258 | 10:09 |
*** andybotting has quit IRC | 10:24 | |
degorenko | sbadia, spredzy hey, are you around? | 10:36 |
sbadia | yup! | 10:37 |
sbadia | hi here o/ | 10:37 |
degorenko | sbadia, hey | 10:37 |
degorenko | we have this one https://review.openstack.org/282098 | 10:37 |
degorenko | take a look on my comments | 10:37 |
sbadia | ack, /me take a look | 10:37 |
degorenko | it is related to tripleo | 10:37 |
sbadia | héhé, I think you're right :) I'll ping Derek | 10:43 |
*** gildub has quit IRC | 10:44 | |
degorenko | sbadia, thanks o/ | 10:45 |
sbadia | np ;) | 10:45 |
openstackgerrit | Jerzy Mikolajczak proposed openstack/puppet-neutron: Remove API configuration values from metadata agent https://review.openstack.org/282276 | 10:59 |
*** rmart04 has joined #puppet-openstack | 11:14 | |
*** Kvisle has joined #puppet-openstack | 11:15 | |
Kvisle | does anyone have any experience with the quality of the puppet modules on el7? (centos in this case) | 11:15 |
openstackgerrit | Lukas Bezdicka proposed openstack/puppet-nova: Supports IPv6 in vnc proxy. https://review.openstack.org/281346 | 11:22 |
*** linkmark has joined #puppet-openstack | 11:27 | |
*** rain has joined #puppet-openstack | 11:38 | |
*** rain is now known as leanderthal | 11:38 | |
*** markvoelker has joined #puppet-openstack | 11:38 | |
*** markvoelker has quit IRC | 11:42 | |
*** karimb has joined #puppet-openstack | 11:45 | |
openstackgerrit | Jerzy Mikolajczak proposed openstack/puppet-openstack-integration: Remove auth_password from neutron metadata agent https://review.openstack.org/282294 | 11:47 |
*** karimb has quit IRC | 11:57 | |
*** davideagle_ has quit IRC | 11:59 | |
*** davideagle_ has joined #puppet-openstack | 12:13 | |
*** rmart04 has quit IRC | 12:18 | |
*** cdelatte has joined #puppet-openstack | 12:22 | |
openstackgerrit | Sergey Kolekonov proposed openstack/puppet-neutron: Add support for modern auth to neutron providers https://review.openstack.org/281227 | 12:24 |
openstackgerrit | Sergey Kolekonov proposed openstack/puppet-neutron: Set v3 auth related options by default https://review.openstack.org/282309 | 12:24 |
*** davideagle_ has quit IRC | 12:27 | |
*** davideagle_ has joined #puppet-openstack | 12:34 | |
openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 12:39 |
*** jaosorior has quit IRC | 12:40 | |
*** jaosorior has joined #puppet-openstack | 12:41 | |
*** jpena is now known as jpena|lunch | 12:44 | |
*** jaosorior has quit IRC | 12:46 | |
*** jaosorior has joined #puppet-openstack | 12:46 | |
*** johnmilton has joined #puppet-openstack | 12:46 | |
*** markvoelker has joined #puppet-openstack | 12:54 | |
*** markvoelker has quit IRC | 12:58 | |
*** markvoelker has joined #puppet-openstack | 13:04 | |
*** jayg|g0n3 is now known as jayg | 13:21 | |
*** 32NAABCSV has joined #puppet-openstack | 13:23 | |
*** 32NAABCSV has quit IRC | 13:38 | |
skolekonov | Looks like Trove deployment is broken now in integration jobs, db-sync fails. Does someone know the root cause? | 13:40 |
*** davideagle_ has quit IRC | 13:42 | |
*** kindjal has joined #puppet-openstack | 13:46 | |
*** davideagle_ has joined #puppet-openstack | 13:53 | |
*** dgurtner has quit IRC | 13:57 | |
*** jpena|lunch is now known as jpena | 14:09 | |
openstackgerrit | Dougal Matthews proposed openstack/puppet-ironic: Change Baremetal to Bare Metal to be consistent with Ironic. https://review.openstack.org/282350 | 14:14 |
*** dalees has quit IRC | 14:17 | |
*** hjensas has quit IRC | 14:37 | |
*** saneax is now known as saneax_AFK | 14:38 | |
*** dfisher has joined #puppet-openstack | 14:39 | |
*** openstackgerrit_ has quit IRC | 14:43 | |
*** bmjen has joined #puppet-openstack | 14:45 | |
*** Hunner has joined #puppet-openstack | 14:45 | |
*** Hunner has quit IRC | 14:45 | |
*** Hunner has joined #puppet-openstack | 14:45 | |
*** mentat has joined #puppet-openstack | 14:45 | |
*** richm has joined #puppet-openstack | 14:54 | |
*** ducttape_ has joined #puppet-openstack | 15:00 | |
*** openstackgerrit_ has joined #puppet-openstack | 15:00 | |
*** linkmark has quit IRC | 15:02 | |
*** davideagle_ has quit IRC | 15:12 | |
*** xarses has quit IRC | 15:12 | |
*** v1k0d3n_ has quit IRC | 15:12 | |
*** davideagle_ has joined #puppet-openstack | 15:14 | |
*** v1k0d3n has joined #puppet-openstack | 15:15 | |
*** davideagle_ has quit IRC | 15:15 | |
*** hjensas has joined #puppet-openstack | 15:16 | |
*** hjensas has joined #puppet-openstack | 15:16 | |
openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 15:20 |
*** baker has joined #puppet-openstack | 15:26 | |
mwhahaha | looks like glance beaker tests have a dependency cycle somehow, http://logs.openstack.org/46/265846/3/check/gate-puppet-glance-puppet-beaker-rspec-dsvm-centos7/23a1596/console.html#_2016-02-19_03_09_05_474 | 15:34 |
mwhahaha | and http://logs.openstack.org/82/282182/1/check/gate-puppet-glance-puppet-beaker-rspec-dsvm-trusty/24f6703/console.html | 15:34 |
*** xarses has joined #puppet-openstack | 15:35 | |
mfisch | degorenko: can you look at this? https://review.openstack.org/#/c/282073/ its not as bad as it looks | 15:40 |
mfisch | promise | 15:40 |
mfisch | oh | 15:40 |
mfisch | nm I see you commented | 15:40 |
degorenko | mfisch, :) | 15:40 |
*** jaosorior has quit IRC | 15:44 | |
*** mdorman has joined #puppet-openstack | 15:52 | |
*** dalees has joined #puppet-openstack | 16:08 | |
*** leanderthal is now known as leanderthal|afk | 16:10 | |
*** xarses has quit IRC | 16:25 | |
mfisch | long term I'm going to move fernet support and pki support to separate classes | 16:25 |
mfisch | keystone's init pp is a hot mess of crap | 16:25 |
*** xarses has joined #puppet-openstack | 16:26 | |
mfisch | degorenko: thoughts ^? | 16:26 |
degorenko | mfisch, good idea | 16:26 |
mfisch | I'll do it after I land this dep class stuff | 16:26 |
degorenko | do not forget to use include for init.pp for backward compatiblity | 16:26 |
mfisch | I might have a preview of it today hopefully | 16:27 |
mfisch | yep | 16:27 |
degorenko | you can add me sure | 16:27 |
mfisch | when I get a preview of the dep class I'll ping you | 16:27 |
degorenko | mfisch, we have non-working days in russia 22-23 feb, i will be unavailable here in irc, but will check review sometime | 16:27 |
*** ddmitriev has joined #puppet-openstack | 16:28 | |
mfisch | "Defender of the Fatherland Day" | 16:28 |
mfisch | looks like a good holiday for guys | 16:28 |
degorenko | :D yep | 16:29 |
mfisch | right after valentines too | 16:29 |
degorenko | and then we will have international women day 8 march | 16:29 |
mfisch | special forces day sounds interesting too | 16:29 |
mfisch | this website could be making stuff up too | 16:30 |
degorenko | mfisch, we have a loooooot of some days, like day of fool :) | 16:31 |
mfisch | april 1? | 16:32 |
*** foxhunt72 is now known as foxhunt_away | 16:32 | |
degorenko | mfisch, yep :) | 16:34 |
mfisch | yeah we have that one too | 16:35 |
openstackgerrit | Miles Gould proposed openstack/puppet-ironic: Allow chainloading of Inspector ramdisk over UEFI https://review.openstack.org/276187 | 16:37 |
richm | ayoung: how goes the keystone federation stuff? | 16:45 |
*** blkperl has joined #puppet-openstack | 16:51 | |
*** duritong has quit IRC | 16:52 | |
*** duritong has joined #puppet-openstack | 16:53 | |
ayoung | richm, I bumped it down in priority until after aI get a manual setup working | 16:57 |
ayoung | richm, but I think I know what is going on | 16:57 |
*** dhollinger has joined #puppet-openstack | 16:57 | |
ayoung | there is some sort of spec that says list can have only a few params, and by adding something, we go beyond what the spec allows. | 16:57 |
ayoung | I think it is this: | 16:58 |
*** rcernin has quit IRC | 16:58 | |
ayoung | dmnit lost the link...one sec | 16:58 |
*** degorenko is now known as _degorenko|afk | 16:59 | |
ayoung | richm, https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L43 calls the openstack_command with args. I put tracing in and we were good up to this call | 17:01 |
ayoung | richm, Heh. I think I was looking at the unit tests now that I reread it | 17:03 |
ayoung | https://github.com/openstack/puppet-openstacklib/blob/master/spec/unit/provider/openstack_spec.rb | 17:03 |
richm | ayoung: yeah - the spec mock for the openstack() method expects arrays in the arguments | 17:04 |
ayoung | richm, so...I think that the list command is, somehere, limited in what it can accept | 17:05 |
richm | ayoung: what's not clear to me is if the openstack command will flatten array arguments when passed to openstack_command https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L43 | 17:05 |
ayoung | richm, to fix it, it looks like I have to find where the arguments are counted. And I can't find that | 17:05 |
richm | ayoung: I don't understand what is different about how you are using request() - there are other places in the code where request is used like this: request('thing', 'list', [args]) - and they all work fine | 17:07 |
ayoung | richm, example? | 17:08 |
richm | ayoung: https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone_user/openstack.rb#L125 | 17:08 |
richm | chem: Any ideas about how we can debug this? | 17:09 |
chem | richm: I was trying to catch up with the problem | 17:09 |
chem | richm ayoung, what is the error :) | 17:09 |
richm | chem: https://review.openstack.org/#/c/282103/ | 17:11 |
chem | richm: ack | 17:11 |
richm | ayoung: is ^^^ the latest code you are using? | 17:11 |
ayoung | chem, OK, when trying to list federation protocols | 17:12 |
ayoung | I need to pass --identity-provider <idp> | 17:12 |
ayoung | let me recreate the error | 17:12 |
ayoung | list = request('federation protocol', 'list', ['--identity-provider', 'keycloak']) | 17:13 |
ayoung | gives me | 17:13 |
ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (5 for 2..3) | 17:13 |
richm | chem: This is from self.instances so it's using self.request from the base class | 17:14 |
chem | ayoung: oki, I get it. Is the review that richm pointed out is the last code ? | 17:14 |
ayoung | chem, yeah | 17:14 |
chem | ayoung:thank for the clear explanation | 17:14 |
ayoung | lots of trial and error | 17:14 |
chem | ayoung:I'm looking into it | 17:14 |
*** hjensas has quit IRC | 17:14 | |
ayoung | chem, I've tried a few variations | 17:14 |
ayoung | and it seems something is choking on the number of params specific to list | 17:15 |
ayoung | if I fake it out so that the openstack provider doesn;'t think it is a list, I can get get back something that looks like the CLI processed it correctly | 17:15 |
richm | chem: What I don't understand is that the code is using request('thing', 'list', [args]) in exactly the same way as used elsewhere - in keystone_user/openstack.rb et. al. | 17:16 |
ayoung | chem, for example, if I run: list = request('federation protocol', ['list', '--quiet', '--format', 'csv', '--identity-provider', 'keycloak']) | 17:17 |
ayoung | puts "#{list}" | 17:17 |
ayoung | I get | 17:17 |
ayoung | "id","mapping" | 17:17 |
ayoung | "saml2","keycloak-saml2" | 17:17 |
ayoung | which is what the list command would then parse. So, I could force it by cut and pasting the lower level code, but would be cleaner to get it right | 17:17 |
chem | richm ayoung the form is correct, that's for sure, the splat operator is working. The error is comming from the openstack command. | 17:19 |
ayoung | chem, I can run the command from the CLI like this: | 17:20 |
chem | richm ayoung (I think) | 17:20 |
ayoung | /bin/openstack federation protocol list --identity-provider keycloak -f csv --quiet | 17:20 |
ayoung | chem, I get a different error if I make openstack CLI angry | 17:21 |
richm | ayoung: does it work if you do /bin/openstack federation protocol list -f csv --quiet --identity-provider keycloak ? | 17:21 |
ayoung | let's see | 17:23 |
ayoung | richm, yes it does | 17:23 |
ayoung | if I mess up the params to the openstack command like this | 17:23 |
ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': Execution of '/bin/openstack federation protocol list --quiet --format csv' returned 2: usage: openstack federation protocol list [-h] | 17:23 |
ayoung | I get back a trace from the output of the command itself | 17:24 |
ayoung | so I don't think it is the CLI that is angry here. I think it is whatever is calling the CLI. And I can't trace down to where that is | 17:24 |
chem | ayound, richm: humm ... so it looks like a problem inside the module, then. Let me do a quick spec for the provider. The error should show up in there as well | 17:25 |
chem | ayoung: can you paste me a working output from the openstack federation protocol list ... command ? | 17:29 |
ayoung | $ /bin/openstack federation protocol list -f csv --quiet --identity-provider keycloak | 17:29 |
ayoung | "id","mapping" | 17:29 |
ayoung | "saml2","keycloak-saml2" | 17:29 |
*** rcernin has joined #puppet-openstack | 17:30 | |
ayoung | chem, Ok so first create an IdP like this | 17:30 |
chem | ayoung:for what I'm doing only the list output will do :) | 17:30 |
*** haplo37 has joined #puppet-openstack | 17:30 | |
ayoung | openstack identity provider create keycroak | 17:31 |
ayoung | except not keycroak for the rest of my stuff to work | 17:31 |
ayoung | keycloak | 17:31 |
ayoung | anyways. | 17:31 |
ayoung | ah, then you need a mapping | 17:31 |
ayoung | that is the tough part, which needsd a file, and why I skipped right to protocol | 17:32 |
ayoung | I'll go back for thampping once we get this | 17:32 |
ayoung | but.. | 17:32 |
ayoung | http://paste.openstack.org/show/487608/ | 17:32 |
ayoung | and create using | 17:32 |
ayoung | openstack mapping create mapping_keycloak_saml2.json keycloak_saml2 | 17:32 |
ayoung | um... | 17:32 |
ayoung | I think that the mapping needs to be | 17:33 |
ayoung | keycloak-saml2 | 17:33 |
ayoung | no underscope | 17:33 |
ayoung | the underscore is messing things up so that should have been | 17:33 |
ayoung | openstack mapping create --rules mapping_keycloak_saml2.json keycloak-saml2 | 17:34 |
ayoung | sorry, like I said, a bit of trial and error | 17:34 |
ayoung | chem, but now we have it in IRC for posterity | 17:34 |
chem | ayoung: that's ok, I have what I need :) | 17:34 |
ayoung | chem, so, I can parse it if I need | 17:35 |
chem | ayoung ... sorry I'm lost here ... one problem at a time :) | 17:37 |
chem | ayoung I could reproduce the error "wrong number of arguments (5 for 2..3)" using rspec | 17:37 |
chem | ayoung: a matter of minutes to find out the reason, now :) | 17:38 |
ayoung | ok | 17:38 |
ayoung | I'll let you run. chem there is a WIP review https://review.openstack.org/#/c/282103/ | 17:39 |
chem | oki, I've got it :) | 17:39 |
chem | ayoung: ^ I'll comment on the review | 17:40 |
*** gfidente has quit IRC | 17:41 | |
ayoung | chem, what was it? | 17:41 |
chem | ayoung: do you mind if I push the spec for the provider ? | 17:41 |
ayoung | chem, not at all | 17:41 |
chem | ayoung: it's basic, but you can work from it after | 17:41 |
ayoung | chem, so, I need two of these: | 17:41 |
ayoung | this one and the one for the mapping | 17:41 |
ayoung | and the mapping one needs a file. I assume I can copy what the identity provider does for that, but I might be back to bother you when I get stuck | 17:42 |
chem | ayoung: actually richm had already the answer. Look at its comment line 81 | 17:43 |
ayoung | but both require the list using the --identity-provider flag, | 17:43 |
ayoung | chem, that is for show...and I wonder if I even needed the list in the first place | 17:43 |
*** jpena has quit IRC | 17:43 | |
chem | ayoung: the error comes from this line not the one on line 76 | 17:43 |
ayoung | ? | 17:44 |
ayoung | hmm, OK , let me try that | 17:44 |
richm | the error is from the 'show' command, not the 'list' command? | 17:44 |
chem | yep | 17:44 |
richm | chem: how can you tell? | 17:44 |
chem | richm: because the list command did not fail on my spec test | 17:44 |
richm | ok | 17:45 |
chem | ayoung: richm request('federation protocol', 'show', ['--identity-provider','keycloak', federation_protocol[:id]]) | 17:46 |
chem | will work | 17:46 |
ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': No resource and no name in property hash in openstack instance | 17:47 |
ayoung | good! | 17:47 |
ayoung | I think I know why | 17:48 |
chem | ayoung: this one is another story :) | 17:48 |
richm | chem: Thanks! | 17:48 |
ayoung | chem, hmmm. Ok I get that part to run with no errors but now it is still trying to create the pre-existing resource | 17:49 |
ayoung | closer | 17:49 |
chem | richm: np | 17:49 |
ayoung | but that is probably cuz I am doing unspeakable things here | 17:49 |
chem | ayoung: it's because you're not matching the existing one properly | 17:50 |
ayoung | let me clean up my code... | 17:50 |
chem | ayoung: in your prefetch you matching on the name while in the instances class method you're not adding the name property to the created object | 17:51 |
chem | ayoung: it can never match | 17:51 |
ayoung | chem, ok... | 17:51 |
*** bnemec has quit IRC | 17:52 | |
chem | ayoung: can you paste me the ouptup of the show command for "federation protocol', 'show', '--format', 'shell', ['--identity-provider', 'keycloak', 'saml2']" on the real systemm ? | 17:54 |
ayoung | chem, so the way these work is that the idp owns the mapping, an the two together are used by the protocol | 17:54 |
ayoung | so do I need to have a global list of all protocols to do this \right? | 17:54 |
ayoung | this one here is hacked to be scoped to one specific identity provider and mapping | 17:54 |
*** derekh has quit IRC | 17:57 | |
chem | ayoung: ouch, that's a mouthfull for a friday evening :) | 17:58 |
ayoung | chem, its ok. If I get this one working, the other should be prett much the same | 17:59 |
chem | ayoung: I can get more of the functional side of this on monday. I just wanted the output of the above command to add it to the spec of the self.instances method | 17:59 |
ayoung | chem, was is 'instances' supposed to have? The complete list of instances of a particular class? | 18:00 |
chem | ayoung: the list of existing object on the system | 18:01 |
chem | ayoung: associated with your type | 18:01 |
ayoung | if that is the case, then the right thing is probably to have nested loops, with the outer looping through the identity providers and the inner looping through the protocols per identity provider | 18:01 |
chem | ayoung: all that is required to get all the fields of your type filled correctly | 18:03 |
chem | ayoung: self.instances is used in two cases : when you run "puppet resource keystone_federation_protocol" and when you use self.prefetch | 18:03 |
ayoung | chem, this would be a lot easier if I didn't need to learn a new language to do it | 18:03 |
chem | ayoung: common, that's even more fun :) | 18:04 |
ayoung | chem, this is just one of my many responsibilities | 18:05 |
ayoung | I did a little bit off ruby 6 years ago | 18:05 |
ayoung | not enough to remember | 18:05 |
*** bnemec has joined #puppet-openstack | 18:08 | |
chem | ayoung ruby is not too hard but puppet type and provider logic is harder, lot of idioms to learn and processes to understand. Especially in the keystone's one. I will keep on reviewing this one. You're not going to be alone :) | 18:08 |
chem | ayoung I'm going to push the spec file I've got. It has blank to fill but it can help you getting started. | 18:10 |
chem | ayoung: is that ok ? | 18:10 |
ayoung | chem, excellent | 18:12 |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-keystone: first hack at keystone_federation_protocol https://review.openstack.org/282103 | 18:13 |
chem | ayoung: oki, done. I've left a comment on this one. | 18:14 |
chem | ayoung: I'm leaving now, I'll review it again on monday. | 18:15 |
ayoung | chem, what do you mean by :"You have to fill the blank here with the actual output of the command. | 18:17 |
ayoung | " | 18:17 |
ayoung | disregard | 18:18 |
chem | ayoung: you need to run this command in your test env and put the output there | 18:18 |
chem | ayoung: I let another comment, refresh :) | 18:18 |
chem | ayoung: when you paste the output, be *very* mindful of extra blank line, it can lead to very strange error | 18:19 |
openstackgerrit | ayoung proposed openstack/puppet-keystone: first hack at keystone_federation_protocol https://review.openstack.org/282103 | 18:20 |
chem | ayoung: you have to put id line right next to the opening single quote | 18:22 |
chem | ayoung: not on a new line | 18:22 |
chem | ayoung: and you should adjust id_provider_attrs to match correct parameter for your provider | 18:23 |
ayoung | chem, will do. Go now. Get out while you still can. | 18:23 |
chem | ayoung: leaaaaving, bye and have a good one. | 18:24 |
*** imcsk8 has quit IRC | 18:25 | |
*** chem has quit IRC | 18:25 | |
*** bodepd has quit IRC | 18:25 | |
*** jesusaur has quit IRC | 18:25 | |
*** abramley has quit IRC | 18:25 | |
*** skolekonov has quit IRC | 18:25 | |
*** dmburmistrov has quit IRC | 18:25 | |
*** Aegil has quit IRC | 18:25 | |
*** pasquier-s has quit IRC | 18:25 | |
*** ikkeT has quit IRC | 18:25 | |
*** fc__ has quit IRC | 18:25 | |
*** clayton has quit IRC | 18:25 | |
*** _ody has quit IRC | 18:25 | |
*** psanchez has quit IRC | 18:25 | |
*** Aegil has joined #puppet-openstack | 18:25 | |
*** _ody has joined #puppet-openstack | 18:25 | |
*** fc__ has joined #puppet-openstack | 18:25 | |
*** skolekonov has joined #puppet-openstack | 18:25 | |
*** bodepd has joined #puppet-openstack | 18:25 | |
*** dmburmistrov has joined #puppet-openstack | 18:25 | |
*** imcsk8 has joined #puppet-openstack | 18:25 | |
*** ikkeT has joined #puppet-openstack | 18:25 | |
*** pasquier-s has joined #puppet-openstack | 18:26 | |
*** abramley has joined #puppet-openstack | 18:26 | |
*** jesusaur has joined #puppet-openstack | 18:26 | |
*** clayton has joined #puppet-openstack | 18:26 | |
*** psanchez has joined #puppet-openstack | 18:27 | |
*** leanderthal|afk has quit IRC | 18:27 | |
*** _degorenko|afk has quit IRC | 18:27 | |
*** mflobo has quit IRC | 18:27 | |
*** llua has quit IRC | 18:27 | |
*** llua` has joined #puppet-openstack | 18:27 | |
*** mflobo has joined #puppet-openstack | 18:28 | |
*** _degorenko|afk has joined #puppet-openstack | 18:28 | |
*** clayton_ has joined #puppet-openstack | 18:28 | |
*** rleander_ has joined #puppet-openstack | 18:28 | |
*** clayton has quit IRC | 18:28 | |
*** clayton_ is now known as clayton | 18:29 | |
*** haplo37 has quit IRC | 18:37 | |
*** rcernin has quit IRC | 18:56 | |
*** cwolferh has quit IRC | 19:03 | |
*** cwolferh has joined #puppet-openstack | 19:09 | |
*** hjensas has joined #puppet-openstack | 19:20 | |
*** hjensas has joined #puppet-openstack | 19:20 | |
*** rcernin has joined #puppet-openstack | 19:23 | |
*** rcernin has quit IRC | 19:45 | |
*** cwolferh_ has joined #puppet-openstack | 19:51 | |
*** cwolferh has quit IRC | 19:52 | |
*** llua` is now known as llua | 20:02 | |
*** llua has joined #puppet-openstack | 20:02 | |
*** hjensas has quit IRC | 20:32 | |
*** haplo37 has joined #puppet-openstack | 20:37 | |
*** baker has quit IRC | 20:51 | |
*** ayoung has quit IRC | 20:52 | |
*** baker has joined #puppet-openstack | 20:57 | |
*** foxhunt_away is now known as foxhunt72 | 21:08 | |
*** brandon has joined #puppet-openstack | 21:11 | |
*** kindjal has quit IRC | 21:17 | |
*** jayg is now known as jayg|g0n3 | 21:21 | |
*** johnmilton has quit IRC | 21:23 | |
*** kindjal has joined #puppet-openstack | 22:01 | |
*** ducttape_ has quit IRC | 22:15 | |
*** ducttape_ has joined #puppet-openstack | 22:16 | |
*** ducttape_ has quit IRC | 22:22 | |
*** francois has quit IRC | 22:29 | |
*** francois has joined #puppet-openstack | 22:37 | |
*** ducttape_ has joined #puppet-openstack | 22:46 | |
*** ducttape_ has quit IRC | 22:47 | |
*** mdorman has quit IRC | 22:47 | |
*** dhollinger has quit IRC | 22:54 | |
*** haplo37 has quit IRC | 23:05 | |
*** foxhunt72 is now known as foxhunt_away | 23:11 | |
*** ducttape_ has joined #puppet-openstack | 23:15 | |
*** baker has quit IRC | 23:16 | |
*** baker has joined #puppet-openstack | 23:16 | |
*** jtomasek has quit IRC | 23:19 | |
*** baker has quit IRC | 23:20 | |
*** ducttape_ has quit IRC | 23:28 | |
*** ducttape_ has joined #puppet-openstack | 23:30 | |
*** saneax_AFK is now known as saneax | 23:31 | |
*** ducttape_ has quit IRC | 23:39 | |
*** dfisher has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!