Thursday, 2015-11-12

*** gildub has quit IRC00:00
*** dfisher has quit IRC00:03
*** _ducttape_ has joined #puppet-openstack00:14
*** ducttape_ has quit IRC00:17
*** angdraug has quit IRC00:34
*** _ducttape_ has quit IRC00:35
*** gildub has joined #puppet-openstack00:36
*** nlahouti has quit IRC00:52
*** nlahouti has joined #puppet-openstack00:52
*** zhangjn has joined #puppet-openstack01:03
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Manage swift with swiftinit service provider  https://review.openstack.org/20322001:05
*** guessi has joined #puppet-openstack01:09
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Manage swift with swiftinit service provider  https://review.openstack.org/20322001:14
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Manage swift with swiftinit service provider  https://review.openstack.org/20322001:22
*** guessi has left #puppet-openstack01:24
*** nlahouti has quit IRC01:29
*** karimb has quit IRC01:30
*** xingchao has joined #puppet-openstack01:32
*** xingchao has quit IRC01:52
*** xingchao has joined #puppet-openstack02:24
*** Weeve has quit IRC02:36
*** lnxnut has joined #puppet-openstack02:37
*** cwolferh has quit IRC03:13
*** fedexo has joined #puppet-openstack03:54
*** richm has quit IRC03:54
openstackgerritMerged openstack/puppet-openstack-specs: Add AUTHORS and Changelog to .gitignore  https://review.openstack.org/24049403:55
openstackgerritMerged openstack/puppet-openstack-integration: tempest: use $::id fact for permissions  https://review.openstack.org/24217903:56
*** Weeve has joined #puppet-openstack04:03
*** cwolferh has joined #puppet-openstack04:06
openstackgerritMerged openstack/puppet-keystone: Add a new param for fernet tokens config  https://review.openstack.org/20367504:06
*** karmix has joined #puppet-openstack04:19
*** karmix_ has quit IRC04:19
*** rahulait has quit IRC04:20
*** khushbu_ has joined #puppet-openstack04:29
*** xingchao has quit IRC04:31
*** rahulait has joined #puppet-openstack05:24
*** fedexo has quit IRC05:42
*** rahulait has quit IRC05:53
*** rahulait has joined #puppet-openstack05:59
*** xingchao has joined #puppet-openstack06:10
*** jerrygb has quit IRC06:14
*** gfidente has quit IRC06:21
*** gfidente has joined #puppet-openstack06:22
*** gfidente has quit IRC06:22
*** gfidente has joined #puppet-openstack06:22
*** dgurtner has joined #puppet-openstack06:33
*** paramite has quit IRC06:37
*** nlahouti has joined #puppet-openstack06:44
*** nlahouti1 has joined #puppet-openstack06:46
*** nlahouti has quit IRC06:48
openstackgerritAndrew Spiers proposed openstack/puppet-designate: Configure rabbit_virtual_host  https://review.openstack.org/24446906:53
*** dgurtner has quit IRC06:55
*** gildub has quit IRC06:56
*** dgurtner has joined #puppet-openstack07:01
*** dgurtner has quit IRC07:01
*** dgurtner has joined #puppet-openstack07:01
*** khushbu_ has quit IRC07:07
*** zhangjn has quit IRC07:12
*** zhangjn has joined #puppet-openstack07:29
*** dgurtner has quit IRC07:31
*** zhangjn has quit IRC07:32
*** zhangjn has joined #puppet-openstack07:33
*** zhangjn has quit IRC07:34
*** gildub has joined #puppet-openstack07:42
*** dgurtner has joined #puppet-openstack07:55
*** khushbu_ has joined #puppet-openstack07:58
*** dgurtner has quit IRC08:07
*** dgurtner has joined #puppet-openstack08:07
*** jpena|zzz is now known as jpena08:19
*** nlahouti1 has quit IRC08:19
*** sleinen-AS559 has joined #puppet-openstack08:26
openstackgerritGael Chamoulaud proposed openstack/puppet-trove: Put all the logging related parameters to the logging class  https://review.openstack.org/24239508:33
*** dgurtner has quit IRC08:35
*** Pablo|off| has joined #puppet-openstack08:40
*** Pablo|off| is now known as pcaruana08:48
*** karimb has joined #puppet-openstack08:48
*** rcernin has joined #puppet-openstack08:50
*** sergmelikyan has joined #puppet-openstack08:53
*** dgurtner has joined #puppet-openstack08:56
*** jistr has joined #puppet-openstack09:03
*** sanjayu has joined #puppet-openstack09:15
openstackgerritJaume Devesa proposed openstack/puppet-tripleo: MidoNet services manifests  https://review.openstack.org/24418409:18
*** sergmelikyan has quit IRC09:18
*** paramite has joined #puppet-openstack09:28
*** sleinen-AS559 has quit IRC09:29
*** openstackgerrit has quit IRC09:46
*** openstackgerrit has joined #puppet-openstack09:47
*** karimb has quit IRC09:47
*** karimb has joined #puppet-openstack09:48
*** khushbu_ has quit IRC09:49
*** rahulait has quit IRC09:54
*** IvanBerezovskiy has joined #puppet-openstack09:56
*** dgurtner has quit IRC09:57
*** dgurtner has joined #puppet-openstack09:59
*** derekh has joined #puppet-openstack10:09
*** paramite is now known as paramite|afk10:09
*** paramite|afk is now known as paramite10:16
*** openstackgerrit has quit IRC10:16
*** openstackgerrit has joined #puppet-openstack10:17
*** sergmelikyan has joined #puppet-openstack10:25
openstackgerritMerged openstack/puppet-neutron: Support for Nuage Neutron plugin in puppet-neutron  https://review.openstack.org/21479810:32
*** sergmelikyan has quit IRC10:38
openstackgerritJaume Devesa proposed openstack/puppet-tripleo: MidoNet services manifests  https://review.openstack.org/24418410:41
*** jistr_ has joined #puppet-openstack10:48
*** rcernin_ has joined #puppet-openstack10:48
*** khushbu_ has joined #puppet-openstack10:48
*** jistr has quit IRC10:49
*** rcernin has quit IRC10:49
*** rcernin has joined #puppet-openstack10:50
*** rcernin_ has quit IRC10:53
*** jistr_ has quit IRC10:54
*** khushbu_ has quit IRC10:58
*** khushbu_ has joined #puppet-openstack11:01
*** jistr_ has joined #puppet-openstack11:05
*** paramite is now known as paramite|afk11:06
*** karimb_ has joined #puppet-openstack11:14
*** karimb has quit IRC11:14
*** jerrygb has joined #puppet-openstack11:15
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: New provider for keystone domain configuration.  https://review.openstack.org/21928911:16
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Support for multiple ldap backend.  https://review.openstack.org/23816411:16
*** gildub has quit IRC11:17
iurygregorygood morning people o/11:18
mkarpinHey!11:19
*** jerrygb has quit IRC11:19
*** chem` has quit IRC11:25
*** chem has joined #puppet-openstack11:26
openstackgerritGael Chamoulaud proposed openstack/puppet-aodh: Remove class_parameter_defaults puppet-line check  https://review.openstack.org/24457611:26
openstackgerritGael Chamoulaud proposed openstack/puppet-barbican: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24457711:27
openstackgerritGael Chamoulaud proposed openstack/puppet-ceilometer: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24457811:28
openstackgerritGael Chamoulaud proposed openstack/puppet-aodh: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24457611:28
*** sergmelikyan has joined #puppet-openstack11:29
openstackgerritGael Chamoulaud proposed openstack/puppet-ceph: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458011:31
*** dgurtner has quit IRC11:31
openstackgerritGael Chamoulaud proposed openstack/puppet-cinder: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458111:32
openstackgerritGael Chamoulaud proposed openstack/puppet-designate: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458311:33
*** trown|outttypeww is now known as trown11:33
openstackgerritGael Chamoulaud proposed openstack/puppet-glance: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458511:34
openstackgerritGael Chamoulaud proposed openstack/puppet-gnocchi: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458611:35
*** xingchao has quit IRC11:35
openstackgerritGael Chamoulaud proposed openstack/puppet-heat: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458711:36
openstackgerritGael Chamoulaud proposed openstack/puppet-horizon: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458911:36
openstackgerritGael Chamoulaud proposed openstack/puppet-ironic: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459011:37
openstackgerritGael Chamoulaud proposed openstack/puppet-keystone: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459111:38
*** lnxnut has quit IRC11:39
openstackgerritGael Chamoulaud proposed openstack/puppet-manila: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459211:40
openstackgerritGael Chamoulaud proposed openstack/puppet-mistral: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459311:41
openstackgerritGael Chamoulaud proposed openstack/puppet-monasca: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459411:42
openstackgerritGael Chamoulaud proposed openstack/puppet-murano: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459511:42
openstackgerritGael Chamoulaud proposed openstack/puppet-neutron: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459611:43
*** cwolferh has quit IRC11:45
openstackgerritGael Chamoulaud proposed openstack/puppet-nova: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459911:45
openstackgerritGael Chamoulaud proposed openstack/puppet-openstack_extras: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460011:46
openstackgerritGael Chamoulaud proposed openstack/puppet-openstack-integration: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460111:47
openstackgerritGael Chamoulaud proposed openstack/puppet-openstacklib: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460211:48
openstackgerritGael Chamoulaud proposed openstack/puppet-sahara: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460311:49
openstackgerritGael Chamoulaud proposed openstack/puppet-swift: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460411:49
openstackgerritGael Chamoulaud proposed openstack/puppet-tempest: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460511:50
openstackgerritGael Chamoulaud proposed openstack/puppet-tripleo: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460711:51
openstackgerritGael Chamoulaud proposed openstack/puppet-trove: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460811:52
openstackgerritGael Chamoulaud proposed openstack/puppet-tuskar: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460911:52
openstackgerritGael Chamoulaud proposed openstack/puppet-vswitch: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24461011:53
openstackgerritGael Chamoulaud proposed openstack/puppet-zaqar: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24461211:54
iurygregoryWOW O.o12:03
gchamoulsorry guys! :-p12:03
iurygregoryno problem kkkkkkkkkkk12:07
iurygregoryjust to know, what is the reason to remove ?12:08
*** dgurtner has joined #puppet-openstack12:08
*** dgurtner has quit IRC12:08
*** dgurtner has joined #puppet-openstack12:08
*** xingchao has joined #puppet-openstack12:10
iurygregoryanyone can help me to find out why the template is not applied properly?  https://review.openstack.org/#/c/216821/ ^^12:11
degorenkogchamoul, yeah, why you want to remove it? :)12:13
gchamouliurygregory: just because we disable a check which has been removed in puppet-lint for a while12:13
iurygregoryoh ^^12:13
degorenkoack12:14
gchamoulhttps://review.openstack.org/#/c/242105/12:14
*** paramite|afk is now known as paramite12:14
degorenkogchamoul, please, set one topic for all reviews12:15
degorenkoi dont want -1 on all patches :D12:15
iurygregoryit's a good idea12:16
gchamouldegorenko: ack12:16
* degorenko away on lunch12:17
*** jistr_ is now known as jistr12:20
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Add keystone domain specific configuration.  https://review.openstack.org/21928912:24
*** paramite is now known as paramite|afk12:31
myatsenkoGuys, plz look at https://review.openstack.org/#/c/233011/12:32
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Support for multiple ldap backend.  https://review.openstack.org/23816412:33
*** paramite|afk is now known as paramite12:34
mkarpinHey! can anyone from core reviewers please check https://review.openstack.org/#/c/243030/? thank you!12:34
mkarpincrinkle, mfisch, sbadia, spredzy : ^^12:34
*** v1k0d3n has quit IRC12:40
*** paramite is now known as paramite|afk12:42
*** dgurtner has quit IRC12:43
*** v1k0d3n has joined #puppet-openstack12:50
*** paramite|afk is now known as paramite12:58
*** sergmelikyan has quit IRC13:04
openstackgerritMerged openstack/puppet-neutron: Split SR-IOV configuration file into driver and agent pieces  https://review.openstack.org/22199113:05
*** sergmelikyan has joined #puppet-openstack13:05
*** ducttape_ has joined #puppet-openstack13:08
openstackgerritMerged openstack/puppet-keystone: Add ability to configure paste ini options using config class  https://review.openstack.org/24303013:10
*** sergmelikyan has quit IRC13:10
*** dgurtner has joined #puppet-openstack13:14
*** dgurtner has joined #puppet-openstack13:14
aderyuginHi, folks! Please take a look: https://review.openstack.org/#/c/220238/13:14
aderyuginclayton, crinkle, mfisch, sbadia, spredzy : ^^^13:15
*** dprince has joined #puppet-openstack13:15
*** jerrygb has joined #puppet-openstack13:15
*** ducttape_ has quit IRC13:17
*** jayg|g0n3 is now known as jayg13:17
*** jerrygb_ has joined #puppet-openstack13:18
*** jerrygb has quit IRC13:22
clayton_ody is there an open issue for this Facter[factname] issue?13:24
*** morazi has joined #puppet-openstack13:26
openstackgerritGael Chamoulaud proposed openstack/puppet-zaqar: metadata: Switch to OpenStack namespace and bump to Kilo  https://review.openstack.org/24465013:29
*** sergmelikyan has joined #puppet-openstack13:31
*** sergmelikyan has quit IRC13:32
openstackgerritGael Chamoulaud proposed openstack/puppet-barbican: metadata: Switch to OpenStack namespace and bump to Kilo  https://review.openstack.org/24465413:33
*** jerrygb_ has quit IRC13:39
*** bklei has joined #puppet-openstack13:41
*** bklei has quit IRC13:42
openstackgerritGael Chamoulaud proposed openstack/puppet-barbican: metadata: Switch to OpenStack namespace and bump to Kilo  https://review.openstack.org/24465413:43
iurygregoryanyone can help me with templates?13:47
openstackgerritGael Chamoulaud proposed openstack/puppet-mistral: metadata: Switch to OpenStack namespace and bump to Kilo  https://review.openstack.org/24466713:50
*** richm has joined #puppet-openstack13:54
openstackgerritMerged openstack/puppet-openstack-integration: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460113:59
openstackgerritMerged openstack/puppet-openstacklib: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460214:00
openstackgerritMerged openstack/puppet-swift: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460414:02
openstackgerritMerged openstack/puppet-openstack_extras: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460014:04
openstackgerritMerged openstack/puppet-monasca: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459414:06
openstackgerritMerged openstack/puppet-mistral: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459314:07
openstackgerritMerged openstack/puppet-nova: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459914:08
openstackgerritMerged openstack/puppet-vswitch: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24461014:08
openstackgerritMerged openstack/puppet-trove: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460814:10
openstackgerritMerged openstack/puppet-sahara: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24460314:10
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: [inspector] Specify SELinux type context for tftp dir  https://review.openstack.org/24467514:11
openstackgerritMerged openstack/puppet-murano: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459514:11
openstackgerritMerged openstack/puppet-ironic: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459014:12
openstackgerritMerged openstack/puppet-horizon: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458914:12
openstackgerritMerged openstack/puppet-neutron: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459614:13
*** ducttape_ has joined #puppet-openstack14:15
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: [inspector] Specify SELinux type context for tftp dir  https://review.openstack.org/24467514:15
*** ducttape_ has quit IRC14:20
*** jerrygb has joined #puppet-openstack14:22
degorenkoclayton, hi, what do you think my comment https://review.openstack.org/#/c/237970 ?14:22
degorenkoabout*14:22
claytonI'm not sure what you mean in the comment14:23
openstackgerritMerged openstack/puppet-keystone: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459114:23
claytonthe *::db class changes that are going in will double the default number of connections for all services14:23
claytongoing in and have gone in14:23
degorenkoclayton, do you saw my reply in your ML about this issue?14:23
claytonoh, let me look, sorry14:24
claytonI redid my mail filters yesterday and apparently it's still not going to the right place14:24
degorenkono problem14:25
claytonso you're suggesting using $::os_service_default then?14:25
degorenkonot exactly14:25
degorenkoas you mentioned - those defaults are different from project14:26
degorenkoso, what i want14:26
claytonthat's not the case for the db classes though14:26
claytonand the db class change is new for this cycle14:26
degorenkowe can raise warning about this14:26
degorenkowe just keep such parameters (which have default in puppet and this default is different from project) with puppet defaults14:27
degorenkoso, is there reason to change all modules now?14:27
degorenkofor those parameters14:27
claytonI think people are going to upgrade from the kilo modules to the liberty modules and in some cases their db or load balancer is going to explode14:28
claytonand I don't think this is an intentional change.14:28
degorenkoso, you suggest remove all those defaults and put undef? or what?14:29
claytonI did the math the other day, if you're running 40 core servers and 3 control nodes and running neutron, glance, cinder, and keystone on your control nodes, that's 5 services * 40 workers * 3 servers * 5 connections vs 10 connections is 3000 vs 6000 db connections14:30
*** itsuugo has joined #puppet-openstack14:30
claytonI think we need to either put $::os_service_default in place (for at least max_pool_size and and max_overflow or we need to reproduce the same functionality using the old style conditional where we ensure absent if it's not set14:31
mwhahahadid the default values (10,20) get added during the liberty cycle?14:31
claytonyes14:32
degorenkoi agree that os_service_default can solve this problem14:32
mwhahahaso if we haven't released the values we should quickly fix them before we cut a release14:32
degorenkobut in the case of large envs you also should change another parameters14:32
mwhahahai think it would be ok not to do the warning thing14:32
claytonmwhahaha they were added when spredzy started this refactoring in august I think.  I assume it wasn't intentional that max_pool_size and max_overflow were set to non-default values14:32
claytonin fact, oslo_db doesn't even have defaults, it allows sqlalchemy to set the defaults14:33
mwhahahahe probably copied from neutron where i think there were default values in the config file14:33
mwhahahaor at least commented values14:33
mwhahahahttp://docs.openstack.org/liberty/config-reference/content/section_neutron.conf.html14:33
claytonperhaps, neutron is the only service we've changed these values for, so that might be why we didn't see it before14:33
spredzyclayton, I need to answer to the thread, but I used 10 and 20 because those were the values in nova or neutron module I can't remember. So I thought it was safe to use the same values everywhere. Anyway create the review to update the behavior14:34
degorenkoclayton, i think that https://review.openstack.org/#/c/237970/ should be merged as is - and after that we can update db class with os_service_defaults14:35
*** sanjayu has quit IRC14:36
*** itsuugo has quit IRC14:43
openstackgerritAlex Schultz proposed openstack/puppet-nova: Use os_package_type for libvirt service name  https://review.openstack.org/24391214:45
claytonI don't think we should make the situation any worse until we know what the resolution is14:48
claytonbut I'm -1 on it, not -2, so someone else is welcome to merge it14:48
*** dfisher has joined #puppet-openstack14:48
mwhahahaMy personal opinion is that we should use service default for the db items14:50
claytonditto14:50
mwhahahamy understanding is that we're good to start using service default in all classes based on the conversation from the trello board14:50
*** khushbu_ has quit IRC14:50
claytonI felt like that was implied, but last I looked it didn't appear to be explicitly stated14:51
mwhahahaIf values were added between stable/kilo and are not in an official release, we should switch them prior to the release14:51
*** paramite has quit IRC14:51
mwhahahaif we cut a release with values then we will need to properly warn to switch them14:51
degorenkoso, then i see only one solution for my patch14:53
degorenkowait for implementing os_service_default for glance14:53
degorenkoand then update my patch14:54
mwhahahaat least a small patch to get it started14:54
degorenkospredzy, what is your progress with glance and os_service_default?14:54
mwhahahamaybe not a full conversion but at least the one that updates the tests and converts one class14:54
mkarpinsorry that i am jumping in14:55
mkarpinbut will be ok this on https://review.openstack.org/#/c/237973/?14:55
mkarpinhttps://review.openstack.org/#/c/237973/14:55
spredzydegorenko, so far none since the summit. I have been on another project since I got back from PTO and haven't had time to look at it yet14:56
spredzywill try to make some time tomm friday to push a review14:56
mkarpinthis patch is for glance os service default support ^^14:56
degorenkospredzy, as mentioned mwhahaha can i upload small patch for spec_helper which will add possibility for os_service_default? and make my patch for db as dependency14:57
*** ducttape_ has joined #puppet-openstack14:57
*** ducttape_ has quit IRC14:57
mwhahahaor mkarpin can remove the WIP and we can use those14:58
*** ducttape_ has joined #puppet-openstack14:58
claytondegorenko: I don't see any reason why we have to wait for the modules to be converted over to os_service_default, in fact I think we should do the opposite14:58
mkarpinyeah i added -1 because was not sure if it should be done14:58
spredzydegorenko, not sure I know the context of what the patch to spec_helper would do. Could you remind me please ?14:58
claytonI think we should decide on a cut-off and not accept any new patches past that date that introduce new parameters that don't use os_service_default14:59
degorenkospredzy, https://review.openstack.org/#/c/237973/6/spec/spec_helper.rb14:59
degorenkoonly this for small patch :)14:59
claytonconverting all the modules over to use os_service_default is a ton of work, but we can decide not to make it any worse14:59
degorenkojust for tests14:59
claytondegorenko: I think that's great14:59
mwhahahayea we need the test update first15:00
mwhahahawe can switch params later15:00
degorenkoso, we have patch from mkarpin , i think his patch should be update with only this change15:00
degorenkomwhahaha, ^ thoughts?15:00
mwhahahai think his patch is ok as is15:01
claytonhas anyone investigated if it's possible to have the modules source a spec_helper in openstacklib?15:01
claytonit'd be nice to have that sort of thing centralized instead of in every module15:01
mwhahahathe problem is openstacklib may not be available to the tests15:01
degorenko^^ yes15:01
mwhahahai'm not sure the load ordering when you run the tests15:02
claytonit's listed as a fixture for all the modules, isn't it?15:02
degorenkoyes it is15:02
mwhahahayea but then you end up including an rb in the fixtures15:02
claytondoesn't rake do all the fixture work?15:02
degorenkobut can we use specs from fixtures module?15:02
degorenkoi guess no15:02
mwhahahait seems weird to me15:02
*** bklei has joined #puppet-openstack15:02
claytonwe do a lot of weird things ;)15:02
mwhahahaindeed15:03
degorenkolet's do more? :)_15:03
*** ducttape_ has quit IRC15:03
spredzydegorenko, the patch seems ok to me in the spec_helper, clayton's idea about having it centralized make totale sense also if possible15:03
claytonwell, we could probably accomplish the same goal with modulesync15:03
openstackgerritSergey Kolekonov proposed openstack/puppet-neutron: Add parameters for Neutron QoS support  https://review.openstack.org/21665415:03
degorenkoactually15:03
degorenkowe can use $LOAD_PATH.push(File.join(File.dirname(__FILE__), 'fixtures', 'modules', 'openstacklib', 'lib')) - for fact15:04
degorenkoi think15:04
claytonand if we used modulesync then we have less coupling between openstacklib and he other modules15:04
claytonbut that's more reviews15:04
spredzyclayton, yes but we have an exponential of n reviews to review for every change15:04
spredzyon the down side15:04
claytonnod.  Although that's not too bad if module sync tags the reviews as being modulesync.  I don't know if it does15:04
claytonie, if we have a ton of reviews that all start with modulesync: subject, then I can just look at one of them and +2 the rest15:05
spredzysince our modules are already pretty tied to openstacklib, I don't see it to bad that it is even tieder15:05
spredzyclayton, yes you can do that, you decide the commit name so you can do "[msync] update os_service_default fact"15:05
claytonmy only complaint is that it makes following master harder, but I never get much sympathy for that complaint :)15:05
spredzyhehe15:05
*** ducttape_ has joined #puppet-openstack15:06
mwhahahaso i think the openstacklib thing goes along with something like https://review.openstack.org/#/c/242330/2/spec/spec_helper.rb15:07
mwhahahawhere we would do a require  'specs/fixtures/modules/openstacklib/spec/defaults.rb' or something of the sort15:08
mwhahahaand *hopefully* that works :D15:08
degorenkoyeah, i'm also think about such solution15:08
degorenkowe can prepare fix for openstacklib and use depends on15:09
degorenkoand hope that it will work :)15:09
mwhahahawhich reminds me i need to fix that review15:09
degorenkomwhahaha, one more comment for your patch15:10
openstackgerritMerged openstack/puppet-ceph: Replace all StackForge names to OpenStack  https://review.openstack.org/23852115:11
openstackgerritAlex Schultz proposed openstack/puppet-cinder: Use rspec-puppet-facts for fact management  https://review.openstack.org/24233015:12
*** dhollinger has joined #puppet-openstack15:13
*** lnxnut has joined #puppet-openstack15:16
dmsimardgchamoul: https://review.openstack.org/#/c/244580/15:19
*** xingchao has quit IRC15:27
*** skolekonov has quit IRC15:38
*** ntpttr has joined #puppet-openstack15:42
*** dgurtner has quit IRC15:43
openstackgerritNate Potter proposed openstack/puppet-magnum: puppet-magnum: Initial commit  https://review.openstack.org/24216415:46
openstackgerritNate Potter proposed openstack/puppet-magnum: puppet-magnum: Initial commit  https://review.openstack.org/24216415:52
*** angdraug has joined #puppet-openstack15:55
*** mdorman has joined #puppet-openstack15:57
*** sergmelikyan has joined #puppet-openstack15:58
*** zeus has quit IRC16:00
*** zeus has joined #puppet-openstack16:01
*** zeus is now known as Guest5378616:01
openstackgerritMerged openstack/puppet-manila: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24459216:11
*** jpena is now known as jpena|brb16:15
openstackgerritNate Potter proposed openstack/puppet-cinder: Add test coverage for cinder::db::mysql  https://review.openstack.org/24473416:16
*** nlahouti has joined #puppet-openstack16:16
ntpttr^^ hah IRC put a smiley face in my commit message16:17
*** nlahouti has quit IRC16:18
*** Guest53786 is now known as zeus16:21
*** zeus has quit IRC16:21
*** zeus has joined #puppet-openstack16:21
*** kbyrne has joined #puppet-openstack16:21
openstackgerritJaume Devesa proposed openstack/puppet-tripleo: MidoNet services manifests  https://review.openstack.org/24418416:21
*** nlahouti has joined #puppet-openstack16:22
*** sergmelikyan has quit IRC16:24
*** nlahouti has quit IRC16:35
*** nlahouti has joined #puppet-openstack16:37
*** sergmelikyan has joined #puppet-openstack16:37
*** mdorman has quit IRC16:38
*** mdorman has joined #puppet-openstack16:42
*** sergmelikyan has quit IRC16:42
*** sergmelikyan has joined #puppet-openstack16:43
*** jpena|brb is now known as jpena16:44
*** sergmelikyan has quit IRC16:48
*** rcernin has quit IRC16:50
*** IvanBerezovskiy has left #puppet-openstack16:54
openstackgerritJaume Devesa proposed openstack/puppet-tripleo: MidoNet services manifests  https://review.openstack.org/24418416:56
*** DarthVigil has joined #puppet-openstack16:59
*** cwolferh has joined #puppet-openstack17:03
*** DarthVigil has quit IRC17:05
*** pcaruana has quit IRC17:06
*** karimb_ has quit IRC17:10
openstackgerritMerged openstack/puppet-ceph: Remove class_parameter_defaults puppet-lint check  https://review.openstack.org/24458017:10
*** DarthVigil has joined #puppet-openstack17:12
*** sanjayu has joined #puppet-openstack17:13
*** rmart04 has joined #puppet-openstack17:16
*** ntpttr has quit IRC17:16
*** DarthVigil has quit IRC17:17
*** DarthVigil has joined #puppet-openstack17:17
*** rmart04 has quit IRC17:21
*** darkxploit has joined #puppet-openstack17:21
*** rmart04 has joined #puppet-openstack17:21
*** xingchao has joined #puppet-openstack17:22
*** trown is now known as trown|lunch17:22
*** rcernin has joined #puppet-openstack17:24
*** sanjayu has quit IRC17:25
*** rmart04_ has joined #puppet-openstack17:26
*** itsuugo has joined #puppet-openstack17:28
*** aojea_ has joined #puppet-openstack17:28
*** rmart04 has quit IRC17:28
*** rmart04_ is now known as rmart0417:28
*** itsuugo has quit IRC17:31
*** aojea_ has quit IRC17:31
*** sergmelikyan has joined #puppet-openstack17:32
*** gfidente has quit IRC17:33
*** gfidente has joined #puppet-openstack17:34
*** sergmelikyan has quit IRC17:36
*** rahulait has joined #puppet-openstack17:40
*** aimon has quit IRC17:49
*** derekh has quit IRC17:54
*** sergmelikyan has joined #puppet-openstack18:00
openstackgerritJaume Devesa proposed openstack/puppet-tripleo: MidoNet services manifests  https://review.openstack.org/24418418:04
*** sergmelikyan has quit IRC18:09
myatsenkocrinle:  spredzy:   hello!!!  plz plz look at https://review.openstack.org/#/c/233011/18:10
mdormanmfisch / clayton   around?  curious how you handle package versions in your puppet deployment.   (i watched your puppetconf talk the other day and now my mind is working)18:13
claytonwe always ensure latest for things we're ever going to upgrade18:13
claytonand we have versioned repos, and change where the repo points when we want to upgrade18:13
mdormankk18:14
mdormando you do any rollback functionality?  or always fail forward?18:14
claytonlatter18:15
claytonour rollback plan is PXE18:15
mdormanyup18:15
claytonvery few of our nodes have any local state that isn't automated18:15
mdormanright.18:16
mdormanthanks for info.18:16
mdormanwe’re making plans to try to get this all going for us, too.18:16
mdormantrying to narrow it down to some smaller first bites18:16
claytonnp, glad to answer questions18:16
*** jpena is now known as jpena|zzz18:17
*** bnemec has quit IRC18:21
*** jistr has quit IRC18:22
*** xingchao has quit IRC18:23
*** trown|lunch is now known as trown18:28
*** aimon has joined #puppet-openstack18:29
*** dgurtner has joined #puppet-openstack18:30
*** dgurtner has joined #puppet-openstack18:30
*** darkxploit has quit IRC18:31
*** itsuugo has joined #puppet-openstack18:37
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: [inspector] Specify SELinux type context for tftp dir  https://review.openstack.org/24467518:41
*** EmilienM has quit IRC18:42
*** darkxploit has joined #puppet-openstack18:44
*** EmilienM has joined #puppet-openstack18:46
*** rmart04 has quit IRC18:47
*** ilbot3 has quit IRC18:52
*** ilbot3 has joined #puppet-openstack18:53
*** angdraug has quit IRC18:58
*** mdorman has quit IRC18:58
*** mdorman has joined #puppet-openstack18:59
*** ntpttr has joined #puppet-openstack19:02
*** ntpttr has quit IRC19:05
*** xingchao has joined #puppet-openstack19:23
*** dgurtner has quit IRC19:24
*** nlahouti has quit IRC19:24
*** nlahouti has joined #puppet-openstack19:24
_odyclayton: re: https://review.openstack.org/#/c/243849.  I had decided to do that because facter 3 being a reimplementation of facter in C++11 so free game for API changes but since you asked I check in with puppet-dev.19:27
claytonit wasn't clear to me if the change was a workaround for a bug, or if the old way of doing this doesn't work with newer facter, or if just the recommended api changed19:28
_odyThey indicate that our old syntax should work but nothing in puppet core uses our syntax and we have modules bugs indicating a need to switch, https://tickets.puppetlabs.com/browse/MODULES-2246.19:28
claytonwfm then19:29
_odyI'll make the commit message better and include links to known issues.19:29
claytonsounds good, thanks19:29
*** xingchao has quit IRC19:29
* _ody would like to start testing against PC119:30
*** DarthVigil has quit IRC19:31
*** rahulait has quit IRC19:31
*** bnemec has joined #puppet-openstack19:33
*** itsuugo has quit IRC19:38
*** angdraug has joined #puppet-openstack19:40
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Add keystone domain specific configuration.  https://review.openstack.org/21928919:47
iurygregorychem, can you help me with the template problem?19:47
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: [inspector] Specify SELinux type context for tftp dir  https://review.openstack.org/24467519:47
chemiurygregory: which problem ?19:48
*** ntpttr has joined #puppet-openstack19:49
iurygregorythe CI is passing, but when i look at http://logs.openstack.org/21/216821/54/check/gate-puppet-keystone-puppet-beaker-rspec-dsvm-trusty/edaa060/logs/apache_config/10-keystone_wsgi_main.conf.txt.gz is only the initial apache configuration for keystone =/19:49
chemiurygregory: strang as in my test vm I could see the file modified ...19:50
iurygregoryyeah =/19:50
*** rmart04 has joined #puppet-openstack19:51
*** sergmelikyan has joined #puppet-openstack19:51
chemthe thing is that the resulting apache conf is the one done by the last acceptance test, which is not necessarily yours.19:51
chemthis is very unhelpfull and confusing19:51
iurygregoryoh ...19:51
chemthe apache conf, to be usable in the console log should be backup after each acceptance test19:51
chemyou're just seeing the last one19:52
chemwhich is not yours19:52
chem:)19:52
iurygregorymake sense XD19:52
iurygregoryso i'll try to create a vagrant instance and see if the manifest is ok19:52
chemiurygregory: the stuff work, but check by yourself :)19:52
iurygregoryyeah, can you do review and point anything o find? ^^19:53
iurygregorywhen you have time19:53
chemI'll do my best for tonight, but my guess would be tomorrow morning (in ~12h)19:54
iurygregoryno problem ;)19:55
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Support for multiple ldap backend.  https://review.openstack.org/23816419:55
*** iurygregory has quit IRC20:04
*** ericksonsantos has quit IRC20:05
*** rmart04 has quit IRC20:06
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Example about composite namevar possibilities.  https://review.openstack.org/24484620:12
*** dprince has quit IRC20:24
*** ducttape_ has quit IRC20:31
*** ilbot3 has quit IRC20:34
*** ilbot3 has joined #puppet-openstack20:34
*** nlahouti has quit IRC20:50
*** cwolferh has quit IRC20:50
*** samuelBartel has joined #puppet-openstack20:55
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Manage swift with swiftinit service provider  https://review.openstack.org/20322020:58
mwhahahaanyone run across neutron_network resource failure because it can't find the specified keystone_tenant?21:01
*** ducttape_ has joined #puppet-openstack21:01
mwhahahaargh i think it's related to the use of the openstack client to do an 'openstack domain list' which may not work because it defaults to v221:05
*** jayg is now known as jayg|g0n321:10
*** cwolferh has joined #puppet-openstack21:14
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Manage swift with swiftinit service provider  https://review.openstack.org/20322021:16
*** itsuugo has joined #puppet-openstack21:17
*** gfidente has quit IRC21:17
*** xingchao has joined #puppet-openstack21:28
*** xingchao has quit IRC21:32
*** aimon has quit IRC21:35
*** ntpttr has quit IRC21:44
*** nlahouti has joined #puppet-openstack21:49
*** kylo has joined #puppet-openstack21:50
*** nlahouti has quit IRC22:03
hogepodgehas anyone else seen the neutron subnet provider breaking?22:05
*** nlahouti has joined #puppet-openstack22:05
hogepodgeit looks like the client has changed options?22:05
hogepodgehttp://paste.openstack.org/show/478743/22:06
*** ddmitriev1 has joined #puppet-openstack22:06
*** mdorman has quit IRC22:06
*** itsuugo has quit IRC22:11
*** sergmelikyan has quit IRC22:12
*** rahulait has joined #puppet-openstack22:14
*** ntpttr has joined #puppet-openstack22:15
*** sergmelikyan has joined #puppet-openstack22:16
mwhahahawhy yes i just created a bug for that22:29
mwhahahahttps://bugs.launchpad.net/puppet-neutron/+bug/151578722:29
openstackLaunchpad bug 1515787 in puppet-neutron "neutron_subnet provider fails when a identity v2 tenant is used" [Undecided,New]22:29
mwhahahaer no that's a different one22:30
mwhahahahogepodge: what version of the openstack client do you have?22:30
hogepodgeIt fails for the kilo python-neutronclient, I'm checking liberty right now22:30
mwhahahait works on liberty22:30
mwhahahait's failing because of the lack of --format=json22:31
hogepodgeor, I guess kilo version of the python-openstackclient22:31
hogepodgeso puppet modules only support one release back now?22:31
*** ducttape_ has quit IRC22:31
mwhahahano that was a regression22:31
mwhahahaso we'll probably need to figure out an alternative22:31
*** ducttape_ has joined #puppet-openstack22:31
mwhahahaplease create a bug22:32
hogepodgedone22:32
*** lnxnut has quit IRC22:32
hogepodgemwhahaha: https://bugs.launchpad.net/puppet-neutron/+bug/151578622:34
openstackLaunchpad bug 1515786 in puppet-neutron "Update https://review.openstack.org/#/c/238156/ breaks neutron provider" [Undecided,New]22:34
*** gildub has joined #puppet-openstack22:34
*** trown is now known as trown|outttypeww22:35
*** dhollinger has quit IRC22:36
openstackgerritAlex Schultz proposed openstack/puppet-neutron: Add workaround for v2 tenant names  https://review.openstack.org/24490022:40
mwhahahadegorenko richm please see https://review.openstack.org/#/c/244900/ I'm pretty sure that it's a dirty hack but I'm not sure the best way to fix it22:42
*** gildub_ has joined #puppet-openstack22:42
*** ntpttr has left #puppet-openstack22:46
*** morazi has quit IRC22:47
*** sergmelikyan has quit IRC22:54
*** ducttape_ has quit IRC22:56
*** ducttape_ has joined #puppet-openstack22:56
*** mdorman has joined #puppet-openstack22:58
openstackgerritCody Herriges proposed openstack/puppet-glance: Make sure Facter is only executed on agent  https://review.openstack.org/24384922:59
*** ducttape_ has quit IRC23:01
_odyclayton: After digging https://review.openstack.org/243849 was a completely different issue.23:01
_odyJust the thing I ran into exposed it.23:01
*** jpena|zzz has quit IRC23:03
*** sanjayu has joined #puppet-openstack23:05
richmmwhahaha: does that make sense?23:06
*** jpena|zzz has joined #puppet-openstack23:10
openstackgerritCody Herriges proposed openstack/puppet-swift: Make sure Facter is only executed on agent  https://review.openstack.org/24385423:10
*** gildub_ has quit IRC23:11
*** gildub has quit IRC23:11
*** samuelBartel has quit IRC23:18
openstackgerritCody Herriges proposed openstack/puppet-neutron: Swamp Facter[].value with Facter.value()  https://review.openstack.org/24385323:21
*** xingchao has joined #puppet-openstack23:29
*** aimon has joined #puppet-openstack23:29
*** nlahouti has quit IRC23:35
*** xingchao has quit IRC23:36
*** nlahouti has joined #puppet-openstack23:39
*** nlahouti has quit IRC23:40
*** nlahouti1 has joined #puppet-openstack23:40
*** ducttape_ has joined #puppet-openstack23:47
*** gildub has joined #puppet-openstack23:47
*** gildub_ has joined #puppet-openstack23:48
*** dfisher has quit IRC23:59
*** bklei has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!