| *** v1k0d3n has quit IRC | 00:02 | |
| *** v1k0d3n has joined #puppet-openstack | 00:02 | |
| nibalizer | hello | 00:03 |
|---|---|---|
| *** gildub has joined #puppet-openstack | 00:09 | |
| *** v1k0d3n has quit IRC | 00:14 | |
| *** saneax has quit IRC | 00:14 | |
| *** v1k0d3n has joined #puppet-openstack | 00:15 | |
| *** markvoelker has joined #puppet-openstack | 00:15 | |
| *** aimon has joined #puppet-openstack | 00:17 | |
| *** severion has joined #puppet-openstack | 00:19 | |
| *** markvoelker has quit IRC | 00:21 | |
| *** v1k0d3n has quit IRC | 00:22 | |
| *** xingchao_ has joined #puppet-openstack | 00:24 | |
| *** linkedinyou has quit IRC | 00:32 | |
| openstackgerrit | Merged openstack/puppet-keystone: Move openstackclient install to keystone::client https://review.openstack.org/209965 | 00:39 |
| openstackgerrit | liaonanhai proposed openstack/puppet-nova: Set reserved_host_memory_mb to 0 using ironic https://review.openstack.org/211872 | 00:43 |
| *** dh64 has quit IRC | 00:45 | |
| *** richm has quit IRC | 00:53 | |
| *** xingchao_ has quit IRC | 00:55 | |
| *** jeblair has quit IRC | 00:56 | |
| *** xingchao_ has joined #puppet-openstack | 00:58 | |
| *** jeblair has joined #puppet-openstack | 00:58 | |
| *** gildub has quit IRC | 01:01 | |
| *** richm has joined #puppet-openstack | 01:03 | |
| *** xingchao_ has quit IRC | 01:06 | |
| *** v1k0d3n has joined #puppet-openstack | 01:10 | |
| *** severion has quit IRC | 01:13 | |
| *** v1k0d3n has quit IRC | 01:14 | |
| *** mesamoo has joined #puppet-openstack | 01:28 | |
| *** mesamoo has quit IRC | 01:28 | |
| *** gildub has joined #puppet-openstack | 01:30 | |
| *** tiswanso has joined #puppet-openstack | 01:44 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Resource keystone_group for Keystone V3 API https://review.openstack.org/202409 | 01:46 |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Keystone Role/Group resource provider https://review.openstack.org/211444 | 01:46 |
| *** tiswanso has quit IRC | 01:48 | |
| *** tiswanso has joined #puppet-openstack | 01:48 | |
| *** angdraug has quit IRC | 01:49 | |
| *** markvoelker has joined #puppet-openstack | 02:05 | |
| *** sergmelikyan has joined #puppet-openstack | 02:08 | |
| *** darkxploit has quit IRC | 02:29 | |
| *** xingchao has quit IRC | 02:50 | |
| openstackgerrit | Michael Chapman proposed openstack/puppet-keystone: Clarify the origin of provider warning messages https://review.openstack.org/212290 | 02:54 |
| *** ducttape_ has joined #puppet-openstack | 03:06 | |
| *** saneax has joined #puppet-openstack | 03:12 | |
| openstackgerrit | Merged openstack/puppet-ironic: Rely on autorequire for config resource ordering https://review.openstack.org/211898 | 03:16 |
| openstackgerrit | Timothy Swanson proposed openstack/puppet-neutron: Update Cisco ML2 classes and templates https://review.openstack.org/197181 | 03:36 |
| *** ducttape_ has quit IRC | 03:39 | |
| *** tiswanso has quit IRC | 03:47 | |
| *** richm has quit IRC | 04:04 | |
| *** saneax has quit IRC | 04:20 | |
| *** saneax has joined #puppet-openstack | 04:22 | |
| *** xarses_ has joined #puppet-openstack | 04:27 | |
| *** topshare has joined #puppet-openstack | 04:57 | |
| *** cdelatte has quit IRC | 05:13 | |
| *** cdelatte has joined #puppet-openstack | 05:13 | |
| *** sergmelikyan has quit IRC | 05:22 | |
| *** cdelatte has quit IRC | 05:33 | |
| *** dgurtner has joined #puppet-openstack | 05:34 | |
| *** dgurtner has quit IRC | 05:34 | |
| *** dgurtner has joined #puppet-openstack | 05:34 | |
| *** dgurtner has quit IRC | 05:35 | |
| *** dgurtner has joined #puppet-openstack | 05:35 | |
| *** dgurtner has joined #puppet-openstack | 05:35 | |
| *** dgurtner has quit IRC | 05:36 | |
| *** dgurtner has joined #puppet-openstack | 05:36 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Keystone Role/Group resource provider https://review.openstack.org/211444 | 05:37 |
| *** markvoelker has quit IRC | 05:41 | |
| *** delattec has joined #puppet-openstack | 05:41 | |
| *** sergmelikyan has joined #puppet-openstack | 05:57 | |
| *** delattec has quit IRC | 06:02 | |
| *** cdelatte has joined #puppet-openstack | 06:07 | |
| *** linkedinyou has joined #puppet-openstack | 06:16 | |
| *** vinsh has quit IRC | 06:17 | |
| *** sergmelikyan has quit IRC | 06:20 | |
| *** dgurtner has quit IRC | 06:28 | |
| *** markvoelker has joined #puppet-openstack | 06:41 | |
| *** markvoelker has quit IRC | 06:46 | |
| *** dgurtner has joined #puppet-openstack | 06:51 | |
| *** linkedinyou has quit IRC | 06:59 | |
| *** dgurtner has quit IRC | 06:59 | |
| *** dgurtner has joined #puppet-openstack | 07:00 | |
| *** jpena has joined #puppet-openstack | 07:22 | |
| *** mtreinish has quit IRC | 07:24 | |
| *** mtreinish has joined #puppet-openstack | 07:27 | |
| *** linkedinyou has joined #puppet-openstack | 07:40 | |
| *** jpena has quit IRC | 07:41 | |
| *** openstackgerrit has quit IRC | 07:41 | |
| *** pabelanger has quit IRC | 07:41 | |
| *** hogepodge has quit IRC | 07:41 | |
| *** bogdando has quit IRC | 07:41 | |
| *** Madkiss has quit IRC | 07:41 | |
| *** colby_ has quit IRC | 07:41 | |
| *** tdb has quit IRC | 07:41 | |
| *** mattymo has quit IRC | 07:41 | |
| *** crinkle has quit IRC | 07:41 | |
| *** ric` has quit IRC | 07:41 | |
| *** joshsamuelson has quit IRC | 07:41 | |
| *** jpena has joined #puppet-openstack | 07:42 | |
| *** openstackgerrit has joined #puppet-openstack | 07:42 | |
| *** pabelanger has joined #puppet-openstack | 07:42 | |
| *** hogepodge has joined #puppet-openstack | 07:42 | |
| *** bogdando has joined #puppet-openstack | 07:42 | |
| *** Madkiss has joined #puppet-openstack | 07:42 | |
| *** colby_ has joined #puppet-openstack | 07:42 | |
| *** tdb has joined #puppet-openstack | 07:42 | |
| *** mattymo has joined #puppet-openstack | 07:42 | |
| *** crinkle has joined #puppet-openstack | 07:42 | |
| *** ric` has joined #puppet-openstack | 07:42 | |
| *** joshsamuelson has joined #puppet-openstack | 07:42 | |
| *** cameron.freenode.net sets mode: +o crinkle | 07:42 | |
| *** Madkiss has quit IRC | 07:44 | |
| *** Madkiss_ has joined #puppet-openstack | 07:44 | |
| *** Madkiss_ is now known as Madkiss | 07:44 | |
| *** mattymo has quit IRC | 07:44 | |
| *** crinkle_ has joined #puppet-openstack | 07:44 | |
| *** joshsamuelson has quit IRC | 07:45 | |
| *** openstackgerrit has quit IRC | 07:45 | |
| *** pabelanger has quit IRC | 07:45 | |
| *** tdb has quit IRC | 07:45 | |
| *** jpena has quit IRC | 07:46 | |
| *** hogepodge has quit IRC | 07:46 | |
| *** bogdando has quit IRC | 07:46 | |
| *** colby_ has quit IRC | 07:46 | |
| *** crinkle has quit IRC | 07:46 | |
| *** ric` has quit IRC | 07:46 | |
| *** tdb has joined #puppet-openstack | 07:47 | |
| *** jprs has joined #puppet-openstack | 07:51 | |
| *** pabelanger has joined #puppet-openstack | 07:52 | |
| *** topshare has quit IRC | 07:53 | |
| *** mattymo has joined #puppet-openstack | 07:54 | |
| *** colby_ has joined #puppet-openstack | 07:58 | |
| *** jpena has joined #puppet-openstack | 08:00 | |
| *** bogdando has joined #puppet-openstack | 08:00 | |
| *** topshare has joined #puppet-openstack | 08:00 | |
| *** openstackgerrit has joined #puppet-openstack | 08:00 | |
| openstackgerrit | Yanis Guenane proposed openstack/puppet-glance: Rely on autorequire for config resource ordering https://review.openstack.org/211937 | 08:03 |
| EmilienM | good morning | 08:05 |
| *** rochaporto has joined #puppet-openstack | 08:07 | |
| *** vinsh has joined #puppet-openstack | 08:09 | |
| *** jpena has quit IRC | 08:17 | |
| *** gildub has quit IRC | 08:17 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-tempest: do not create tempest.conf from .sample file https://review.openstack.org/210784 | 08:17 |
| *** jpena has joined #puppet-openstack | 08:22 | |
| *** jistr has joined #puppet-openstack | 08:26 | |
| *** gfidente has joined #puppet-openstack | 08:29 | |
| openstackgerrit | Merged openstack/puppet-ceilometer: acceptance: clean an old FIXME in manifest https://review.openstack.org/209321 | 08:32 |
| *** jpena has quit IRC | 08:38 | |
| *** jpena has joined #puppet-openstack | 08:39 | |
| *** crinkle_ is now known as crinkle | 08:41 | |
| *** markvoelker has joined #puppet-openstack | 08:43 | |
| *** hogepodge has joined #puppet-openstack | 08:43 | |
| *** markvoelker has quit IRC | 08:47 | |
| openstackgerrit | Merged stackforge/puppet-ceph: Allow customization of OSDs journal size via class param https://review.openstack.org/211329 | 09:08 |
| openstackgerrit | Merged openstack/puppet-gnocchi: Rely on autorequire for config resource ordering https://review.openstack.org/211891 | 09:09 |
| openstackgerrit | Merged openstack/puppet-designate: Rely on autorequire for config resource ordering https://review.openstack.org/211890 | 09:13 |
| openstackgerrit | Merged openstack/puppet-cinder: Rely on autorequire for config resource ordering https://review.openstack.org/211886 | 09:16 |
| openstackgerrit | Merged openstack/puppet-ceilometer: Rely on autorequire for config resource ordering https://review.openstack.org/211884 | 09:18 |
| openstackgerrit | Merged openstack/puppet-keystone: Rely on autorequire for config resource ordering https://review.openstack.org/211900 | 09:18 |
| openstackgerrit | Merged openstack/puppet-keystone: Rely on autorequire for config resource ordering https://review.openstack.org/211900 | 09:18 |
| openstackgerrit | Merged openstack/puppet-heat: Rely on autorequire for config resource ordering https://review.openstack.org/211894 | 09:21 |
| openstackgerrit | Merged openstack/puppet-nova: Rely on autorequire for config resource ordering https://review.openstack.org/211909 | 09:26 |
| openstackgerrit | Yanis Guenane proposed openstack/puppet-neutron: Make package change run the db_sync https://review.openstack.org/202920 | 09:34 |
| *** gildub has joined #puppet-openstack | 09:37 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-heat: acceptance: bump to Liberty release https://review.openstack.org/209290 | 09:49 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: acceptance: bump to Liberty release https://review.openstack.org/209293 | 09:50 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-ceilometer: WSGI: make it work, and test it with acceptance https://review.openstack.org/209320 | 09:59 |
| *** saneax has quit IRC | 10:00 | |
| *** saneax has joined #puppet-openstack | 10:02 | |
| degorenko | spredzy, hey o/ why nobody is review your patch https://review.openstack.org/#/c/202574/ ? | 10:04 |
| *** topshare has quit IRC | 10:06 | |
| spredzy | degorenko, o/ I dont know ... People are busy or in vacation I guess. August is always a slow time. Although I did have some review. Will ping richm later today to know if he thinks the test are enough :) | 10:06 |
| degorenko | spredzy, oh, okay, will wait then :) thanks | 10:07 |
| EmilienM | degorenko, spredzy: have you tried this patch on another module using Depends-On ? | 10:09 |
| degorenko | EmilienM, spredzy good idea | 10:09 |
| EmilienM | so people would actually see it works | 10:10 |
| spredzy | EmilienM, all modules were green this morning before Rely on autorequire got merged. Not its in merged conflict. Else the patch is ready to merge.https://review.openstack.org/#/c/209882/ | 10:10 |
| spredzy | EmilienM, all puppet-openstack modules have been patched with this review (puppet-openstacklib) as a Depends-On https://review.openstack.org/#/q/status:open+branch:master+topic:inifile_proxy_provider,n,z | 10:10 |
| spredzy | Look at the acceptance test in each of them :) | 10:11 |
| EmilienM | ah | 10:11 |
| EmilienM | spredzy: https://review.openstack.org/#/c/209882/4/spec/acceptance/heat_config_spec.rb,cm | 10:12 |
| EmilienM | excellent | 10:12 |
| spredzy | :) | 10:12 |
| spredzy | Will rebase the on in conflict later today | 10:12 |
| EmilienM | spredzy: though I have suggestions on the acceptance patch, I'll +2 the openstacklib | 10:13 |
| spredzy | EmilienM, shoot either here or on a review I will need to amend all the reviews anyway :) | 10:13 |
| EmilienM | spredzy: done - brb | 10:15 |
| *** jeblair has quit IRC | 10:15 | |
| *** jeblair has joined #puppet-openstack | 10:16 | |
| spredzy | EmilienM, ack | 10:17 |
| degorenko | EmilienM, can you review my patch https://review.openstack.org/205987 ? :) it has already +2 and +1 from Sahara team. Do we need +1 from Sahara PTL? :) | 10:19 |
| EmilienM | degorenko: looking now and commenting | 10:23 |
| degorenko | EmilienM, so, if parameters absolutely wrong, have never been used in sahara and was added by mistake (why?) - they should be deprecated? | 10:27 |
| EmilienM | degorenko: because they have been added, we need to support them | 10:28 |
| EmilienM | I know it's bizarre | 10:28 |
| EmilienM | but we have an interface, we need to support it | 10:28 |
| EmilienM | we can't just "drop parameters" | 10:28 |
| degorenko | EmilienM, then, i just drop those parameters from config, but left warning message and mark them as deprecated, is it right? | 10:29 |
| EmilienM | degorenko: yeah, like you do with other deprecated params in init.pp | 10:29 |
| EmilienM | degorenko: and a nice warning explaining the params are useless :) | 10:29 |
| degorenko | EmilienM, in init.pp were just only deprecated and renamed, but there are different case. Okay, i'll upload new patch. | 10:30 |
| EmilienM | degorenko: after that, I'll +2 | 10:30 |
| EmilienM | spredzy: do you think we can drop these parameters? | 10:33 |
| EmilienM | degorenko: wait | 10:33 |
| spredzy | EmilienM, let me refind a link I used to +2 this | 10:33 |
| degorenko | spredzy, https://review.openstack.org/#/c/205987 | 10:33 |
| EmilienM | spredzy: this is my question ^ | 10:34 |
| EmilienM | spredzy: what do you think about my comment | 10:34 |
| degorenko | EmilienM, btw, should i use one 'if' for all of them or per each 'if' ? | 10:35 |
| EmilienM | degorenko: wait a sec, I'm just asking some feedback from other reviewers - maybe we can move forward with this one | 10:35 |
| spredzy | Well based on https://github.com/openstack/sahara/blob/stable/kilo/etc/sahara/sahara.conf.sample-basic and https://github.com/openstack/sahara/blob/master/etc/sahara/sahara.conf.sample-basic | 10:35 |
| EmilienM | I'm not talking about OpenStack functional | 10:36 |
| EmilienM | I'm talking about Puppet interface here | 10:36 |
| spredzy | those parameters have never been used, so basically if someone was using them s/he didn't know what s/he was doing | 10:36 |
| EmilienM | if anyone is running a manifest with this parameter | 10:36 |
| EmilienM | the catalog will fail | 10:36 |
| spredzy | It will since those parameters doesn't exist anymore | 10:36 |
| EmilienM | that's my point | 10:36 |
| spredzy | So yes I guess the safest path will be to deprecate them for some tie | 10:37 |
| spredzy | time* | 10:37 |
| degorenko | EmilienM, spredzy my point for this - that is using of this parameters - mistake and it should failed. Because it wrong parameters. But, i can left waring message | 10:37 |
| degorenko | s/waring/warning | 10:37 |
| degorenko | okay, i'll prepare new patch | 10:38 |
| degorenko | and again: EmilienM, btw, should i use one 'if' for all of them or per each 'if' ? | 10:38 |
| EmilienM | degorenko: you can use OR | 10:39 |
| degorenko | so i can use one if? | 10:39 |
| EmilienM | I guess? | 10:42 |
| EmilienM | if $param or $param2 ... | 10:43 |
| degorenko | okay, i will use per each if | 10:43 |
| degorenko | it will be more informative and have no spam | 10:43 |
| degorenko | s/have/has | 10:43 |
| *** markvoelker has joined #puppet-openstack | 10:43 | |
| openstackgerrit | Denis Egorenko proposed openstack/puppet-sahara: Update parameters for Sahara https://review.openstack.org/205987 | 10:48 |
| *** markvoelker has quit IRC | 10:48 | |
| degorenko | EmilienM, spredzy ^ take a look please | 10:49 |
| EmilienM | degorenko: sure | 10:49 |
| EmilienM | degorenko: +2 | 10:51 |
| degorenko | EmilienM, thanks! | 10:51 |
| *** xingchao has joined #puppet-openstack | 10:54 | |
| degorenko | spredzy, EmilienM https://review.openstack.org/#/c/205987/ tests passed :) let | 11:07 |
| degorenko | let's merge :D | 11:07 |
| degorenko | EmilienM, spredzy also, this patch is actual for kilo, can i cherry-pick them? | 11:08 |
| EmilienM | degorenko: you'll have yes | 11:08 |
| EmilienM | degorenko: and drop the warnings in master ;) | 11:09 |
| degorenko | EmilienM, this patch is for master now :( | 11:09 |
| EmilienM | degorenko: yes | 11:09 |
| EmilienM | but later | 11:09 |
| degorenko | oh, okay :) | 11:09 |
| *** gildub has quit IRC | 11:11 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Keystone Role/Group resource provider https://review.openstack.org/211444 | 11:14 |
| *** myatsenko has joined #puppet-openstack | 11:30 | |
| *** markvoelker has joined #puppet-openstack | 11:44 | |
| *** saneax has quit IRC | 11:46 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-sahara: acceptance: bump to Liberty release https://review.openstack.org/212496 | 11:47 |
| *** markvoelker has quit IRC | 11:49 | |
| *** markvoelker has joined #puppet-openstack | 11:53 | |
| *** jpena has quit IRC | 11:57 | |
| *** jpena has joined #puppet-openstack | 11:59 | |
| *** jpena is now known as jpena|lunch | 11:59 | |
| *** ducttape_ has joined #puppet-openstack | 12:04 | |
| *** xarses_ has quit IRC | 12:04 | |
| *** ducttape_ has quit IRC | 12:11 | |
| iurygregory | good morning | 12:13 |
| *** xingchao has quit IRC | 12:19 | |
| *** xingchao has joined #puppet-openstack | 12:20 | |
| *** ducttape_ has joined #puppet-openstack | 12:20 | |
| *** jayg|g0n3 is now known as jayg | 12:24 | |
| *** xingchao has quit IRC | 12:25 | |
| degorenko | morning o/ | 12:30 |
| iurygregory | \o | 12:30 |
| mattymo_ | markvoelker, hey | 12:34 |
| *** ducttape_ has quit IRC | 12:38 | |
| *** sergmelikyan has joined #puppet-openstack | 12:51 | |
| *** richm has joined #puppet-openstack | 12:54 | |
| *** sergmelikyan has quit IRC | 12:56 | |
| *** richm has quit IRC | 12:56 | |
| *** richm has joined #puppet-openstack | 12:56 | |
| EmilienM | pabelanger: hello ! | 12:57 |
| *** openstackgerrit has quit IRC | 13:01 | |
| *** openstackgerrit has joined #puppet-openstack | 13:02 | |
| *** saneax has joined #puppet-openstack | 13:09 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version https://review.openstack.org/212523 | 13:16 |
| *** jpena|lunch is now known as jpena | 13:17 | |
| openstackgerrit | Andrey Yevsyukov proposed openstack/puppet-neutron: Add support for neutron-agent-mlnx deployment https://review.openstack.org/209997 | 13:18 |
| *** tiswanso has joined #puppet-openstack | 13:20 | |
| *** sergmelikyan has joined #puppet-openstack | 13:22 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version https://review.openstack.org/212523 | 13:26 |
| *** v1k0d3n has joined #puppet-openstack | 13:27 | |
| mattymo_ | hey EmilienM | 13:27 |
| EmilienM | mattymo: o/ | 13:28 |
| mattymo_ | you wouldn't happen to know if gildub comes on irc often? he seems to be avoiding it | 13:28 |
| EmilienM | mattymo: it's very late for him at this time, I suspect he's offline - though he's sending patches | 13:29 |
| mattymo_ | yeah from tactical range, it seems | 13:29 |
| mattymo_ | EmilienM, do you happen to know where he is located? | 13:29 |
| EmilienM | mattymo: australia | 13:30 |
| mattymo_ | oh that explains a lot | 13:30 |
| *** sergmelikyan has quit IRC | 13:36 | |
| *** sergmelikyan has joined #puppet-openstack | 13:37 | |
| *** prad_ has joined #puppet-openstack | 13:37 | |
| *** dfisher has joined #puppet-openstack | 13:38 | |
| *** dgurtner has quit IRC | 13:43 | |
| *** tiswanso has quit IRC | 13:49 | |
| *** tiswanso has joined #puppet-openstack | 13:50 | |
| *** sergmelikyan has quit IRC | 13:57 | |
| spredzy | clayton, if around can I ask for reviews on https://review.openstack.org/#/q/status:open+branch:master+topic:autorequire_package_or_file,n,z | 13:59 |
| degorenko | spredzy, hey, can you merge this? https://review.openstack.org/#/c/205987/ :) | 14:01 |
| *** dgurtner has joined #puppet-openstack | 14:02 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: acceptance: bump to Liberty release https://review.openstack.org/209293 | 14:03 |
| openstackgerrit | Yanis Guenane proposed openstack/puppet-ceilometer: Reflect provider change in puppet-openstacklib https://review.openstack.org/209868 | 14:05 |
| *** tiswanso has quit IRC | 14:05 | |
| *** ferest has joined #puppet-openstack | 14:06 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version https://review.openstack.org/212523 | 14:09 |
| *** ferest has quit IRC | 14:11 | |
| *** aviramb has joined #puppet-openstack | 14:13 | |
| pabelanger | EmilienM: morning | 14:13 |
| EmilienM | pabelanger: hey | 14:15 |
| EmilienM | pabelanger: can you see https://review.openstack.org/210089 and tell me what you think? | 14:15 |
| dfisher | can I ask a general puppet question in here, or should I go try #puppet? | 14:16 |
| dfisher | I rarely have any luck in #puppet :/ | 14:16 |
| *** tiswanso has joined #puppet-openstack | 14:16 | |
| EmilienM | dfisher: go ahead! We'll add it to the beer list :P | 14:17 |
| dfisher | shit, at this point, I just need to wheel a keg in. | 14:17 |
| dfisher | or 3 | 14:17 |
| dfisher | ok, so, I have a puppet environment. configured as /etc/puppet/environment/foo | 14:17 |
| dfisher | if I still something in …/foo/manifests/site.pp like "notify { message => 'hello world' }" it works | 14:18 |
| dfisher | i see that. | 14:18 |
| dfisher | in foo/manifests/site.pp, I have import statements for nodes. | 14:18 |
| dfisher | import "…/foo/manifests/nodes/node1.pp" | 14:18 |
| dfisher | all I have in node1.pp is: | 14:19 |
| dfisher | node 'openstack-1.us.oracle.com' { | 14:19 |
| dfisher | mysql::db { 'cinder': | 14:19 |
| dfisher | user => 'cinder', | 14:19 |
| dfisher | password => 'cinder', | 14:19 |
| dfisher | host => 'localhost', | 14:19 |
| dfisher | } | 14:19 |
| dfisher | } | 14:19 |
| pabelanger | EmilienM: commented added | 14:19 |
| EmilienM | pabelanger: looking | 14:19 |
| dfisher | just … make me a cinder database. | 14:19 |
| dfisher | nothing complicated. | 14:19 |
| EmilienM | pabelanger: cool!, feel free to take over :) | 14:19 |
| dfisher | in the agent log, I get: | 14:19 |
| dfisher | 2015-08-13 14:15:56 +0000 Puppet (notice): Starting Puppet client version 3.6.2 | 14:19 |
| dfisher | 2015-08-13 14:16:00 +0000 Puppet (err): Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter provider on Mysql_database[cinder] on node openstack-kz-1.us.oracle.com | 14:19 |
| EmilienM | pabelanger: see other comments from crinkle on other patches - maybe we can move forward those things this week | 14:20 |
| dfisher | but when I run 'puppet apply' with the same code, it works fine. | 14:20 |
| dfisher | root@:/var/log/puppet# puppet apply --noop -e "mysql::db { 'cinder': user => 'cinder', password => 'cinder',}" | 14:20 |
| dfisher | Notice: /Stage[main]/Main/Mysql::Db[cinder]/Mysql_user[cinder@localhost]/ensure: current_value absent, should be present (noop) | 14:20 |
| dfisher | Notice: /Stage[main]/Main/Mysql::Db[cinder]/Mysql_database[cinder]/ensure: current_value absent, should be present (noop) | 14:20 |
| dfisher | Notice: /Stage[main]/Main/Mysql::Db[cinder]/Mysql_grant[cinder@localhost/cinder.*]/ensure: current_value absent, should be present (noop) | 14:20 |
| dfisher | Notice: Mysql::Db[cinder]: Would have triggered 'refresh' from 3 events | 14:20 |
| dfisher | Notice: Class[Main]: Would have triggered 'refresh' from 1 events | 14:20 |
| EmilienM | dfisher: please use paste | 14:20 |
| pabelanger | jebus | 14:20 |
| dfisher | sorry. | 14:20 |
| dfisher | will paste. | 14:20 |
| EmilienM | dfisher: it's likely your puppet master node missing some modules or? | 14:21 |
| pabelanger | EmilienM: Ya, I have some fedora 22 stuff I'm working on this week. So, not sure if I'll have the time this week to focus on puppet-openstack-integration. Also trying to get msync patchset signed off too | 14:21 |
| EmilienM | pabelanger: I have time. Can I do that? | 14:21 |
| EmilienM | pabelanger: so we can make progress | 14:22 |
| dfisher | puppet module list shows the mysql module | 14:22 |
| EmilienM | pabelanger: I'll take your bits and add Co-Authored-By stuff | 14:22 |
| pabelanger | EmilienM: if you want, but won't be able to review until next week | 14:24 |
| pabelanger | or until I get fedora 22 dibs going | 14:24 |
| EmilienM | pabelanger: at least prepare the patch and see how gate works | 14:24 |
| EmilienM | pabelanger: and get crinkle's feedback | 14:25 |
| EmilienM | pabelanger: you'll have time to review it won't land before next week anyway | 14:25 |
| EmilienM | just to make progress on that | 14:25 |
| aviramb | dfisher does "puppet apply /etc/puppet/environment/foo/manifests/nodes/node1.pp" fails too? | 14:25 |
| dfisher | it's on a different system. | 14:25 |
| dfisher | i can easily scp it over | 14:25 |
| dfisher | and try it | 14:26 |
| dfisher | http://paste.openstack.org/show/412891/ | 14:26 |
| dfisher | paste of above. apologies for that | 14:26 |
| dfisher | aviramb: if I scp node1.pp over to the agent system, yes, it works | 14:28 |
| aviramb | and if you work in production/default env using master-agent? | 14:29 |
| dfisher | i'm pretty sure it'll work if I move back to default | 14:31 |
| dfisher | give me a sec. | 14:31 |
| *** ducttape_ has joined #puppet-openstack | 14:35 | |
| *** linkedinyou has quit IRC | 14:35 | |
| dfisher | ok, might need more than a sec. I think I hosed something :) | 14:37 |
| *** bklei has joined #puppet-openstack | 14:40 | |
| *** vmbrasseur has quit IRC | 14:42 | |
| *** linkedinyou has joined #puppet-openstack | 14:42 | |
| *** vmbrasseur has joined #puppet-openstack | 14:47 | |
| bklei | crinkle are you cool with https://review.openstack.org/#/c/211736/ and https://review.openstack.org/#/c/212117/ now? | 14:54 |
| *** dgurtner has quit IRC | 14:56 | |
| *** jistr is now known as jistr|mtg | 14:57 | |
| *** sergmelikyan has joined #puppet-openstack | 14:58 | |
| *** mdorman has joined #puppet-openstack | 15:03 | |
| *** sergmelikyan has quit IRC | 15:03 | |
| *** bklei_ has joined #puppet-openstack | 15:19 | |
| *** bklei has quit IRC | 15:22 | |
| *** xingchao has joined #puppet-openstack | 15:23 | |
| *** paramite has joined #puppet-openstack | 15:23 | |
| *** angdraug has joined #puppet-openstack | 15:23 | |
| *** morazi has joined #puppet-openstack | 15:28 | |
| *** darkxploit has joined #puppet-openstack | 15:30 | |
| *** darkxploit has quit IRC | 15:31 | |
| *** darkxploit has joined #puppet-openstack | 15:32 | |
| *** darkxploit has quit IRC | 15:33 | |
| *** darkxploit has joined #puppet-openstack | 15:34 | |
| *** jistr|mtg is now known as jistr | 15:34 | |
| crinkle | bklei_: looks good | 15:43 |
| *** darkxploit has quit IRC | 15:45 | |
| *** dprince has joined #puppet-openstack | 15:47 | |
| *** jistr has quit IRC | 15:48 | |
| EmilienM | crinkle: I dropped some comments on https://review.openstack.org/#/c/210784/ & https://review.openstack.org/#/c/210380/ | 15:49 |
| *** myatsenko has left #puppet-openstack | 15:51 | |
| *** myatsenko has joined #puppet-openstack | 15:51 | |
| openstackgerrit | Eric Peterson proposed openstack/puppet-keystone: Adding wsgi log formatting https://review.openstack.org/212091 | 15:51 |
| ducttape_ | EmilienM - I knew I was going to need unit test ;) | 15:56 |
| * ducttape_ curses unit tests | 15:56 | |
| EmilienM | ducttape_: ;) | 15:56 |
| *** darkxploit has joined #puppet-openstack | 15:57 | |
| ducttape_ | and if crinkle is happy, does that mean everyone is happy? | 15:58 |
| EmilienM | :) | 15:58 |
| openstackgerrit | Merged openstack/puppet-monasca: Allow config of check idle connection for persister https://review.openstack.org/211736 | 16:02 |
| openstackgerrit | Merged openstack/puppet-monasca: Fix template variable scoping https://review.openstack.org/212117 | 16:03 |
| *** morazi has quit IRC | 16:04 | |
| *** dprince has quit IRC | 16:05 | |
| *** aimon has quit IRC | 16:05 | |
| dfisher | EmilienM: aviramb helped me figure everything out. My version of puppet (3.6.2) needs PUP-1515 (fixed in 3.7.5/4.0.0) | 16:09 |
| EmilienM | dfisher: cool | 16:10 |
| dfisher | so, i either need to figure out how to work with 3.6.2 or go through the worst process ever to update puppet in solaris | 16:10 |
| dfisher | are the openstack modules 4.x compliant? | 16:10 |
| openstackgerrit | Eric Peterson proposed openstack/puppet-keystone: Adding wsgi log formatting https://review.openstack.org/212091 | 16:14 |
| spredzy | crinkle, ping. With EmilienM we're not sure for this series (https://review.openstack.org/#/q/status:open+branch:master+topic:inifile_proxy_provider,n,z) if it is worth having a separate acceptance test scenarios. We would like to have your opinion | 16:14 |
| * ducttape_ adds unit test, still curses them | 16:14 | |
| *** darkxploit has quit IRC | 16:15 | |
| spredzy | ie. for modules with a single configuration provider it might be not worth it. But when modules have a lot of config providers (like neutron) - it seems like we are better off leaving them on their file https://review.openstack.org/#/c/209875/9/spec/acceptance/neutron_config_spec.rb,cm | 16:15 |
| crinkle | spredzy: i would think the tests we already have would generally catch config issues? | 16:18 |
| spredzy | crinkle, those test are meant to ensure the new behavior is working as expected | 16:18 |
| spredzy | crinkle, the behavior that if we specify a specific keyword it is then absent from the file | 16:18 |
| crinkle | oh i see | 16:19 |
| crinkle | ¯\_(ツ)_/¯ | 16:19 |
| crinkle | I feel like acceptance tests should just be checking whether the stuff is generally working, not inspecting the contents of config files | 16:19 |
| crinkle | maybe an acceptance test in openstacklib? | 16:20 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: configure and run tempest https://review.openstack.org/207078 | 16:20 |
| spredzy | crinkle, in openstacklib we have a unittest, since openstack_config can not be instantiated itself we can't test the behavior there | 16:20 |
| EmilienM | crinkle: +1 | 16:20 |
| spredzy | hence the tests in the respective modules | 16:20 |
| crinkle | spredzy: hrm yeah | 16:20 |
| EmilienM | pabelanger: both patches in https://review.openstack.org/207078 | 16:21 |
| crinkle | spredzy: but it seems overkill to add that test to all the modules, if one is workin they're all probably working | 16:21 |
| crinkle | spredzy: idk i don't have a good answer | 16:21 |
| EmilienM | maybe write acceptance test in the openstacklib module | 16:21 |
| EmilienM | by creating a fake provider | 16:22 |
| EmilienM | and see how it behaves | 16:22 |
| *** paramite has quit IRC | 16:23 | |
| *** mwoodson has joined #puppet-openstack | 16:24 | |
| pabelanger | EmilienM: ack | 16:25 |
| EmilienM | spredzy: ^ | 16:25 |
| *** EmilienM sets mode: +o crinkle | 16:26 | |
| *** EmilienM sets mode: +o clayton | 16:26 | |
| *** EmilienM sets mode: +o spredzy | 16:26 | |
| spredzy | EmilienM, hmmm How do you create fake providers in acceptance test ? I could do what you suggest, but the openstacklib patch will need to go first (as-is), then the keystone patch (minus the acceptance), then a new openstacklib patch that demostrates the behavior once the keystone patch has been merged | 16:29 |
| EmilienM | spredzy: you can do dependencies | 16:30 |
| EmilienM | but the idea would be to create a fake_config provider | 16:30 |
| EmilienM | and test it | 16:30 |
| spredzy | but how do you create a fake config provider in acceptance test ? | 16:30 |
| spredzy | A fake config provider has already been created in the unit test to demostrate the behavior | 16:30 |
| spredzy | acceptance test are plain puppet code as far as I know | 16:31 |
| EmilienM | spredzy: maybe you can create an actual provider? | 16:31 |
| EmilienM | and consume this provider from acceptance | 16:31 |
| spredzy | EmilienM, nop, that is not the point, the openstacklib is supposed to be a fully transparent proxy | 16:31 |
| EmilienM | maybe it's overkill | 16:31 |
| *** openstackgerrit has quit IRC | 16:31 | |
| spredzy | what I can do is create another review (with an acceptance test only) that will depend on the keystone (inifilx_proxy_provider), that will depend on the actual code for the proxy in openstacklib | 16:32 |
| spredzy | would you guys be ok with that ? EmilienM crinkle ? | 16:32 |
| *** openstackgerrit has joined #puppet-openstack | 16:32 | |
| crinkle | haha | 16:32 |
| EmilienM | it does not solve our problem of testing the code | 16:32 |
| crinkle | i think that will work | 16:32 |
| spredzy | EmilienM, why not ? It will prove that the provider works | 16:33 |
| spredzy | as expected | 16:33 |
| EmilienM | spredzy: what about if, later I want to patch your code? how is it tested? | 16:33 |
| spredzy | in the openstacklib acceptance test | 16:33 |
| spredzy | every config provider will be children of openstack_config | 16:33 |
| spredzy | so if you change anything there every module will be impacted and the acceptance test of openstacklib will fail | 16:34 |
| EmilienM | spredzy: but you still need to write a fake provider, isn't? | 16:34 |
| spredzy | no at all | 16:34 |
| bklei_ | thx for the merges crinkle | 16:34 |
| spredzy | I will rely on one of our providers (be it keystone, nova or whichever) | 16:35 |
| EmilienM | spredzy: go ahead with your proposal, I guess I'm missing something | 16:35 |
| EmilienM | ahh | 16:35 |
| spredzy | hence the 3 review dance | 16:35 |
| EmilienM | but you need to install keystone then | 16:35 |
| EmilienM | in openstacklib acceptance | 16:35 |
| spredzy | well not instanciating the keystone class but yes installing it in the module path | 16:36 |
| spredzy | well if you stand by the -1 earlier when you didn't like the File { '/etc/keystone/keystone.conf' : } resource for testing, yes I will have to instantiate keystone | 16:36 |
| EmilienM | spredzy: brb lunch | 16:37 |
| EmilienM | spredzy: send it, I'll see :) | 16:37 |
| spredzy | EmilienM, ack | 16:37 |
| *** xingchao has quit IRC | 16:38 | |
| EmilienM | pabelanger: it works: https://jenkins05.openstack.org/job/gate-puppet-openstack-integration-dsvm-centos7/16/console | 16:41 |
| *** aimon has joined #puppet-openstack | 16:42 | |
| pabelanger | EmilienM: scary! | 16:42 |
| *** jpena has quit IRC | 16:43 | |
| openstackgerrit | Matthew Mosesohn proposed openstack/puppet-keystone: Update get_endpoint to use credentials auth_url first https://review.openstack.org/207890 | 16:52 |
| *** sergmelikyan has joined #puppet-openstack | 16:58 | |
| *** ddmitriev has quit IRC | 16:59 | |
| *** ddmitriev has joined #puppet-openstack | 17:02 | |
| *** ddmitriev has quit IRC | 17:02 | |
| *** sergmelikyan has quit IRC | 17:02 | |
| openstackgerrit | Benedikt von St. Vieth proposed openstack/puppet-glance: solve duplicate declaration issue for python-openstackclient https://review.openstack.org/211863 | 17:04 |
| *** rochaporto has quit IRC | 17:11 | |
| EmilienM | crinkle: could you please revisit https://review.openstack.org/#/c/209320/ ? | 17:19 |
| *** gfidente has quit IRC | 17:25 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-ceilometer: WSGI: make it work, and test it with acceptance https://review.openstack.org/209320 | 17:32 |
| EmilienM | crinkle: thx^ | 17:32 |
| dfisher | how would i check gerrit to see if there are any outstanding reviews against a specific file in a specific branch? Can I do that/ | 17:35 |
| *** gfidente has joined #puppet-openstack | 17:37 | |
| *** gfidente has quit IRC | 17:37 | |
| *** gfidente has joined #puppet-openstack | 17:37 | |
| *** xingchao has joined #puppet-openstack | 17:39 | |
| openstackgerrit | Dmitry Ilyin proposed openstack/puppet-neutron: Add retries to nova_admin_tenant_id_setter https://review.openstack.org/194673 | 17:39 |
| *** angdraug has quit IRC | 17:41 | |
| *** xingchao has quit IRC | 17:43 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: api: require ::keystone::python https://review.openstack.org/212680 | 17:45 |
| EmilienM | spredzy: ^ | 17:45 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: acceptance: bump to Liberty release https://review.openstack.org/209293 | 17:46 |
| openstackgerrit | Matthew Mosesohn proposed openstack/puppet-keystone: Update get_endpoint to use credentials auth_url first https://review.openstack.org/207890 | 17:54 |
| mattymo_ | dfisher, you'll have to do some awk magic, but you can dump it with this command: | 17:57 |
| mattymo_ | ssh -p 29418 review.openstack.org gerrit query --files --current-patch-set project:openstack/puppet-keyston | 17:57 |
| mattymo_ | +e | 17:57 |
| *** sergmelikyan has joined #puppet-openstack | 17:58 | |
| openstackgerrit | Richard Raseley proposed openstack/puppet-zaqar: puppet-zaqar: Initial commit https://review.openstack.org/204225 | 18:04 |
| *** chem has joined #puppet-openstack | 18:06 | |
| *** imcsk8 has quit IRC | 18:07 | |
| *** imcsk8 has joined #puppet-openstack | 18:07 | |
| *** angdraug has joined #puppet-openstack | 18:19 | |
| *** gfidente has quit IRC | 18:27 | |
| dfisher | thanks! | 18:30 |
| *** sergmelikyan has quit IRC | 18:59 | |
| *** tiswanso has quit IRC | 19:01 | |
| *** tiswanso has joined #puppet-openstack | 19:02 | |
| *** sergmelikyan has joined #puppet-openstack | 19:12 | |
| *** chem has quit IRC | 19:14 | |
| *** chem has joined #puppet-openstack | 19:14 | |
| *** v1k0d3n has left #puppet-openstack | 19:21 | |
| *** v1k0d3n has joined #puppet-openstack | 19:21 | |
| Hunner | v1k0d3n: hi | 19:21 |
| *** v1k0d3n has left #puppet-openstack | 19:21 | |
| *** mesamoo has joined #puppet-openstack | 19:22 | |
| *** tiswanso has quit IRC | 19:42 | |
| *** imcsk8 has quit IRC | 19:43 | |
| *** imcsk8 has joined #puppet-openstack | 19:43 | |
| *** tiswanso has joined #puppet-openstack | 19:45 | |
| *** tiswanso has quit IRC | 19:54 | |
| *** tiswanso has joined #puppet-openstack | 19:56 | |
| *** jayg is now known as jayg|g0n3 | 20:00 | |
| *** chem has quit IRC | 20:08 | |
| openstackgerrit | Timothy Swanson proposed openstack/puppet-neutron: Update Cisco ML2 classes and templates https://review.openstack.org/197181 | 20:35 |
| *** xingchao has joined #puppet-openstack | 20:42 | |
| *** xingchao has quit IRC | 20:48 | |
| *** v1k0d3n has joined #puppet-openstack | 20:54 | |
| v1k0d3n | Hunner: question...i was talking to david about this last week, is there a good vagrant deployment of puppet pe similar to the SE one you guys use internally? of the one's that i've found on github, many are outdated and pretty broken (and none are 2015.2 versions). | 21:02 |
| Hunner | v1k0d3n: https://atlas.hashicorp.com/puppetlabs is where I would look to find the latest vagrant vms. Looks like the PE ones are 3.8.1 currently. | 21:03 |
| v1k0d3n | Hunner: of course i left the big part out...(sorry)...are you guys using a vagrant version for auto-creation of r10k with github/gitlab etc environments? sort of a puppet dev workflow in a box? | 21:05 |
| Hunner | v1k0d3n: Oh, there is also the acceptance tests for the modules | 21:08 |
| Hunner | v1k0d3n: One of the gating jobs runs `bundle install && bundle exec rspec spec/acceptance` on modules, which runs specs like https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/basic_keystone_spec.rb on nodepool machines. You can also run it locally and it will vagrant up a test machine | 21:11 |
| Hunner | v1k0d3n: I don't think I know what you mean... PL runs beaker tests on all of our modules, usually pointing at an internal VM infrastructure, and openstack does the same thing pointed at nodepool | 21:12 |
| Hunner | Neither of those use vagrant, though beaker can do vagrant for local dev & testing | 21:13 |
| v1k0d3n | Hunner: david and i first started talking about the r10k workflow hooks with github/gitlab, whatever. | 21:13 |
| v1k0d3n | i am using gitlab for testing. | 21:13 |
| Hunner | Also, we usually use the *-nocm machines that don't come with puppet installed, and install puppet as part of the test run https://github.com/openstack/puppet-keystone/blob/master/spec/spec_helper_acceptance.rb#L4 | 21:13 |
| Hunner | v1k0d3n: It looks like the openstack puppet project uses r10k to build out their module list though https://github.com/openstack/puppet-openstack-integration/blob/master/install_modules.sh#L31 | 21:14 |
| v1k0d3n | he pointed me to a couple of github projects which were meant to vagrant up a puppet workflow with working r10k hooks to automatically create environments. but each one we found was pretty broken. ah, github...love or hate. | 21:14 |
| v1k0d3n | good find there...that's pretty cool | 21:15 |
| v1k0d3n | so these are the mods you wanted me to use...the openstack modules, correct? | 21:15 |
| v1k0d3n | not forge etc. | 21:15 |
| Hunner | Those methods appear to be called from a modules spec/spec_helper_acceptance.rb files prior to running any manifests | 21:15 |
| Hunner | forge.puppetlabs.com/openstack are the released versions of github.com/openstack/puppet-* | 21:16 |
| Hunner | So you can point r10k at github, the forge, or probably even gerrit. Ppatches should always be submitted to gerrit, and github is available just for conveniece | 21:16 |
| *** mesamoo has quit IRC | 21:26 | |
| *** tiswanso has quit IRC | 21:27 | |
| *** sergmelikyan has quit IRC | 21:28 | |
| *** sergmelikyan has joined #puppet-openstack | 21:31 | |
| *** sergmelikyan has quit IRC | 21:37 | |
| *** sergmelikyan has joined #puppet-openstack | 22:10 | |
| clayton | r10k + gerrit works fine, that's how we do all our deploys | 22:24 |
| *** mesamoo has joined #puppet-openstack | 22:24 | |
| *** gildub has joined #puppet-openstack | 22:35 | |
| *** sergmelikyan has quit IRC | 22:36 | |
| openstackgerrit | Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version https://review.openstack.org/212523 | 22:42 |
| *** bklei_ has quit IRC | 22:47 | |
| *** dfisher has quit IRC | 22:48 | |
| *** bklei has joined #puppet-openstack | 22:48 | |
| *** bklei has quit IRC | 22:48 | |
| *** sergmelikyan has joined #puppet-openstack | 22:49 | |
| *** ducttape_ has quit IRC | 22:50 | |
| *** xarses has joined #puppet-openstack | 23:03 | |
| *** prad_ has quit IRC | 23:08 | |
| *** xarses has quit IRC | 23:15 | |
| *** sergmelikyan has quit IRC | 23:15 | |
| *** xavpaice has joined #puppet-openstack | 23:19 | |
| *** xavpaice has left #puppet-openstack | 23:20 | |
| *** aimon has quit IRC | 23:21 | |
| *** chem has joined #puppet-openstack | 23:31 | |
| *** sergmelikyan has joined #puppet-openstack | 23:38 | |
| *** markvoelker has quit IRC | 23:50 | |
| *** xingchao has joined #puppet-openstack | 23:57 | |
| *** aimon has joined #puppet-openstack | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!