Monday, 2015-06-15

« Sunday, 2015-06-14 Index Tuesday, 2015-06-16 »
*** saneax has quit IRC00:05
*** ferest has quit IRC00:33
*** ferest has joined #puppet-openstack00:34
*** aimon_ has joined #puppet-openstack00:37
*** xingchao has quit IRC00:38
*** ferest has quit IRC00:38
*** imcsk8_ has joined #puppet-openstack01:15
*** imcsk8 has quit IRC01:17
*** imcsk8 has joined #puppet-openstack01:24
*** imcsk8_ has quit IRC01:25
*** ducttape_ has joined #puppet-openstack01:38
*** ilbot3 has quit IRC01:46
*** ilbot3 has joined #puppet-openstack01:48
*** ducttape_ has quit IRC02:20
*** bdemers has quit IRC02:39
*** bdemers has joined #puppet-openstack02:39
*** bdemers has quit IRC02:41
*** bdemers has joined #puppet-openstack02:44
*** aimon_ has quit IRC02:45
*** bdemers has quit IRC03:06
*** bdemers has joined #puppet-openstack03:07
*** bdemers has quit IRC03:22
*** bdemers has joined #puppet-openstack03:22
*** bdemers has quit IRC03:30
*** bdemers has joined #puppet-openstack03:30
*** logan2 has quit IRC03:35
*** gildub has joined #puppet-openstack05:10
*** hostranger has joined #puppet-openstack06:07
*** hostranger has left #puppet-openstack06:08
*** tfz has quit IRC06:25
*** tshtilma has joined #puppet-openstack07:06
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: support for keystone v3 api - v3 domain utility code  https://review.openstack.org/17838507:08
*** jtomasek has joined #puppet-openstack07:09
*** alex_bh has joined #puppet-openstack07:10
*** prad has quit IRC07:27
*** jpena has joined #puppet-openstack07:28
*** aimon has quit IRC07:28
*** tfz has joined #puppet-openstack07:28
*** dgurtner has joined #puppet-openstack07:32
*** dgurtner has quit IRC07:32
*** dgurtner has joined #puppet-openstack07:32
*** prad has joined #puppet-openstack07:42
*** gildub has quit IRC08:10
*** gfidente has joined #puppet-openstack08:59
*** rushiagr_away is now known as rushiagr09:34
*** paramite has joined #puppet-openstack09:45
openstackgerritvsaienko proposed openstack/puppet-horizon: Add cache_backend and cache_options params  https://review.openstack.org/19054809:52
*** saneax has joined #puppet-openstack09:53
*** dgurtner has quit IRC10:36
*** saneax has quit IRC11:11
*** dgurtner has joined #puppet-openstack11:12
*** rushiagr is now known as rushiagr_away11:15
*** arnaud_orange has joined #puppet-openstack11:22
*** rushiagr_away is now known as rushiagr11:27
*** morazi has quit IRC11:36
*** iurygregory has joined #puppet-openstack11:37
*** aarefiev has quit IRC11:38
*** ddmitriev has joined #puppet-openstack11:39
*** aarefiev has joined #puppet-openstack11:39
*** alex_bh2 has joined #puppet-openstack11:46
*** alex_bh has quit IRC11:47
*** saneax has joined #puppet-openstack11:47
*** arnaud_orange has quit IRC11:54
*** xarses has quit IRC12:03
*** degorenko has joined #puppet-openstack12:03
*** alex_bh2 has quit IRC12:07
*** alex_bh has joined #puppet-openstack12:08
*** alex_bh has left #puppet-openstack12:08
*** bdemers has quit IRC12:11
*** arnaud_orange has joined #puppet-openstack12:11
*** vinsh has quit IRC12:18
*** vinsh has joined #puppet-openstack12:18
*** jayg|g0n3 is now known as jayg12:19
*** vinsh has quit IRC12:22
*** prad has quit IRC12:30
*** jpena is now known as jpena|lunch12:30
*** aimon has joined #puppet-openstack12:32
*** saneax has quit IRC12:36
*** saneax has joined #puppet-openstack12:45
*** morazi has joined #puppet-openstack12:46
*** zerda has joined #puppet-openstack12:46
*** saneax has quit IRC12:46
*** saneax has joined #puppet-openstack12:50
*** xarses has joined #puppet-openstack12:53
*** petems has left #puppet-openstack12:54
*** zerda has quit IRC12:55
*** ducttape_ has joined #puppet-openstack13:06
*** paramite is now known as paramite|afk13:07
*** cdent has joined #puppet-openstack13:08
*** saneax has quit IRC13:09
*** rushiagr is now known as rushiagr_away13:14
*** saneax has joined #puppet-openstack13:14
*** ducttape_ has quit IRC13:18
*** gfidente is now known as gfidente|afk13:19
*** prad has joined #puppet-openstack13:23
*** vinsh has joined #puppet-openstack13:24
*** vinsh has quit IRC13:25
*** vinsh has joined #puppet-openstack13:25
*** vinsh has quit IRC13:29
*** ferest has joined #puppet-openstack13:29
*** bdemers has joined #puppet-openstack13:43
*** jpena|lunch is now known as jpena13:43
*** paramite|afk is now known as paramite13:46
socialwhat's the plan with modules and openstackclient?13:51
socialare we switching to it?13:51
*** zigo has joined #puppet-openstack14:03
*** rcallawa has joined #puppet-openstack14:04
*** stevemar has joined #puppet-openstack14:12
xarsessocial: I thought it already was14:21
xarsesafaik puppet-keystone is using it already14:22
*** openstackgerrit has quit IRC14:24
*** openstackgerrit has joined #puppet-openstack14:24
socialxarses: well puppet-cinder is not using it nor is neutron14:27
xarsesmaybe still in progress then14:28
xarsesI've been in a hole for a while14:28
*** kkirkpatrick has joined #puppet-openstack14:29
*** morazi has quit IRC14:34
*** morazi has joined #puppet-openstack14:35
jpenacrinkle, if you have a sec, can you check my latest comment on https://review.openstack.org/173327 ? I can make the rspec test work for Puppet 3.x or Puppet 4.x, but not for both. I'm not sure if there is a syntax that will  please both14:37
*** mdorman has joined #puppet-openstack14:46
*** xingchao has joined #puppet-openstack14:49
mwhahahajpena: you could cheat and in the rspec have different checks based on the version of puppet14:53
mwhahahahttp://paste.openstack.org/show/284205/ does something like that where it only does one type of check if puppet >= 3.514:54
jpenamwhahaha: it makes sense, I'll give that a try. Thanks!14:54
*** bdemers has quit IRC15:03
*** ducttape_ has joined #puppet-openstack15:06
*** gfidente|afk is now known as gfidente15:10
openstackgerritJavier Peña proposed openstack/puppet-horizon: Add support for WEBROOT in local_settings  https://review.openstack.org/17332715:13
*** xingchao has quit IRC15:29
*** xingchao has joined #puppet-openstack15:33
*** nosleep77 has joined #puppet-openstack15:37
*** xingchao has quit IRC15:37
*** xarses_ has joined #puppet-openstack15:40
*** xarses_ has quit IRC15:41
*** xarses_ has joined #puppet-openstack15:41
*** xarses has quit IRC15:44
*** tshtilma has quit IRC15:48
*** paramite is now known as paramite|afk15:51
degorenkoHi guys! I have some question: why puppet-sahara doesn't have any tags? Who is responsible for this module?15:52
*** morazi has quit IRC15:52
*** morazi has joined #puppet-openstack15:56
*** saneax has quit IRC16:01
*** tfz has quit IRC16:02
*** saneax has joined #puppet-openstack16:03
*** xarses_ has quit IRC16:09
*** xarses has joined #puppet-openstack16:09
*** xarses has quit IRC16:10
*** xarses has joined #puppet-openstack16:10
*** xarses has quit IRC16:11
*** xarses has joined #puppet-openstack16:12
*** hogepodge has quit IRC16:13
openstackgerritRajini Ram proposed openstack/puppet-cinder: Added support for DellStorageCenter ISCSI cinder driver  https://review.openstack.org/18937216:17
*** dgurtner has quit IRC16:19
*** hogepodge has joined #puppet-openstack16:20
*** xarses has quit IRC16:27
*** xarses has joined #puppet-openstack16:27
*** xarses has quit IRC16:28
*** xarses has joined #puppet-openstack16:28
*** aimon has quit IRC16:32
*** imcsk8 is now known as imcsk8|afk16:33
*** dprince has joined #puppet-openstack16:34
*** jpena has quit IRC16:45
*** ferest has quit IRC16:47
*** richm has joined #puppet-openstack16:57
openstackgerritJonathan Proulx proposed openstack/puppet-keystone: Pull in upstream stable/kilo wsgi script  https://review.openstack.org/19188616:57
*** rcallawa_ has joined #puppet-openstack16:59
*** rcallawa has quit IRC17:02
richmhello17:02
richmIs there an official code formatting for puppet openstack projects ruby code?17:03
richme.g. use 2 spaces for indent17:03
*** xarses_ has joined #puppet-openstack17:07
*** xarses has quit IRC17:10
*** aimon has joined #puppet-openstack17:18
mgagnerichm: better look at other code and see if there is any convention17:29
mgagnerichm: but I think we should adopt rubocop so we can settle on one style once and for all17:29
mgagneI explored the idea a couple of months ago but there is a long of work to make it happen in term of style standardization17:30
richmmgagne: everywhere I can see, we use 2 spaces17:31
mgagneI guess it's a same bet to say our convention is 2 spaces17:31
richmbut a recent review used tabs, which got me to thinking17:31
mgagnetabs are usually avoid17:32
richmhttps://review.openstack.org/#/c/178385/12/lib/puppet/provider/keystone/util.rb17:32
mgagneyea, better convert them to spaces17:33
mgagneI don't watch changes that often anymore but it would be something I would ask to change17:33
*** RichardRaseley has joined #puppet-openstack17:39
openstackgerritDenis Egorenko proposed openstack/puppet-sahara: Enable tests for oslo_messaging_rabbit/rabit_host parameter  https://review.openstack.org/19191317:42
openstackgerritDenis Egorenko proposed openstack/puppet-sahara: Enable tests for oslo_messaging_rabbit/rabbit_hosts parameter  https://review.openstack.org/19191317:44
*** saneax has quit IRC17:48
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - v3 domain utility code  https://review.openstack.org/17838517:51
*** imcsk8|afk is now known as imcsk817:51
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the domain resource  https://review.openstack.org/17443917:54
*** xarses_ has quit IRC17:56
*** xarses_ has joined #puppet-openstack17:56
*** xarses_ is now known as xarses17:56
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the project resource  https://review.openstack.org/17446817:56
*** xarses has quit IRC17:56
*** xarses has joined #puppet-openstack17:57
RichardRaseleyCan someone in the 'puppet-openstack' Launchpad group kick the maintainership of 'puppet-zaqar' back to me until I finish setting it up? I seem to have locked myself out.17:57
*** tfz has joined #puppet-openstack17:57
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the user resource  https://review.openstack.org/17497618:02
*** rcallawa_ has quit IRC18:07
*** rcallawa has joined #puppet-openstack18:08
*** rcallawa has quit IRC18:08
*** stevemar2 has joined #puppet-openstack18:09
*** stevemar has quit IRC18:09
*** rcallawa has joined #puppet-openstack18:09
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the user_role resource  https://review.openstack.org/17499918:19
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - keystone and keystone::roles::admin  https://review.openstack.org/17506018:21
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - add domains to service_identity  https://review.openstack.org/18058618:22
openstackgerritRichard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - beaker tests  https://review.openstack.org/17882818:23
*** xarses_ has joined #puppet-openstack18:25
*** xarses has quit IRC18:29
*** xarses_ is now known as xarses18:32
RichardRaseleycrinkle: With regard to the new Zaqar module, what would be the appropriate set of tests to populate first, following the model in openstack-infra/project-config/jenkins/jobs/projects.yaml ? All Puppet modules appear the same save for their inclusion of 'puppet-beaker-jobs' ...18:42
*** nosleep77 has left #puppet-openstack18:43
*** cdent has quit IRC18:49
*** stevemar2 is now known as stevemar18:51
dmsimardIs there a quick howto to convert existing reviews to the new repos/review config ?18:58
dmsimardCan't seem to figure it out ..18:58
crinkleRichardRaseley: they should all have beaker jobs19:00
openstackgerritDavid Moreau Simard proposed openstack/puppet-keystone: Synchronize Keystone WSGI script with upstream  https://review.openstack.org/19121219:01
dmsimardAh nevermind, think I figured it out19:01
openstackgerritDavid Moreau Simard proposed openstack/puppet-keystone: Synchronize Keystone WSGI script with upstream  https://review.openstack.org/19121219:02
RichardRaseleycrinkle: OK. For example, puppet-monasca does not.19:11
*** xarses has quit IRC19:11
RichardRaseleyand puppet-gnocchi - but I didn't know if that was because they19:12
RichardRaseleywas by design*19:12
*** xarses has joined #puppet-openstack19:12
*** dprince has quit IRC19:39
*** gfidente has quit IRC19:58
openstackgerritRajini Ram proposed openstack/puppet-cinder: Added support for DellStorageCenter ISCSI cinder driver  https://review.openstack.org/18937219:59
openstackgerritRajini Ram proposed openstack/puppet-cinder: Added support for DellStorageCenter ISCSI cinder driver  https://review.openstack.org/18937219:59
*** cwolferh has quit IRC20:00
*** cwolferh has joined #puppet-openstack20:02
*** rcallawa has quit IRC20:04
*** jayg is now known as jayg|g0n320:06
*** paramite|afk is now known as paramite20:16
*** paramite has quit IRC20:18
*** cwolferh has quit IRC20:19
*** dgurtner has joined #puppet-openstack20:21
*** dgurtner has quit IRC20:21
*** dgurtner has joined #puppet-openstack20:21
*** krotscheck has joined #puppet-openstack20:52
mgagneRichardRaseley: do you know if there is a better construct than the one proposed here? https://review.openstack.org/#/c/184646/20/manifests/server/notifications.pp20:58
mgagneRichardRaseley: to check for empty stirng20:58
mgagnestring*20:58
mgagne-> ! ($nova_admin_password and $nova_admin_password != '') this is difficult to read and uses double negation20:59
openstackgerritColleen Murphy proposed openstack/puppet-keystone: Use zuul-cloner and clone map to clone dependencies  https://review.openstack.org/19083920:59
*** stevemar2 has joined #puppet-openstack21:03
*** stevemar has quit IRC21:04
mwhahahamgagne: if !pick($nova_admin_password, false)21:10
mwhahahaas pick will use the second value if the first is undef or an empty string21:10
*** iurygregory has quit IRC21:11
mgagne_ody: ^ ?21:11
mwhahahanot sure if better, but it might work :D21:12
*** morazi has quit IRC21:14
mwhahahayup works21:15
_odymgagne: I've been doing the annoying double negation thing.21:16
mgagne_ody: sure, I'm looking for a way to improve it21:16
_odymwhahaha's would work for things that aren't going to be set to "false" (as a string) at some point.21:16
mwhahahait only breaks down for false21:17
_odyWhich is what I've been dealing with lately with getting Puppet 3.x code to pass on Puppet 4.x.21:18
mwhahaha:(21:18
mwhahahadoes validate_string work for those?21:19
_odyFor things that might be set to false, I tried str2bool but the new Puppet 4.x function API gets angry if you feed a bool into the fuction.21:19
*** rcallawa has joined #puppet-openstack21:24
*** rcallawa has quit IRC21:24
openstackgerritColleen Murphy proposed openstack/puppet-keystone: Use zuul-cloner and clone map to clone dependencies  https://review.openstack.org/19083921:25
*** rcallawa has joined #puppet-openstack21:25
_odymgagne: ah, you are actually looking through my puppet-neutron patch set...hmm. Tomorrow is my Puppet OpenStack day...going to try and not get lost in it right now.21:31
mgagnealright21:31
_odymgagne: Did a quick look anyway.  Might just be a consequence of the test for which we can easily fix.  The line here is probably a bad way to test the case where no admin password is provided, https://github.com/ody/puppet-neutron/blob/make_tests_pass_on_4/spec/classes/neutron_server_notifications_spec.rb#L96.21:35
mgagne_ody: cool, as long as we make the manifest more readable, I'm fine21:36
RichardRaseleymgagne: Sorry for the delay. Does validate_string work for checking on an empty or undef?21:37
RichardRaseleyI would defer to _ody on that one though.21:37
*** tfz has quit IRC21:38
_odyYean.  I'll hack on it more tomorrow...21:39
RichardRaseleymgagne: Ah, looks like that would cause a compilation failure.21:39
RichardRaseleyOK21:39
*** iurygregory has joined #puppet-openstack21:39
*** stevemar2 is now known as stevemar21:43
RichardRaseleymgagne: if $nova_admin_password and $nova_admin_password != '' <- Seems like a sane test, no?21:51
mgagnethe double negation makes it hard to understand21:51
mgagneif ! ($nova_admin_password and $nova_admin_password != '') {}21:52
*** dgurtner has quit IRC21:54
RichardRaseleyMy test isn't double negated, right?21:54
RichardRaseleyif the variable exists (not undef) and is not equal to an empty string, then use the provided value.21:54
RichardRaseleyif $password and $password != "" { notice("password is set") } else { notice("password is not set") }21:54
RichardRaseleymgagne: ^21:55
mgagneMy question was related to line #79 and #83, not #98 https://review.openstack.org/#/c/184646/20/manifests/server/notifications.pp21:55
*** tfz has joined #puppet-openstack21:55
RichardRaseleymgagne: Yes...21:57
mgagneI think we could benefit from a function here21:57
mgagnebut it's not a show stopper unless this construct ends up in all our modules21:58
RichardRaseleymgagne: What about something like this https://gist.github.com/richardraseley/faac6243d314fe17d15922:01
mgagnereally? =)22:01
RichardRaseleymgagne: Or an unless? https://gist.github.com/richardraseley/29b269111df4042f5ea322:02
RichardRaseleyYeah, why not?22:02
mgagneyea, I was looking at unless and when it got introduced22:03
mgagnebtw, why not undef? why false?22:03
mgagneanything special with undef?22:03
*** RichardR_ has joined #puppet-openstack22:03
RichardR_sorry, disconnected22:04
RichardR_mgagne: ^22:04
mgagneyea, I was looking at unless and when it got introduced22:04
mgagne6:0322:04
mgagnebtw, why not undef? why false?22:04
mgagne6:0322:04
mgagneanything special with undef?22:04
RichardR_mgagne: Not sure, that is just the way that I am used to testing for undef.22:04
RichardR_I don't know a good reason to not call it out specifically though.22:05
RichardR_I think unless looks pretty clean.22:05
mgagneyes22:05
mgagnebut I still don't understand why we can't have a helper here22:05
mgagneit used to be short and clear, now it's twice as long and less clear22:06
RichardR_What is the reason for creating a helper? I assume you mean a function.22:06
mgagneyes functio22:06
RichardR_(Always keep in mind that you're speaking to a non-developer when you talk to me.) =]22:06
*** RichardRaseley has quit IRC22:07
RichardR_I generally prefer to have a little bit longer native language construct. Might just be personal preference.22:07
mgagneRichardR_: just for the sake of readability22:07
RichardR_mgagne: Gotta run to a meeting, interesting conversation I'd like to hear other input.22:08
RichardR_TTYL!22:08
mgagnesure22:08
*** RichardR_ has quit IRC22:08
*** djm68 has joined #puppet-openstack22:13
mdormanis there someplace that defines what version of openstack client is require for the different keystone providers (in master)?  or do i just assume ‘kilo'?22:16
crinklemdorman: the version available for kilo in both ubuntu and rhel should be sufficient, i believe it's >=1.0.322:18
mdormancool thanks22:20
*** stevemar has quit IRC22:21
*** djm68 has quit IRC22:23
openstackgerritColleen Murphy proposed openstack/puppet-keystone: Use zuul-cloner and clone map to clone dependencies  https://review.openstack.org/19083922:26
*** djm68 has joined #puppet-openstack22:33
*** saneax has joined #puppet-openstack22:45
*** hogepodge has quit IRC22:52
*** djm68 has quit IRC22:54
*** ducttape_ has quit IRC22:58
openstackgerritMathieu Gagné proposed openstack/puppet-nova: Introduce public_url, internal_url and admin_url (and v3/ec2)  https://review.openstack.org/7045823:04
*** ducttape_ has joined #puppet-openstack23:07
openstackgerritMike Dorman proposed openstack/puppet-nova: Declare package with $package_name, not $nova_title  https://review.openstack.org/19200923:08
*** kkirkpatrick has quit IRC23:13
*** hogepodge has joined #puppet-openstack23:19
*** ducttape_ has quit IRC23:20
*** djm68 has joined #puppet-openstack23:23
*** EmilienM|afk is now known as EmilienM23:24
*** aimon has quit IRC23:27
*** djm68 has quit IRC23:27
*** jtomasek has quit IRC23:34
*** mdorman has quit IRC23:36
openstackgerritMerged openstack/puppet-tempest: spec: pin rspec-puppet to 1.0.1  https://review.openstack.org/19147023:37
openstackgerritMerged openstack/puppet-designate: Change spec tests to use puppetlabs/concat  https://review.openstack.org/19146823:38
openstackgerritMerged openstack/puppet-sahara: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133823:42
openstackgerritMerged openstack/puppet-cinder: Update spec_helper_acceptance for project renames  https://review.openstack.org/19132723:42
openstackgerritMerged openstack/puppet-openstacklib: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133723:43
openstackgerritMerged openstack/puppet-trove: Update spec_helper_acceptance for project renames  https://review.openstack.org/19134023:43
openstackgerritMerged openstack/puppet-swift: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133923:45
openstackgerritMerged openstack/puppet-vswitch: Update spec_helper_acceptance for project renames  https://review.openstack.org/19134123:46
openstackgerritMerged openstack/puppet-manila: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133423:47
openstackgerritMerged openstack/puppet-glance: Update spec_helper_acceptance for project renames  https://review.openstack.org/19132923:47
openstackgerritMerged openstack/puppet-heat: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133023:47
openstackgerritMerged openstack/puppet-ironic: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133223:48
openstackgerritMerged openstack/puppet-horizon: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133123:48
openstackgerritMerged openstack/puppet-keystone: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133323:49
openstackgerritMerged openstack/puppet-nova: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133623:49
openstackgerritMerged openstack/puppet-neutron: Update spec_helper_acceptance for project renames  https://review.openstack.org/19133523:51
openstackgerritMerged openstack/puppet-tempest: Update .gitreview file for project rename  https://review.openstack.org/19146023:54
*** aimon has joined #puppet-openstack23:55
*** aimon_ has joined #puppet-openstack23:57
*** djm68 has joined #puppet-openstack23:59
« Sunday, 2015-06-14 Index Tuesday, 2015-06-16 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!