| *** s3wong has quit IRC | 00:19 | |
| *** deadalnix has quit IRC | 01:35 | |
| *** ohama has quit IRC | 01:49 | |
| *** ohama has joined #openvswitch | 01:50 | |
| *** rcernin has joined #openvswitch | 01:53 | |
| *** ihrachys has quit IRC | 02:45 | |
| *** rcernin has quit IRC | 03:06 | |
| *** acidfoo has quit IRC | 03:24 | |
| *** rcernin has joined #openvswitch | 03:24 | |
| *** rcernin has quit IRC | 03:26 | |
| *** rcernin has joined #openvswitch | 03:27 | |
| *** tbachman has quit IRC | 03:29 | |
| *** tbachman has joined #openvswitch | 03:30 | |
| *** anilvenkata has joined #openvswitch | 04:49 | |
| *** thaller has quit IRC | 06:19 | |
| *** thaller has joined #openvswitch | 06:20 | |
| *** links has joined #openvswitch | 06:27 | |
| *** jaicaa has quit IRC | 06:29 | |
| *** jaicaa has joined #openvswitch | 06:31 | |
| *** ohama has quit IRC | 06:32 | |
| *** ohama has joined #openvswitch | 06:33 | |
| *** eelco has joined #openvswitch | 06:55 | |
| *** dholler has joined #openvswitch | 06:58 | |
| *** rcernin has quit IRC | 07:00 | |
| *** rcernin has joined #openvswitch | 07:14 | |
| *** slaweq has joined #openvswitch | 07:17 | |
| *** ktraynor has quit IRC | 07:27 | |
| *** rcernin has quit IRC | 07:30 | |
| *** ralonsoh has joined #openvswitch | 07:37 | |
| *** rcernin has joined #openvswitch | 07:55 | |
| *** rcernin has quit IRC | 08:00 | |
| *** rcernin has joined #openvswitch | 08:12 | |
| *** mdgray has joined #openvswitch | 08:15 | |
| *** rcernin has quit IRC | 08:17 | |
| *** flaviof_ has joined #openvswitch | 08:29 | |
| *** edwarnicke_ has joined #openvswitch | 08:29 | |
| *** weiti_ has joined #openvswitch | 08:30 | |
| *** jbenet_ has joined #openvswitch | 08:30 | |
| *** bern- has joined #openvswitch | 08:31 | |
| *** BlackDex_ has joined #openvswitch | 08:33 | |
| *** mnasiadka_ has joined #openvswitch | 08:33 | |
| *** markmcclain has joined #openvswitch | 08:34 | |
| *** elvira has joined #openvswitch | 08:41 | |
| *** mnasiadka has quit IRC | 08:43 | |
| *** markmcclain1 has quit IRC | 08:43 | |
| *** BlackDex has quit IRC | 08:43 | |
| *** weiti has quit IRC | 08:43 | |
| *** bern has quit IRC | 08:43 | |
| *** flaviof has quit IRC | 08:43 | |
| *** jbenet has quit IRC | 08:43 | |
| *** edwarnicke has quit IRC | 08:43 | |
| *** mnasiadka_ is now known as mnasiadka | 08:43 | |
| *** flaviof_ is now known as flaviof | 08:43 | |
| *** edwarnicke_ is now known as edwarnicke | 08:43 | |
| *** jbenet_ is now known as jbenet | 08:43 | |
| *** markmcclain has quit IRC | 08:45 | |
| *** markmcclain has joined #openvswitch | 08:48 | |
| *** rcernin has joined #openvswitch | 09:13 | |
| *** rcernin has quit IRC | 09:17 | |
| *** ktraynor has joined #openvswitch | 09:18 | |
| *** deadalnix has joined #openvswitch | 09:26 | |
| *** istokes has joined #openvswitch | 09:50 | |
| *** istokes has quit IRC | 09:51 | |
| *** istokes has joined #openvswitch | 09:54 | |
| *** tredaelli has joined #openvswitch | 10:14 | |
| *** tredaelli is now known as timothy | 10:14 | |
| *** timothy has quit IRC | 10:19 | |
| *** jangutter has joined #openvswitch | 10:41 | |
| *** jangutter has quit IRC | 10:43 | |
| *** jangutter has joined #openvswitch | 10:43 | |
| *** jangutter_ has quit IRC | 10:44 | |
| *** rcernin has joined #openvswitch | 11:08 | |
| *** rcernin has quit IRC | 11:13 | |
| *** jangutter_ has joined #openvswitch | 11:42 | |
| *** jangutter has quit IRC | 11:45 | |
| *** acidfoo has joined #openvswitch | 12:17 | |
| *** rcernin has joined #openvswitch | 12:24 | |
| *** rcernin has quit IRC | 12:29 | |
| *** rcernin has joined #openvswitch | 12:48 | |
| *** rcernin has quit IRC | 12:53 | |
| *** bostondriver has joined #openvswitch | 13:25 | |
| *** jangutter has joined #openvswitch | 13:34 | |
| *** jangutter_ has quit IRC | 13:37 | |
| *** jangutter has quit IRC | 13:43 | |
| *** jangutter_ has joined #openvswitch | 13:44 | |
| *** aconole has joined #openvswitch | 14:01 | |
| *** jangutter has joined #openvswitch | 14:16 | |
| *** zhouhan has joined #openvswitch | 14:20 | |
| *** thaller has quit IRC | 14:20 | |
| *** thaller has joined #openvswitch | 14:20 | |
| *** jangutter_ has quit IRC | 14:20 | |
| *** bern- is now known as bern | 14:29 | |
| *** rcernin has joined #openvswitch | 14:49 | |
| *** rcernin has quit IRC | 14:54 | |
| *** dqx has quit IRC | 15:10 | |
| *** dqx has joined #openvswitch | 15:30 | |
| *** dqx has quit IRC | 15:35 | |
| *** dqx has joined #openvswitch | 15:38 | |
| *** dmellado has quit IRC | 15:45 | |
| *** dmellado has joined #openvswitch | 15:46 | |
| *** teardown has quit IRC | 16:32 | |
| *** links has quit IRC | 16:33 | |
| *** thaller has quit IRC | 16:35 | |
| *** thaller has joined #openvswitch | 16:35 | |
| *** teardown has joined #openvswitch | 16:38 | |
| *** rcernin has joined #openvswitch | 16:50 | |
| *** zhouhan has quit IRC | 16:50 | |
| *** rcernin has quit IRC | 16:55 | |
| *** istokes has quit IRC | 17:00 | |
| *** dcbw has joined #openvswitch | 17:03 | |
| *** eelco has quit IRC | 17:04 | |
| *** matteo has quit IRC | 17:07 | |
| *** dceara has joined #openvswitch | 17:14 | |
| *** jangutter_ has joined #openvswitch | 17:26 | |
| *** jangutter has quit IRC | 17:29 | |
| *** dholler has quit IRC | 17:31 | |
| *** slaweq has quit IRC | 17:49 | |
| *** slaweq has joined #openvswitch | 17:51 | |
| *** ralonsoh has quit IRC | 18:09 | |
| *** blp has joined #openvswitch | 18:09 | |
| *** karthikc has joined #openvswitch | 18:11 | |
| *** dhathri has joined #openvswitch | 18:12 | |
| blp | Hello everyone! | 18:14 |
|---|---|---|
| *** mmichelson_ is now known as mmichelson | 18:14 | |
| mmichelson | Hi! | 18:14 |
| mmichelson | I'm going to get this thing started | 18:14 |
| mmichelson | #startmeeting ovn_community_development_meeting | 18:14 |
| openstack | Meeting started Thu Mar 4 18:14:55 2021 UTC and is due to finish in 60 minutes. The chair is mmichelson. Information about MeetBot at http://wiki.debian.org/MeetBot. | 18:14 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 18:14 |
| _lore_ | hi all | 18:14 |
| openstack | The meeting name has been set to 'ovn_community_development_meeting' | 18:14 |
| numans | Hello | 18:15 |
| mmichelson | As a reminder, tomorrow is the expected release date of OVN 21.03 | 18:15 |
| mmichelson | Are there any urgent last minute bug fixes that need to be made before we can release? | 18:15 |
| mmichelson | If so, then please post them in here at some point during the meeting | 18:16 |
| numans | Yes. I have a 2 patch series - https://patchwork.ozlabs.org/project/ovn/list/?series=231930 | 18:16 |
| mmichelson | Most all of my work recently has been trying to fix an oddball network setup that OpenStack expects to work but that does not in OVN currently | 18:16 |
| numans | in which the 2nd one applies to branch-21.03 | 18:16 |
| numans | sorry go ahead | 18:17 |
| mmichelson | numans, it's fine, I'm done. | 18:17 |
| imaximets | mmichelson, we need to shift OVS submodule, I guess. DO we have submodule on branch-21.03? | 18:17 |
| mmichelson | imaximets, yes, we should. We can update it if needed. | 18:17 |
| numans | mmichelson, for sure we need to update for master | 18:17 |
| numans | otherwise north-ddlog compilation fails. | 18:18 |
| mmichelson | got it | 18:18 |
| *** zhouhan has joined #openvswitch | 18:18 | |
| mmichelson | If we can determine which specific OVS commit to update the submodule to, then I can put that change in. | 18:18 |
| imaximets | mmichelson, there is a ovsdb-cs fix that we need. So, at least: ac09cbfcb70ac6f443f039d5934448bd80f74493 | 18:19 |
| mmichelson | imaximets, ok | 18:19 |
| numans | Also blp sent an email for this - https://mail.openvswitch.org/pipermail/ovs-dev/2021-February/380834.html | 18:19 |
| blp | I wasn't quite sure what to do to update the submodule. Do I just do a commit for it and then send an email as usual? | 18:20 |
| blp | I have not worked with submodules much. | 18:21 |
| mmichelson | blp, this is new territory for us as a project. My thought was that we'd submit it as a patch just like anything else. | 18:21 |
| imaximets | mmichelson, dceara also has idl fixes on a list, but I had no enough time to review them yet. Pretty important, so we will have to move submodule one more time once they got in. | 18:22 |
| mmichelson | imaximets, OK. Should this delay the release? | 18:23 |
| numans | I'd say better to delay so that release ovn tag points to the required ovs commit | 18:24 |
| imaximets | blp, mmichelson: for submodule updates... Submodule updates are just simple patches, so the process should not be different. | 18:24 |
| imaximets | mmichelson, numans: idl fixes are important, but I don't know how much time it will take for me to review them. It's a tracking code and it's not easy. | 18:25 |
| numans | I'm planning to test them out tomorrow and hopefully review the code too. I don't know much of the tracking code. | 18:26 |
| numans | may be zhouhan or blp can take a look ? | 18:26 |
| numans | its blocking a customer deployment too. | 18:26 |
| imaximets | If someone could help, that will be great. | 18:26 |
| numans | This is the patchset - https://patchwork.ozlabs.org/project/openvswitch/list/?series=231872 | 18:26 |
| blp | Oh, yuck, this is the hardest part of the idl code. | 18:27 |
| blp | Maintaining the graph structure is not fun. | 18:27 |
| zhouhan | numans: ok. I will take a look. It looks to be a bug of my initial patch | 18:28 |
| dceara | Sorry for joining late, thanks numans and imaximets for bringing up the IDL issue. Yes, I'd be very grateful for reviews because it's quite complex what's going on there. | 18:28 |
| numans | Also we have deployed this fix on our one of the internal deployment where the issue is seen and we haven't heard of any ovn-controller crashes after that. | 18:28 |
| numans | So seems like its working :) | 18:28 |
| blp | I do like that it has a thorough commit message. | 18:28 |
| zhouhan | Does DDlog ovsdb wrapper use this part of code? | 18:29 |
| blp | No, DDlog doesn't use anything in ovsdb-idl.* | 18:29 |
| zhouhan | blp: ok, good to know. So it must have its own way to find the old/new data even for a deleted row, right? | 18:30 |
| blp | Yes. | 18:30 |
| blp | DDlog is very strong at dealing with changes, and with graph algorithms. | 18:30 |
| blp | Algorithms like graph connectivity are basically one-liners. | 18:31 |
| *** mdgray has quit IRC | 18:31 | |
| imaximets | blp, we need ovn-controller-ddlog ASAP. :D | 18:32 |
| imaximets | jk | 18:32 |
| * zhouhan need to get some time to experience the power of DDlog | 18:32 | |
| * numans started getting some nice feelers about ddlog. long way to go though. | 18:32 | |
| numans | I mean to learn it :) | 18:33 |
| mmichelson | Yeah I need to take another week to really get my DDLog sea legs | 18:33 |
| numans | Ok. Can I go real quick If no one is updating ? | 18:33 |
| mmichelson | go for it numans | 18:34 |
| *** slaweq has quit IRC | 18:34 | |
| numans | I tested blp's new ddlog improvement patches and provided my Acks. Also reported a couple of issues. | 18:34 |
| blp | I see a remarkable number of races in our tests. | 18:35 |
| numans | I submitted a 2 patch series to address some issues for the feature on supporting lb_force_snat_ip router ip option. The first patch is a ddlog patch. | 18:35 |
| numans | zhouhan, If you could take a look at my replies for the ct.inv patch and provide your comments. That would be great. | 18:35 |
| numans | That's it from me. | 18:36 |
| zhouhan | numans: ok, checking now | 18:36 |
| mmichelson | numans, I had a look at those patches, but my lack of ddlog certainty has made it difficult for me to ACK them with confidence | 18:36 |
| mmichelson | (I understand the C part of patch 2 just fine though :) ) | 18:36 |
| numans | mmichelson, you could ack for the C part :). | 18:36 |
| mmichelson | numans, yeah I guess that's true | 18:37 |
| numans | blp, I also noticed some memory leaks with northd-ddlog. | 18:37 |
| blp | numans: I'll take a look at the ddlog code in your patch "northd: Fix the missing force_snat_for_lb flows when router_ip is..." | 18:37 |
| blp | numans: Memory leaks are usually an easy fix. I'll take care of them. | 18:37 |
| numans | blp, thanks. I think there can be a better way to do the ddlog changes I did. | 18:38 |
| numans | cool. | 18:38 |
| numans | If someone wants to go next. | 18:39 |
| imaximets | Very small update from my side. | 18:39 |
| blp | numans: Your patch introduces a new ddlog function force_snat_for_lb(), but I don't think it calls it anywhere. | 18:40 |
| imaximets | I pushed raft fixes and ovsdb-cs fix to OVS master and backported as necessary. Will review idl patches from dceara once will find enough time. That's it. | 18:40 |
| numans | blp, I think I'm making use of it in northd.dl. May be I forgot to check in the code. I'll double check the patch now. | 18:40 |
| blp | numans: Oh, gosh, I didn't see that change because there was C code in the middle. Sorry. | 18:41 |
| numans | no worries. I was wondering if I checked in the code. I normally do that mistake. | 18:41 |
| zhouhan | numans: getting rid of ct.inv seems to be a big behavior change (although maybe small in the code). Did we get enough feedback from users (e.g. customers of RedHat?). I am really curious how people rely on (or disregard) it. | 18:42 |
| numans | zhouhan, From what I understand, with ovs datapath being liberal on tcp window validation we will never hit the ct.inv scenario. | 18:43 |
| numans | zhouhan, I understand your concern. I'll work on v2 and make it's usage enabled by default. | 18:44 |
| numans | and add a config option. | 18:44 |
| zhouhan | numans: how about checksum errors, or receiving a packet without TCP connection established? | 18:44 |
| *** dhathri has quit IRC | 18:45 | |
| numans | zhouhan, when you send a pkt to conntrack it will mark it as new if its not yet established. | 18:45 |
| numans | I need to check on the checksum errors. | 18:45 |
| *** dhathri has joined #openvswitch | 18:45 | |
| zhouhan | numans: sorry that I don't have fresh memory about LB usage of CT. Does it rely on ct.inv, too? (in response to why users won't just use stateless ACLs if they don't care ct.inv) | 18:46 |
| numans | zhouhan, right now we send all the pkts to conntrack if a logical switch has lb associated. | 18:47 |
| numans | and hence we can't have stateless ACLs. | 18:47 |
| zhouhan | numans: hmm, got it | 18:47 |
| zhouhan | numans: thx for explaining. I will response in the email. (worse case the configurable option should work, I think) | 18:48 |
| numans | zhouhan, thanks. | 18:48 |
| numans | zhouhan, if you could also take a look at the other physical/logical flow engine patch that would be great. | 18:49 |
| numans | I need to rebase though. | 18:49 |
| zhouhan | numans: yes, really sorry that. I started the review but somehow got distracted. It is hanging in my head :) | 18:50 |
| numans | no worries. | 18:50 |
| zhouhan | numans: no worries about rebase. I can review based on a earlier commit. | 18:50 |
| numans | there is another RFC patch I submitted - if you could take a real quick when you get time - https://patchwork.ozlabs.org/project/ovn/patch/20210225191950.3494656-1-numans@ovn.org/ | 18:50 |
| numans | thanks. | 18:50 |
| numans | this RFC patch is not urgent. | 18:50 |
| *** rcernin has joined #openvswitch | 18:50 | |
| zhouhan | numans: sure. It is somehow related | 18:51 |
| * zhouhan sorry for hijacking the meeting. If someone is updating please continue | 18:52 | |
| mmichelson | Uh, I think we were on imaximets but I think he was done | 18:52 |
| imaximets | mmichelson, yep. | 18:52 |
| mmichelson | So whoever wants to go next, feelf ree | 18:52 |
| mmichelson | s/feelf ree/feel free/ | 18:52 |
| mmichelson | And if nobody else wishes to report, then I will declare this meeting over. | 18:53 |
| mmichelson | Based on the need to update the OVS submodule, and based on needing an unmerged fix, I think we should probably delay the release of 21.03 until we get that fix included. | 18:54 |
| numans | +1 | 18:54 |
| mmichelson | In the meantime, I'll take a look at the OVN patches that numans linked and see if we can get those merged too. | 18:54 |
| _lore_ | can I go next? | 18:54 |
| numans | thanks. | 18:54 |
| mmichelson | oh sure thing _lore_ | 18:54 |
| _lore_ | last week I mainly worked adding counters for ovn incremental processing | 18:55 |
| *** ktraynor has quit IRC | 18:55 | |
| _lore_ | posted v6 upstream | 18:55 |
| _lore_ | acked by Mark (Gray) | 18:55 |
| _lore_ | then I posted a refactor of nat code in ovn-northd, no behaviour changes, just code movement :) | 18:56 |
| *** rcernin has quit IRC | 18:56 | |
| _lore_ | thx | 18:56 |
| blp | I've got to go... talk to you guys next week | 18:57 |
| *** blp has quit IRC | 18:57 | |
| mmichelson | _lore_, I'm interested in that refactor. I need to reserve some time to review it :) | 18:57 |
| mmichelson | Anybody else? | 18:57 |
| mmichelson | OK, thanks everyone! | 18:59 |
| _lore_ | mmichelson: ack, go for it :) | 18:59 |
| mmichelson | Bye! | 18:59 |
| mmichelson | #endmeeting | 18:59 |
| openstack | Meeting ended Thu Mar 4 18:59:13 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/ovn_community_development_meeting/2021/ovn_community_development_meeting.2021-03-04-18.14.html | 18:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ovn_community_development_meeting/2021/ovn_community_development_meeting.2021-03-04-18.14.txt | 18:59 |
| *** karthikc has left #openvswitch | 18:59 | |
| openstack | Log: http://eavesdrop.openstack.org/meetings/ovn_community_development_meeting/2021/ovn_community_development_meeting.2021-03-04-18.14.log.html | 18:59 |
| _lore_ | bye all | 18:59 |
| numans | Bye | 18:59 |
| imaximets | bye | 18:59 |
| dceara | bye | 18:59 |
| *** dceara has quit IRC | 18:59 | |
| zhouhan | bye | 19:00 |
| *** rcernin has joined #openvswitch | 19:12 | |
| *** rcernin has quit IRC | 19:17 | |
| fnordahl | mmichelson: aparently I missed the meeting, but would like to mention that I'm working on a handful of missing RBAC rule bugs along with test suite changes to enable SSL+RBAC for ovn-controller by default in our tests so that we can catch them in the gate moving forward, will most likely post the series tomorrow, hope that is not too late for 21.03. | 19:22 |
| mmichelson | fnordahl, OK. The release is delayed due to the IDL fixes needed in OVS. If we can get your fixes in as well, then sure, they'd be fine for 21.03. However, if there are findings in your changeset and we get the OVS IDL changes in before we can get your changes in, then I don't think they're severe enough to delay the 21.03 release any further. | 19:42 |
| fnordahl | mmichelson: sounds good to me, ta | 19:56 |
| *** rcernin has joined #openvswitch | 20:00 | |
| *** elvira has quit IRC | 20:02 | |
| *** slaweq has joined #openvswitch | 20:29 | |
| *** warewolf_ is now known as warewolf | 20:42 | |
| *** rcernin has quit IRC | 20:43 | |
| *** imaximets_ has joined #openvswitch | 20:50 | |
| *** imaximets has quit IRC | 20:52 | |
| *** rcernin has joined #openvswitch | 21:09 | |
| *** fbl has quit IRC | 21:10 | |
| *** rcernin has quit IRC | 21:49 | |
| *** slaweq has quit IRC | 22:27 | |
| *** rcernin has joined #openvswitch | 22:29 | |
| *** dcbw has quit IRC | 22:53 | |
| *** rcernin has quit IRC | 22:54 | |
| *** rcernin has joined #openvswitch | 22:54 | |
| *** bostondriver has quit IRC | 22:56 | |
| *** dqx has quit IRC | 23:06 | |
| *** dqx has joined #openvswitch | 23:12 | |
| *** acidfoo has quit IRC | 23:25 | |
| *** zhouhan has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!