Thursday, 2020-12-17

*** JamesBenson has quit IRC00:08
*** armax has quit IRC00:21
*** matteo is now known as matteo|00:36
*** JamesBenson has joined #openvswitch00:43
*** JamesBenson has quit IRC00:49
*** tbachman has quit IRC00:52
*** tbachman has joined #openvswitch00:53
*** JamesBenson has joined #openvswitch01:21
*** thaller has quit IRC01:24
*** fkautz has quit IRC01:24
*** fnordahl has quit IRC01:24
*** mnasiadka has quit IRC01:24
*** ghormoon has quit IRC01:24
*** lynxis has quit IRC01:24
*** sri_ has quit IRC01:24
*** flaviof has quit IRC01:24
*** edwarnicke has quit IRC01:24
*** mepholic has quit IRC01:24
*** ghormoon has joined #openvswitch01:25
*** JamesBenson has quit IRC01:25
*** thaller has joined #openvswitch01:30
*** fkautz has joined #openvswitch01:30
*** fnordahl has joined #openvswitch01:30
*** mnasiadka has joined #openvswitch01:30
*** lynxis has joined #openvswitch01:30
*** sri_ has joined #openvswitch01:30
*** flaviof has joined #openvswitch01:30
*** edwarnicke has joined #openvswitch01:30
*** mepholic has joined #openvswitch01:30
*** matteo| has quit IRC01:56
*** matteo has joined #openvswitch03:24
*** spatel has joined #openvswitch03:32
*** dcbw has quit IRC04:58
*** tbachman has quit IRC05:22
*** tbachman has joined #openvswitch05:22
*** acidfu has quit IRC05:41
*** thaller_ has joined #openvswitch05:51
*** acidfu has joined #openvswitch05:52
*** thaller has quit IRC05:55
*** acidfu has quit IRC05:56
*** anilvenkata has joined #openvswitch06:02
*** jaicaa has quit IRC06:28
*** jaicaa has joined #openvswitch06:30
*** spatel has quit IRC06:32
*** apus has quit IRC07:08
*** apus has joined #openvswitch07:08
*** ralonsoh has joined #openvswitch07:14
*** rcernin has quit IRC07:14
*** dholler has joined #openvswitch07:20
*** wondra has quit IRC07:24
*** rcernin has joined #openvswitch07:30
*** fdangelo has joined #openvswitch07:31
*** eelco has joined #openvswitch07:33
*** thaller_ has quit IRC07:34
*** thaller_ has joined #openvswitch07:34
*** slaweq has joined #openvswitch07:35
*** teardown has quit IRC07:36
*** teardown has joined #openvswitch07:37
*** slaweq has quit IRC07:38
*** thaller_ has quit IRC07:42
*** thaller_ has joined #openvswitch07:42
*** slaweq has joined #openvswitch07:50
*** slaweq has quit IRC08:01
*** slaweq has joined #openvswitch08:08
*** mdgray has joined #openvswitch08:18
*** yamamoto has quit IRC08:24
*** yamamoto has joined #openvswitch08:25
*** yamamoto has joined #openvswitch08:26
*** yamamoto has quit IRC08:30
*** yamamoto has joined #openvswitch08:31
*** yamamoto has joined #openvswitch08:32
*** yamamoto has quit IRC08:36
*** rcernin has quit IRC08:44
*** yamamoto has joined #openvswitch09:08
*** elvira has joined #openvswitch09:12
*** yamamoto has quit IRC09:17
*** yamamoto has joined #openvswitch09:31
*** spatel has joined #openvswitch09:33
*** yamamoto has quit IRC09:33
*** spatel has quit IRC09:37
*** yamamoto has joined #openvswitch10:21
*** yamamoto has quit IRC10:32
*** lord4163 has joined #openvswitch11:06
*** yamamoto has joined #openvswitch11:45
*** fbl has joined #openvswitch11:54
*** JamesBenson has joined #openvswitch12:01
*** JamesBenson has quit IRC12:07
*** JamesBenson has joined #openvswitch12:07
*** donhw_ has joined #openvswitch13:08
*** yamamoto has quit IRC13:09
*** spatel has joined #openvswitch13:09
*** donhw has quit IRC13:13
*** spatel has quit IRC13:15
*** ihrachys has quit IRC13:21
*** ihrachys has joined #openvswitch13:28
*** bostondriver has joined #openvswitch13:33
*** spatel has joined #openvswitch13:41
*** dcbw has joined #openvswitch14:05
*** yamamoto has joined #openvswitch14:13
kklimonda_I'm trying to change ovn nbdb/sbdb inactivity_probe timeout, and the only way of doing that I could find was creating connection entry in database like:14:20
kklimonda_```ovn-sbctl -- --id=@conn_uuid create Connection target="ptcp\:6642\:0.0.0.0" inactivity_probe=60000 -- set SB_Global . connections=@conn_uuid```14:20
kklimonda_but that makes ovsdb listen on 0.0.0.0, and given how this connection is apparently global between all clusterd ovsdb nodes I'm not even sure what should be put into target to listen only on specific IP address14:21
numanskklimonda_, Yes. That's the only way for the probes from ovsdb-server to the connected clients.14:21
numanskklimonda_, you can put a specific IP.14:21
numans kklimonda_ ovn-sbct set-connection ptcp:6642:IP (for example)14:22
numansor ovn-sbctl set connection . target="ptcp\:6642\:10.0.0.4" for example14:22
kklimonda_numans: how does that work with clustered ovsdb? I thought that this is shared between all nodes, in which case each one would need a different IP address14:23
numanskklimonda_, ok. you mean raft cluster ? or active/passive ?14:23
kklimonda_I mean raft cluster14:23
*** yamamoto has quit IRC14:26
numanskklimonda_, this is how openshift sets the probe interval - https://github.com/openshift/cluster-network-operator/blob/master/bindata/network/ovn-kubernetes/ovnkube-master.yaml#L27114:26
numanslet me see what LISTEN_DUAL_STACK can have the value14:27
numanskklimonda_, may be you can just set - target="ptcp:6642"14:29
kklimonda_numans: thanks, I'll try although it seems setting this outside of k8s (where each pod has one interface) won't really do what I want14:42
*** acidfu has joined #openvswitch14:48
*** aserdean has joined #openvswitch15:13
*** armax has joined #openvswitch15:34
*** eelco has quit IRC16:03
*** dcbw has quit IRC16:12
*** yamamoto has joined #openvswitch16:24
*** yamamoto has quit IRC16:31
*** dcbw has joined #openvswitch16:40
*** dceara has joined #openvswitch16:40
*** teardown_ has joined #openvswitch17:00
*** eelco has joined #openvswitch17:01
*** teardown has quit IRC17:03
*** eelco has quit IRC17:13
*** ralonsoh has quit IRC17:23
*** elvira has quit IRC17:40
*** elvira has joined #openvswitch17:43
*** panda has joined #openvswitch17:48
*** panda has quit IRC18:11
*** dyusupov has joined #openvswitch18:11
*** panda has joined #openvswitch18:13
*** zhouhan has joined #openvswitch18:15
mmichelsonIt's about that time. I'm going to get the meeting started18:15
mmichelson#startmeeting ovn_community_development_discussion18:15
openstackMeeting started Thu Dec 17 18:15:21 2020 UTC and is due to finish in 60 minutes.  The chair is mmichelson. Information about MeetBot at http://wiki.debian.org/MeetBot.18:15
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.18:15
openstackThe meeting name has been set to 'ovn_community_development_discussion'18:15
mmichelsonHi everyone18:15
*** blp has joined #openvswitch18:16
blphi!18:16
mmichelsonTomorrow is the proposed release date for 20.12.018:16
dcearaHi18:16
mmichelsonSo I have sent out the commits just before this meeting started18:16
mmichelsonThat way we can get it released early-ish (for the western hemisphere) tomorrow18:16
mmichelsonIn other news, I reworked my unit test patches so that rather than trying to introduce a framework that requires instrumenting source files, it just is a small refactor of some IPAM code and addition of tests using ovstest18:17
blpmmichelson: +118:17
mmichelsonblp, I'm glad you're here today :) The release of 20.12.0 means we should be in position to merge DDLog to master whenever you think you're ready.18:17
blpmmichelson: That is good news.18:18
mmichelsonI understand you're currently working on a new version of your patches18:18
blpI see that Dumitru passed along some more reviews.18:18
mmichelsonWould you want to get the latest version posted or would you rather us merge what currently exists?18:18
blpI think that my job is then:18:18
blp- Rebase and deal with whatever changes have happened.18:18
blp- Address Dumitru's feedback.18:18
blpIf the changes are relatively small based on those two things, then I'd be inclined to merge it.18:19
blpIf they need more work, then I'd be inclined to post a v10.18:19
blpWhat do you think?18:19
blpAnd post-merge there are at least two jobs left:18:19
blp- Keep up-to-date with changes.18:19
blp- Run benchmarks and iterate on making it faster and scale better.18:20
dcearablp: The last patch of the series depends on the IDL split changes (which need a rebase).  I'm not sure if there are more changes needed in the IDL patches, but with the current version quite a few OVN tests were failing.18:20
blpI think it was Numan who passed along a useful benchmark script.18:20
blpOh, crap.18:20
mmichelsonblp, for the rebase step, I assume you're not going to aim for feature parity, right?18:20
blpmmichelson: I've kept up with feature parity so far.18:20
mmichelsonblp, ah, ok. I just know that some of the changes (such as the datapath groups change) could be kind of big.18:21
blpI'll rebase the IDL split changes then.18:21
blpLast time I did that I did not see any test failures, but maybe some were introduced aftewrad.18:22
blpIt's hard to keep rebasing a big series against a constantly shifting base.18:22
mmichelsonyes it is18:22
mmichelsonthat's why I was wondering if we should just merge what we have and then work directly in master from this point?18:22
mmichelsonThat way, devs introducing new features to northd can introduce to C and DDLog simultaneously18:23
blpIf the IDL split changes can get into OVS, then we can do that.18:23
mmichelsonAnd we only have to chase that gap that currently exists from between your last posting and now18:23
blpWithout the IDL split changes, ovn+ddlog won't compile.18:23
mmichelsongot it18:23
blpI agree with the philosophy otherwise though.18:23
imaximetsblp, I'm going to review idl-split patch-set tomorrow.18:23
blpimaximets: Thanks! That will enable the rest.18:23
blpimaximets: I'll try to get the rebase of it done today, then.18:24
zhouhanblp: for the post-merge task "keep up-to-date with changes", is it assumed that the developer who submit the change should keep the DDlog part up-to-date?18:24
blpzhouhan: I would hope so, but I am also available to help, either to eduate developers or to help doing the porting.18:24
zhouhanblp: sounds good!18:24
imaximetsblp, ok.  One quick comment: can we re-name reconnect_try_receive to reconnect_receive_attempt ?  Current name sounds like we're requesting it to receive something.18:25
blpimaximets: OK.18:25
imaximetsblp, thanks!18:25
blpimaximets: I'll fold that into my rebase then.18:27
mmichelsonanyway, I kind of transitioned the conversation to ddlog, but to be clear I also was done talking about the things I had worked on.18:27
blpI don't think I have anything else.18:27
blp918:28
blpoops wrong window18:28
imaximetsI have a topic to discuss.18:28
imaximetslast time I talked about this patch: https://patchwork.ozlabs.org/project/openvswitch/patch/20201211205447.3874314-1-i.maximets@ovn.org/  for ovsdb-server.18:29
*** istokes has joined #openvswitch18:29
blpimaximets: yes18:30
imaximetsbasically, it changes the format of file transactions that stored in database file and in raft logs to contain diffs of columns.18:30
imaximetsrecent tests shows decrease by 90% of memory consumption for northbound database for ovn-k8s tests, 40% for southbound datbase and overall 40% reduction in disk IO.18:31
blpwow!18:31
imaximetsblp, zhouhan: it'll be great if you can review it.18:31
zhouhanimaximets: ok!18:31
imaximetsmain problem, I guess, is the upgrade process, since ovd ovsdb-server will not be able to read new database format.18:32
blpI'll put it on my to-do list.18:32
imaximetsthat is also a problem if we'll have different versions of ovsdb-server within same raft cluster.18:32
imaximetsblp, thanks!18:32
blpWhy is that a problem for upgrades? I would expect that to be a problem for downgrades, which are still worth considering but not in the same way.18:33
imaximetsIt's because if raft leader will send new append request to old follower that will be a problem.18:34
blpOh, OK, I see, we're changing not just the on-disk format but the format that gets sent around the raft cluster.18:34
imaximetsyep18:34
imaximetsI also worked on adding memory reports to ovn processes today: https://patchwork.ozlabs.org/project/ovn/patch/20201217181427.639377-1-i.maximets@ovn.org/18:35
imaximetsthat's it from my side.18:35
blpMaybe this format parameter should be part of the database definition, so that the cluster has to agree on what format to use from the start.18:35
blpThen, the format would only be upgraded once all the cluster members can handle it.18:36
imaximetsblp, problem is that we must be sure that new old server will not be connected to a cluster once format changed.18:37
imaximetsblp, and also old ovsdb-server will not understand that something is wrong.18:37
pandacan ovsdb raft cluster size change during normal operations ?18:38
blpimaximets: The format upgrade would have to happen after the software upgrade was finished.18:38
blppanda: OVSDB supports adding and removing raft cluster members, yes.18:38
*** dholler has quit IRC18:39
blppanda: And, of course, cluster members can fail and come back at runtime. I don't know whether you consider failures to be normal operations.18:39
imaximetsblp, I added a cmdline option to disable new format.  After upgrade user will be able to enable it via unixctl or be re-starting without the option.18:39
imaximets*by18:39
imaximetsbut I'm not sure if that is a best way to handle this.18:40
blpimaximets: That's kind of an admin-intensive way to deal with it. The admin will have to make sure to use the right command-line options during upgrade, and then turn them off afterward.18:40
blpimaximets: It might be harder to automate than telling people to upgrade the database format once they have finished their server upgrade.18:41
blpimaximets: I'm not an admin though.18:41
imaximetsblp, I can't think of a correct automatic way that will work in all cases.  But I'd like to discuss ideas on a mail-list.18:43
blpimaximets: OK.18:43
mmichelsoncool, y'all. Anybody else?18:44
dcearaI just wanted to mention that since yesterday OVN CI runs with AddressSanitizer enabled for clang (memleak detection too) on GitHub.  Thanks imaximets for the suggestion and review!18:45
dcearaThat's it on my side, thanks!18:45
blpAddressSanitizer is a big help. Glad to see it in use for CI.18:47
blpAnyone else?18:48
mmichelsonI guess that's it18:49
*** dyusupov has quit IRC18:49
mmichelsonThanks everyone!18:50
*** dyusupov has joined #openvswitch18:50
mmichelson#endmeeting18:50
blpThanks! Bye!18:50
openstackMeeting ended Thu Dec 17 18:50:21 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)18:50
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-12-17-18.15.html18:50
dcearaBye!18:50
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-12-17-18.15.txt18:50
openstackLog:            http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-12-17-18.15.log.html18:50
* panda grumbles18:50
*** blp has quit IRC18:50
pandaI have to study raft cluster a bit more18:50
*** dyusupov has quit IRC18:51
*** dyusupov has joined #openvswitch18:52
*** anilvenkata_ has joined #openvswitch18:54
*** anilvenkata has quit IRC18:57
*** dyusupov has quit IRC18:57
*** teardown has joined #openvswitch19:06
*** teardown_ has quit IRC19:09
*** istokes has left #openvswitch19:24
*** elvira has quit IRC19:38
*** anilvenkata_ has quit IRC19:41
*** zhouhan has quit IRC19:43
*** mdgray has quit IRC19:51
*** dceara has quit IRC19:54
*** apus has quit IRC20:00
*** apus has joined #openvswitch20:00
*** teardown has quit IRC20:16
*** teardown has joined #openvswitch20:18
*** teardown_ has joined #openvswitch20:45
*** teardown has quit IRC20:49
*** slaweq has quit IRC20:59
*** tbachman has quit IRC22:01
*** tbachman has joined #openvswitch22:03
*** yamamoto has joined #openvswitch22:10
*** teardown has joined #openvswitch22:14
*** rcernin has joined #openvswitch22:15
*** teardown_ has quit IRC22:17
*** slaweq has joined #openvswitch22:21
*** slaweq has quit IRC22:33
*** ihrachys has quit IRC22:43
*** bostondriver has quit IRC22:46
*** tbachman has quit IRC23:31
*** tbachman has joined #openvswitch23:34

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!