*** thaller has joined #openvswitch | 00:03 | |
*** yamamoto has joined #openvswitch | 00:17 | |
*** markPilon has joined #openvswitch | 01:04 | |
*** yamamoto has quit IRC | 01:23 | |
*** yamamoto has joined #openvswitch | 01:26 | |
*** yamamoto has quit IRC | 01:30 | |
*** markPilon has quit IRC | 02:03 | |
*** markPilon has joined #openvswitch | 02:17 | |
*** markPilon has quit IRC | 02:24 | |
*** armax has joined #openvswitch | 02:27 | |
*** yamamoto has joined #openvswitch | 02:51 | |
*** yamamoto has quit IRC | 03:05 | |
*** yamamoto has joined #openvswitch | 03:06 | |
*** Kamilion has quit IRC | 04:08 | |
*** armax has quit IRC | 04:08 | |
*** donhw has quit IRC | 04:08 | |
*** strondeak has quit IRC | 04:08 | |
*** jon_d____ has quit IRC | 04:08 | |
*** zigo has quit IRC | 04:08 | |
*** aconole has quit IRC | 04:08 | |
*** ihrachys has quit IRC | 04:08 | |
*** oanson has quit IRC | 04:08 | |
*** ChanServ has quit IRC | 04:08 | |
*** lathiat has quit IRC | 04:08 | |
*** erig_ has quit IRC | 04:08 | |
*** techwave61 has quit IRC | 04:08 | |
*** jaicaa has quit IRC | 04:08 | |
*** nickv1985 has quit IRC | 04:08 | |
*** af1cs has quit IRC | 04:08 | |
*** grive has quit IRC | 04:08 | |
*** tabakhase has quit IRC | 04:08 | |
*** JStoker has quit IRC | 04:08 | |
*** lynxis has quit IRC | 04:08 | |
*** balkamos has quit IRC | 04:08 | |
*** ghormoon has quit IRC | 04:08 | |
*** fnordahl has quit IRC | 04:08 | |
*** zhouhan has quit IRC | 04:08 | |
*** ktraynor has quit IRC | 04:08 | |
*** camelCaser has quit IRC | 04:08 | |
*** weiti has quit IRC | 04:08 | |
*** thaller has quit IRC | 04:08 | |
*** dmarchand has quit IRC | 04:08 | |
*** meph has quit IRC | 04:08 | |
*** BlackDex has quit IRC | 04:08 | |
*** osmanlicilegi has quit IRC | 04:08 | |
*** panda has quit IRC | 04:08 | |
*** spinningmonkey has quit IRC | 04:08 | |
*** jpwgarrison has quit IRC | 04:08 | |
*** lostd_ has quit IRC | 04:08 | |
*** ndim has quit IRC | 04:08 | |
*** amaron has quit IRC | 04:08 | |
*** trident has quit IRC | 04:08 | |
*** kevinbenton has quit IRC | 04:08 | |
*** Madkiss has quit IRC | 04:08 | |
*** avishnoi has quit IRC | 04:08 | |
*** frickler has quit IRC | 04:08 | |
*** dqx has quit IRC | 04:08 | |
*** imaximets has quit IRC | 04:08 | |
*** fkautz has quit IRC | 04:08 | |
*** SPF|Cloud has quit IRC | 04:08 | |
*** fab23_ has quit IRC | 04:08 | |
*** ohama has quit IRC | 04:08 | |
*** edwarnicke has quit IRC | 04:08 | |
*** NobodyCam has quit IRC | 04:08 | |
*** gizmoguy has quit IRC | 04:08 | |
*** slaweq has quit IRC | 04:08 | |
*** jamespage has quit IRC | 04:08 | |
*** kklimonda has quit IRC | 04:08 | |
*** mTeK has quit IRC | 04:08 | |
*** blahdodo has quit IRC | 04:08 | |
*** darkemon has quit IRC | 04:08 | |
*** atpa8a has quit IRC | 04:08 | |
*** matteo has quit IRC | 04:08 | |
*** numans has quit IRC | 04:08 | |
*** yamamoto has quit IRC | 04:08 | |
*** mmichelson_ has quit IRC | 04:08 | |
*** bern1 has quit IRC | 04:08 | |
*** |subz3r0| has quit IRC | 04:08 | |
*** dobson has quit IRC | 04:08 | |
*** znf has quit IRC | 04:08 | |
*** thiagoss has quit IRC | 04:08 | |
*** gadago has quit IRC | 04:08 | |
*** mnasiadka has quit IRC | 04:08 | |
*** fbl has quit IRC | 04:08 | |
*** _lore_ has quit IRC | 04:08 | |
*** markmcclain has quit IRC | 04:08 | |
*** warewolf has quit IRC | 04:08 | |
*** flaviof has quit IRC | 04:08 | |
*** d1rewolf has quit IRC | 04:08 | |
*** techwave61 has joined #openvswitch | 04:14 | |
*** erig_ has joined #openvswitch | 04:14 | |
*** lathiat has joined #openvswitch | 04:14 | |
*** fnordahl has joined #openvswitch | 04:14 | |
*** ghormoon has joined #openvswitch | 04:14 | |
*** balkamos has joined #openvswitch | 04:14 | |
*** lynxis has joined #openvswitch | 04:14 | |
*** JStoker has joined #openvswitch | 04:14 | |
*** tabakhase has joined #openvswitch | 04:14 | |
*** grive has joined #openvswitch | 04:14 | |
*** af1cs has joined #openvswitch | 04:14 | |
*** nickv1985 has joined #openvswitch | 04:14 | |
*** jaicaa has joined #openvswitch | 04:14 | |
*** oanson has joined #openvswitch | 04:14 | |
*** ihrachys has joined #openvswitch | 04:14 | |
*** aconole has joined #openvswitch | 04:14 | |
*** Kamilion has joined #openvswitch | 04:14 | |
*** frickler has joined #openvswitch | 04:14 | |
*** avishnoi has joined #openvswitch | 04:14 | |
*** kevinbenton has joined #openvswitch | 04:14 | |
*** Madkiss has joined #openvswitch | 04:14 | |
*** trident has joined #openvswitch | 04:14 | |
*** amaron has joined #openvswitch | 04:14 | |
*** gizmoguy has joined #openvswitch | 04:14 | |
*** NobodyCam has joined #openvswitch | 04:14 | |
*** edwarnicke has joined #openvswitch | 04:14 | |
*** imaximets has joined #openvswitch | 04:14 | |
*** dqx has joined #openvswitch | 04:14 | |
*** weiti has joined #openvswitch | 04:14 | |
*** camelCaser has joined #openvswitch | 04:14 | |
*** ktraynor has joined #openvswitch | 04:14 | |
*** zhouhan has joined #openvswitch | 04:14 | |
*** BlackDex has joined #openvswitch | 04:14 | |
*** meph has joined #openvswitch | 04:14 | |
*** dmarchand has joined #openvswitch | 04:14 | |
*** thaller has joined #openvswitch | 04:14 | |
*** jpwgarrison has joined #openvswitch | 04:14 | |
*** spinningmonkey has joined #openvswitch | 04:14 | |
*** panda has joined #openvswitch | 04:14 | |
*** osmanlicilegi has joined #openvswitch | 04:14 | |
*** mmichelson__ has joined #openvswitch | 04:14 | |
*** numans has joined #openvswitch | 04:14 | |
*** matteo has joined #openvswitch | 04:14 | |
*** atpa8a has joined #openvswitch | 04:14 | |
*** darkemon has joined #openvswitch | 04:14 | |
*** blahdodo has joined #openvswitch | 04:14 | |
*** mTeK has joined #openvswitch | 04:14 | |
*** kklimonda has joined #openvswitch | 04:14 | |
*** jamespage has joined #openvswitch | 04:14 | |
*** slaweq has joined #openvswitch | 04:14 | |
*** yamamoto has joined #openvswitch | 04:14 | |
*** mnasiadka has joined #openvswitch | 04:14 | |
*** fkautz has joined #openvswitch | 04:14 | |
*** flaviof has joined #openvswitch | 04:14 | |
*** SPF|Cloud has joined #openvswitch | 04:14 | |
*** bern1 has joined #openvswitch | 04:14 | |
*** fbl has joined #openvswitch | 04:14 | |
*** |subz3r0| has joined #openvswitch | 04:14 | |
*** ChanServ has joined #openvswitch | 04:14 | |
*** ohama has joined #openvswitch | 04:14 | |
*** fab23_ has joined #openvswitch | 04:14 | |
*** gadago has joined #openvswitch | 04:14 | |
*** thiagoss has joined #openvswitch | 04:14 | |
*** znf has joined #openvswitch | 04:14 | |
*** dobson has joined #openvswitch | 04:14 | |
*** _lore_ has joined #openvswitch | 04:14 | |
*** markmcclain has joined #openvswitch | 04:14 | |
*** warewolf has joined #openvswitch | 04:14 | |
*** tepper.freenode.net sets mode: +o ChanServ | 04:14 | |
*** lostd_ has joined #openvswitch | 04:15 | |
*** ndim has joined #openvswitch | 04:15 | |
*** armax has joined #openvswitch | 04:15 | |
*** donhw has joined #openvswitch | 04:15 | |
*** strondeak has joined #openvswitch | 04:15 | |
*** jon_d____ has joined #openvswitch | 04:15 | |
*** zigo has joined #openvswitch | 04:15 | |
*** SPF|Cloud has quit IRC | 04:16 | |
*** d1rewolf has joined #openvswitch | 04:17 | |
*** SPF|Cloud has joined #openvswitch | 04:19 | |
*** yamamoto has quit IRC | 04:35 | |
*** yamamoto has joined #openvswitch | 04:38 | |
*** anilvenkata has joined #openvswitch | 05:07 | |
*** mmirecki has joined #openvswitch | 05:09 | |
*** mmirecki has quit IRC | 05:20 | |
*** links has joined #openvswitch | 05:20 | |
*** psahoo has joined #openvswitch | 05:26 | |
*** anilvenkata has quit IRC | 05:33 | |
*** eelco has joined #openvswitch | 06:03 | |
*** anilvenkata has joined #openvswitch | 06:03 | |
*** slaweq has quit IRC | 07:01 | |
*** blahdodo has quit IRC | 07:03 | |
*** slaweq has joined #openvswitch | 07:04 | |
*** blahdodo has joined #openvswitch | 07:11 | |
*** mmirecki has joined #openvswitch | 07:12 | |
*** dceara has joined #openvswitch | 07:24 | |
*** dceara has quit IRC | 07:25 | |
*** dceara has joined #openvswitch | 07:29 | |
*** rtjure has joined #openvswitch | 07:56 | |
*** maciejjozefczyk has joined #openvswitch | 07:57 | |
*** yamamoto has quit IRC | 08:26 | |
*** yamamoto has joined #openvswitch | 08:28 | |
*** yamamoto has quit IRC | 08:29 | |
*** yamamoto has joined #openvswitch | 08:29 | |
*** its-surya has joined #openvswitch | 08:46 | |
*** rtjure has quit IRC | 09:06 | |
*** mbarroso has joined #openvswitch | 09:46 | |
*** yamamoto has quit IRC | 09:53 | |
*** yamamoto has joined #openvswitch | 10:08 | |
*** yamamoto has joined #openvswitch | 10:09 | |
*** yamamoto has quit IRC | 10:11 | |
*** yamamoto has joined #openvswitch | 10:12 | |
*** slaweq has quit IRC | 10:33 | |
*** thaller has quit IRC | 10:41 | |
*** thaller has joined #openvswitch | 10:41 | |
*** markPilon has joined #openvswitch | 10:48 | |
*** dceara has quit IRC | 11:23 | |
*** lathiat has quit IRC | 11:23 | |
*** erig_ has quit IRC | 11:23 | |
*** techwave61 has quit IRC | 11:23 | |
*** dceara has joined #openvswitch | 11:27 | |
*** lathiat has joined #openvswitch | 11:27 | |
*** erig_ has joined #openvswitch | 11:27 | |
*** techwave61 has joined #openvswitch | 11:27 | |
*** jon_d____ has quit IRC | 11:28 | |
*** jon_d___ has joined #openvswitch | 11:28 | |
*** slaweq has joined #openvswitch | 11:30 | |
*** yamamoto has quit IRC | 11:30 | |
*** erig_ is now known as erig | 11:39 | |
*** yamamoto has joined #openvswitch | 11:40 | |
*** yamamoto has quit IRC | 11:42 | |
*** psahoo has quit IRC | 11:42 | |
*** psahoo has joined #openvswitch | 11:56 | |
*** yamamoto has joined #openvswitch | 12:00 | |
*** slaweq has quit IRC | 12:11 | |
*** yamamoto has quit IRC | 12:18 | |
*** yamamoto has joined #openvswitch | 12:28 | |
*** slaweq has joined #openvswitch | 12:28 | |
panda | I'm having a compilation problem on OVN | 12:40 |
---|---|---|
numans | panda, what's that ? | 12:40 |
panda | numans: it's probably my fault, let me try one more thing | 12:42 |
panda | numans: yep, nevermind, I updated everything to the latest master and there were some leftovers. A boot.sh/configure/make solved the issue. | 12:47 |
numans | panda, ok. cool | 12:47 |
*** psahoo has quit IRC | 12:49 | |
*** yamamoto has quit IRC | 12:53 | |
*** bostondriver1 has joined #openvswitch | 12:56 | |
panda | numans: since you're there ready in the corner, I have a question: I'm working on https://bugzilla.redhat.com/show_bug.cgi?id=1851788 and added https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L2676. I'm trying to understand how string the validation should be there. If I have to verify for example that the route info must follow a specific string format, I must reuse what's already | 13:03 |
openstack | bugzilla.redhat.com bug 1851788 in ovn2.13 "[ovn2.13-rhel8]dnssl/rdnss/route_info doesn't take effect if send_periodic is false" [Medium,New] - Assigned to ovnteam | 13:03 |
panda | in https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L2856 | 13:03 |
panda | numans: also, I really tried to see if I could avoid duplication between the periodic and non periodic RA, but it's quite difficult until I have a more clear idea of what's needed on one side and another. | 13:04 |
*** yamamoto has joined #openvswitch | 13:05 | |
panda | and it seems that even if the logic is similar, some parts will not be. The buffer handling for example. | 13:05 |
numans | panda, honestly I don't see a reason to avoid duplication if at all there is duplication. | 13:05 |
numans | I'd rather leave AS-IS | 13:05 |
panda | numans: it's dirty :) | 13:05 |
panda | numans: my tendency is usually leave the code a bit better than how I found it. | 13:06 |
*** psahoo has joined #openvswitch | 13:06 | |
panda | numans: not always possible though | 13:06 |
numans | panda, In this case I don't see a need to unify the code because the way reply is handled is different from the periodic stuff | 13:06 |
numans | panda, I didn't understand your question - " I'm trying to understand how string the validation should be there. If I have to verify for example that the route info must follow a specific string forma ..." | 13:07 |
panda | numans: a sorry s/string/strict/ | 13:07 |
numans | ok | 13:07 |
panda | numans: and unify code would have save us the time of implementing the same options twice ... | 13:09 |
numans | panda, regarding the strictness, is tht field a string ? | 13:10 |
*** yamamoto has quit IRC | 13:12 | |
panda | numans: RDNSS should be a comma separated list of Ipv6 but right now OVN supports only one recursive DNS so that's easy to verify as IPv6 | 13:14 |
numans | panda, Ok. basic level validation is better | 13:14 |
panda | numans: DNSSL is a commma separated list of domains | 13:14 |
panda | numans: ROUTE_INFO instead is a very complex string that needs parsing | 13:15 |
panda | numans: ex route_info="HIGH-aef1::11/48,LOW-aef2::11/96" | 13:15 |
numans | panda, in the actual IPv6 RA, its not string right ? | 13:16 |
numans | but rather an encoded option which would have this info ? | 13:16 |
panda | numans: no, it's a variable size option | 13:16 |
numans | panda, ok. | 13:16 |
panda | numans: so yes, it's encoded | 13:17 |
numans | ok. | 13:17 |
panda | numans: so my doubt is more or less, just check it's a string, or check that the string is well formed too .. | 13:18 |
numans | panda, Ok. since anyway while encoding it you need to check its string, probably in the parse_*() you don;t have to do much | 13:23 |
numans | panda, but in the encode, you can return error if it's not formatted properly. The code to encode is here - https://github.com/ovn-org/ovn/blob/master/controller/pinctrl.c#L3290 | 13:24 |
numans | panda, So may be you can add a util function to encode route info in lib/ovn-util.c | 13:24 |
numans | and call this function in both pinctrl.c and action.c | 13:24 |
numans | I think that's possible | 13:24 |
numans | there's no point in having the same encode code duplicated. | 13:25 |
panda | numans: I'm duplicating that code here https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L2856 | 13:25 |
numans | panda, then I'd definitely suggest to make a util function | 13:25 |
numans | and I think its possible | 13:26 |
*** warewolf_ has joined #openvswitch | 13:26 | |
panda | numans: ok, that's what I tried before, but I need to understand what's common and what's different in the two calls, so I can create a common part. | 13:27 |
*** SPF|Cloud has quit IRC | 13:27 | |
*** d1rewolf has quit IRC | 13:27 | |
*** warewolf has quit IRC | 13:27 | |
*** fbl_ has joined #openvswitch | 13:27 | |
*** SPF|Cloud has joined #openvswitch | 13:28 | |
panda | numans: I'll try to do the same thing for https://github.com/ovn-org/ovn/blob/master/controller/pinctrl.c#L3227 and https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L2787 | 13:28 |
*** fbl has quit IRC | 13:28 | |
panda | numans: but they have different assumptions and extracting the logic is not entirely trivial | 13:28 |
*** d1rewolf has joined #openvswitch | 13:28 | |
panda | numans: thanks :) | 13:29 |
*** fbl_ has quit IRC | 13:29 | |
*** markmcclain has quit IRC | 13:29 | |
*** fbl has joined #openvswitch | 13:29 | |
*** _lore_ has quit IRC | 13:30 | |
*** markmcclain has joined #openvswitch | 13:30 | |
*** _lore_ has joined #openvswitch | 13:31 | |
*** yamamoto has joined #openvswitch | 13:38 | |
*** dcbw has joined #openvswitch | 13:39 | |
*** yamamoto has quit IRC | 13:42 | |
*** yamamoto has joined #openvswitch | 13:52 | |
*** mmirecki has quit IRC | 14:19 | |
*** mmirecki has joined #openvswitch | 14:21 | |
*** mmirecki has quit IRC | 14:25 | |
*** links has quit IRC | 14:54 | |
*** slaweq has quit IRC | 15:04 | |
*** yamamoto has quit IRC | 15:10 | |
*** markPilon has quit IRC | 15:38 | |
*** mbarroso has quit IRC | 15:53 | |
*** psahoo has quit IRC | 16:04 | |
*** psahoo has joined #openvswitch | 16:12 | |
*** armax has quit IRC | 16:16 | |
*** psahoo has quit IRC | 16:18 | |
*** armax has joined #openvswitch | 16:20 | |
*** armax has quit IRC | 16:20 | |
*** psahoo has joined #openvswitch | 16:25 | |
*** its-surya has quit IRC | 16:27 | |
*** dceara has quit IRC | 16:45 | |
*** dmellado has joined #openvswitch | 16:50 | |
*** dmellado has quit IRC | 17:04 | |
*** psahoo has quit IRC | 17:06 | |
*** dmellado has joined #openvswitch | 17:08 | |
*** mmirecki has joined #openvswitch | 17:08 | |
*** mmirecki has quit IRC | 17:13 | |
*** dmellado has quit IRC | 17:26 | |
*** ktraynor has quit IRC | 17:30 | |
*** eelco has quit IRC | 17:33 | |
*** armax has joined #openvswitch | 17:36 | |
*** armax has quit IRC | 17:38 | |
*** thaller_ has joined #openvswitch | 19:41 | |
*** thaller has quit IRC | 19:43 | |
*** maciejjozefczyk has quit IRC | 20:25 | |
*** fab23_ has quit IRC | 20:28 | |
*** fab23 has joined #openvswitch | 20:44 | |
*** bostondriver1 has quit IRC | 21:36 | |
*** zhouhan has quit IRC | 22:08 | |
*** rcernin has joined #openvswitch | 22:09 | |
*** zhouhan has joined #openvswitch | 22:12 | |
*** dmellado has joined #openvswitch | 22:20 | |
*** zhouhan has quit IRC | 22:26 | |
*** zhouhan has joined #openvswitch | 22:41 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!