Friday, 2020-07-10

*** thaller has joined #openvswitch00:03
*** yamamoto has joined #openvswitch00:17
*** markPilon has joined #openvswitch01:04
*** yamamoto has quit IRC01:23
*** yamamoto has joined #openvswitch01:26
*** yamamoto has quit IRC01:30
*** markPilon has quit IRC02:03
*** markPilon has joined #openvswitch02:17
*** markPilon has quit IRC02:24
*** armax has joined #openvswitch02:27
*** yamamoto has joined #openvswitch02:51
*** yamamoto has quit IRC03:05
*** yamamoto has joined #openvswitch03:06
*** Kamilion has quit IRC04:08
*** armax has quit IRC04:08
*** donhw has quit IRC04:08
*** strondeak has quit IRC04:08
*** jon_d____ has quit IRC04:08
*** zigo has quit IRC04:08
*** aconole has quit IRC04:08
*** ihrachys has quit IRC04:08
*** oanson has quit IRC04:08
*** ChanServ has quit IRC04:08
*** lathiat has quit IRC04:08
*** erig_ has quit IRC04:08
*** techwave61 has quit IRC04:08
*** jaicaa has quit IRC04:08
*** nickv1985 has quit IRC04:08
*** af1cs has quit IRC04:08
*** grive has quit IRC04:08
*** tabakhase has quit IRC04:08
*** JStoker has quit IRC04:08
*** lynxis has quit IRC04:08
*** balkamos has quit IRC04:08
*** ghormoon has quit IRC04:08
*** fnordahl has quit IRC04:08
*** zhouhan has quit IRC04:08
*** ktraynor has quit IRC04:08
*** camelCaser has quit IRC04:08
*** weiti has quit IRC04:08
*** thaller has quit IRC04:08
*** dmarchand has quit IRC04:08
*** meph has quit IRC04:08
*** BlackDex has quit IRC04:08
*** osmanlicilegi has quit IRC04:08
*** panda has quit IRC04:08
*** spinningmonkey has quit IRC04:08
*** jpwgarrison has quit IRC04:08
*** lostd_ has quit IRC04:08
*** ndim has quit IRC04:08
*** amaron has quit IRC04:08
*** trident has quit IRC04:08
*** kevinbenton has quit IRC04:08
*** Madkiss has quit IRC04:08
*** avishnoi has quit IRC04:08
*** frickler has quit IRC04:08
*** dqx has quit IRC04:08
*** imaximets has quit IRC04:08
*** fkautz has quit IRC04:08
*** SPF|Cloud has quit IRC04:08
*** fab23_ has quit IRC04:08
*** ohama has quit IRC04:08
*** edwarnicke has quit IRC04:08
*** NobodyCam has quit IRC04:08
*** gizmoguy has quit IRC04:08
*** slaweq has quit IRC04:08
*** jamespage has quit IRC04:08
*** kklimonda has quit IRC04:08
*** mTeK has quit IRC04:08
*** blahdodo has quit IRC04:08
*** darkemon has quit IRC04:08
*** atpa8a has quit IRC04:08
*** matteo has quit IRC04:08
*** numans has quit IRC04:08
*** yamamoto has quit IRC04:08
*** mmichelson_ has quit IRC04:08
*** bern1 has quit IRC04:08
*** |subz3r0| has quit IRC04:08
*** dobson has quit IRC04:08
*** znf has quit IRC04:08
*** thiagoss has quit IRC04:08
*** gadago has quit IRC04:08
*** mnasiadka has quit IRC04:08
*** fbl has quit IRC04:08
*** _lore_ has quit IRC04:08
*** markmcclain has quit IRC04:08
*** warewolf has quit IRC04:08
*** flaviof has quit IRC04:08
*** d1rewolf has quit IRC04:08
*** techwave61 has joined #openvswitch04:14
*** erig_ has joined #openvswitch04:14
*** lathiat has joined #openvswitch04:14
*** fnordahl has joined #openvswitch04:14
*** ghormoon has joined #openvswitch04:14
*** balkamos has joined #openvswitch04:14
*** lynxis has joined #openvswitch04:14
*** JStoker has joined #openvswitch04:14
*** tabakhase has joined #openvswitch04:14
*** grive has joined #openvswitch04:14
*** af1cs has joined #openvswitch04:14
*** nickv1985 has joined #openvswitch04:14
*** jaicaa has joined #openvswitch04:14
*** oanson has joined #openvswitch04:14
*** ihrachys has joined #openvswitch04:14
*** aconole has joined #openvswitch04:14
*** Kamilion has joined #openvswitch04:14
*** frickler has joined #openvswitch04:14
*** avishnoi has joined #openvswitch04:14
*** kevinbenton has joined #openvswitch04:14
*** Madkiss has joined #openvswitch04:14
*** trident has joined #openvswitch04:14
*** amaron has joined #openvswitch04:14
*** gizmoguy has joined #openvswitch04:14
*** NobodyCam has joined #openvswitch04:14
*** edwarnicke has joined #openvswitch04:14
*** imaximets has joined #openvswitch04:14
*** dqx has joined #openvswitch04:14
*** weiti has joined #openvswitch04:14
*** camelCaser has joined #openvswitch04:14
*** ktraynor has joined #openvswitch04:14
*** zhouhan has joined #openvswitch04:14
*** BlackDex has joined #openvswitch04:14
*** meph has joined #openvswitch04:14
*** dmarchand has joined #openvswitch04:14
*** thaller has joined #openvswitch04:14
*** jpwgarrison has joined #openvswitch04:14
*** spinningmonkey has joined #openvswitch04:14
*** panda has joined #openvswitch04:14
*** osmanlicilegi has joined #openvswitch04:14
*** mmichelson__ has joined #openvswitch04:14
*** numans has joined #openvswitch04:14
*** matteo has joined #openvswitch04:14
*** atpa8a has joined #openvswitch04:14
*** darkemon has joined #openvswitch04:14
*** blahdodo has joined #openvswitch04:14
*** mTeK has joined #openvswitch04:14
*** kklimonda has joined #openvswitch04:14
*** jamespage has joined #openvswitch04:14
*** slaweq has joined #openvswitch04:14
*** yamamoto has joined #openvswitch04:14
*** mnasiadka has joined #openvswitch04:14
*** fkautz has joined #openvswitch04:14
*** flaviof has joined #openvswitch04:14
*** SPF|Cloud has joined #openvswitch04:14
*** bern1 has joined #openvswitch04:14
*** fbl has joined #openvswitch04:14
*** |subz3r0| has joined #openvswitch04:14
*** ChanServ has joined #openvswitch04:14
*** ohama has joined #openvswitch04:14
*** fab23_ has joined #openvswitch04:14
*** gadago has joined #openvswitch04:14
*** thiagoss has joined #openvswitch04:14
*** znf has joined #openvswitch04:14
*** dobson has joined #openvswitch04:14
*** _lore_ has joined #openvswitch04:14
*** markmcclain has joined #openvswitch04:14
*** warewolf has joined #openvswitch04:14
*** tepper.freenode.net sets mode: +o ChanServ04:14
*** lostd_ has joined #openvswitch04:15
*** ndim has joined #openvswitch04:15
*** armax has joined #openvswitch04:15
*** donhw has joined #openvswitch04:15
*** strondeak has joined #openvswitch04:15
*** jon_d____ has joined #openvswitch04:15
*** zigo has joined #openvswitch04:15
*** SPF|Cloud has quit IRC04:16
*** d1rewolf has joined #openvswitch04:17
*** SPF|Cloud has joined #openvswitch04:19
*** yamamoto has quit IRC04:35
*** yamamoto has joined #openvswitch04:38
*** anilvenkata has joined #openvswitch05:07
*** mmirecki has joined #openvswitch05:09
*** mmirecki has quit IRC05:20
*** links has joined #openvswitch05:20
*** psahoo has joined #openvswitch05:26
*** anilvenkata has quit IRC05:33
*** eelco has joined #openvswitch06:03
*** anilvenkata has joined #openvswitch06:03
*** slaweq has quit IRC07:01
*** blahdodo has quit IRC07:03
*** slaweq has joined #openvswitch07:04
*** blahdodo has joined #openvswitch07:11
*** mmirecki has joined #openvswitch07:12
*** dceara has joined #openvswitch07:24
*** dceara has quit IRC07:25
*** dceara has joined #openvswitch07:29
*** rtjure has joined #openvswitch07:56
*** maciejjozefczyk has joined #openvswitch07:57
*** yamamoto has quit IRC08:26
*** yamamoto has joined #openvswitch08:28
*** yamamoto has quit IRC08:29
*** yamamoto has joined #openvswitch08:29
*** its-surya has joined #openvswitch08:46
*** rtjure has quit IRC09:06
*** mbarroso has joined #openvswitch09:46
*** yamamoto has quit IRC09:53
*** yamamoto has joined #openvswitch10:08
*** yamamoto has joined #openvswitch10:09
*** yamamoto has quit IRC10:11
*** yamamoto has joined #openvswitch10:12
*** slaweq has quit IRC10:33
*** thaller has quit IRC10:41
*** thaller has joined #openvswitch10:41
*** markPilon has joined #openvswitch10:48
*** dceara has quit IRC11:23
*** lathiat has quit IRC11:23
*** erig_ has quit IRC11:23
*** techwave61 has quit IRC11:23
*** dceara has joined #openvswitch11:27
*** lathiat has joined #openvswitch11:27
*** erig_ has joined #openvswitch11:27
*** techwave61 has joined #openvswitch11:27
*** jon_d____ has quit IRC11:28
*** jon_d___ has joined #openvswitch11:28
*** slaweq has joined #openvswitch11:30
*** yamamoto has quit IRC11:30
*** erig_ is now known as erig11:39
*** yamamoto has joined #openvswitch11:40
*** yamamoto has quit IRC11:42
*** psahoo has quit IRC11:42
*** psahoo has joined #openvswitch11:56
*** yamamoto has joined #openvswitch12:00
*** slaweq has quit IRC12:11
*** yamamoto has quit IRC12:18
*** yamamoto has joined #openvswitch12:28
*** slaweq has joined #openvswitch12:28
pandaI'm having a compilation problem on OVN12:40
numanspanda, what's that ?12:40
pandanumans: it's probably my fault, let me try one more thing12:42
pandanumans: yep, nevermind, I updated everything to the latest master and there were some leftovers. A boot.sh/configure/make solved the issue.12:47
numanspanda, ok. cool12:47
*** psahoo has quit IRC12:49
*** yamamoto has quit IRC12:53
*** bostondriver1 has joined #openvswitch12:56
pandanumans: since you're there ready in the corner, I have a question: I'm working on https://bugzilla.redhat.com/show_bug.cgi?id=1851788 and added https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L2676. I'm trying to understand how string the validation should be there. If I have to verify for example that the route info must follow a specific string format, I must reuse what's already13:03
openstackbugzilla.redhat.com bug 1851788 in ovn2.13 "[ovn2.13-rhel8]dnssl/rdnss/route_info doesn't take effect if send_periodic is false" [Medium,New] - Assigned to ovnteam13:03
pandain https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L285613:03
pandanumans: also, I really tried to see if I could avoid duplication between the periodic and non periodic RA, but it's quite difficult until I have a more clear idea of what's needed on one side and another.13:04
*** yamamoto has joined #openvswitch13:05
pandaand it seems that even if the logic is similar, some parts will not be. The buffer handling for example.13:05
numanspanda, honestly I don't see a reason to avoid duplication if at all there is duplication.13:05
numansI'd rather leave AS-IS13:05
pandanumans: it's dirty :)13:05
pandanumans: my tendency is usually leave the code a bit better than how I found it.13:06
*** psahoo has joined #openvswitch13:06
pandanumans: not always possible though13:06
numanspanda, In this case I don't see a need to unify the code because the way reply is handled is different from the periodic stuff13:06
numanspanda, I didn't understand your question - " I'm trying to understand how string the validation should be there. If I have to verify for example that the route info must follow a specific string forma ..."13:07
pandanumans: a sorry s/string/strict/13:07
numansok13:07
pandanumans: and unify code would have save us the time of implementing the same options twice ...13:09
numanspanda, regarding the strictness, is tht field a string ?13:10
*** yamamoto has quit IRC13:12
pandanumans: RDNSS should be a comma separated list of Ipv6 but right now OVN supports only one recursive DNS so that's easy to verify as IPv613:14
numanspanda, Ok. basic level validation is better13:14
pandanumans: DNSSL is a commma separated list of domains13:14
pandanumans: ROUTE_INFO instead is a very complex string that needs parsing13:15
pandanumans: ex route_info="HIGH-aef1::11/48,LOW-aef2::11/96"13:15
numanspanda, in the actual IPv6 RA, its not string right ?13:16
numansbut rather an encoded option which would have this info ?13:16
pandanumans: no, it's a variable size option13:16
numanspanda, ok.13:16
pandanumans: so yes, it's encoded13:17
numansok.13:17
pandanumans: so my doubt is more or less, just check it's a string, or check that the string is well formed too ..13:18
numanspanda, Ok. since anyway while encoding it you need to check its string, probably in the parse_*() you don;t have to do much13:23
numanspanda, but in the encode, you can return error if it's not formatted properly. The code to encode is here - https://github.com/ovn-org/ovn/blob/master/controller/pinctrl.c#L329013:24
numanspanda, So may be you can add a util function to encode route info in lib/ovn-util.c13:24
numansand call this function in both pinctrl.c and action.c13:24
numansI think that's possible13:24
numansthere's no point in having the same encode code duplicated.13:25
pandanumans: I'm duplicating that code here https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L285613:25
numanspanda, then I'd definitely suggest to make a util function13:25
numansand I think its possible13:26
*** warewolf_ has joined #openvswitch13:26
pandanumans: ok, that's what I tried before, but I need to understand what's common and what's different in the two calls, so I can create a common part.13:27
*** SPF|Cloud has quit IRC13:27
*** d1rewolf has quit IRC13:27
*** warewolf has quit IRC13:27
*** fbl_ has joined #openvswitch13:27
*** SPF|Cloud has joined #openvswitch13:28
pandanumans: I'll try to do the same thing for https://github.com/ovn-org/ovn/blob/master/controller/pinctrl.c#L3227 and https://github.com/gabrielecerami/ovn/blob/ra_opti0ons/lib/actions.c#L278713:28
*** fbl has quit IRC13:28
pandanumans: but they have different assumptions and extracting the logic is not entirely trivial13:28
*** d1rewolf has joined #openvswitch13:28
pandanumans: thanks :)13:29
*** fbl_ has quit IRC13:29
*** markmcclain has quit IRC13:29
*** fbl has joined #openvswitch13:29
*** _lore_ has quit IRC13:30
*** markmcclain has joined #openvswitch13:30
*** _lore_ has joined #openvswitch13:31
*** yamamoto has joined #openvswitch13:38
*** dcbw has joined #openvswitch13:39
*** yamamoto has quit IRC13:42
*** yamamoto has joined #openvswitch13:52
*** mmirecki has quit IRC14:19
*** mmirecki has joined #openvswitch14:21
*** mmirecki has quit IRC14:25
*** links has quit IRC14:54
*** slaweq has quit IRC15:04
*** yamamoto has quit IRC15:10
*** markPilon has quit IRC15:38
*** mbarroso has quit IRC15:53
*** psahoo has quit IRC16:04
*** psahoo has joined #openvswitch16:12
*** armax has quit IRC16:16
*** psahoo has quit IRC16:18
*** armax has joined #openvswitch16:20
*** armax has quit IRC16:20
*** psahoo has joined #openvswitch16:25
*** its-surya has quit IRC16:27
*** dceara has quit IRC16:45
*** dmellado has joined #openvswitch16:50
*** dmellado has quit IRC17:04
*** psahoo has quit IRC17:06
*** dmellado has joined #openvswitch17:08
*** mmirecki has joined #openvswitch17:08
*** mmirecki has quit IRC17:13
*** dmellado has quit IRC17:26
*** ktraynor has quit IRC17:30
*** eelco has quit IRC17:33
*** armax has joined #openvswitch17:36
*** armax has quit IRC17:38
*** thaller_ has joined #openvswitch19:41
*** thaller has quit IRC19:43
*** maciejjozefczyk has quit IRC20:25
*** fab23_ has quit IRC20:28
*** fab23 has joined #openvswitch20:44
*** bostondriver1 has quit IRC21:36
*** zhouhan has quit IRC22:08
*** rcernin has joined #openvswitch22:09
*** zhouhan has joined #openvswitch22:12
*** dmellado has joined #openvswitch22:20
*** zhouhan has quit IRC22:26
*** zhouhan has joined #openvswitch22:41

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!