opendevreview | Stephen Finucane proposed openstack/zaqar master: devstack: Be tolerant of existing /etc/apt/sources.list.d dir https://review.opendev.org/c/openstack/zaqar/+/945555 | 11:14 |
---|---|---|
opendevreview | Stephen Finucane proposed openstack/zaqar master: Add pyproject.toml file https://review.opendev.org/c/openstack/zaqar/+/945557 | 11:17 |
stephenfin | tkajinam: FYI https://github.com/gophercloud/gophercloud/issues/3336 | 13:49 |
stephenfin | we're seeing failures in gophercloud for zaqar tests. the root cause seems to be that zaqar is returning paths rather than URLs in the 'links' fields in the responses of most/all APIs, including the versions ('/') API | 13:50 |
stephenfin | IMO your change to move zaqar to deploying under a path instead of using a port has merely exposed an existing bug | 13:51 |
opendevreview | Stephen Finucane proposed openstack/zaqar master: tests: Set host for unit tests https://review.opendev.org/c/openstack/zaqar/+/945588 | 13:55 |
opendevreview | Stephen Finucane proposed openstack/zaqar master: api: Use absolute URLs in versions endpoint https://review.opendev.org/c/openstack/zaqar/+/945589 | 13:55 |
stephenfin | There is the start of fix. Assuming that makes sense, it needs to be done for all APIs. | 13:56 |
opendevreview | Stephen Finucane proposed openstack/zaqar master: doc: Update contributor guide for running tests https://review.opendev.org/c/openstack/zaqar/+/945605 | 14:35 |
opendevreview | Stephen Finucane proposed openstack/zaqar master: tox: Bump minimum to v4 https://review.opendev.org/c/openstack/zaqar/+/945606 | 14:35 |
opendevreview | Stephen Finucane proposed openstack/zaqar master: Remove dox.yaml https://review.opendev.org/c/openstack/zaqar/+/945607 | 14:35 |
tkajinam | stephenfin, ugh.. it seems so > exposed an existing bug | 14:37 |
tkajinam | I generally agree with the proposed fix but I may have to check how it may affect zaqarclient. | 14:38 |
stephenfin | Yes, I suspect this is going to be somewhat tricky hence I've only address the root URL for now. | 14:38 |
tkajinam | thanks for the heads-up and these patches ! | 14:39 |
stephenfin | filed a bug too https://bugs.launchpad.net/zaqar/+bug/2104271 | 14:43 |
opendevreview | Stephen Finucane proposed openstack/zaqar master: api: Use absolute URLs in versions endpoint https://review.opendev.org/c/openstack/zaqar/+/945589 | 14:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!