| *** wxy__ has joined #openstack-zaqar | 00:55 | |
| *** eliqiao has joined #openstack-zaqar | 02:14 | |
| wxy__ | ping flwang, | 02:53 |
|---|---|---|
| wxy__ | flwang, OSprofiler's patch is ready. Please review them. | 02:53 |
| wxy__ | @wanghao, vkmc flaper87 | 02:54 |
| flwang | wxy__: yep, i saw that | 02:57 |
| flwang | thank you very much for working on this | 02:57 |
| flwang | that's the most important feature i would like to see in ocata | 02:57 |
| flwang | but i'm busy to prepare the summit session recently so i'm have to review it after summit | 02:58 |
| flwang | or during summit | 02:58 |
| wxy__ | flwang, That's ok. I'll write a guide for it in these days. | 02:58 |
| flwang | the summit session i'm working on is very complex | 02:58 |
| flwang | wxy__: yep, it would be nice for review | 02:59 |
| flwang | since i will definitely try it before +2 :) | 02:59 |
| wxy__ | flwang, sure, I tested with mongo, it works well. I'll take more test with other backends. | 03:01 |
| flwang | awesome | 03:06 |
| flwang | btw, as for the subscription confirmation | 03:06 |
| flwang | i have a quesiton | 03:07 |
| flwang | if i didn't enable confirmation, zaqar shouldn't send any confirmation notification, right? | 03:07 |
| flwang | wxy__: we send confirm notification at here https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/subscriptions.py#L218 | 03:12 |
| flwang | but at https://github.com/openstack/zaqar/blob/master/zaqar/notification/notifier.py#L82 i'm thinking zaqar shouldn't send any confirm notification if the feature is totally disabled in conf | 03:13 |
| flwang | wxy__: did i miss anything? | 03:13 |
| wxy__ | flwang, so it depends on what's the config option "require_confirmation" meaning. | 03:16 |
| wxy__ | flwang, Now zaqar will always send the confirm notification. | 03:17 |
| wxy__ | flwang, but message notification can be sent only when "require_confirmation=True" and "confirmed=True" | 03:19 |
| flwang | based on my understanding, we should leave a chance for any existing user to migrate to newton without trouble | 03:21 |
| flwang | for current case, they will receive the confirm notification even require_confirmation=false | 03:21 |
| flwang | right? | 03:21 |
| wxy__ | flwang, yes | 03:21 |
| wxy__ | flwang, we need a small patch to fix it. | 03:22 |
| flwang | wxy__: could you pls fix it? otherwise i can do that | 03:22 |
| flwang | i'm playing the notification much recently ;) | 03:22 |
| flwang | oh, btw, you will be in barcelona, right? | 03:23 |
| wxy__ | flwang, I hope your can fix it. It can let us in the same page. :) | 03:24 |
| wxy__ | flwang, yes I'll be there. | 03:24 |
| flwang | wxy__: awesome, i will fix it | 03:24 |
| flwang | i think we just need to check require_confirmation in https://github.com/openstack/zaqar/blob/master/zaqar/notification/notifier.py#L82 | 03:25 |
| flwang | if it's false, just do nothing | 03:25 |
| wxy__ | flwang, agree | 03:25 |
| flwang | wxy__: cool | 03:27 |
| *** flwang1 has quit IRC | 04:40 | |
| *** exploreshaifali has joined #openstack-zaqar | 05:56 | |
| *** Ravikiran_K has joined #openstack-zaqar | 06:15 | |
| *** rcernin has joined #openstack-zaqar | 06:56 | |
| *** tesseract- has joined #openstack-zaqar | 07:04 | |
| *** exploreshaifali has quit IRC | 07:56 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:01 | |
| *** exploreshaifali has quit IRC | 08:07 | |
| *** dynarro has joined #openstack-zaqar | 08:19 | |
| *** GB21 has joined #openstack-zaqar | 08:28 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:49 | |
| *** kragniz has quit IRC | 08:53 | |
| *** kragniz has joined #openstack-zaqar | 08:54 | |
| *** exploreshaifali has quit IRC | 08:59 | |
| *** kragniz has quit IRC | 09:17 | |
| *** Ravikiran_K has quit IRC | 09:17 | |
| *** shu-mutou-AWAY has quit IRC | 09:17 | |
| *** jtomasek has quit IRC | 09:17 | |
| *** openstackgerrit has quit IRC | 09:17 | |
| *** dynarro has quit IRC | 09:17 | |
| *** zigo has quit IRC | 09:17 | |
| *** rbrady_ has quit IRC | 09:17 | |
| *** pmathews_ has quit IRC | 09:17 | |
| *** Kevin_Zheng has quit IRC | 09:17 | |
| *** godlike has quit IRC | 09:17 | |
| *** Qiming has quit IRC | 09:17 | |
| *** vipuls has quit IRC | 09:17 | |
| *** zhiyan has quit IRC | 09:17 | |
| *** therve has quit IRC | 09:17 | |
| *** GB21 has quit IRC | 09:17 | |
| *** rcernin has quit IRC | 09:17 | |
| *** eliqiao has quit IRC | 09:17 | |
| *** odyssey4me has quit IRC | 09:17 | |
| *** ryansb has quit IRC | 09:17 | |
| *** mdnadeem has quit IRC | 09:17 | |
| *** flaper87 has quit IRC | 09:17 | |
| *** wxy__ has quit IRC | 09:17 | |
| *** Guest66666 has quit IRC | 09:17 | |
| *** EmilienM has quit IRC | 09:17 | |
| *** ameade has quit IRC | 09:17 | |
| *** boris-42 has quit IRC | 09:17 | |
| *** kong has quit IRC | 09:17 | |
| *** tonyb has quit IRC | 09:17 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:20 | |
| *** GB21 has joined #openstack-zaqar | 09:57 | |
| *** kragniz has joined #openstack-zaqar | 10:00 | |
| *** wxy__ has joined #openstack-zaqar | 10:07 | |
| *** Guest66666 has joined #openstack-zaqar | 10:07 | |
| *** EmilienM has joined #openstack-zaqar | 10:07 | |
| *** boris-42 has joined #openstack-zaqar | 10:07 | |
| *** tonyb has joined #openstack-zaqar | 10:07 | |
| *** kong has joined #openstack-zaqar | 10:09 | |
| *** rcernin has joined #openstack-zaqar | 10:09 | |
| *** eliqiao has joined #openstack-zaqar | 10:09 | |
| *** odyssey4me has joined #openstack-zaqar | 10:09 | |
| *** ryansb has joined #openstack-zaqar | 10:09 | |
| *** mdnadeem has joined #openstack-zaqar | 10:09 | |
| *** flaper87 has joined #openstack-zaqar | 10:09 | |
| *** kong has quit IRC | 10:10 | |
| *** rcernin has quit IRC | 10:10 | |
| *** eliqiao has quit IRC | 10:10 | |
| *** odyssey4me has quit IRC | 10:10 | |
| *** ryansb has quit IRC | 10:10 | |
| *** mdnadeem has quit IRC | 10:10 | |
| *** flaper87 has quit IRC | 10:10 | |
| *** wxy__ has quit IRC | 10:10 | |
| *** Guest66666 has quit IRC | 10:10 | |
| *** EmilienM has quit IRC | 10:10 | |
| *** boris-42 has quit IRC | 10:10 | |
| *** tonyb has quit IRC | 10:10 | |
| *** wxy__ has joined #openstack-zaqar | 10:26 | |
| *** Guest66666 has joined #openstack-zaqar | 10:26 | |
| *** EmilienM has joined #openstack-zaqar | 10:26 | |
| *** boris-42 has joined #openstack-zaqar | 10:26 | |
| *** tonyb has joined #openstack-zaqar | 10:26 | |
| *** Ravikiran_K has joined #openstack-zaqar | 10:27 | |
| *** shu-mutou-AWAY has joined #openstack-zaqar | 10:27 | |
| *** rcernin has joined #openstack-zaqar | 10:27 | |
| *** eliqiao has joined #openstack-zaqar | 10:27 | |
| *** odyssey4me has joined #openstack-zaqar | 10:27 | |
| *** ryansb has joined #openstack-zaqar | 10:27 | |
| *** flaper87 has joined #openstack-zaqar | 10:27 | |
| *** jtomasek has joined #openstack-zaqar | 10:28 | |
| *** openstackgerrit has joined #openstack-zaqar | 10:28 | |
| *** kong has joined #openstack-zaqar | 10:28 | |
| *** ameade has joined #openstack-zaqar | 10:28 | |
| *** dynarro has joined #openstack-zaqar | 10:28 | |
| *** zigo has joined #openstack-zaqar | 10:28 | |
| *** rbrady_ has joined #openstack-zaqar | 10:28 | |
| *** pmathews_ has joined #openstack-zaqar | 10:28 | |
| *** Kevin_Zheng has joined #openstack-zaqar | 10:28 | |
| *** godlike has joined #openstack-zaqar | 10:28 | |
| *** Qiming has joined #openstack-zaqar | 10:28 | |
| *** vipuls has joined #openstack-zaqar | 10:28 | |
| *** zhiyan has joined #openstack-zaqar | 10:28 | |
| *** therve has joined #openstack-zaqar | 10:28 | |
| *** dynarro has quit IRC | 10:46 | |
| *** dynarro has joined #openstack-zaqar | 10:47 | |
| *** wanghao_ has joined #openstack-zaqar | 10:54 | |
| *** Ravikiran_K has quit IRC | 11:24 | |
| *** flaper87 has quit IRC | 11:56 | |
| *** flaper87 has joined #openstack-zaqar | 12:12 | |
| *** flaper87 has quit IRC | 12:12 | |
| *** flaper87 has joined #openstack-zaqar | 12:12 | |
| *** rbrady_ is now known as rbrady | 12:19 | |
| *** Eva-i has quit IRC | 12:39 | |
| *** GB21 has quit IRC | 12:58 | |
| *** wanghao_ has quit IRC | 13:00 | |
| *** honza_ is now known as honza | 13:02 | |
| *** exploreshaifali has quit IRC | 13:03 | |
| *** exploreshaifali has joined #openstack-zaqar | 14:16 | |
| *** openstackgerrit has quit IRC | 14:18 | |
| *** openstackgerrit has joined #openstack-zaqar | 14:18 | |
| *** dynarro has quit IRC | 14:22 | |
| *** rcernin has quit IRC | 15:20 | |
| *** mpanetta has quit IRC | 15:27 | |
| *** mpanetta has joined #openstack-zaqar | 15:27 | |
| *** mpanetta has quit IRC | 15:31 | |
| *** mpanetta has joined #openstack-zaqar | 15:31 | |
| *** pmathews_ has quit IRC | 15:35 | |
| *** rbrady is now known as rbrady-mtg | 15:47 | |
| *** tqtran has joined #openstack-zaqar | 16:01 | |
| *** tesseract- has quit IRC | 16:06 | |
| *** pmathews has joined #openstack-zaqar | 16:07 | |
| *** rbrady-mtg is now known as rbrady | 17:19 | |
| *** adu has joined #openstack-zaqar | 18:32 | |
| *** adu has quit IRC | 19:01 | |
| *** tqtran has quit IRC | 19:56 | |
| *** openstackgerrit has quit IRC | 20:19 | |
| *** openstackgerrit has joined #openstack-zaqar | 20:19 | |
| *** rbrady is now known as rbrady-afk | 20:25 | |
| *** tqtran has joined #openstack-zaqar | 20:29 | |
| *** mpanetta has quit IRC | 20:35 | |
| *** mpanetta has joined #openstack-zaqar | 20:36 | |
| *** flwang1 has joined #openstack-zaqar | 20:47 | |
| *** flwang1 has quit IRC | 21:57 | |
| *** exploreshaifali has quit IRC | 22:33 | |
| *** pmathews has quit IRC | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!