| *** rcernin has quit IRC | 00:13 | |
| *** shu-mutou has joined #openstack-zaqar | 01:01 | |
| wanghao | flwang: ping | 01:05 |
|---|---|---|
| wanghao | flwang: hi, I see the SNS api doc, http://docs.aws.amazon.com/sns/latest/api/API_ConfirmSubscription.html, in Response Elements, there is a response that will return with topic arn. and I also tested the javascript you pasted, it got the response after it sent the ConfirmSubscription request.See this http://paste.openstack.org/show/510945. | 01:06 |
| wanghao | flwang: So maybe we should have response about the confirmation subscription request. | 01:07 |
| flwang | wanghao: yep, i saw your comment. and one thing i would like to know is the additional info returned in the response | 01:09 |
| flwang | wanghao: what's this 7e1557bc-a8f3-4ffc-a8af-72db50b1da06 ? | 01:10 |
| wanghao | flwang: it's subscription id. | 01:20 |
| wanghao | flwang: it's made up of topic:uuid. | 01:22 |
| flwang | wanghao: i think we're a little bit different from the SNS | 01:36 |
| flwang | in our case, when user send the confirm request, he has already know, queue(topic), subscription id and the service URL(arn) | 01:37 |
| flwang | but in SNS, seems there is no subscription id in the request | 01:37 |
| flwang | wanghao: did you see my point? | 02:41 |
| flwang | wanghao: i mean, seems when the client send the request, it has known all the information the server returns | 02:41 |
| wanghao | flwang: yeah, I see. | 02:58 |
| flwang | wanghao: so that's my point :) | 02:59 |
| wanghao | flwang: emmm, okay, I'm fine with it. It's not necessary to return something. | 03:00 |
| wanghao | flwang: Spec will be updated soon. | 03:00 |
| flwang | wanghao: no no | 03:01 |
| flwang | that's just my concern/question | 03:01 |
| flwang | not sure if the others have different opinions | 03:02 |
| flwang | it's not a blocker | 03:02 |
| wanghao | flwang: Currently, I plan to return the queue name only, but it's already in request URL too. | 03:03 |
| wanghao | flwang: Maybe we can return somthing else, but I'm not sure now. | 03:04 |
| flwang | if user confirm again, what happened? | 03:04 |
| wanghao | flwang: just return 201 code in my mind. | 03:06 |
| wanghao | flwang: Did you think we can return some messages for this case? | 03:07 |
| openstackgerrit | wanghao proposed openstack/zaqar: [WIP]Subscription Confirmation Support for MongoDB https://review.openstack.org/316601 | 03:14 |
| flwang | wanghao: i'm not sure, since client know all the information, and the user just want to know if the confirmation is successful | 03:16 |
| wanghao | flwang: em, they'll know it from 200 code. | 03:18 |
| flwang | wanghao: yes | 03:18 |
| wanghao | flwang: i'm thinking response body may be useful in exception cases. | 03:18 |
| wanghao | flwang: just reutrn some exception message. | 03:19 |
| wanghao | flwang: as what we're doing in other API. | 03:19 |
| flwang | wanghao: possibly, i don't have too much reason to object having the resp body :) | 03:22 |
| wanghao | flwang: so my suggestion is there's no resp body if request is successful, and return some message for exception. | 03:24 |
| wanghao | flwang: like creation of queue | 03:24 |
| *** AAzza_ has joined #openstack-zaqar | 03:24 | |
| flwang | wanghao: ok, i'm good with that | 03:25 |
| *** AAzza has quit IRC | 03:28 | |
| wanghao | flwang: sure, I'll specify it in spec. | 03:28 |
| *** AAzza_ has quit IRC | 03:30 | |
| *** AAzza has joined #openstack-zaqar | 03:30 | |
| flwang | wanghao: awesome, thanks | 03:31 |
| wanghao | flwang: :) | 03:33 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: (redis)Fix the 503 error when get/delete messages https://review.openstack.org/328824 | 03:34 |
| openstackgerrit | wanghao proposed openstack/zaqar-specs: Subscription confirmation support https://review.openstack.org/284555 | 03:38 |
| *** flwang1 has joined #openstack-zaqar | 03:54 | |
| flwang1 | wanghao: can you help review this https://review.openstack.org/#/c/326704/ ? | 03:54 |
| wanghao | flwang1: Sure | 03:55 |
| openstackgerrit | wanghao proposed openstack/zaqar: Fix incorrect message when getting non-existing claim https://review.openstack.org/328826 | 04:00 |
| wanghao | flwang1: this patch is good to me. | 04:05 |
| flwang1 | wanghao: cool, thanks | 04:05 |
| wanghao | flwang1: Give +2 to this :) | 04:07 |
| openstackgerrit | Merged openstack/zaqar: Make queues lazy in subscriptions https://review.openstack.org/320749 | 04:09 |
| * wanghao lunch time | 04:17 | |
| *** flwang1 has quit IRC | 04:19 | |
| openstackgerrit | Merged openstack/zaqar: Add release notes https://review.openstack.org/326704 | 04:27 |
| *** rcernin has joined #openstack-zaqar | 06:14 | |
| *** rcernin has quit IRC | 06:18 | |
| *** rcernin has joined #openstack-zaqar | 06:19 | |
| *** tesseract has joined #openstack-zaqar | 07:00 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Adding Negative tests cases to Zaqar v2 https://review.openstack.org/319825 | 07:04 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar-ui: Imported Translations from Zanata https://review.openstack.org/328886 | 08:02 |
| *** flwang1 has joined #openstack-zaqar | 08:31 | |
| flwang1 | Eva-i: around? | 08:39 |
| flwang1 | wanghao: wxy: any topic you guys want to highlight on the weekly meeting? | 08:40 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: (redis)Fix the 503 error when get/delete messages https://review.openstack.org/328824 | 08:47 |
| wxy | flwang1: I guess the subscription confirm spec is almost ready for merge | 08:51 |
| flwang1 | wxy: yep, i'm going to approve it after wanghao addressed your comments | 08:51 |
| flwang1 | wxy: and pls +1 if you like it :) | 08:51 |
| flwang1 | wxy: your gate job patch has been merged :D | 08:52 |
| wxy | flwang1: :) | 08:53 |
| wxy | flwang1: next step for tempest is this one: https://review.openstack.org/#/c/319825/ | 08:53 |
| wxy | flwang1: some redis bugs need to be fixed first | 08:54 |
| flwang1 | wxy: add your topics here https://etherpad.openstack.org/p/zaqar-meeting-agenda | 08:55 |
| wxy | flwang1: OK | 08:56 |
| flwang1 | wxy: can you help cherry pick https://review.openstack.org/#/c/326710/ to mitaka and liberty? then i can approve it | 09:05 |
| wxy | flwang1: Sure, Will do it later. | 09:07 |
| flwang1 | thank you so much | 09:08 |
| *** pcaruana has joined #openstack-zaqar | 09:27 | |
| *** shu-mutou is now known as shu-mutou-AFK | 09:28 | |
| wxy | flwang1: https://review.openstack.org/#/c/328924/ https://review.openstack.org/#/c/328925/ | 09:39 |
| wxy | flwang1: these two | 09:39 |
| openstackgerrit | Neerja Narayan proposed openstack/zaqar: Adding Negative tests cases to Zaqar v2 https://review.openstack.org/319825 | 11:23 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Adding Negative tests cases to Zaqar v2 https://review.openstack.org/319825 | 11:45 |
| *** fesp has joined #openstack-zaqar | 11:52 | |
| *** fesp has quit IRC | 12:08 | |
| *** flaper87 has quit IRC | 12:09 | |
| *** flaper87 has joined #openstack-zaqar | 12:15 | |
| *** flaper87 has quit IRC | 12:15 | |
| *** flaper87 has joined #openstack-zaqar | 12:15 | |
| *** srwilkers has joined #openstack-zaqar | 13:22 | |
| *** srwilkers has quit IRC | 13:37 | |
| *** srwilkers has joined #openstack-zaqar | 13:57 | |
| *** mpanetta has joined #openstack-zaqar | 14:05 | |
| *** mpanetta has quit IRC | 14:06 | |
| *** mpanetta has joined #openstack-zaqar | 14:06 | |
| *** srwilkers has quit IRC | 14:12 | |
| *** AAzza_ has joined #openstack-zaqar | 14:25 | |
| *** srwilkers has joined #openstack-zaqar | 14:26 | |
| *** AAzza has quit IRC | 14:28 | |
| *** AAzza has joined #openstack-zaqar | 14:28 | |
| *** AAzza_ has quit IRC | 14:30 | |
| *** srwilkers has quit IRC | 14:48 | |
| *** mpanetta has quit IRC | 14:56 | |
| *** mpanetta has joined #openstack-zaqar | 14:58 | |
| *** srwilkers has joined #openstack-zaqar | 15:11 | |
| *** srwilkers has quit IRC | 15:27 | |
| *** tesseract has quit IRC | 15:39 | |
| *** rcernin has quit IRC | 15:59 | |
| *** rcernin has joined #openstack-zaqar | 16:30 | |
| *** rcernin has quit IRC | 16:35 | |
| *** rcernin has joined #openstack-zaqar | 16:36 | |
| *** pcaruana has quit IRC | 16:38 | |
| *** srwilkers has joined #openstack-zaqar | 17:02 | |
| *** srwilkers has quit IRC | 17:36 | |
| *** pcaruana has joined #openstack-zaqar | 17:39 | |
| flwang1 | reminder: we will have meeting after 15 mins :) | 17:43 |
| Eva-i | flwang1: hello | 17:56 |
| flwang1 | Eva-i: hi :) | 17:58 |
| flwang1 | Eva-i: what's your time now ? | 17:58 |
| Eva-i | flwang1: almost 21.00 | 17:59 |
| flwang1 | Eva-i: ah, nice time | 17:59 |
| Eva-i | flwang1: yes, the best | 17:59 |
| *** srwilkers has joined #openstack-zaqar | 18:04 | |
| *** tqtran has joined #openstack-zaqar | 18:35 | |
| *** srwilkers has quit IRC | 18:49 | |
| *** srwilkers has joined #openstack-zaqar | 18:53 | |
| *** tqtran has quit IRC | 19:11 | |
| flwang1 | Eva-i: vkmc: ryansb: flaper87: can you help review this one https://review.openstack.org/#/c/327296/ ? it's a little bit tricky | 19:42 |
| Eva-i | flwang1: I'm going to merge it | 19:44 |
| Eva-i | flwang1: I like it | 19:44 |
| vkmc | flwang1, Eva-i, agree with that... we got some queries about it in the past | 19:46 |
| *** flwang1 has quit IRC | 19:56 | |
| *** srwilkers has quit IRC | 20:08 | |
| openstackgerrit | Merged openstack/zaqar: Use debug instead of warning for pipeline implement error https://review.openstack.org/327296 | 20:10 |
| *** mpanetta_ has joined #openstack-zaqar | 20:17 | |
| *** mpanetta has quit IRC | 20:20 | |
| *** srwilkers has joined #openstack-zaqar | 20:22 | |
| *** srwilkers has quit IRC | 20:24 | |
| *** tqtran has joined #openstack-zaqar | 20:34 | |
| *** mpanetta_ has quit IRC | 20:37 | |
| *** mpanetta has joined #openstack-zaqar | 20:38 | |
| openstackgerrit | Merged openstack/python-zaqarclient: Ensure the float value of api version could work https://review.openstack.org/308736 | 21:04 |
| flwang | Eva-i: ping | 21:33 |
| *** flwang1 has joined #openstack-zaqar | 21:40 | |
| *** rcernin has quit IRC | 21:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/321737 | 21:55 |
| *** njohnston is now known as njohnston|afk | 21:55 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/322589 | 21:57 |
| Eva-i | flwang: pong | 22:45 |
| flwang | Eva-i: i saw the comments you left on the subscription confirmation spec | 22:59 |
| flwang | so i would like to discuss about the html page testing | 23:00 |
| flwang | because IMHO, even we host the html page, it's still hard to auto test it | 23:00 |
| Eva-i | flwang: okay | 23:01 |
| Eva-i | flwang: it will be easy for developer to manually test it | 23:03 |
| flwang | Eva-i: yes, and given it's a really simple page, so i don't really worry about the testing. we just need to add a NOTE for the confirmation part code to highlight that | 23:05 |
| flwang | when change the code, the contributor need to make sure the sample html page works | 23:06 |
| flwang | my 0.02 | 23:06 |
| Eva-i | flwang: okay, good. Still automatic testing is possible, if we put some extra efforts. | 23:07 |
| flwang | how? | 23:07 |
| Eva-i | flwang: for example by using http://www.seleniumhq.org/about/platforms.jsp#programming-languages | 23:09 |
| flwang | Eva-i: oh my god | 23:09 |
| flwang | i know selenium very well, since my wife is an automation tester, but | 23:09 |
| flwang | that's totally out of zaqar's scope IMHO | 23:10 |
| Eva-i | flwang: but manual testing of small page is still ok for me.. | 23:10 |
| Eva-i | flwang: okay, I trust you | 23:10 |
| flwang | Eva-i: sorry, i will insist on my opinion ;) | 23:10 |
| flwang | zaqar is a service not a website | 23:11 |
| flwang | we just need to make sure the api works | 23:11 |
| flwang | that said, we only need to cover the api testing | 23:11 |
| flwang | maybe I'm wrong, but i think if i'm wrong, the next PTL will fix my problem :D | 23:11 |
| Eva-i | flwang: it's okay, it's okay | 23:12 |
| Eva-i | flwang: this question doesn't bothers me | 23:12 |
| Eva-i | *bother | 23:12 |
| flwang | Eva-i: cool, but i really appreciate for your thoughts | 23:12 |
| flwang | Eva-i: you're doing a great job | 23:13 |
| flwang | when can we get a new install guide patchset? | 23:14 |
| Eva-i | flwang: I just wanted to hear wanghao's opinion again and maybe change your mind by making a comment about where to host the confirmation web page. | 23:14 |
| Eva-i | flwang: tonight | 23:14 |
| flwang | Eva-i: <3 | 23:15 |
| flwang | Eva-i: yep, sure, i will leave a comment | 23:15 |
| Eva-i | flwang: I made "installing on red hat" page, now I need to fill "verifying" page. | 23:15 |
| flwang | Eva-i: awesome | 23:21 |
| flwang | looking forward to review it :) | 23:21 |
| Eva-i | flwang: yes =) | 23:22 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!