| *** davideagnello has quit IRC | 00:02 | |
| *** davideagnello has joined #openstack-zaqar | 00:14 | |
| openstackgerrit | Merged openstack/python-zaqarclient: Remove pypy support https://review.openstack.org/290830 | 00:33 |
|---|---|---|
| flwang | flaper87: still around for some discussion? | 00:37 |
| Eva-i | flwang: hi again. I was writing a blog post, Now I'm finally going to write patch and review client's patches. | 00:44 |
| flwang | Eva-i: nice :) | 00:46 |
| *** shu-mutou-AFK is now known as shu-mutou | 01:00 | |
| tqtran | thanks guys the core nomination, i will only be using it for the zaqar-ui. all of your concerns are valid. If i do review zaqar patches, it will be +1/-1 only. | 02:41 |
| *** tqtran has quit IRC | 02:42 | |
| openstackgerrit | Shu Muto proposed openstack/zaqar-ui: Fix styles of table views https://review.openstack.org/290953 | 03:41 |
| *** shu-mutou is now known as shu-mutou-AFK | 03:43 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix cleanup in metadata putting test https://review.openstack.org/292699 | 03:53 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Validate PUT of reserved queue attributes metadata https://review.openstack.org/292702 | 04:00 |
| *** flwang1 has quit IRC | 04:05 | |
| *** wanghao has quit IRC | 04:44 | |
| *** wanghao has joined #openstack-zaqar | 04:45 | |
| *** tesseract has joined #openstack-zaqar | 07:13 | |
| *** tesseract is now known as Guest97519 | 07:13 | |
| *** itisha has joined #openstack-zaqar | 07:57 | |
| *** Guest97519 has quit IRC | 08:00 | |
| *** tesseract has joined #openstack-zaqar | 08:05 | |
| *** tesseract is now known as Guest91794 | 08:06 | |
| *** dynarro has joined #openstack-zaqar | 08:08 | |
| *** wanghao has quit IRC | 08:43 | |
| *** wanghao has joined #openstack-zaqar | 08:43 | |
| *** Guest91794 has quit IRC | 08:45 | |
| *** flwang1 has joined #openstack-zaqar | 08:51 | |
| *** Guest91794 has joined #openstack-zaqar | 08:59 | |
| flwang1 | flaper87: around? | 09:31 |
| *** rcernin has joined #openstack-zaqar | 09:31 | |
| *** dynarro has quit IRC | 09:34 | |
| *** itisha has quit IRC | 11:09 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted | 11:14 | |
| *** itisha has joined #openstack-zaqar | 11:17 | |
| -openstackstatus- NOTICE: Gerrit had to be restarted because was not responsive. As a consequence, some of the test results have been lost, from 08:30 UTC to 10:30 UTC approximately. Please recheck any affected jobs by this problem. | 11:34 | |
| -openstackstatus- NOTICE: Gerrit had to be restarted because was not responsive. As a consequence, some of the test results have been lost, from 09:30 UTC to 11:30 UTC approximately. Please recheck any affected jobs by this problem. | 11:37 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix update queue's metadata issue https://review.openstack.org/292843 | 12:02 |
| wxy | flaper87: ping | 12:06 |
| flaper87 | wxy: pong | 12:08 |
| wxy | flaper87: https://review.openstack.org/#/c/289179/5/tests/functional/queues/v1/test_queues.py | 12:09 |
| wxy | flaper87: If I move it to zaqarclient.tests.queues, the v2 functional test will get error. | 12:09 |
| wxy | because v2 based on v1.1 | 12:09 |
| wxy | flaper87: Do I miss something? and maybe the same with unit test. | 12:13 |
| flaper87 | wxy: gotcha, nvm then :) | 12:13 |
| flaper87 | wxy: no no, I mixed up some tests in my head | 12:13 |
| flaper87 | :) | 12:13 |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Fix the get/set queue metadata https://review.openstack.org/289179 | 12:14 |
| wxy | flaper87: and I add a message in v1.1 as you suggested. Please take a look if you're free. Thanks. :) | 12:20 |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Fix the get/set queue metadata https://review.openstack.org/289179 | 12:27 |
| *** amitgandhinz has joined #openstack-zaqar | 13:15 | |
| *** ig0r__ has joined #openstack-zaqar | 13:18 | |
| *** dynarro has joined #openstack-zaqar | 13:19 | |
| *** ig0r_ has quit IRC | 13:22 | |
| *** ametts has joined #openstack-zaqar | 14:00 | |
| *** wanghao has quit IRC | 14:01 | |
| *** wanghao has joined #openstack-zaqar | 14:02 | |
| *** Guest41345 has quit IRC | 14:03 | |
| *** Guest91794 has quit IRC | 14:31 | |
| *** david_cu has joined #openstack-zaqar | 14:48 | |
| *** ametts has quit IRC | 14:56 | |
| -openstackstatus- NOTICE: Launchpad OpenID SSO is currently experiencing issues preventing login. The Launchpad team is working on the issue | 14:59 | |
| *** ChanServ changes topic to "Launchpad OpenID SSO is currently experiencing issues preventing login. The Launchpad team is working on the issue" | 14:59 | |
| *** tesseract has joined #openstack-zaqar | 15:06 | |
| *** tesseract is now known as Guest71467 | 15:07 | |
| *** ChanServ changes topic to "OpenStack Queuing and Notification Service || Smile :D || Meetings every Monday @ 21:00 UTC/15:00 UTC || Wiki: https://wiki.openstack.org/wiki/Zaqar || Paste: http://paste.openstack.org/ || Send messages and make some noise :D" | 15:33 | |
| -openstackstatus- NOTICE: Launchpad SSO is back to normal - happy hacking | 15:33 | |
| *** itisha has quit IRC | 15:49 | |
| *** GB21 has joined #openstack-zaqar | 16:21 | |
| *** rcernin has quit IRC | 16:35 | |
| *** Guest71467 has quit IRC | 16:42 | |
| *** tqtran has joined #openstack-zaqar | 17:09 | |
| *** openstackgerrit has quit IRC | 17:14 | |
| *** openstackgerrit_ is now known as openstackgerrit | 17:14 | |
| *** openstackgerrit has quit IRC | 17:15 | |
| *** openstackgerrit_ has joined #openstack-zaqar | 17:15 | |
| *** openstackgerrit_ is now known as openstackgerrit | 17:16 | |
| *** openstackgerrit_ has joined #openstack-zaqar | 17:16 | |
| *** dynarro has quit IRC | 17:18 | |
| *** pcaruana has quit IRC | 17:24 | |
| *** pcaruana has joined #openstack-zaqar | 17:36 | |
| *** ametts has joined #openstack-zaqar | 17:38 | |
| *** david_cu has quit IRC | 17:49 | |
| *** david_cu has joined #openstack-zaqar | 17:49 | |
| *** david_cu has quit IRC | 17:54 | |
| *** david_cu has joined #openstack-zaqar | 18:09 | |
| *** flwang has quit IRC | 18:16 | |
| *** flwang has joined #openstack-zaqar | 18:29 | |
| *** GB21 has quit IRC | 18:34 | |
| openstackgerrit | Merged openstack/zaqar-ui: Fix styles of table views https://review.openstack.org/290953 | 19:02 |
| *** flwang1 has quit IRC | 19:03 | |
| *** ametts has quit IRC | 20:00 | |
| *** ig0r_ has joined #openstack-zaqar | 20:03 | |
| *** ametts has joined #openstack-zaqar | 20:04 | |
| *** ig0r__ has quit IRC | 20:06 | |
| flwang | flaper87: ping re queue's metadata | 20:30 |
| flaper87 | flwang: sup? | 20:31 |
| *** flwang1 has joined #openstack-zaqar | 20:31 | |
| flwang | flaper87: yesterday i mentioned the problem of queue's metadata and the PATCH usage error, but i didn't get any comments from you guys | 20:31 |
| flaper87 | flwang: oh, mmh. I could've sworn I replied | 20:32 |
| flaper87 | Maybe I commented on the patch? | 20:32 |
| * flaper87 shrugs | 20:32 | |
| flaper87 | is there even a patch? | 20:33 |
| flwang | flaper87: https://review.openstack.org/292843 | 20:33 |
| flwang | flaper87: i'm thinking if i should still add more shit on this or just workaround it now | 20:34 |
| flwang | i made a mistake when i fix the queue's metadata update issue | 20:34 |
| flwang | i just followed the same way we're using for pool update and flavor update | 20:34 |
| flaper87 | mmh, IIRC, this code is released and changing it means we'd be changing the API | 20:35 |
| flaper87 | but what's the problem again? | 20:35 |
| flwang | flaper87: yes, so that's why i would like to talk with you since you know some history | 20:35 |
| flwang | the PATCH usage for pool and flavor is not correct | 20:36 |
| flaper87 | because it replaces the whole document ? | 20:36 |
| flwang | yes | 20:36 |
| flwang | is there any special reason why we did that? | 20:36 |
| flwang | for pool and flavor | 20:36 |
| flaper87 | And queue's patch, instead, does the right thing. Right? | 20:36 |
| *** flwang1 has quit IRC | 20:37 | |
| flwang | no, queue's patch is doing the same thing which i would like to fix it now | 20:37 |
| flaper87 | mmh, but changing that breaks the API :/ | 20:38 |
| flaper87 | The only way I can see this done is by having both, PUT and PATCH | 20:38 |
| flwang | yes, i know. i'm wondering if i should just fix the queue's patch or fix all of them in Newton | 20:38 |
| flaper87 | (or POST, not sure) | 20:38 |
| flwang | or any other way works | 20:38 |
| flaper87 | Support both methods and fix the crap | 20:38 |
| flaper87 | That will still break the current API | 20:39 |
| flaper87 | mmhhh | 20:39 |
| flwang | flaper87: if i still fix queue's patch, why do we still break the API? we can release it in RC1 | 20:39 |
| flaper87 | flwang: wait, is that a code that hasn't been released? | 20:41 |
| flaper87 | I thought it had been released | 20:41 |
| flaper87 | (sorry, I'm jumping between this and the tc meeting) | 20:41 |
| flwang | flaper87: it's in M-3 | 20:42 |
| flaper87 | flwang: wait | 20:42 |
| flwang | which i want to fix it in RC1 | 20:42 |
| flwang | but we have released the client :( | 20:42 |
| flaper87 | flwang: my question is: Has the queue PATCH endpoint been releaed already? | 20:42 |
| flaper87 | I'd say, fix the server if the API has not been released. Is it going to break the client? I don't think so | 20:43 |
| flwang | define 'released'? we added it in Mitaka, so technically, we haven't released it | 20:43 |
| flaper87 | flwang: that's what I wanted to know | 20:43 |
| flaper87 | :) | 20:43 |
| flwang | it will break the client i think | 20:43 |
| flaper87 | Let's fix it | 20:43 |
| flaper87 | flwang: mmh, why? | 20:43 |
| flwang | brb | 20:44 |
| Eva-i | flwang: hello | 20:52 |
| *** akanksha_ has joined #openstack-zaqar | 20:52 | |
| flwang | Eva-i: hi | 20:56 |
| Eva-i | flwang: so before RC1 you are going to remove this https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/queues.py#L141 and look if metadata things will not break in the client? I'm okay with it. In Newton we can make our PATCH and PUT methods right. | 20:56 |
| flwang | flaper87: sorry was in standup meeting | 20:56 |
| flaper87 | flwang: np | 20:57 |
| flwang | Eva-i: that's the current plan, but i'm discussing with flaper87to figure out what's the proper way | 20:57 |
| Eva-i | flwang: oki | 20:57 |
| flwang | flaper87: that because the way of patch is post something like [{'op': 'add', 'path': '/mykey', 'value': 'foo'}] | 20:58 |
| flwang | flaper87: can you see my point? | 20:58 |
| *** flwang1 has joined #openstack-zaqar | 20:58 | |
| flwang | but for current implement, the body is just the metdata dict | 20:59 |
| flwang | so i'm thinking if it's a bad idea if we support both format in mitaka and remove the wrong one in newton | 20:59 |
| flwang | that said zaqar server can accept both body format | 21:00 |
| flwang | and in newton, we can release another version for client to get a smooth migration | 21:00 |
| flwang1 | i know it's a ugly :( | 21:01 |
| flaper87 | flwang1: we can fix both | 21:10 |
| flwang1 | what do you mean fix both? in Mitaka? | 21:11 |
| flaper87 | flwang1: sure... Fix the server, fix the client. Backport the client patch to mitaka and release the minor version with the fix | 21:12 |
| flaper87 | Or, again, we support both but it still requires a change in the client | 21:12 |
| flwang1 | flaper87: do you think support both body is a bad idea? if it's not too bad, i prefer this one, since it won't introduce an urgent client fix | 21:13 |
| flwang1 | flaper87: thoughts? | 21:13 |
| *** jtomasek has quit IRC | 21:16 | |
| flaper87 | flwang1: why doesn't it require a client fix? Isn't the client using PATCH ? | 21:16 |
| flaper87 | flwang1: can you point me to the original patches? | 21:17 |
| flaper87 | flwang1: both server and client | 21:17 |
| flaper87 | please :D | 21:17 |
| *** jtomasek has joined #openstack-zaqar | 21:18 | |
| flwang1 | flaper87: sure, in a meeting, maybe slow | 21:21 |
| flwang1 | server side : https://review.openstack.org/#/c/280941/ | 21:22 |
| *** amitgandhinz has quit IRC | 21:26 | |
| flwang1 | flaper87: client side https://review.openstack.org/288073 | 21:27 |
| *** jtomasek has quit IRC | 21:28 | |
| *** pcaruana has quit IRC | 21:38 | |
| flaper87 | flwang1: AFICT, either way requires a new client release | 21:43 |
| flwang1 | flaper87: if so, how about let's fix it with the right way, the correct patch usage? | 21:44 |
| flaper87 | flwang1: ++ | 21:45 |
| flwang1 | flaper87: btw, are you happy we're still playing with queue and queue's metadata? i know you're not a big fan of queue :) | 21:45 |
| flaper87 | I'm not and I hope you appreciate the fact that I didn't start ranting about this | 21:45 |
| flaper87 | hahahahaha | 21:45 |
| flwang1 | glad it's confirmed again :D | 21:48 |
| flwang1 | anyway, i'm going to fix it today and i'm looking for a quick review :) | 21:49 |
| flaper87 | sounds good | 21:50 |
| *** pcaruana has joined #openstack-zaqar | 21:52 | |
| flwang1 | flaper87: thank you for the feedback, man | 21:54 |
| openstackgerrit | David Cusatis proposed openstack/zaqar-ui: Add Subscriptions to Queue drawer https://review.openstack.org/284921 | 22:00 |
| Eva-i | flwang1: you are going to implement the correct PATCH method, right? You mean patch request bodies will look like described in this document: http://tools.ietf.org/html/rfc6902 ? | 22:06 |
| flwang1 | Eva-i: yes | 22:06 |
| Eva-i | flwang1: oh. I hope it will be not too hard. | 22:07 |
| *** david_cu has quit IRC | 22:07 | |
| flwang1 | Eva-i: hope so, if you can help me on the client side, it would be great | 22:08 |
| Eva-i | flwang1: I'm not sure I'll be able to help before looking at zaqar server patch. | 22:09 |
| flwang | Eva-i: ok | 22:09 |
| *** flwang1 has quit IRC | 22:12 | |
| *** flwang1 has joined #openstack-zaqar | 22:12 | |
| *** mpanetta has quit IRC | 22:13 | |
| *** david-lyle has quit IRC | 22:13 | |
| Eva-i | flwang1: flwang: hm, do you know where vkmc could be? | 22:17 |
| flwang1 | Eva-i: no idea, sorry | 22:18 |
| Eva-i | flwang1: hope she's okay | 22:19 |
| flwang | Eva-i: i'm looking for her too | 22:19 |
| flwang | for some trove questions | 22:19 |
| *** shakamunyi has joined #openstack-zaqar | 22:32 | |
| *** GB21 has joined #openstack-zaqar | 22:54 | |
| *** ametts has quit IRC | 23:29 | |
| *** akanksha_ has quit IRC | 23:47 | |
| *** tqtran is now known as tqtran-afk | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!