Monday, 2016-02-29

*** csoukup has quit IRC00:07
*** amitgandhinz has quit IRC00:08
flwangvkmc: ping00:37
flwangryansb: are you working on the client patch for metadata update?00:40
*** achanda has quit IRC01:00
*** amitgandhinz has joined #openstack-zaqar01:04
*** amitgandhinz has quit IRC01:17
*** achanda has joined #openstack-zaqar02:10
*** amitgandhinz has joined #openstack-zaqar02:14
*** achanda has quit IRC02:14
*** achanda has joined #openstack-zaqar02:15
openstackgerritMerged openstack/zaqar: Fix the tempest test error  https://review.openstack.org/28346602:18
*** achanda has quit IRC02:22
*** amitgandhinz has quit IRC02:27
flwangEva-i: ping02:36
flwangEva-i: what's the race-condition issue you mentioned at https://review.openstack.org/#/c/265723/7/zaqar/transport/wsgi/v2_0/messages.py ?02:36
openstackgerritFei Long Wang proposed openstack/zaqar: Fix the TTL issue of subscriptions for Redis  https://review.openstack.org/27654802:37
*** mdnadeem has joined #openstack-zaqar02:43
*** mdnadeem_ has quit IRC02:46
*** boris-42 has joined #openstack-zaqar02:50
*** mdnadeem has quit IRC02:54
*** mdnadeem has joined #openstack-zaqar02:55
*** mdnadeem has quit IRC02:57
*** mdnadeem has joined #openstack-zaqar02:57
wxyHi, guys. Please review the bp if you get time : https://review.openstack.org/#/c/284555/    I'd like to start to code ASAP. Thanks02:59
flwangwxy: i'm reading this 'Yes, your opinion is a option, but single resource could be managed  standalone, we can make querying to know how much subscription is  waiting to be confirmed and from security point, subscription will be  expire if user's endpoint don't confirm it in time(that's why we set ttl  here).'03:07
flwangwe can make querying to know how much subscription is  waiting to be confirmed and from security point03:07
flwangso what's the potential security issue?03:07
wxyI guess that if we use Subscription resource to confirm, we should give subscriber a token,  But the subscriber  could use the token to do anything.03:12
wxyflwang: Is that security issue?03:14
flwangwxy: i can see the point now03:16
flwangthinking03:17
flwangwxy: is SNS using a separate endpoint?03:23
*** amitgandhinz has joined #openstack-zaqar03:24
wxyflwang: TBH, I don't know.03:27
wxyBut it send a token to the SNS03:28
openstackgerritMerged openstack/zaqar: Add tempest test for v1.1  https://review.openstack.org/28390603:30
openstackgerritMerged openstack/zaqar: Add tempest test for wsgi v2  https://review.openstack.org/28401603:31
wxyflwang: The url is like: https://sns.us-west-2.amazonaws.com/?Action=ConfirmSubscription&TopicArn=arn:aws:sns:us-west-2:123456789012:MyTopic&Token=2336412f37fb687f5d51e6e203:31
wxySo we can see Action=ConfirmSubscription03:31
wxyDoes it mean a  separate endpoint? Or AMAZON has a way to distinguish the token?03:33
flwangi will like to do some investigation and get ryansb's opinion about this03:35
flwangwxy: so pls hold a bit :)03:35
therveflwang, Are the tempest tests actually run anywhere? Just saw the patches go in03:35
flwangtherve: no, we're not using it for gate yet03:36
flwangtherve: i would like to use the tempest test as a gate job in Newton03:36
therveThat's... unfortunate03:36
flwangtherve: yep, we should use it03:36
flwangmdnadeem: ping03:37
*** amitgandhinz has quit IRC03:37
*** achanda has joined #openstack-zaqar03:37
flwangtherve: btw, what's your timezone?03:38
therveWish I knew03:38
flwangtherve: whahaha03:38
wxyflwang: Yes, I'd like to know his opinion.  You could bring it up if he is online.03:38
flwangwxy: sure03:38
therveflwang, Also is the client release in the works?03:40
flwangtherve: yes, i'm waiting for several patches before propose a release03:41
therveMokay03:41
flwangtherve: the top 5 https://review.openstack.org/#/q/project:openstack/python-zaqarclient+status:open03:42
flwangtherve: sorry for the delay03:42
*** achanda has quit IRC03:42
therveNo worries03:45
*** achanda has joined #openstack-zaqar03:49
mdnadeemflwang: pong03:54
*** achanda has quit IRC03:55
flwangmdnadeem: can you rebase https://review.openstack.org/266808 and https://review.openstack.org/266822 ?03:56
flwangmdnadeem: seems you're very busy recently?03:56
mdnadeemflwang, yah sure, i will03:56
flwangmdnadeem: thank you so much03:56
mdnadeemflwang, welcome :)03:57
flwangmdnadeem: are you busy for some internal stuff?03:57
flwangmdnadeem: can't see you around recently03:57
mdnadeemflwang, yes, Project get change from company side, however i still like to contribute in zaqar03:59
flwangmdnadeem: awesome :) thank you!!!03:59
openstackgerritMD NADEEM proposed openstack/python-zaqarclient: Update pool on pool create if it exists  https://review.openstack.org/26680804:00
openstackgerritMD NADEEM proposed openstack/python-zaqarclient: Update flavor on flavor create if it exists  https://review.openstack.org/26682204:00
*** flwang1 has quit IRC04:02
*** itisha has joined #openstack-zaqar04:03
*** david-lyle has joined #openstack-zaqar04:13
*** amitgandhinz has joined #openstack-zaqar04:34
*** david-lyle has quit IRC04:36
*** amitgandhinz has quit IRC04:47
*** david-lyle has joined #openstack-zaqar04:50
*** achanda has joined #openstack-zaqar04:55
*** david-lyle has quit IRC04:56
*** achanda has quit IRC05:01
*** exploreshaifali has joined #openstack-zaqar05:27
*** exploreshaifali has quit IRC05:34
*** amitgandhinz has joined #openstack-zaqar05:44
*** amitgandhinz has quit IRC05:57
*** exploreshaifali has joined #openstack-zaqar05:58
*** achanda has joined #openstack-zaqar05:58
*** achanda has quit IRC06:02
*** achanda has joined #openstack-zaqar06:11
*** rcernin has joined #openstack-zaqar06:44
*** rcernin has quit IRC06:49
*** amitgandhinz has joined #openstack-zaqar06:54
*** neerja has joined #openstack-zaqar07:00
*** amitgandhinz has quit IRC07:08
*** exploreshaifali has quit IRC07:24
*** rcernin has joined #openstack-zaqar07:24
*** pcaruana has joined #openstack-zaqar07:43
*** amitgandhinz has joined #openstack-zaqar08:04
*** neerja has quit IRC08:06
*** jtomasek has joined #openstack-zaqar08:07
*** amitgandhinz has quit IRC08:17
*** exploreshaifali has joined #openstack-zaqar08:18
*** achanda has quit IRC08:26
*** AAzza has quit IRC08:27
*** exploreshaifali has quit IRC08:28
*** rcernin has quit IRC08:29
*** AAzza has joined #openstack-zaqar08:34
*** achanda has joined #openstack-zaqar08:37
*** rcernin has joined #openstack-zaqar08:37
*** exploreshaifali has joined #openstack-zaqar08:44
*** flwang1 has joined #openstack-zaqar08:46
flwang1vkmc: ping08:47
flwang1Eva-i: ping08:47
*** achanda has quit IRC09:08
*** achanda has joined #openstack-zaqar09:12
*** amitgandhinz has joined #openstack-zaqar09:14
Eva-iflwang1: hello, I'm here09:24
flwang1Eva-i: hi :)09:24
flwang1Eva-i: would you mind explaining the comment at https://review.openstack.org/#/c/265723/7/zaqar/transport/wsgi/v2_0/messages.py ?09:25
*** amitgandhinz has quit IRC09:27
Eva-iflwang1: oki. Here's "on_post" method in CollectionResource class in messages.py. We have only one instance of CollectionResource in instance of Zaqar. If it's possible to run "on_post" method two or more times simultaneously, there will be a race condition problem, becase in this method we change CollectionResource instance's variable. But seems like nothing to worry about: "on_post" method will not ever run two times or more simultaneously.09:40
flwang1Eva-i: but no matter it run how many times, the logic will change the value09:41
flwang1am i missing anything?09:41
Eva-iflwang1: what do you mean?09:42
flwang1Eva-i: i mean i can't see the race condition09:43
flwang1therve: ping09:43
Eva-iflwang1: TLDR: your code is okay if "on_post" method can't be executed simultaneously.09:43
therveflwang1, Yes09:44
therveFor future reference https://blogs.gnome.org/markmc/2014/02/20/naked-pings/09:44
Eva-iflwang1: oki, I can show you where race condition could be, if "on_post" method was able to executed two times or more simultaneously.09:44
flwang1therve: sorry, i should say ping, re https://review.openstack.org/#/c/265723/7/zaqar/transport/wsgi/v2_0/messages.py09:44
flwang1therve: can you see any race condition issue based on the new change?09:45
therveLet's see09:45
flwang1therve: thanks09:45
therveflwang1, That probably works, but it's just bad design09:53
Eva-iflwang1: So if "on_post" method could be run simultaneously two times or more. Imagine there are two requests sent simultaneously to Zaqar: first request for posting message to a normal queue. Second request is same, but the queue has  '_default_message_ttl' attribute. So the first request comes and "self._message_post_spec" instance variable gets server config's default ttl (L182). But before the variable gets passed to L199, second request c09:53
*** achanda has quit IRC09:53
*** boris-42 has quit IRC09:54
therveThere is no reason for message_post_spec to be a instance variable anymore09:54
therveThat could potentially be an issue if we have a multi-threaded wsgi container09:54
therveThough other problems would appear I suspect09:55
Eva-iI don't think we will have a problem with multi-threaded wsgi container, because instances of Zaqar will be separated and have their own CollectionResource objects.09:55
Eva-itherve: +1, I don't like how it looks either.09:56
Eva-ithis can be done without assigning new value to "self._message_post_spec"09:57
therveRight it feels fairly uncontroversial to me :)09:58
flwang1so how about let's just use a internal variable?09:58
therveYeah that's the point, just remove the self09:58
flwang1Eva-i: which comment is the -1 coming from?10:00
Eva-iflwang1: here: https://review.openstack.org/#/c/265723/7/zaqar/tests/unit/transport/wsgi/v2_0/test_validation.py10:00
flwang1the typo, right?10:00
Eva-iflwang1: ah. yes, and the typo. So -1 is comes from not properly cleaned test and from typo.10:01
Eva-iflwang1: we need to merge this patch today, right?10:03
flwang1got10:03
flwang1in this week10:03
flwang1by Fir10:04
flwang1Fri10:04
Eva-iflwang1: I'm sure we will merge it until Friday. If it will be not ready, we can force it's merging and then fix bugs.10:04
flwang1Eva-i: correct :)10:04
*** amitgandhinz has joined #openstack-zaqar10:24
*** flwang1 has quit IRC10:26
*** amitgandhinz has quit IRC10:37
*** flaper87 has quit IRC10:56
*** flaper87 has joined #openstack-zaqar10:56
*** exploreshaifali has quit IRC11:06
*** achanda has joined #openstack-zaqar11:24
*** achanda has quit IRC11:29
*** amitgandhinz has joined #openstack-zaqar11:33
*** exploreshaifali has joined #openstack-zaqar11:47
*** amitgandhinz has quit IRC11:47
*** khushbu_ has joined #openstack-zaqar11:57
-openstackstatus- NOTICE: Infra currently has a long backlog. Please be patient and where possible avoid rechecks while it catches up.12:07
*** khushbu_ has quit IRC12:13
*** achanda has joined #openstack-zaqar12:26
*** achanda has quit IRC12:30
*** exploreshaifali has quit IRC12:38
*** wanghao has quit IRC12:41
*** wanghao has joined #openstack-zaqar12:42
*** amitgandhinz has joined #openstack-zaqar12:43
*** pcaruana has quit IRC12:53
*** amitgandhinz has quit IRC12:57
*** exploreshaifali has joined #openstack-zaqar12:58
*** wanghao has quit IRC13:07
*** wanghao has joined #openstack-zaqar13:08
*** pcaruana has joined #openstack-zaqar13:08
*** exploreshaifali has quit IRC13:28
*** achanda has joined #openstack-zaqar13:53
*** malini has joined #openstack-zaqar13:56
*** malini1 has joined #openstack-zaqar13:58
*** AAzza has quit IRC14:00
*** venkat has joined #openstack-zaqar14:00
*** venkat has quit IRC14:00
*** malini has quit IRC14:01
*** Eva-i has quit IRC14:04
*** Eva-i has joined #openstack-zaqar14:09
*** achanda has quit IRC14:13
*** AAzza has joined #openstack-zaqar14:15
*** boris-42 has joined #openstack-zaqar14:16
*** sriram has joined #openstack-zaqar14:27
*** sriram has quit IRC14:27
*** malini1 has quit IRC14:32
*** pt_15 has joined #openstack-zaqar14:34
*** pcaruana has quit IRC14:38
*** ametts has joined #openstack-zaqar14:42
*** amitgandhinz has joined #openstack-zaqar14:49
*** wanghao has quit IRC14:51
*** wanghao has joined #openstack-zaqar14:51
*** pcaruana has joined #openstack-zaqar14:52
*** khushbu has joined #openstack-zaqar15:10
*** khushbu_ has joined #openstack-zaqar15:11
*** AAzza has quit IRC15:33
*** sriram has joined #openstack-zaqar15:49
*** AAzza has joined #openstack-zaqar16:01
*** rcernin has quit IRC16:16
*** pcaruana has quit IRC16:17
*** ametts has quit IRC16:24
*** jtomasek has quit IRC16:34
Eva-iOh, seems like we missed the meeting...17:04
*** exploreshaifali has joined #openstack-zaqar17:05
*** mpanetta has joined #openstack-zaqar17:09
*** boris-42 has quit IRC17:14
*** openstackgerrit has quit IRC17:18
*** openstackgerrit has joined #openstack-zaqar17:18
*** david-lyle has joined #openstack-zaqar17:30
*** wanghao has quit IRC17:32
*** wanghao has joined #openstack-zaqar17:34
*** csoukup has joined #openstack-zaqar17:35
*** davideagnello has joined #openstack-zaqar17:40
openstackgerritDavid Cusatis proposed openstack/zaqar-ui: Add Subscriptions to Queue drawer  https://review.openstack.org/28492117:41
*** wanghao has quit IRC17:45
*** wanghao has joined #openstack-zaqar17:46
*** achanda has joined #openstack-zaqar17:47
*** exploreshaifali has quit IRC17:54
*** david-lyle has quit IRC17:55
*** david-lyle_ has joined #openstack-zaqar17:55
*** achanda has quit IRC18:04
*** boris-42 has joined #openstack-zaqar18:30
*** flwang1 has joined #openstack-zaqar18:36
*** flwang1 has quit IRC18:42
*** khushbu has quit IRC18:52
*** khushbu_ has quit IRC18:52
*** ametts has joined #openstack-zaqar18:54
*** malini has joined #openstack-zaqar18:57
openstackgerritAndreas Jaeger proposed openstack/python-zaqarclient: Remove unused pngmath Sphinx extension  https://review.openstack.org/28621918:58
openstackgerritAndreas Jaeger proposed openstack/zaqar: Remove unused pngmath Sphinx extension  https://review.openstack.org/28622519:00
*** malini1 has joined #openstack-zaqar19:01
openstackgerritAndreas Jaeger proposed openstack/zaqar-ui: Remove unused pngmath Sphinx extension  https://review.openstack.org/28622719:01
*** malini has quit IRC19:04
*** pt_15 has quit IRC19:12
*** pt_15 has joined #openstack-zaqar19:14
*** ametts has quit IRC19:27
*** khushbu__ has joined #openstack-zaqar19:30
*** khushbu___ has joined #openstack-zaqar19:31
*** achanda has joined #openstack-zaqar19:47
*** achanda has quit IRC19:57
*** amitgandhinz has quit IRC20:03
*** amitgandhinz has joined #openstack-zaqar20:05
*** achanda has joined #openstack-zaqar20:11
*** david-lyle_ is now known as david-lyle20:12
*** exploreshaifali has joined #openstack-zaqar20:18
*** flwang1 has joined #openstack-zaqar20:23
flwangdid we have a meeting ?20:32
vkmcwe didn't20:32
flwangvkmc: oh, you're around20:32
vkmcI am20:32
Eva-iflwang: we can do it20:32
flwangvkmc: could we meet after 30mins?20:33
Eva-iflwang: vkmc: hello20:33
vkmcsure20:33
flwangvkmc: https://review.openstack.org/280941 https://review.openstack.org/269398 pls help review20:33
vkmcflwang, yes, I'm on it... had been struggling with a few things in the env20:33
*** malini1 has left #openstack-zaqar20:33
flwangvkmc: cool, thanks20:34
flwangvkmc: https://review.openstack.org/266808 and this20:35
vkmcI'm currently reviewing https://review.openstack.org/#/c/283838/20:35
*** exploreshaifali has quit IRC20:39
*** pt_15 has quit IRC20:45
*** itisha has quit IRC20:49
flwangare you guys ok for a meeting after 2 mins in zaqar channel?20:58
flwangi'm thining proposing a new meeting time after summit20:58
Eva-iyes21:01
Eva-iI'm ready21:01
flwang#startmeeting zaqar21:02
openstackMeeting started Mon Feb 29 21:02:12 2016 UTC and is due to finish in 60 minutes.  The chair is flwang. Information about MeetBot at http://wiki.debian.org/MeetBot.21:02
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.21:02
openstackThe meeting name has been set to 'zaqar'21:02
flwangi don't have much topics today21:02
flwangso feel free raise your hand and insert your topics21:02
flwang#topic code review21:02
Eva-ioki21:02
vkmco/21:02
vkmc:)21:02
Eva-io/21:03
flwangthis week is the M-3 final days21:03
flwangso let's focus on code review21:03
*** davideagnello has quit IRC21:03
flwangwe have some good patches need to be merged21:04
Eva-iflwang: I'm going to review your redis subscription TTL patch today21:04
*** davideagnello has joined #openstack-zaqar21:04
flwangEva-i: awesome21:04
flwanghttps://review.openstack.org/270464   mongo TTL subscription21:05
flwanghttps://review.openstack.org/276548 redis subscriptoin TTL21:05
vkmcreviewing21:06
flwangmore attributes of queue https://review.openstack.org/26572321:07
Eva-ihttps://review.openstack.org/280941 Support metadata update issue for v1.1 and v221:08
Eva-igoing to review this as well21:08
flwanghttps://review.openstack.org/273931 "group" word should be used instead "pool"21:08
Eva-ithat's a big patch21:11
*** AAzza has quit IRC21:11
vkmcyeah21:11
*** khushbu__ has quit IRC21:13
*** khushbu___ has quit IRC21:13
*** AAzza has joined #openstack-zaqar21:13
Eva-ianything else?21:14
flwangno, actually, you can just review all the opening patch on the top21:15
flwangthose are we want to merge :)21:15
*** tqtran has joined #openstack-zaqar21:15
*** amitgandhinz has quit IRC21:15
Eva-iyes, I'm going to fix my two patches and then review these all21:15
Eva-iI don't have topics to propose today21:16
*** sriram has quit IRC21:16
*** ametts has joined #openstack-zaqar21:22
flwangsorry, in another meeting21:23
flwangso let's focus on code review and the M-3 stuff this week21:23
Eva-iflwang: alright, though I really want to fix my patches first =)21:23
flwangEva-i: haha, cool21:24
flwangany other topic?21:25
flwangi think this could be short meeting?21:25
Eva-iyes21:25
flwangvkmc: ^21:26
vkmcyes21:27
vkmc!21:28
vkmcI'm with reviews and other stuff21:28
vkmclet's focus on reviewing for M3 this week21:28
vkmcFF is coming21:28
flwangvkmc: cool, thanks21:29
flwang#endmeeting21:29
openstackMeeting ended Mon Feb 29 21:29:48 2016 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)21:29
openstackMinutes:        http://eavesdrop.openstack.org/meetings/zaqar/2016/zaqar.2016-02-29-21.02.html21:29
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/zaqar/2016/zaqar.2016-02-29-21.02.txt21:29
openstackLog:            http://eavesdrop.openstack.org/meetings/zaqar/2016/zaqar.2016-02-29-21.02.log.html21:29
*** davideagnello has quit IRC21:32
*** tqtran has quit IRC21:34
*** davideagnello has joined #openstack-zaqar21:34
*** amitgandhinz has joined #openstack-zaqar21:36
flwangEva-i: are you going to update this https://review.openstack.org/#/c/282114/ ?21:41
Eva-iflwang: oh, yes, thanks for reminder21:42
openstackgerritEva Balycheva proposed openstack/python-zaqarclient: Make TransportErrors more descriptive  https://review.openstack.org/28211421:44
Eva-iflwang: okay, I fixed it21:44
openstackgerritMerged openstack/zaqar-ui: Ability to delete queues  https://review.openstack.org/28508321:45
flwangEva-i: thanks a lot21:46
flwangryansb: around? are you working on the patch for metadata update on client side?21:46
ryansbflwang: yeah, I'll be posting that tomorrow21:56
*** tqtran has joined #openstack-zaqar21:56
*** ametts has quit IRC21:56
flwangryansb: cool, thanks21:59
openstackgerritMerged openstack/zaqar-ui: Remove unused pngmath Sphinx extension  https://review.openstack.org/28622722:03
*** tqtran has quit IRC22:09
*** tqtran has joined #openstack-zaqar22:09
*** ametts has joined #openstack-zaqar22:21
*** tqtran has quit IRC22:22
*** tqtran has joined #openstack-zaqar22:23
*** ametts has quit IRC22:27
openstackgerritMerged openstack/zaqar: Fix validation in websocket unit tests  https://review.openstack.org/28383822:28
*** tqtran has left #openstack-zaqar22:31
openstackgerritMerged openstack/python-zaqarclient: Remove unused pngmath Sphinx extension  https://review.openstack.org/28621922:32
*** tqtran has joined #openstack-zaqar22:39
*** achanda has quit IRC22:54
*** amitgandhinz has quit IRC22:55
*** achanda has joined #openstack-zaqar23:08
*** mpanetta has quit IRC23:15
openstackgerritThai Tran proposed openstack/zaqar-ui: Removed batch action service  https://review.openstack.org/28632123:35
*** kgriffs is now known as kgriffs|afk23:41
*** csoukup has quit IRC23:55
*** tqtran has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!