| *** csoukup has joined #openstack-zaqar | 01:12 | |
| *** achanda has quit IRC | 01:13 | |
| *** csoukup has quit IRC | 01:14 | |
| *** achanda has joined #openstack-zaqar | 01:17 | |
| *** achanda has quit IRC | 01:20 | |
| *** david-lyle has joined #openstack-zaqar | 01:23 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix 500 error when create pools in wsgi v2. https://review.openstack.org/274537 | 02:02 |
|---|---|---|
| *** kgriffs is now known as kgriffs|afk | 02:08 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Get non-existing queue should return 200 https://review.openstack.org/280473 | 02:15 |
| *** pt_15_ has quit IRC | 02:35 | |
| *** itisha has quit IRC | 02:37 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix 500 error when create pools in wsgi v2. https://review.openstack.org/274537 | 02:37 |
| *** flwang1 has quit IRC | 03:56 | |
| *** david-lyle has quit IRC | 04:03 | |
| *** achanda has joined #openstack-zaqar | 04:48 | |
| wanghao | flwang: ping | 04:50 |
| wanghao | flwang: hi felong, I noticed client patch(https://review.openstack.org/#/c/276603/) merged failed since the 'pool_group' was unexpected, but we need to merge this first and then server side. Do you have any suggestion about this situation? | 04:53 |
| *** david-lyle has joined #openstack-zaqar | 04:55 | |
| *** achanda has quit IRC | 06:39 | |
| *** david-lyle has quit IRC | 06:39 | |
| *** david-lyle has joined #openstack-zaqar | 06:41 | |
| *** GB21 has joined #openstack-zaqar | 06:43 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Ensure hmget return right data format https://review.openstack.org/280517 | 06:43 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Ensure hmget return right data format https://review.openstack.org/280517 | 06:46 |
| *** achanda has joined #openstack-zaqar | 06:59 | |
| *** rcernin has joined #openstack-zaqar | 07:37 | |
| *** GB21 has quit IRC | 07:40 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Get non-existing queue should return 200 https://review.openstack.org/280473 | 07:45 |
| *** kragniz has quit IRC | 07:46 | |
| *** kragniz has joined #openstack-zaqar | 07:46 | |
| *** GB21 has joined #openstack-zaqar | 08:41 | |
| *** JAHoagie has joined #openstack-zaqar | 08:55 | |
| *** achanda has quit IRC | 09:03 | |
| *** achanda has joined #openstack-zaqar | 09:06 | |
| openstackgerrit | wanghao proposed openstack/zaqar: Update operation should return updated result https://review.openstack.org/280563 | 09:24 |
| *** achanda has quit IRC | 09:28 | |
| *** dynarro has joined #openstack-zaqar | 09:39 | |
| *** GB21 has quit IRC | 10:08 | |
| *** GB21 has joined #openstack-zaqar | 10:09 | |
| *** GB21 has quit IRC | 10:24 | |
| *** GB21 has joined #openstack-zaqar | 10:26 | |
| *** GB21 has quit IRC | 10:33 | |
| *** dynarro has quit IRC | 10:45 | |
| *** GB21 has joined #openstack-zaqar | 10:47 | |
| *** GB21 has quit IRC | 11:25 | |
| *** achanda has joined #openstack-zaqar | 11:28 | |
| *** achanda has quit IRC | 11:34 | |
| *** GB21 has joined #openstack-zaqar | 11:45 | |
| *** Qiming has joined #openstack-zaqar | 11:46 | |
| *** GB21 has quit IRC | 12:02 | |
| *** Qiming has quit IRC | 12:08 | |
| *** Qiming has joined #openstack-zaqar | 12:12 | |
| *** Qiming has quit IRC | 12:17 | |
| *** pcaruana has joined #openstack-zaqar | 12:18 | |
| *** achanda has joined #openstack-zaqar | 12:31 | |
| *** achanda has quit IRC | 12:37 | |
| *** boris-42 has joined #openstack-zaqar | 12:56 | |
| *** vkmc_ has joined #openstack-zaqar | 13:04 | |
| *** JAHoagie has quit IRC | 14:02 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:04 | |
| *** JAHoagie has joined #openstack-zaqar | 14:07 | |
| *** sriram has joined #openstack-zaqar | 14:08 | |
| *** dynarro has joined #openstack-zaqar | 14:13 | |
| *** mpanetta has joined #openstack-zaqar | 14:21 | |
| *** itisha has joined #openstack-zaqar | 14:25 | |
| *** amitgandhinz has quit IRC | 14:32 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:33 | |
| *** achanda has joined #openstack-zaqar | 14:35 | |
| *** achanda has quit IRC | 14:40 | |
| *** kgriffs|afk is now known as kgriffs | 14:44 | |
| *** ametts has joined #openstack-zaqar | 14:51 | |
| *** JAHoagie has quit IRC | 15:15 | |
| *** vkmc_ has quit IRC | 15:20 | |
| *** malini has joined #openstack-zaqar | 15:21 | |
| *** flwang1 has joined #openstack-zaqar | 15:49 | |
| *** malini has quit IRC | 15:59 | |
| *** malini has joined #openstack-zaqar | 16:04 | |
| *** pcaruana has quit IRC | 16:18 | |
| *** boris-42 has quit IRC | 16:34 | |
| *** pt_15_ has joined #openstack-zaqar | 16:34 | |
| *** rcernin has quit IRC | 16:37 | |
| *** achanda has joined #openstack-zaqar | 16:38 | |
| *** achanda has quit IRC | 16:44 | |
| *** rcernin has joined #openstack-zaqar | 17:09 | |
| *** flwang1 has quit IRC | 17:25 | |
| *** dynarro has quit IRC | 17:53 | |
| *** achanda has joined #openstack-zaqar | 17:59 | |
| *** achanda has quit IRC | 18:06 | |
| *** malini has quit IRC | 18:06 | |
| *** malini has joined #openstack-zaqar | 18:15 | |
| *** davideagnello has joined #openstack-zaqar | 18:18 | |
| *** achanda has joined #openstack-zaqar | 18:23 | |
| *** david-lyle has quit IRC | 18:27 | |
| *** david-lyle has joined #openstack-zaqar | 18:35 | |
| *** mpanetta has quit IRC | 18:40 | |
| *** malini has quit IRC | 18:52 | |
| *** malini has joined #openstack-zaqar | 19:44 | |
| *** david-lyle has quit IRC | 20:18 | |
| *** malini has quit IRC | 20:25 | |
| *** flwang1 has joined #openstack-zaqar | 20:43 | |
| *** sriram has quit IRC | 21:28 | |
| openstackgerrit | Merged openstack/zaqar: Ensure hmget return right data format https://review.openstack.org/280517 | 21:34 |
| openstackgerrit | Merged openstack/zaqar: Get non-existing queue should return 200 https://review.openstack.org/280473 | 21:35 |
| flwang1 | vkmc: would you mind reviewing this one https://review.openstack.org/#/c/267923/ ? +2ed already | 21:41 |
| vkmc | of course | 21:42 |
| flwang | vkmc: thanks :) | 21:48 |
| vkmc | flwang, np | 21:48 |
| flwang | flaper87: kgriffs: any chance you guys around? | 21:48 |
| vkmc | good team work btw :d | 21:48 |
| flwang | vkmc: would you like to discuss the queue metadata together? | 21:49 |
| vkmc | flwang, sure! although I don't remember the exact details of why we removed metadata in the first place :( | 21:49 |
| flwang | the m-3 is coming and i would like to fix it in Mitaka | 21:49 |
| vkmc | it would be useful to have flaper87 and kgriffs input about that | 21:49 |
| flwang | vkmc: we didn't remove it technically | 21:49 |
| vkmc | technically... ok | 21:49 |
| vkmc | :D | 21:49 |
| vkmc | so what are your thoughts about it? | 21:50 |
| flwang | after v1.1, for zaqar server side, user can set the metadata when create queue | 21:50 |
| flwang | but unfortunately, after create the queue, no way to update the metadata now | 21:50 |
| flwang | vkmc: i think there are two ways | 21:51 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix metadata update issue for v1.1 and v2 https://review.openstack.org/280941 | 21:51 |
| flwang | 1. ^ see above link | 21:51 |
| flwang | 2. add PATCh support for queue | 21:51 |
| flwang | in v1, we have a metadata api endpoint, since in v1, queue endpoint doesn't support PUT body | 21:52 |
| flwang | since v1.1 we support the PUT body | 21:52 |
| vkmc | yeah | 21:52 |
| vkmc | PUT is for creation | 21:52 |
| vkmc | queue creation | 21:52 |
| vkmc | we use PATCH for claims and pools | 21:53 |
| flwang | vkmc: yes, a straightforward way is using PATCH | 21:53 |
| vkmc | so we could add PATCH for queue | 21:53 |
| vkmc | yeah | 21:53 |
| flwang | and flavors | 21:53 |
| vkmc | I think it makes complete sense | 21:53 |
| vkmc | yeah... :) | 21:53 |
| vkmc | now... the metadata we put to queues are not really relevant, right? like we don't do anything special with that | 21:53 |
| flwang | and we do also need the client support | 21:54 |
| vkmc | it just carry information for users on demand | 21:54 |
| vkmc | ok ok | 21:54 |
| flwang | yes | 21:54 |
| flwang | for queue creation, there is no problem | 21:54 |
| flwang | metadata can be written into db successfully | 21:54 |
| flwang | the issue is about updating | 21:54 |
| vkmc | what blocker are you hitting? | 21:56 |
| *** jtomasek has quit IRC | 21:58 | |
| flwang | vkmc: not too much, just wondering if we should get metadata back given the complicated history | 22:00 |
| flwang | vkmc: and i definitely need some support for code review given the schedule is tight | 22:01 |
| vkmc | flwang, ok, count with me on that | 22:03 |
| vkmc | we need to 1. add patch to the server side in v1.1/v2 (wsgi/websocket and in the storage strategies) and 2. add support in the client | 22:04 |
| vkmc | not sure if 1. can be splitted | 22:05 |
| flwang | vkmc: yep, would you like to help the websocket part? I never touched that | 22:05 |
| vkmc | flwang, of course | 22:05 |
| vkmc | I can implement that pretty quickly | 22:06 |
| vkmc | we need to define a few things... including request signature and response codes | 22:06 |
| flwang | vkmc: awesome, i will upload patch and add you as reviewer | 22:06 |
| vkmc | if you can, submit the impl for wsgi and I'll mimic it in websocket | 22:07 |
| flwang | vkmc: awesome, cool | 22:07 |
| vkmc | so... whenever you are ready, count me in | 22:07 |
| flwang | vkmc: great, thanks | 22:07 |
| vkmc | I see the storage part is being covered here https://review.openstack.org/#/c/280941/1 | 22:08 |
| vkmc | I'll review when I'm back home (I'm at the office) | 22:08 |
| flwang | vkmc: yep, but that's the #1 solution | 22:11 |
| flwang | vkmc: and even we go for #2(PATCH), I'm not really sure if we should still keep the change in https://review.openstack.org/#/c/280941/1 thoughts? | 22:12 |
| openstackgerrit | Merged openstack/python-zaqarclient: Fix queue stats for v1.1 and above versions https://review.openstack.org/267923 | 22:12 |
| flwang | with https://review.openstack.org/#/c/280941, the metadata will be udpated if user is using PUT for an existing queue | 22:12 |
| flwang | similar behaviour like pool and flavor, the question we discussed very long time since the tokyo summit | 22:13 |
| flwang | therve: i just realized you implemented the zaqar integration with mistral, THANK YOU | 22:22 |
| vkmc | ok, let me check both changes | 22:23 |
| vkmc | using PUT for update seems a bit odd since we are using PATCH for other endpoints | 22:23 |
| vkmc | and... we should we consistent | 22:23 |
| vkmc | I'll review when I'm back | 22:23 |
| vkmc | heading out for the day now | 22:23 |
| vkmc | o/ | 22:23 |
| vkmc | thanks :) | 22:23 |
| vkmc | therve++ awesome! | 22:23 |
| flwang | vkmc: see you :) | 22:23 |
| *** rcernin has quit IRC | 23:18 | |
| *** flwang has quit IRC | 23:19 | |
| *** flwang has joined #openstack-zaqar | 23:33 | |
| *** EmilienM_ has joined #openstack-zaqar | 23:36 | |
| *** EmilienM has quit IRC | 23:37 | |
| *** ameade has quit IRC | 23:37 | |
| *** EmilienM_ is now known as EmilienM | 23:37 | |
| *** EmilienM is now known as Guest28836 | 23:37 | |
| *** Guest28836 has quit IRC | 23:41 | |
| *** Guest28836 has joined #openstack-zaqar | 23:41 | |
| *** Guest28836 is now known as EmilienM | 23:42 | |
| *** ameade has joined #openstack-zaqar | 23:43 | |
| *** ametts has quit IRC | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!