| *** ametts has quit IRC | 00:00 | |
| *** lei-zh has joined #openstack-zaqar | 00:05 | |
| *** lei-zh has left #openstack-zaqar | 00:05 | |
| flwang | Eva-i: so you're using v2? | 00:11 |
|---|---|---|
| Eva-i | flwang: on curl operation I use v2, on python-openstackclient I use default api. Oki, I'll try to use api v2 on python-openstackclient then. But what about capabilities when I get flavor by curl? | 00:14 |
| flwang | Eva-i: for v2, basically, basically you can't specify cap, since zaqar will detect the cap for you | 00:14 |
| Eva-i | flwang: oh, I see. I'll try to check it. | 00:15 |
| *** lei-zh has joined #openstack-zaqar | 00:19 | |
| *** lei-zh has left #openstack-zaqar | 01:08 | |
| Eva-i | flwang: flwang1: maybe when we get subscription, Zaqar server should show it's age? Like it's showing the age for claims and messages, how do you think? | 02:50 |
| Eva-i | flwang: flwang1: maybe we should show 204 response code, when there are no subscriptions to queue? Like when there are no messages in queue? | 02:52 |
| flwang | Eva-i: for age, see https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/subscriptions.py | 02:53 |
| flwang | we don't have the created time, so if we want to add it, we need that field | 02:53 |
| flwang | what's our current code? 200? | 02:54 |
| Eva-i | flwang1: flwang: now Zaqar returns 200 OK code and unusable data on subscription list when there are no subscriptions | 02:54 |
| flwang | unusable data? | 02:55 |
| Eva-i | Yes: {"links": [{"href": "/v2/queues/my-lovely-queue/subscriptions?marker=", "rel": "next"}], "subscriptions": []} | 02:55 |
| flwang | what's the benefit to change it from 200 to 204? | 02:57 |
| *** mdnadeem has joined #openstack-zaqar | 02:58 | |
| Eva-i | flwang: integrity, expected behavior. If we'll do like that, we'll make it's behavior similar to listing messages in the queue. | 02:58 |
| flwang | Eva-i: we could do that, but that has low priority :) | 03:00 |
| Eva-i | flwang: we need to do it before making API v2 stable | 03:00 |
| Eva-i | flwang: so oki, we can wait now | 03:00 |
| Eva-i | flwang: i can fill a bug, if you want, so we will not forget about it | 03:01 |
| flwang | Eva-i: ok, thanks | 03:01 |
| Eva-i | flwang: hm. This document says that 204 code must be returned only on successful deletion: https://specs.openstack.org/openstack/api-wg/guidelines/http.html#xx-success-codes | 03:09 |
| Eva-i | flwang: maybe it's good that on empty subscription listing zaqar returns 200 OK code | 03:10 |
| *** kgriffs is now known as kgriffs|afk | 03:15 | |
| Eva-i | flwang: I'm looking now at claim mongodb implementation, and to compute age, it uses only 'claim_expires' and 'ttl' fields. https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/claims.py#L87 | 03:15 |
| Eva-i | I think "age" is must-have. | 03:16 |
| flwang | Eva-i: yep, i know | 03:16 |
| flwang | let me explain | 03:16 |
| flwang | see line 112 https://review.openstack.org/#/c/270464/2/zaqar/storage/mongodb/subscriptions.py | 03:17 |
| flwang | I'm using None if user want to have a permanent subscription | 03:17 |
| flwang | so that's why i said we need a created field | 03:18 |
| Eva-i | mmm | 03:18 |
| flwang | but after more thought, i think we can do it with another way | 03:18 |
| flwang | fill the field with number instead of None | 03:18 |
| flwang | the number is the seconds of the time | 03:19 |
| flwang | we may could work out a solution or just add a new 'created' field | 03:20 |
| Eva-i | flwang: no, I don't understand the another way. Also I still feel uneasy about permanent subscriptions. | 03:21 |
| flwang | Eva-i: permanent subscription is easy for mongodb | 03:21 |
| flwang | but i haven't dig into redis to achieve that | 03:22 |
| flwang | Eva-i: you can google the TTL implementation of mongodb, then you know why/how it works | 03:22 |
| flwang | if the TTL index is on a non-Date field, it doesn't work | 03:24 |
| Eva-i | I'm worrying not about technical details, but about user cases | 03:25 |
| Eva-i | flwang: I'll try to formulate tomorrow my thoughts | 03:26 |
| flwang | Eva-i: ok, cool | 03:26 |
| Eva-i | flwang: okay, finally reviewed your ttl patch. I do reviews slow, because I'm trying not to miss anything.. | 03:37 |
| flwang | Eva-i: tips for review, be confident for your review, don't hesitate to use -1 | 03:37 |
| Eva-i | flwang: i just forgot to click to -1, I wanted. | 03:37 |
| flwang | do it :) | 03:38 |
| Eva-i | already | 03:38 |
| flwang | FYI, guys, the ceilometer + zaqar is approved https://review.openstack.org/#/c/264309/ | 03:39 |
| Eva-i | wow | 03:39 |
| flwang | integration with searchlight/horizon is coming.... https://review.openstack.org/#/c/246220/ | 03:40 |
| *** flwang1 has quit IRC | 04:05 | |
| *** lane_kong has quit IRC | 04:55 | |
| *** david-lyle has quit IRC | 05:02 | |
| *** david-lyle has joined #openstack-zaqar | 05:03 | |
| *** flwang1 has joined #openstack-zaqar | 06:02 | |
| *** flwang1 has quit IRC | 06:06 | |
| *** lane_kong has joined #openstack-zaqar | 06:45 | |
| *** achanda has quit IRC | 07:06 | |
| *** rcernin has joined #openstack-zaqar | 07:20 | |
| *** achanda has joined #openstack-zaqar | 08:06 | |
| *** achanda has quit IRC | 08:13 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:31 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-zaqar | 10:02 | |
| *** achanda has joined #openstack-zaqar | 10:11 | |
| *** achanda has quit IRC | 10:17 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Ensure the format of input be JSON https://review.openstack.org/270748 | 11:39 |
| *** boris-42 has quit IRC | 12:03 | |
| *** achanda has joined #openstack-zaqar | 12:14 | |
| *** lane_kong has quit IRC | 12:15 | |
| *** achanda has quit IRC | 12:20 | |
| vkmc | w000t! flwang :D | 12:25 |
| vkmc | just read the backlo | 12:25 |
| vkmc | g | 12:25 |
| *** Guest7791 is now known as bradjones | 13:12 | |
| *** bradjones has joined #openstack-zaqar | 13:12 | |
| *** exploreshaifali has quit IRC | 13:54 | |
| *** dynarro has joined #openstack-zaqar | 14:06 | |
| *** achanda has joined #openstack-zaqar | 14:17 | |
| *** achanda has quit IRC | 14:23 | |
| *** sriram has joined #openstack-zaqar | 14:30 | |
| *** njohnston has joined #openstack-zaqar | 14:31 | |
| *** ametts has joined #openstack-zaqar | 14:54 | |
| *** malini has joined #openstack-zaqar | 14:59 | |
| *** boris-42 has joined #openstack-zaqar | 15:07 | |
| *** achanda has joined #openstack-zaqar | 15:20 | |
| *** achanda has quit IRC | 15:20 | |
| *** achanda has joined #openstack-zaqar | 15:20 | |
| *** kgriffs|afk is now known as kgriffs | 15:22 | |
| *** achanda has quit IRC | 15:33 | |
| *** csoukup has joined #openstack-zaqar | 15:44 | |
| *** achanda has joined #openstack-zaqar | 15:55 | |
| *** achanda has quit IRC | 16:02 | |
| *** rcernin has quit IRC | 16:09 | |
| *** rcernin has joined #openstack-zaqar | 16:49 | |
| *** mpanetta has joined #openstack-zaqar | 17:03 | |
| *** fesp has joined #openstack-zaqar | 17:56 | |
| *** dynarro has quit IRC | 18:00 | |
| *** malini has quit IRC | 18:15 | |
| *** fesp has quit IRC | 18:32 | |
| *** malini has joined #openstack-zaqar | 18:42 | |
| *** ametts has quit IRC | 19:01 | |
| *** njohnston has quit IRC | 19:07 | |
| *** njohnston has joined #openstack-zaqar | 19:07 | |
| *** fesp has joined #openstack-zaqar | 19:13 | |
| *** ametts has joined #openstack-zaqar | 19:14 | |
| *** malini has quit IRC | 19:23 | |
| *** ametts has quit IRC | 19:24 | |
| *** Eva-i has quit IRC | 19:46 | |
| *** Eva-i has joined #openstack-zaqar | 19:48 | |
| *** fesp has quit IRC | 20:04 | |
| flwang | vkmc: ryansb: therve: could you review the subscriptions TTL fix of Mongo https://review.openstack.org/#/c/270464/2 ? and let me know your thoughts | 20:19 |
| flwang | in this patch, if user won't pass in TTL, then the subscription will be a permanent subscription | 20:20 |
| *** mdnadeem has quit IRC | 20:22 | |
| therve | flwang, As a quick look it looks okay. Eva-i's comments seem relevant though. | 20:23 |
| flwang | therve: thanks, Eva-i's comments are only related to the type/value check i think | 20:24 |
| flwang | therve: i have tested it locally, it works great | 20:24 |
| therve | Cool | 20:25 |
| flwang | therve: thanks for the feedback | 20:25 |
| therve | Np | 20:25 |
| ryansb | flwang: will do | 20:25 |
| flwang | therve: many times i want to invite you join the core team, but there are too many Redhater, and given the diversity requirement, i have to wait :) | 20:26 |
| flwang | but i know you're always around, haha | 20:26 |
| flwang | ryansb: thanks | 20:26 |
| therve | Yeah get some fresh blood :) | 20:27 |
| flwang | therve: yep, we need some fresh blood | 20:27 |
| flwang | i'm drafting some blogs of zaqar to prompt Zaqar in China | 20:28 |
| *** flwang1 has joined #openstack-zaqar | 20:28 | |
| *** ryansb has quit IRC | 20:40 | |
| *** ryansb has joined #openstack-zaqar | 20:44 | |
| *** ryansb has quit IRC | 20:44 | |
| *** ryansb has joined #openstack-zaqar | 20:44 | |
| *** mpanetta has quit IRC | 21:09 | |
| *** kgriffs is now known as kgriffs|afk | 21:10 | |
| *** mpanetta has joined #openstack-zaqar | 21:10 | |
| *** kgriffs|afk is now known as kgriffs | 21:26 | |
| *** mdnadeem has joined #openstack-zaqar | 21:30 | |
| *** sriram has quit IRC | 21:31 | |
| *** csoukup has quit IRC | 21:33 | |
| openstackgerrit | Merged openstack/python-zaqarclient: Add a way to create a signed URL from a queue https://review.openstack.org/270201 | 21:33 |
| *** mdnadeem has quit IRC | 21:38 | |
| *** csoukup has joined #openstack-zaqar | 21:48 | |
| Eva-i | flwang: I have tested your ttl patch | 21:54 |
| *** pradk has joined #openstack-zaqar | 22:13 | |
| *** mpanetta has quit IRC | 22:32 | |
| flwang | Eva-i: feedback? | 22:44 |
| *** njohnston has quit IRC | 22:45 | |
| Eva-i | flwang: I tested it by providing different valid values in requests. It works good. Also I tested extreme values for TTL variable, which was affected by the patch and catched an exception as I mentioned in comments. | 23:01 |
| *** csoukup has quit IRC | 23:01 | |
| flwang | awesome | 23:01 |
| flwang | Eva-i: what's the 'extreme values' you're using? | 23:02 |
| Eva-i | flwang: I tried python's sys.maxsize+1, it passes validation and throws exception in the storage driver. I tried python's sys.maxsize-1, it throws exception too. I don't know the exaxt value at which the exception is not thrown. I guess it would be safe to use a value smaller than C's MAX_INT http://www.cplusplus.com/reference/climits/ | 23:11 |
| Eva-i | s/exaxt/exact | 23:11 |
| Eva-i | flwang: though I haven't tried extreme negative values. I think it would be okay. | 23:12 |
| flwang | Eva-i: ok, i see. good to know, I will take a look what's the value can be used for date, thanks for the test | 23:14 |
| Eva-i | flwang: I'm thinking now... Maybe other subscription variables should go through a stricter validation. | 23:14 |
| flwang | Eva-i: i will upload a new patchset | 23:14 |
| Eva-i | flwang: nice | 23:14 |
| flwang | Eva-i: for subscriptions, we only have 'subscriber', 'ttl' and 'options' | 23:15 |
| Eva-i | flwang: I mean 'subscriber' and 'options' | 23:15 |
| flwang | for 'options', it just a dict/json format | 23:17 |
| flwang | for subscriber, it's a URL or mailto:<email> | 23:17 |
| Eva-i | flwang: should't we check 'options's keys and values? | 23:18 |
| flwang | Eva-i: why do you think we need? | 23:20 |
| flwang | it could be anything | 23:20 |
| Eva-i | flwang: by mistake I was able to create a subscription like this: mailto://example@example.com. The email subscriptions weren't working in this case, of course. But okay, maybe other people will not make such mistake. | 23:21 |
| *** bradjones_ has joined #openstack-zaqar | 23:31 | |
| *** bradjones_ has joined #openstack-zaqar | 23:31 | |
| *** rcernin has quit IRC | 23:47 | |
| *** bradjones_ has quit IRC | 23:47 | |
| *** bradjones_ has joined #openstack-zaqar | 23:47 | |
| *** bradjones_ has joined #openstack-zaqar | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!