*** mdnadeem has joined #openstack-zaqar | 05:14 | |
*** GB21 has joined #openstack-zaqar | 06:22 | |
*** davideag_ has joined #openstack-zaqar | 06:30 | |
*** davideagnello has quit IRC | 06:33 | |
*** stanchan has quit IRC | 07:27 | |
*** stanchan has joined #openstack-zaqar | 07:36 | |
*** GB21 has quit IRC | 08:11 | |
*** zigo has quit IRC | 10:57 | |
*** zigo has joined #openstack-zaqar | 10:57 | |
*** njohnsto_ has joined #openstack-zaqar | 11:53 | |
*** njohnsto_ has quit IRC | 11:55 | |
*** njohnsto_ has joined #openstack-zaqar | 11:56 | |
*** mdnadeem has quit IRC | 14:05 | |
*** mdnadeem has joined #openstack-zaqar | 14:44 | |
*** njohnsto_ has quit IRC | 14:47 | |
*** njohnston has joined #openstack-zaqar | 14:47 | |
*** mdnadeem has quit IRC | 15:32 | |
*** GB21 has joined #openstack-zaqar | 16:36 | |
*** GB21 has quit IRC | 17:37 | |
openstackgerrit | Merged openstack/python-zaqarclient: Query claim CLI support for v1 https://review.openstack.org/258801 | 20:11 |
---|---|---|
openstackgerrit | Merged openstack/python-zaqarclient: Claim renew CLI support for v1 https://review.openstack.org/260927 | 20:11 |
openstackgerrit | Merged openstack/python-zaqarclient: Claim release CLI support for v1 https://review.openstack.org/260954 | 20:13 |
openstackgerrit | Merged openstack/zaqar: Make enforce_type=True in CONF.set_override https://review.openstack.org/263359 | 20:13 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 20:42 |
Eva-i | flwang: ping | 20:48 |
flwang1 | Eva-i: pong | 20:49 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription delete v2 https://review.openstack.org/261280 | 20:49 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription show v2 https://review.openstack.org/261282 | 20:49 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription update v2 https://review.openstack.org/261303 | 20:49 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription list v2 https://review.openstack.org/263531 | 20:49 |
flwang1 | Eva-i: i saw the config ref has been merged, right? :) | 20:50 |
flwang1 | congrats!!! | 20:50 |
Eva-i | flwang1: yes, here it is https://review.openstack.org/#/c/263405/ | 20:50 |
Eva-i | flwang1: yep, congrats us | 20:50 |
Eva-i | flwang1: have you checked it out? | 20:50 |
Eva-i | flwang1: I want to ask something about this patch | 20:50 |
flwang1 | checked what? | 20:51 |
Eva-i | flwang1: checked this patch | 20:51 |
flwang1 | the config patch? | 20:52 |
flwang1 | what's the question? i can't follow, sorry | 20:52 |
Eva-i | flwang1: yes, the configuration reference patch. Particularly this page: http://docs-draft.openstack.org/05/263405/7/gate/gate-openstack-manuals-tox-doc-publish-checkbuild/24be02f//publish-docs/draft/config-reference/messaging/zaqar-api.html | 20:52 |
Eva-i | flwang1: is this page written good? | 20:53 |
flwang1 | oh, i didn't, let me see ;) | 20:54 |
flwang1 | Eva-i: i didn't see the notification configuration | 20:56 |
flwang1 | for the pipeline | 20:56 |
flwang1 | ah, got it | 20:57 |
flwang1 | it's under storage | 20:57 |
flwang1 | Eva-i: but how can the user know the value of subscription_pipeline? | 20:58 |
Eva-i | flwang1: the user can't know anything about possible values for pipelines now, but he must, That's why I reported a bug about pipelines. | 20:59 |
flwang1 | Eva-i: in zaqar? | 20:59 |
Eva-i | flwang1: that's right | 21:00 |
Eva-i | flwang1: also me an Victoria think that all options in [storage] section are confusing to user. Maybe this should be refactored in Zaqar in the future. | 21:02 |
flwang1 | hmm.... but i think it's a config/docs issue | 21:02 |
flwang1 | why we need to refactor zaqar? | 21:02 |
Eva-i | flwang1: should the information about possible values for pipelines be located inside configuration tables or outside in config-ref? | 21:05 |
flwang1 | and I think we're messaging service, not 'message service' :) | 21:05 |
flwang1 | Eva-i: i would like to have a note in config-ref | 21:06 |
flwang1 | to explain the pipeline of zaqar and the value for message_pipeline, since otherwise, user can't know how to config notifications | 21:07 |
flwang1 | Eva-i: see https://www.openstack.org/software/project-navigator/ | 21:08 |
flwang1 | we're "Messaging Service' | 21:08 |
Eva-i | flwang1: the docbook config-ref in Zaqar repository calls Zaqar "Messaging and Notification service". I used it, but Doc team told that it is wrong: because "Message service" is current official name for zaqar project: https://git.openstack.org/cgit/openstack/governance/tree/reference/projects.yaml#n3747 | 21:09 |
Eva-i | flwang1: Doc team follows this instruction http://docs.openstack.org/contributor-guide/writing-style/openstack-components.html | 21:10 |
Eva-i | flwang1: maybe it's a bug in "projects.yaml" file | 21:10 |
Eva-i | flwang1: "would like to have a note in config-ref" so you mean, outside configuration tables and zaqar code? I can do it. Also what about default values for pipelines, currently they don't have their default values, is it okay? | 21:14 |
flwang1 | Eva-i: i don't want to set the default value for pipeline since it may impact the performance | 21:15 |
flwang1 | for example, user maybe not want to enable the notification service for zaqar | 21:16 |
flwang1 | and AFAIK, the only pipeline we're using is the message_pipeline for notifications | 21:16 |
Eva-i | flwang1: thanks, now it all makes sense. I'll try describe it in config-ref in next patch, but I'm not 100% sure I understand the concept of these pipeline options. | 21:20 |
flwang1 | you can take a look the implementation of notification | 21:21 |
flwang1 | for example, when a msg posted to a queue, if there is the pipeline for notifications, then the msg will be also passed to the pipeline | 21:22 |
Eva-i | flwang1: I was unable to notifications for more than month, just because I didn't knew about options turning notifications on and there was no documentation. | 21:22 |
flwang1 | so that in the pipeline driver, we can forward it to the subscribers | 21:22 |
flwang1 | Eva-i: you should ask :) | 21:22 |
flwang1 | and sorry, it's not well-documented | 21:23 |
Eva-i | flwang1: I asked, but with wrong questions | 21:24 |
Eva-i | flwang1: and I made a fatal assumption that notifications in Zaqar should work by default | 21:25 |
flwang1 | Eva-i: haha :) | 21:25 |
flwang1 | anyway, thank you so much for your effort to the docs of zaqar | 21:26 |
flwang1 | i'm really happy to see now we have a config ref | 21:26 |
Eva-i | flwang1: that slowed me down in finding the truth. Only after Victoria shared her "zaqar.conf", I barely noticed the line "message_pipeline = zaqar.notification.notifier" and tried it in my "zaqar.conf". | 21:27 |
Eva-i | flwang1: yes, no problem =) | 21:27 |
flwang1 | Eva-i: btw, would you mind taking the api-ref again? :) | 21:29 |
flwang1 | given you have done much work on that | 21:29 |
flwang1 | i'm afraid i don't have enough time to do that in Mitaka | 21:29 |
*** mdnadeem has joined #openstack-zaqar | 21:29 | |
Eva-i | flwang1: so the task will be to make api-ref without autogenerated api tables? | 21:30 |
Eva-i | flwang1: also in config-ref I said about "zaqar.conf": "This file is located in /etc/zaqar. If there is a file zaqar.conf in ~/.zaqar directory, it is used instead of the one in /etc/zaqar directory". Is this right? | 21:33 |
Eva-i | flwang1: I'm sorry, I have so many questions now... | 21:37 |
flwang1 | sorry, just back | 21:51 |
flwang1 | 1. for api ref, do we need tables? I think it's about how to generate .rst format fitted swager | 21:51 |
flwang1 | 2. yes, IIRC | 21:52 |
Eva-i | flwang1: I think yes, all api-refs have tables with endpoints and responses. See http://developer.openstack.org/api-ref-identity-v2.html | 21:58 |
flwang1 | ah, so you call it 'table' | 22:01 |
Eva-i | flwang1: yes | 22:01 |
flwang1 | ok | 22:01 |
flwang1 | so is it possible to get a 'hook' for the tool (sorry, i forgot the name) to let it work property with zaqar? | 22:05 |
Eva-i | flwang1: I don't know, I'll try to investigate the possibility of hook tomorrow. Last time I checked, everything was painful about writing api-ref during this release cycle. Maybe things have changed. | 22:08 |
Eva-i | flwang1: I have found interesting file in Zaqar repository: doc/user-guide/zaqar-api-ref/target/generated-resources/xml/xslt/3619-os-zaqar-apiRef.wadl. I believe this file was somehow autogenerated. So maybe it's possible to write a hook, which will generate api-ref tables in swagger/rst format. | 22:09 |
flwang1 | Eva-i: let's ping vkmc | 22:10 |
flwang1 | she must know more about that part | 22:10 |
Eva-i | flwang1: oh, this file is not in repository. So it means it was generated locally by me. | 22:13 |
Eva-i | flwang1: okay, I'll ask her | 22:13 |
flwang1 | Eva-i: oh, wait | 22:13 |
flwang1 | the api-ref it's different from the api we're talking about | 22:14 |
Eva-i | flwang1: what do you mean? | 22:16 |
flwang1 | never mind | 22:16 |
Eva-i | flwang1: also again about config-ref. Do you like where pipeline options can be currently found in config-ref. I can move it to the different article, if you think that it doesn't belong to "Storage driver options" article. | 22:21 |
Eva-i | ? | 22:21 |
flwang1 | Eva-i: i would like to see a separated topic for notification | 22:23 |
flwang1 | thoughts? | 22:23 |
Eva-i | flwang1: this is a nice idea. I can make separate page "Notifications Options". | 22:24 |
flwang1 | yes | 22:24 |
flwang1 | i think it would be great | 22:24 |
Eva-i | flwang1: is whole [storage] section with pipelines exists because of notifications? | 22:25 |
flwang1 | so when user look the doc, they can know how to config notifications of zaqar | 22:25 |
flwang1 | nope | 22:25 |
flwang1 | pipelines exist before notifications | 22:25 |
flwang1 | notifications just leverage the pipeline of message to make it easier and simple | 22:26 |
Eva-i | flwang1: hm, what if I make "Pipelines options" and "Notifications options" pages? In both I will include the tables with pipeline options. In "Pipeline options" I will describe pipelines in general. In "Notifications options" I will describe how to turn on notifications using pipelines. Would you like that? | 22:32 |
flwang1 | i'm hesitate to have a pipeline options given we already have the storage options | 22:33 |
flwang1 | how about add a note into storage options to explain the pipeline of zaqar | 22:33 |
flwang1 | instead of creating a new topic for pipeline | 22:33 |
Eva-i | flwang1: yes, I can do it. thought pipelines more relate to transport, not storage. It is wrong? | 22:34 |
Eva-i | *I thought | 22:34 |
flwang1 | pipeline is more related to storage, afait | 22:35 |
Eva-i | flwang1: oki, thank you | 22:36 |
flwang1 | anytime | 22:39 |
flwang1 | Eva-i: would you mind taking a look at this https://review.openstack.org/201214 ? | 22:50 |
flwang1 | given you just fixed a similar gate failure | 22:50 |
Eva-i | flwang1: oki, let's see... | 22:52 |
flwang1 | Eva-i: thanks | 22:55 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Support claims for v2 https://review.openstack.org/265663 | 23:07 |
Eva-i | flwang1: okay, I have found the cause of failing. | 23:08 |
flwang1 | Eva-i: cool | 23:08 |
Eva-i | flwang1: Zaqar's kilo branch doesn't contain devstack directory with gate hook. See https://github.com/openstack/zaqar/tree/stable/kilo | 23:09 |
flwang1 | Eva-i: yes | 23:09 |
Eva-i | flwang1: so this hook is not found | 23:09 |
flwang1 | we may need to talk with infra team to see how to fix this kind of issue | 23:10 |
flwang1 | since i don't think porting the devstack folder is a good idea | 23:10 |
Eva-i | flwang1: perhaps there are two options: 1. we can add hook to kilo branch (but would it be wrong?) 2. Somehow turn off hooking in Zaqar gate jobs when kilo branch is detected. I think we can modify these lines below: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/zaqar.yaml#L74 | 23:15 |
flwang1 | Eva-i: but without the hook, can kilo gate still work? I"m not sure | 23:17 |
flwang1 | i have to go for lunch, ttyl | 23:17 |
Eva-i | flwang1: yes, I'm not sure either. You're right, we should ask infra team. | 23:17 |
flwang1 | ok, thanks for working on this | 23:18 |
flwang1 | brb | 23:18 |
*** mdnadeem has quit IRC | 23:52 | |
Eva-i | flwang1: are you here? =) | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!