| *** Qiming has quit IRC | 00:13 | |
| flwang | open bug for what? | 00:14 |
|---|---|---|
| *** lei-zh1 has joined #openstack-zaqar | 00:26 | |
| Eva-i | flwang: for adding parameters. | 00:35 |
| flwang | no, why it deserves a bug? | 00:36 |
| Eva-i | flwang: just thought this should be documented also somewhere other than in commit message. But okay. | 00:38 |
| *** tej has quit IRC | 00:38 | |
| Eva-i | *somewhere else | 00:42 |
| *** lei-zh1 has quit IRC | 00:42 | |
| flwang | agree | 00:44 |
| Eva-i | flwang: I will just add information about this option to benchmark-tool manual. | 00:46 |
| Eva-i | flwang: would you like to review this documentation patch https://review.openstack.org/#/c/250582/ ? I hope I didn't make too much in this single patch. | 00:48 |
| flwang | Eva-i: it's on my list, but yep, it's long | 00:50 |
| flwang | so i need some time to eat it | 00:50 |
| Eva-i | flwang: oki. Also I got new information about official API-ref conversion from Anne Gentle. If I understand her correctly, she said that API references sources will be converted from DocBook/WADL to Swagger/RST. And it will happen in the near future: http://paste.openstack.org/show/GzJhkfjbAt2olqQWbUZ7/ | 01:03 |
| flwang | Eva-i: wow, it's a good news | 01:04 |
| Eva-i | flwang: because you too think that DocBook/WADL format is hard to write? | 01:06 |
| flwang | Eva-i: yep | 01:06 |
| flwang | swagger can save your a lot of time | 01:06 |
| Eva-i | flwang: hehe, im terrified of it too. =) | 01:06 |
| flwang | cool :) | 01:12 |
| Eva-i | flwang: so let's wait until the start of conversion and then write API reference in proper format? | 01:13 |
| flwang | Eva-i: we can wait a little bit, but mean while we need to investigate more details and leave comments/questions on anne's spec | 01:15 |
| *** pradk has joined #openstack-zaqar | 01:32 | |
| *** david-lyle has joined #openstack-zaqar | 01:37 | |
| *** lei-zh1 has joined #openstack-zaqar | 01:42 | |
| *** kgriffs is now known as kgriffs|afk | 01:43 | |
| *** Qiming has joined #openstack-zaqar | 02:04 | |
| *** pradk is now known as pradk-afk | 03:00 | |
| *** pradk-afk is now known as pradk | 03:01 | |
| *** kgriffs|afk is now known as kgriffs | 03:06 | |
| *** dmowrer has joined #openstack-zaqar | 03:22 | |
| *** boris-42_ has quit IRC | 03:23 | |
| *** dmowrer has quit IRC | 03:27 | |
| *** flwang1 has quit IRC | 03:58 | |
| *** lei-zh1 has quit IRC | 04:25 | |
| *** njohnsto_ has joined #openstack-zaqar | 04:32 | |
| *** njohnston has quit IRC | 04:36 | |
| *** njohnsto_ has quit IRC | 04:49 | |
| *** kgriffs is now known as kgriffs|afk | 04:58 | |
| Eva-i | Hello | 05:02 |
| Eva-i | How can I reopen this change, so I can send a new patchset to it: https://review.openstack.org/#/c/196652/ ? | 05:02 |
| Eva-i | It's now abandoned | 05:02 |
| *** kgriffs|afk is now known as kgriffs | 05:03 | |
| *** lei-zh1 has joined #openstack-zaqar | 05:04 | |
| *** ig0r__ has joined #openstack-zaqar | 05:15 | |
| *** ig0r_ has quit IRC | 05:19 | |
| *** ig0r__ has quit IRC | 05:21 | |
| *** Qiming has quit IRC | 06:44 | |
| *** ig0r_ has joined #openstack-zaqar | 07:32 | |
| *** ig0r_ has quit IRC | 08:11 | |
| *** kgriffs is now known as kgriffs|afk | 08:14 | |
| *** dmowrer has joined #openstack-zaqar | 08:16 | |
| *** kgriffs|afk is now known as kgriffs | 08:18 | |
| *** kgriffs is now known as kgriffs|afk | 08:19 | |
| *** ig0r_ has joined #openstack-zaqar | 08:19 | |
| *** dmowrer has quit IRC | 08:20 | |
| *** rcernin has joined #openstack-zaqar | 08:44 | |
| *** ig0r_ has quit IRC | 08:53 | |
| *** lei-zh1 has left #openstack-zaqar | 09:18 | |
| *** ig0r_ has joined #openstack-zaqar | 09:19 | |
| *** ig0r_ has quit IRC | 09:47 | |
| *** ig0r_ has joined #openstack-zaqar | 11:08 | |
| *** ig0r_ has quit IRC | 11:46 | |
| *** ig0r_ has joined #openstack-zaqar | 12:14 | |
| *** dmowrer has joined #openstack-zaqar | 12:15 | |
| *** rcernin has quit IRC | 12:18 | |
| *** ig0r_ has quit IRC | 12:24 | |
| *** pradk has quit IRC | 13:04 | |
| *** ig0r_ has joined #openstack-zaqar | 13:16 | |
| *** ig0r_ has quit IRC | 13:25 | |
| *** tej has joined #openstack-zaqar | 13:50 | |
| *** mdnadeem has joined #openstack-zaqar | 13:52 | |
| *** sriram has joined #openstack-zaqar | 14:03 | |
| *** tej has quit IRC | 14:07 | |
| *** tej has joined #openstack-zaqar | 14:23 | |
| *** mdnadeem has quit IRC | 14:38 | |
| *** ig0r_ has joined #openstack-zaqar | 14:41 | |
| *** ig0r_ has quit IRC | 14:43 | |
| *** pradk has joined #openstack-zaqar | 14:51 | |
| *** ig0r_ has joined #openstack-zaqar | 15:01 | |
| *** ig0r_ has quit IRC | 15:06 | |
| *** dynarro has joined #openstack-zaqar | 15:23 | |
| *** tej has quit IRC | 15:37 | |
| *** dynarro has quit IRC | 15:43 | |
| *** david-ly_ has joined #openstack-zaqar | 15:50 | |
| *** david-lyle has quit IRC | 15:53 | |
| *** david-ly_ is now known as david-lyle | 15:53 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:57 | |
| *** tej has joined #openstack-zaqar | 16:10 | |
| *** ig0r_ has joined #openstack-zaqar | 16:21 | |
| *** ig0r_ has quit IRC | 16:47 | |
| *** mpanetta has joined #openstack-zaqar | 17:01 | |
| *** tej has quit IRC | 17:37 | |
| *** flwang1 has joined #openstack-zaqar | 18:21 | |
| flwang1 | vkmc: ping | 18:23 |
| flwang1 | vkmc: flaper87: can you pls help review the zaqar client patches? many of them just waiting for your bless :) | 18:35 |
| Eva-i | flwang1: hello | 18:36 |
| flwang1 | Eva-i: hi | 18:36 |
| Eva-i | flwang: i'm trying to rebase the "claimsv2" patch. Everything is alright locally. But when I try to "git review" this happens http://paste.openstack.org/show/kZSJxijV3wb7aqU6KjJs/. What should I do? | 18:37 |
| *** shakamunyi has quit IRC | 18:44 | |
| flwang1 | clicking... | 18:50 |
| flwang1 | paste is slow when i access it from home | 18:54 |
| Eva-i | flwang1: you can try this http://pastebin.com/vBmd41ei | 18:56 |
| flwang1 | i see it | 18:57 |
| flwang1 | that because this patch is depending on another one da8ea51 Added support to notifications and which has been abandoned | 18:58 |
| Eva-i | flwang1: but we reopened this patch and I rebased it | 18:58 |
| Eva-i | flwang1: by using gerrit interface | 18:59 |
| flwang1 | hmm... | 19:00 |
| Eva-i | flwang1: gerrit review refers now to this patch https://review.openstack.org/#/c/209238 | 19:00 |
| Eva-i | flwang1: of couse this patch is closed, because it's merged | 19:01 |
| flwang1 | did you try to rebase ? | 19:04 |
| Eva-i | flwang1: I did "git review -d <claimsv2 patch number>" and by this I created new local branch, then I rebased it's locally with master branch, solved conflicts and fixed one test, then I made "git add ." and "git commit --amend", and executed "git review". It doesn't mean I rebased? | 19:07 |
| flwang1 | ok, then there is another solution | 19:12 |
| flwang1 | can you show me the git log? | 19:12 |
| Eva-i | flwang1: here http://pastebin.com/CB2ZGpPz | 19:15 |
| *** kgriffs|afk is now known as kgriffs | 19:16 | |
| Eva-i | flwang1: it's a top of git log | 19:16 |
| flwang1 | and then we can use git reset a0b16699e41395fa8c7c9219f16bada7e8979914 to get a new uncommit patch but | 19:20 |
| flwang1 | hmmmm | 19:20 |
| flwang1 | it's a complicated case | 19:21 |
| flwang1 | if may have to remove those codes belongs to the notification patches | 19:22 |
| *** kgriffs is now known as kgriffs|afk | 19:22 | |
| Eva-i | flwang1: remove some codes from "notifications" and squash these "notifications" and "claims" commits? What if gerrit will continue referring to the merged patch? | 19:24 |
| *** tej has joined #openstack-zaqar | 19:24 | |
| Eva-i | flwang1: maybe there's some magic gerrit command that will make this patches stop referring to the merged patch? | 19:27 |
| flwang1 | i don't think so | 19:35 |
| flwang1 | in my opinion, the easy way is reset and combine the notification patch and the claim patch | 19:39 |
| flwang1 | but you'd better remove the code related to notification patch | 19:40 |
| flwang1 | that's my suggestion, if it's too hard for you, just leave it for me, i will take care it | 19:40 |
| vkmc | so... the problem is that it has a dependency to an already merged patch | 19:42 |
| vkmc | git rebase -i master | 19:43 |
| vkmc | remove the merged dependency | 19:43 |
| vkmc | and git review again | 19:43 |
| vkmc | Eva-i, ^ | 19:46 |
| vkmc | flwang, sure | 19:46 |
| Eva-i | vkmc: thanks, Vic, doing it | 19:47 |
| vkmc | Eva-i, k, let me know how it goes | 19:47 |
| Eva-i | vkmc: what do you mean by "remove the merged dependency"? Remove all the code related to the "notifications" patch? | 19:48 |
| *** shakamunyi has joined #openstack-zaqar | 19:48 | |
| flwang1 | the patch depended is abandoned, not merged, i think | 19:50 |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Added support to claims https://review.openstack.org/213165 | 19:50 |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: wip: Added support to notifications https://review.openstack.org/196652 | 19:50 |
| flwang1 | see? | 19:51 |
| Eva-i | vkmc: hm now it finally worked, I was able to send to review both patches | 19:52 |
| Eva-i | vkmc: flwang1: what I just did is squashing of duplicated "notifications" commits: http://paste.openstack.org/show/Dxn0e3OFC1j9QxI0ozTU/ | 19:53 |
| Eva-i | vkmc: flwang1: but you would like me also to detach "claims" patch from "notifications" patch? | 19:54 |
| *** shakamunyi has quit IRC | 19:55 | |
| flwang1 | doraly won't work on that patch and i'm working on a new patch to support subscription | 19:56 |
| vkmc | cool! | 19:57 |
| Eva-i | flwang1: vkmc: okay, so I'll also squash "notifications" with "claims" and remore related code to notifications, right? Just want to be sure. | 19:58 |
| flwang1 | vkmc: https://review.openstack.org/249395 i'm talking about this | 19:58 |
| flwang1 | and i'm going to split it into 5 patches | 19:58 |
| flwang1 | vkmc: i saw you restored doraly's patch, so if you want to give me a hand, it would be great | 19:58 |
| flwang1 | but now, i really need your help for the code review ;) | 19:58 |
| vkmc | not sure I follow | 19:58 |
| flwang1 | https://review.openstack.org/196652 you restored this one, right? | 19:59 |
| vkmc | Doraly's patch on notifications was abandoned and I restored it because I thought Eva-i wanted to work on those reusing the code that was there | 19:59 |
| vkmc | but you, flwang1, are creating a different patch set for the same? | 19:59 |
| flwang1 | i'm not aware of there is a patch, since it's abandoned at Sep | 20:00 |
| flwang1 | so that's why i created https://review.openstack.org/249395 | 20:01 |
| Eva-i | vkmc: I think yes, he's making the patch solving the same problem | 20:01 |
| vkmc | ok so let's abandon that again, remove the dependency, and work on claims separately | 20:01 |
| Eva-i | okay, so it's decided then | 20:01 |
| vkmc | +1 | 20:02 |
| flwang1 | vkmc: sorry for the confustion | 20:02 |
| vkmc | it's ok, thanks you guys for working on it | 20:02 |
| vkmc | :) | 20:02 |
| flwang1 | vkmc: https://review.openstack.org/248982 this one is very critical i think | 20:03 |
| flwang1 | any user of our client can't create a queue | 20:05 |
| flwang1 | with command line | 20:05 |
| *** flwang1 has quit IRC | 20:29 | |
| *** flwang1 has joined #openstack-zaqar | 20:29 | |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Added support to claims https://review.openstack.org/213165 | 20:35 |
| Eva-i | Sorry it took so long | 20:36 |
| Eva-i | flwang1: now this patch is rebased and fixed a bit, what would you like me to do now? | 20:36 |
| *** ig0r_ has joined #openstack-zaqar | 20:37 | |
| openstackgerrit | Merged openstack/zaqar: Updated from global requirements https://review.openstack.org/256537 | 20:39 |
| flwang1 | Eva-i: these files Azaqarclient/tests/queues/v1/__init__.py0 linesSide-by-SideUnified Rzaqarclient/tests/queues/v1/queues.pyrenamed from zaqarclient/tests/queues/queues.py+0, -0Side-by-SideUnified Azaqarclient/tests/queues/v2/claims.py79 linesSide-by-SideUnified | 20:46 |
| flwang1 | should be restored | 20:46 |
| flwang1 | we don't need them | 20:47 |
| flwang1 | see https://review.openstack.org/245415 | 20:47 |
| *** rcernin has joined #openstack-zaqar | 20:56 | |
| Eva-i | flwang: can you please clarify a bit what do you mean? Should I delete them? | 20:59 |
| *** pradk has quit IRC | 21:31 | |
| *** dmowrer has quit IRC | 21:34 | |
| *** dmowrer has joined #openstack-zaqar | 21:35 | |
| *** pradk has joined #openstack-zaqar | 21:36 | |
| *** pradk has quit IRC | 21:37 | |
| *** dmowrer has quit IRC | 21:39 | |
| *** pradk has joined #openstack-zaqar | 21:42 | |
| *** pradk has quit IRC | 21:55 | |
| *** mpanetta has quit IRC | 21:59 | |
| *** sriram has quit IRC | 22:30 | |
| *** dmowrer has joined #openstack-zaqar | 22:36 | |
| *** openstackgerrit has quit IRC | 22:37 | |
| *** openstackgerrit has joined #openstack-zaqar | 22:37 | |
| *** rcernin has quit IRC | 22:37 | |
| *** dmowrer has quit IRC | 22:40 | |
| *** tej has quit IRC | 22:42 | |
| *** shakamunyi has joined #openstack-zaqar | 22:51 | |
| *** shakamunyi has quit IRC | 23:00 | |
| *** amitgandhinz has quit IRC | 23:11 | |
| *** amitgandhinz has joined #openstack-zaqar | 23:24 | |
| *** shakamunyi has joined #openstack-zaqar | 23:26 | |
| *** shakamunyi has quit IRC | 23:32 | |
| *** tej has joined #openstack-zaqar | 23:34 | |
| flwang1 | Eva-i: still around? | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!