| *** achanda has quit IRC | 00:07 | |
| *** amitgandhinz has joined #openstack-zaqar | 00:27 | |
| *** flaper87 has quit IRC | 01:27 | |
| *** flaper87 has joined #openstack-zaqar | 01:28 | |
| *** flaper87 has quit IRC | 01:33 | |
| *** flaper87 has joined #openstack-zaqar | 01:39 | |
| *** amitgandhinz has quit IRC | 01:49 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:49 | |
| *** amitgandhinz has quit IRC | 01:54 | |
| *** OneLostSoul has joined #openstack-zaqar | 02:18 | |
| *** flwang1 has quit IRC | 02:31 | |
| *** flwang1 has joined #openstack-zaqar | 02:31 | |
| OneLostSoul | I have questions about the testing. | 02:37 |
|---|---|---|
| *** achanda has joined #openstack-zaqar | 02:37 | |
| *** flwang1 has quit IRC | 02:43 | |
| *** flwang1 has joined #openstack-zaqar | 02:43 | |
| *** flwang1 has quit IRC | 02:46 | |
| vkmc | OneLostSoul, shoot1 | 03:03 |
| vkmc | s/1/! | 03:03 |
| OneLostSoul | I have been looking at notifier.py | 03:07 |
| OneLostSoul | I do not see any functional testing for that feature. | 03:07 |
| OneLostSoul | In test_notifier.py NotifierTest.test_post() .... | 03:09 |
| OneLostSoul | I do not understand why the first two calls to assert_called_with have the same arguments. | 03:10 |
| OneLostSoul | vkmc, can you shed light on these? | 03:11 |
| vkmc | OneLostSoul, could you share me a link? | 03:11 |
| vkmc | code is hosted here https://github.com/openstack/zaqar | 03:11 |
| OneLostSoul | https://github.com/openstack/zaqar/tree/master/tests/functional is the link for the directory of functional testing (if I understand). | 03:15 |
| OneLostSoul | as also is https://github.com/openstack/zaqar/tree/master/zaqar/tests/functional | 03:17 |
| OneLostSoul | https://github.com/openstack/zaqar/tree/master/zaqar/tests/unit/notification/test_notifier.py seems to be the unit test. | 03:18 |
| vkmc | its ok, its under zaqar/tests/unit | 03:19 |
| vkmc | its a unit test | 03:19 |
| vkmc | :) | 03:19 |
| OneLostSoul | Maybe I should have directed my questions to flwang. | 03:19 |
| vkmc | sure | 03:20 |
| OneLostSoul | He asked me to look at notifier | 03:20 |
| vkmc | I don't understand your concern though | 03:20 |
| vkmc | you say that there is no notifications functional test? | 03:20 |
| vkmc | if that is... yes you are right | 03:20 |
| vkmc | there are only unit tests for that feature | 03:20 |
| vkmc | and we should add the functional ones | 03:20 |
| OneLostSoul | First question: answered! | 03:21 |
| vkmc | cool :) | 03:22 |
| OneLostSoul | The sequence of six calls to assert_called_with() I expected to do a vector expansion of the two lists; but it is not (0,0), (0,1), (1,0), (1,1), (2,0), (2,1). | 03:23 |
| OneLostSoul | Does that mean the unit test doesn't properly test? | 03:24 |
| OneLostSoul | Or does the second call to assert_called_with() do something other than an exact repeat of the previous call? | 03:27 |
| OneLostSoul | flwang, can you comment? | 03:28 |
| *** sriram has joined #openstack-zaqar | 03:38 | |
| *** achanda has quit IRC | 03:44 | |
| *** sriram has quit IRC | 03:57 | |
| *** sriram has joined #openstack-zaqar | 03:57 | |
| *** sriram has quit IRC | 04:03 | |
| flwang | OneLostSoul: sorry, I was away. now back | 04:08 |
| flwang | i'm reading your 2nd question | 04:09 |
| flwang | OneLostSoul: there are three subscriptions for the queue, and two messages posted to the queue, then the expected behaviour is the requests.post will be called 6 times | 04:13 |
| flwang | but I didn't really understand what's your question, would you mind explaining more? | 04:15 |
| OneLostSoul | Please compare the first two calls to assert_called_with. | 04:16 |
| OneLostSoul | The arguments are, if I read correctly, identical. | 04:16 |
| OneLostSoul | The six calls should have the pattern (0,0), (0,1), (1,0), (1,1), (2,0), (2,1) ; but it does not. | 04:17 |
| flwang | ah, shit happened :) I will submit a new patch, thanks for the headsup | 04:17 |
| flwang | i definitely missed two cases i think | 04:18 |
| flwang | OneLostSoul: nice catch | 04:18 |
| OneLostSoul | I am thinking that we need a new assert method. | 04:18 |
| flwang | what did you mean a new assert method? | 04:19 |
| OneLostSoul | One that will take the lists and expand out the cross products. | 04:19 |
| OneLostSoul | Then you would have only coded one call with the lists and it would have been right. | 04:20 |
| flwang | but the assert method is from mock library | 04:26 |
| flwang | are you saying to create a customized one? | 04:26 |
| OneLostSoul | Not sure. | 04:26 |
| *** achanda has joined #openstack-zaqar | 04:35 | |
| *** OneLostSoul has quit IRC | 05:17 | |
| *** dynarro has joined #openstack-zaqar | 07:09 | |
| *** dynarro has quit IRC | 07:16 | |
| *** achanda has quit IRC | 07:24 | |
| *** achanda has joined #openstack-zaqar | 07:36 | |
| *** achanda has quit IRC | 07:57 | |
| *** flwang1 has joined #openstack-zaqar | 09:39 | |
| *** flaper87 has quit IRC | 10:05 | |
| *** flaper87 has joined #openstack-zaqar | 10:05 | |
| *** dguerri is now known as _dguerri | 10:59 | |
| *** _dguerri is now known as dguerri | 11:00 | |
| *** dguerri is now known as _dguerri | 11:20 | |
| *** _dguerri is now known as dguerri | 11:37 | |
| *** flwang1 has quit IRC | 11:59 | |
| *** exploreshaifali has joined #openstack-zaqar | 12:04 | |
| *** vkmc has quit IRC | 12:08 | |
| *** vkmc has joined #openstack-zaqar | 12:08 | |
| *** kgriffs|afk is now known as kgriffs | 12:39 | |
| *** sriram has joined #openstack-zaqar | 13:11 | |
| *** kgriffs is now known as kgriffs|afk | 13:33 | |
| *** dguerri is now known as _dguerri | 14:01 | |
| *** _dguerri is now known as dguerri | 14:05 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:13 | |
| *** csoukup has joined #openstack-zaqar | 14:23 | |
| *** achanda has joined #openstack-zaqar | 15:03 | |
| *** davideagnello has quit IRC | 15:07 | |
| *** achanda has quit IRC | 15:08 | |
| *** exploreshaifali has quit IRC | 15:50 | |
| *** kgriffs|afk is now known as kgriffs | 16:39 | |
| *** achanda has joined #openstack-zaqar | 16:52 | |
| *** davideagnello has joined #openstack-zaqar | 16:54 | |
| *** exploreshaifali has joined #openstack-zaqar | 17:08 | |
| *** dguerri is now known as _dguerri | 17:24 | |
| *** _dguerri is now known as dguerri | 17:25 | |
| *** VeggieMeat has quit IRC | 17:29 | |
| *** VeggieMeat has joined #openstack-zaqar | 17:29 | |
| *** dguerri is now known as _dguerri | 18:09 | |
| *** exploreshaifali has quit IRC | 18:25 | |
| *** _dguerri is now known as dguerri | 19:30 | |
| *** dguerri is now known as _dguerri | 20:57 | |
| *** csoukup has quit IRC | 20:59 | |
| *** mpanetta has joined #openstack-zaqar | 21:35 | |
| *** _dguerri is now known as dguerri | 22:12 | |
| *** dguerri is now known as _dguerri | 22:22 | |
| *** amitgandhinz has quit IRC | 22:44 | |
| *** kgriffs is now known as kgriffs|afk | 22:47 | |
| *** ametts has quit IRC | 22:51 | |
| *** achanda has quit IRC | 22:53 | |
| *** sriram has quit IRC | 23:09 | |
| *** kgriffs|afk is now known as kgriffs | 23:47 | |
| *** achanda has joined #openstack-zaqar | 23:53 | |
| *** kgriffs is now known as kgriffs|afk | 23:58 | |
| *** achanda has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!