*** JAHoagie has quit IRC | 00:08 | |
*** flaper87 has quit IRC | 00:11 | |
*** flaper87 has joined #openstack-zaqar | 00:15 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement webhook notifier driver https://review.openstack.org/151529 | 01:27 |
---|---|---|
*** amalagon has joined #openstack-zaqar | 01:34 | |
*** flwang1 has joined #openstack-zaqar | 02:29 | |
flwang1 | vkmc: ping | 02:29 |
vkmc | flwang1, pong | 02:53 |
*** chandankumar has joined #openstack-zaqar | 02:54 | |
*** achanda has quit IRC | 02:59 | |
flwang1 | vkmc: no worries, i have leave the comments on your patch | 03:03 |
flwang1 | will submit them soon | 03:03 |
vkmc | flwang1, k, thanks :) | 03:09 |
vkmc | loooool | 03:17 |
vkmc | clipo is in gerrit | 03:17 |
*** chandankumar has quit IRC | 03:33 | |
*** flwang1 has quit IRC | 04:01 | |
*** achanda has joined #openstack-zaqar | 04:12 | |
*** chandankumar has joined #openstack-zaqar | 04:50 | |
*** reed has quit IRC | 05:29 | |
*** chandankumar has quit IRC | 05:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/169628 | 06:03 |
*** amalagon has quit IRC | 06:06 | |
*** chandankumar has joined #openstack-zaqar | 06:06 | |
*** Nutan has joined #openstack-zaqar | 06:17 | |
*** chandankumar has joined #openstack-zaqar | 06:18 | |
*** dynarro has joined #openstack-zaqar | 06:39 | |
*** flaper87 has quit IRC | 06:45 | |
*** flaper87 has joined #openstack-zaqar | 06:45 | |
flaper87 | flwang: any vote on the devstack patch? | 06:51 |
flaper87 | flwang: btw, how do you test the notifications/webhook thing ? | 06:58 |
flaper87 | flwang: have you been using curl? | 06:58 |
flaper87 | or just unittests? | 06:58 |
openstackgerrit | Merged openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/169628 | 07:16 |
openstackgerrit | Merged openstack/zaqar: Implement webhook notifier driver https://review.openstack.org/151529 | 07:19 |
flaper87 | flwang: ^ | 07:23 |
*** achanda has quit IRC | 07:36 | |
*** achanda has joined #openstack-zaqar | 07:42 | |
*** achanda has quit IRC | 07:43 | |
Nutan | What are common options in zaqar? | 08:29 |
flaper87 | Nutan: options that are used by different packages in zaqar | 08:30 |
Nutan | flaper87: options are defined in bootstrap.py, right? | 08:32 |
flaper87 | Nutan: not all of them. For example, the mongodb options are defined in zaqar.storage.mongodb.options | 08:33 |
flaper87 | but the "global" ones yes, those are in bootstrap | 08:33 |
Nutan | okay, I am actually wanted to know what these parameters mean, for example, cfg.BoolOpt('daemon', default=False, help='Run Zaqar server in the background.'), so first parameter is 'daemon', are these values pre-defined like 'debug' and so on? | 08:38 |
Nutan | Where are they defined? | 08:38 |
flaper87 | Nutan: what do you mean with pre-defined ? | 08:39 |
flaper87 | We need `daemon` to fork zaqar properly when running as a daemon (or in devstack with SCREEN=False) | 08:39 |
Nutan | Yes, just like deamon, 'debug' has been used and it has correponding help message | 08:40 |
*** dynarro has quit IRC | 08:40 | |
Nutan | Can you tell me where is BoolOpt defined? | 08:41 |
*** dynarro has joined #openstack-zaqar | 08:41 | |
flaper87 | Nutan: Ah, that's oslo_config | 08:41 |
flaper87 | it's a library | 08:41 |
flaper87 | The one we use to manage configuration and cli parameters | 08:42 |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Add websockets to our test suite https://review.openstack.org/169313 | 08:47 |
Nutan | okay | 09:05 |
*** Nutan has quit IRC | 09:17 | |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Add websockets to our test suite https://review.openstack.org/169313 | 09:35 |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Remove QueueController from data to control plane https://review.openstack.org/144340 | 10:01 |
*** dynarro has quit IRC | 10:21 | |
*** achanda has joined #openstack-zaqar | 10:44 | |
*** achanda has quit IRC | 10:48 | |
*** amalagon has joined #openstack-zaqar | 11:32 | |
vkmc | morning o/ | 11:36 |
*** amalagon has quit IRC | 11:36 | |
*** JAHoagie has joined #openstack-zaqar | 11:48 | |
flaper87 | vkmc: yo yo! | 11:49 |
*** JAHoagie has quit IRC | 11:52 | |
vkmc | flaper87, watcha doin'? | 11:54 |
flaper87 | vkmc: OpenStack housekeeping :/ | 11:55 |
flaper87 | We need to merge the remaining patches | 11:56 |
flaper87 | :D | 11:56 |
vkmc | oh yes | 11:56 |
vkmc | can I help with something? | 11:56 |
flaper87 | I'd like to set up an environment with latest Zaqar to test notifications | 11:56 |
* vkmc sends gummybears and coffee to flaper87 | 11:56 | |
flaper87 | jasondotstar: there? You were working on the puppet manifests for Zaqar, right? | 11:59 |
flaper87 | vkmc: could you try to replicate this? http://logs.openstack.org/13/169313/4/check/gate-zaqar-python34/94359d4/console.html | 12:21 |
vkmc | flaper87, sure | 12:22 |
flaper87 | vkmc: thank you :) | 12:23 |
vkmc | no problema | 12:23 |
* flaper87 can't create a py34 env | 12:23 | |
flaper87 | stupid python | 12:23 |
flaper87 | flwang: can we mark this blueprint as implemented? https://blueprints.launchpad.net/zaqar/+spec/notifications | 12:46 |
flaper87 | vkmc: what's left to do for websockets? | 12:47 |
vkmc | flaper87, it depends | 12:47 |
vkmc | I was planning to cover claims as well | 12:47 |
vkmc | but I'm not sure if we are ok with time | 12:47 |
vkmc | I can have it done by this afternoon | 12:47 |
vkmc | pools, flavors and notifications will be implemented in liberty | 12:47 |
flaper87 | I was thinking this morning that it might be a good idea to push this websockets feature to L | 12:48 |
flaper87 | it's in a good state but there are still missing pieces | 12:48 |
vkmc | yes I agree | 12:48 |
flaper87 | that are important for it to be completely usable | 12:48 |
flaper87 | ok | 12:48 |
flaper87 | lets do that | 12:48 |
vkmc | we are not fully mapping all the Zaqar API | 12:48 |
vkmc | that is my only concern | 12:48 |
vkmc | we could have it in Kilo, but as experimental | 12:49 |
vkmc | or tech preview | 12:49 |
vkmc | what do you think? | 12:49 |
vkmc | flaper87, ^ | 12:50 |
flaper87 | vkmc: it will be shipped as-is for sure. One thing we should do, though, is to have a warning there saying it's experimental | 12:51 |
flaper87 | I can do that | 12:51 |
vkmc | flaper87, that sounds grea | 12:51 |
vkmc | t | 12:51 |
*** chandankumar has quit IRC | 12:52 | |
vkmc | the basic prod-cons scenario is being covered | 12:52 |
vkmc | IMO that's good enough for a tech preview | 12:52 |
vkmc | I'll try to work on the benchmarks soon, that will make it even better | 12:53 |
vkmc | I have to adapt the client for that | 12:53 |
flaper87 | vkmc: sounds good, lemme know if I can help | 12:56 |
vkmc | oki | 12:56 |
flaper87 | btw, pls, review the QueueController patch | 12:56 |
flaper87 | :) | 12:56 |
vkmc | I'm on it | 12:56 |
flaper87 | awesome | 12:56 |
vkmc | I know, thanks | 12:57 |
flaper87 | LOOOOOL | 12:59 |
*** dynarro has joined #openstack-zaqar | 13:02 | |
*** sriram has joined #openstack-zaqar | 13:09 | |
*** JAHoagie has joined #openstack-zaqar | 13:10 | |
vkmc | flaper87, I could reproduce the error in py34 | 13:21 |
vkmc | I gotta rush now, but I'll debug when I'm back | 13:21 |
flaper87 | vkmc: awesome, thanks! | 13:23 |
*** mpanetta has joined #openstack-zaqar | 13:26 | |
-openstackstatus- NOTICE: gerrit has been restarted to restore event streaming. any change events missed by zuul (between 12:48 and 13:28 utc) will need to be rechecked or have new approval votes set | 13:29 | |
*** sriram has quit IRC | 13:33 | |
*** amitgandhinz has joined #openstack-zaqar | 13:34 | |
*** sriram has joined #openstack-zaqar | 13:34 | |
*** chandankumar has joined #openstack-zaqar | 13:53 | |
*** ametts has joined #openstack-zaqar | 13:58 | |
*** cpallares has joined #openstack-zaqar | 13:59 | |
*** ametts has quit IRC | 14:27 | |
*** exploreshaifali has joined #openstack-zaqar | 14:39 | |
flaper87 | vkmc: back ? | 14:58 |
vkmc | back | 14:58 |
flaper87 | vkmc: ok, lemme know if/when you have time to debug that py34 issue, it's annoying | 14:59 |
flaper87 | it has something to do with ddt's decorator | 15:00 |
flaper87 | but it seemed to work on other places | 15:00 |
flaper87 | so, no idea | 15:00 |
flaper87 | vkmc: btw, did you file a bug for that "queue validation" issue you found? | 15:02 |
vkmc | not yet | 15:02 |
vkmc | I have it in my TODO: queue validation for lazy queue creation and another bug I don't remember now | 15:03 |
flaper87 | vkmc: ok, when you do, that sounds like a bug dynarro could work on, unless you fixed it alreay | 15:04 |
vkmc | flaper87, no, I haven't fix it | 15:04 |
vkmc | it has dynarro's name | 15:04 |
flaper87 | vkmc: WHAT? YOU HAVEN'T FIXED IT? You dissapoint me | 15:05 |
vkmc | D: | 15:05 |
openstackgerrit | Doraly Navarro proposed openstack/zaqar: makes uri unique to avoid duplicated pools https://review.openstack.org/169798 | 15:12 |
*** dynarro has quit IRC | 15:21 | |
*** JAHoagie has quit IRC | 15:23 | |
vkmc | oh ok ok | 15:31 |
*** exploreshaifali has quit IRC | 15:31 | |
vkmc | I think I get what this is about | 15:31 |
*** chandankumar has quit IRC | 15:35 | |
*** reed has joined #openstack-zaqar | 15:35 | |
openstackgerrit | Victoria MartÃnez de la Cruz proposed openstack/zaqar: Add websockets to our test suite https://review.openstack.org/169313 | 15:43 |
vkmc | flaper87, ^ | 15:43 |
*** JAHoagie has joined #openstack-zaqar | 16:17 | |
*** exploreshaifali has joined #openstack-zaqar | 16:25 | |
*** dynarro has joined #openstack-zaqar | 16:25 | |
*** amitgandhinz has quit IRC | 16:26 | |
*** amitgandhinz has joined #openstack-zaqar | 16:28 | |
*** dynarro has quit IRC | 16:30 | |
*** JAHoagie has quit IRC | 16:32 | |
*** JAHoagie has joined #openstack-zaqar | 16:39 | |
*** amitgandhinz has quit IRC | 16:48 | |
*** achanda has joined #openstack-zaqar | 17:08 | |
*** achanda has quit IRC | 17:10 | |
*** achanda has joined #openstack-zaqar | 17:14 | |
*** davideag_ has joined #openstack-zaqar | 17:30 | |
*** davideagnello has quit IRC | 17:33 | |
*** ametts has joined #openstack-zaqar | 17:43 | |
*** exploreshaifali has quit IRC | 17:47 | |
*** Akanksha08 has joined #openstack-zaqar | 17:58 | |
Akanksha08 | Hi | 17:58 |
Akanksha08 | I am working on this issue https://bugs.launchpad.net/zaqar/+bug/1429393 | 17:59 |
openstack | Launchpad bug 1429393 in zaqar "Move debug option to common options" [Medium,In progress] - Assigned to Akanksha (akanksha-aha) | 17:59 |
Akanksha08 | did a grep and found this https://github.com/openstack/zaqar/blob/master/zaqar/transport/websocket/driver.py#L36 | 18:00 |
Akanksha08 | so there is a debug option but that I could find that option for only this particular driver | 18:00 |
Akanksha08 | Is it expected to move only this option to the common options? | 18:02 |
*** dynarro has joined #openstack-zaqar | 18:05 | |
vkmc | Akanksha08, hi! | 18:17 |
vkmc | let me check | 18:17 |
Akanksha08 | Hi | 18:18 |
Akanksha08 | okay | 18:18 |
openstackgerrit | Doraly Navarro proposed openstack/zaqar: makes uri unique to avoid duplicated pools https://review.openstack.org/169798 | 18:45 |
Akanksha08 | vkmc, did you check? | 18:47 |
*** achanda has quit IRC | 18:52 | |
vkmc | Akanksha08, I did | 18:56 |
vkmc | as you say, the only appearance is in websocket | 18:56 |
vkmc | so only fix it there | 18:56 |
Akanksha08 | okay | 18:56 |
vkmc | probably for future additions we are going to use the debug option from common | 18:56 |
*** dynarro has quit IRC | 18:59 | |
Akanksha08 | okay | 18:59 |
Akanksha08 | By common do you mean the general options which are global | 19:01 |
Akanksha08 | https://github.com/openstack/zaqar/blob/ae7996869ff78f7377d9038ee09ef1deb2fbef6b/zaqar/bootstrap.py#L47 | 19:01 |
vkmc | Akanksha08, correct | 19:03 |
Akanksha08 | cool! Will do it then. | 19:04 |
Akanksha08 | Thanks a lot! | 19:04 |
vkmc | np, thanks to you | 19:04 |
Akanksha08 | :) | 19:07 |
flaper87 | vkmc: Thanks for fixing that issue with py34 <3 | 19:11 |
*** kgriffs|afk is now known as kgriffs | 19:11 | |
flaper87 | now, review the freaking patch | 19:12 |
flaper87 | :P | 19:12 |
flaper87 | and the QueueController one | 19:12 |
flaper87 | brb, dinner | 19:12 |
*** kgriffs is now known as kgriffs|afk | 19:12 | |
vkmc | flaper87, np :) | 19:13 |
vkmc | enjoy | 19:13 |
vkmc | roger that | 19:13 |
vkmc | I'll check the queuecontroller in a while, it looks good but I should re read it | 19:21 |
*** achanda has joined #openstack-zaqar | 19:23 | |
*** mpanetta has quit IRC | 19:26 | |
*** ametts has quit IRC | 19:27 | |
openstackgerrit | Akanksha proposed openstack/zaqar: Moves debug option to common options https://review.openstack.org/169894 | 19:38 |
*** reed has quit IRC | 19:40 | |
*** davideag_ has quit IRC | 19:57 | |
*** Akanksha08 has quit IRC | 19:57 | |
*** davideagnello has joined #openstack-zaqar | 19:58 | |
*** davideagnello has quit IRC | 19:58 | |
*** davideagnello has joined #openstack-zaqar | 19:58 | |
flwang | flaper87: done | 20:01 |
*** JAHoagie has quit IRC | 20:20 | |
*** amitgandhinz has joined #openstack-zaqar | 20:25 | |
*** JAHoagie has joined #openstack-zaqar | 20:30 | |
flaper87 | flwang: can I get your review here? https://review.openstack.org/#/c/144340/ | 20:41 |
flaper87 | We need to land that asap so pls, any feedback is important | 20:41 |
flaper87 | flwang: also, https://review.openstack.org/#/c/169313/ | 20:42 |
*** mpanetta has joined #openstack-zaqar | 20:49 | |
flwang | flaper87: yep, sir | 20:51 |
flaper87 | flwang: PLEASE, PLEASE, PLEASE, PLEASE! | 20:52 |
flwang | I need some time for https://review.openstack.org/#/c/144340/ | 20:53 |
flwang | it's a big change | 20:53 |
flaper87 | flwang: yes but please, I beg you to tackle it today if possible | 20:54 |
flwang | flaper87: i will do that today :) | 20:56 |
flaper87 | flwang: awesome, thanks! | 20:57 |
flwang | anytime, sir | 20:57 |
flwang | btw, I will be in vacation from tomorrow until next Thu | 20:57 |
*** achanda has quit IRC | 21:06 | |
*** flwang1 has joined #openstack-zaqar | 21:10 | |
flwang1 | flaper87: do we still need this https://review.openstack.org/#/c/146354/ ? | 21:11 |
*** sriram has quit IRC | 21:16 | |
*** amitgandhinz has quit IRC | 21:17 | |
*** achanda has joined #openstack-zaqar | 21:18 | |
flaper87 | flwang1: yes, we need that! | 21:19 |
flaper87 | flwang1: thanks for the heads up | 21:19 |
flwang1 | flaper87: could you pls review it? | 21:19 |
flwang1 | i think we need to get it in to keep the design be consistent with the code | 21:19 |
*** boris-42 has quit IRC | 21:28 | |
openstackgerrit | Merged openstack/zaqar: Add websockets to our test suite https://review.openstack.org/169313 | 21:32 |
*** boris-42 has joined #openstack-zaqar | 21:57 | |
*** flwang1 has quit IRC | 22:03 | |
*** cpallares has quit IRC | 22:14 | |
*** mpanetta has quit IRC | 22:16 | |
*** reed has joined #openstack-zaqar | 22:59 | |
*** reed has left #openstack-zaqar | 22:59 | |
*** JAHoagie has quit IRC | 23:11 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!