*** achanda has quit IRC | 00:15 | |
*** achanda has joined #openstack-zaqar | 00:16 | |
*** achanda has quit IRC | 00:18 | |
*** achanda has joined #openstack-zaqar | 00:18 | |
*** achanda has quit IRC | 00:30 | |
*** chandankumar has joined #openstack-zaqar | 02:44 | |
*** exploreshaifali has joined #openstack-zaqar | 02:55 | |
*** exploreshaifali has quit IRC | 03:00 | |
*** chandankumar has quit IRC | 03:05 | |
*** cpallares has quit IRC | 03:21 | |
vkmc | flwang, so, that change is missing something, not sure what :( | 03:30 |
---|---|---|
flwang | vkmc: yep, I will take a look later, let's work it out | 03:32 |
flwang | btw, I would like to apply for the FFE for notification | 03:32 |
flwang | but I can't catch flaper87, pls forward my request to him if you meet him | 03:32 |
vkmc | sure | 03:33 |
vkmc | I'll let him know | 03:33 |
*** csoukup has joined #openstack-zaqar | 03:33 | |
*** exploreshaifali has joined #openstack-zaqar | 03:39 | |
*** chandankumar has joined #openstack-zaqar | 03:39 | |
*** csoukup has quit IRC | 03:48 | |
*** flwang1 has quit IRC | 03:50 | |
*** csoukup has joined #openstack-zaqar | 04:04 | |
*** csoukup has quit IRC | 04:09 | |
*** boris-42 has joined #openstack-zaqar | 04:47 | |
*** achanda has joined #openstack-zaqar | 05:06 | |
*** exploreshaifali has quit IRC | 05:23 | |
*** achanda has quit IRC | 06:25 | |
*** achanda has joined #openstack-zaqar | 06:27 | |
openstackgerrit | Zhi Yan Liu proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 07:20 |
*** achanda has quit IRC | 07:35 | |
*** achanda has joined #openstack-zaqar | 07:39 | |
*** achanda has quit IRC | 08:10 | |
*** exploreshaifali has joined #openstack-zaqar | 08:12 | |
openstackgerrit | Zhi Yan Liu proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 08:24 |
*** dynarro has joined #openstack-zaqar | 08:40 | |
*** boris-42 has quit IRC | 09:12 | |
*** dynarro has quit IRC | 09:40 | |
*** amalagon has quit IRC | 10:02 | |
*** amalagon has joined #openstack-zaqar | 10:03 | |
*** exploreshaifali has quit IRC | 10:21 | |
*** exploreshaifali has joined #openstack-zaqar | 10:45 | |
*** boris-42 has joined #openstack-zaqar | 10:51 | |
*** achanda has joined #openstack-zaqar | 11:45 | |
*** achanda has quit IRC | 11:49 | |
vkmc | morning | 11:51 |
*** bradjones has joined #openstack-zaqar | 12:17 | |
*** bradjones has joined #openstack-zaqar | 12:17 | |
flaper87 | vkmc: gooooooooooood morning | 12:28 |
flaper87 | vkmc: could you review dynarro's patch ? | 12:30 |
vkmc | flaper87, buen dia seƱor Fla | 12:30 |
vkmc | flaper87, yeah, I rebased exploreshaifali patch on it | 12:31 |
vkmc | I'll approve | 12:31 |
vkmc | not sure what is missing from exploreshaifali patch | 12:32 |
vkmc | but its blocking flwang | 12:32 |
vkmc | btw, he asked for FFE | 12:32 |
exploreshaifali | gooooooooood morning! | 12:33 |
exploreshaifali | I am working for patch only | 12:34 |
vkmc | https://review.openstack.org/#/c/165153/ <- flaper87, where is my torroncini? | 12:34 |
exploreshaifali | will notify in few minutes :) | 12:34 |
vkmc | exploreshaifali, how is it going? | 12:34 |
exploreshaifali | vkmc, looking what else is needed, though there will be many test cases that will fail | 12:35 |
exploreshaifali | as now I will remove queuecontroller and queuedatabase methods from DataDriver | 12:35 |
vkmc | cool | 12:35 |
vkmc | makes sense | 12:35 |
vkmc | flaper87, https://review.openstack.org/#/q/status:open+project:openstack/zaqar+branch:master+topic:bp/persistent-transport,n,z | 12:43 |
exploreshaifali | flaper87, vkmc now we are getting obvious error - Stage <zaqar.storage.mongodb.messages.MessageQueueHandler instance at 0x7fb1fc4644d0> does not implement create | 12:59 |
exploreshaifali | do we need to add a create method inside messageQueueHandler? | 12:59 |
exploreshaifali | What we have decided is only to keep those methods inside MessageQueueHandler that need message_controller() | 13:00 |
exploreshaifali | one more thing | 13:01 |
*** boris-42 has quit IRC | 13:02 | |
exploreshaifali | redis queues._create method https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/queues.py#L136 needs message_controller() so I am shifting this method also into redis's MessageQueueHandler | 13:02 |
vkmc | exploreshaifali, those are warnings | 13:03 |
vkmc | exploreshaifali, I think we would require changing the pipeline implementation, but I dunno what flaper87 has in mind | 13:03 |
vkmc | exploreshaifali, leave them as is right now and focus on debugging the tests | 13:03 |
exploreshaifali | vkmc, okay :D | 13:04 |
openstackgerrit | Merged openstack/zaqar: Make the Pipeline inmutable https://review.openstack.org/165153 | 13:05 |
* flaper87 back | 13:09 | |
flaper87 | vkmc: I ate your torroncini | 13:09 |
vkmc | flaper87, you wouldn't dare | 13:11 |
*** sriram has joined #openstack-zaqar | 13:11 | |
*** dynarro has joined #openstack-zaqar | 13:12 | |
vkmc | dynarro, Merged openstack/zaqar: Make the Pipeline inmutable https://review.openstack.org/165153 | 13:13 |
vkmc | dynarro, thx :) | 13:13 |
dynarro | vkmc: np ;) | 13:13 |
vkmc | flaper87, btw, I managed to check out the tests yesterday | 13:16 |
vkmc | flaper87, websocket | 13:16 |
vkmc | it doesn't seem we are using the transport at all, we are simply testing the api | 13:17 |
vkmc | is that right? | 13:17 |
*** boris-42 has joined #openstack-zaqar | 13:40 | |
*** amitgandhinz has joined #openstack-zaqar | 13:47 | |
*** csoukup has joined #openstack-zaqar | 13:48 | |
*** fifieldt has quit IRC | 13:51 | |
openstackgerrit | Merged openstack/zaqar: This change adds missing help strings for claims https://review.openstack.org/163168 | 13:54 |
flaper87 | vkmc: that sounds correct | 13:56 |
flaper87 | for the unittests, we don't need to go through the wire | 13:57 |
*** cpallares has joined #openstack-zaqar | 13:57 | |
vkmc | flaper87, all right | 13:59 |
vkmc | no, I lied | 13:59 |
flaper87 | lol | 14:00 |
flaper87 | LIAR! | 14:00 |
vkmc | if we don't go through the wire we are not testing the transport at all | 14:00 |
vkmc | we are testing the api | 14:00 |
vkmc | only | 14:00 |
vkmc | in the case of WSGI, Falcon provides an structure to create the environment for the request being issued | 14:00 |
vkmc | but in this case, we don't have that | 14:00 |
*** cpallares has quit IRC | 14:03 | |
flaper87 | vkmc: well, the wire is just one part of the whole workflow that we're skipping in the unittests but we won't skip in the functional tests | 14:03 |
flaper87 | The most importan parts are precisely testing the API, the response objects, the request objects, etc | 14:03 |
vkmc | flaper87, ok, so... maybe it would be clearer if we put those unit tests under an api module | 14:04 |
flaper87 | vkmc: where are they right now ? | 14:04 |
flaper87 | I guess yeah, that'd make sense, but we need to have that documented somewhere | 14:05 |
vkmc | flaper87, transport/websocket | 14:05 |
exploreshaifali | vkmc, this is some I am playing with, could not figure out what to do http://paste.openstack.org/show/193118/ | 14:14 |
*** amalagon has quit IRC | 14:21 | |
*** amalagon has joined #openstack-zaqar | 14:28 | |
*** exploreshaifali has quit IRC | 14:31 | |
*** mpanetta has joined #openstack-zaqar | 14:35 | |
*** achanda has joined #openstack-zaqar | 14:47 | |
*** achanda has quit IRC | 14:52 | |
*** reed has joined #openstack-zaqar | 14:59 | |
*** chandankumar has quit IRC | 14:59 | |
*** chandankumar has joined #openstack-zaqar | 14:59 | |
*** amalagon has quit IRC | 15:00 | |
*** amalagon has joined #openstack-zaqar | 15:00 | |
*** cpallares has joined #openstack-zaqar | 15:18 | |
*** pcaruana has joined #openstack-zaqar | 15:19 | |
*** amalagon has quit IRC | 15:38 | |
openstackgerrit | Victor Sergeyev proposed openstack/zaqar: Use generate_uuid() from oslo.utils https://review.openstack.org/165466 | 15:41 |
*** chandankumar has quit IRC | 16:03 | |
*** exploreshaifali has joined #openstack-zaqar | 16:06 | |
*** amalagon has joined #openstack-zaqar | 16:10 | |
*** dynarro has quit IRC | 16:34 | |
*** amalagon has quit IRC | 16:34 | |
*** akanksha has joined #openstack-zaqar | 16:44 | |
akanksha | vkmc: ping? | 16:44 |
vkmc | akanksha, pong | 16:44 |
akanksha | vkmc, hello. I am sorry I was out of action for a while. My university exams were going on. Just two more left now. I worked on two bugs but I am having issues submitting patches and running tests. | 16:46 |
vkmc | akanksha, I saw you submitted one already, the UUID one | 16:47 |
akanksha | I didnt submit it on gerrit yet. I just discussed it with shaifali on irc. I cant seem to submit a patch. I get an error message saying I havent updated contact information and when I try to do that I get an error from the openstack review server. Also I need to work on my Outreachy Application for which I wanted to discuss the project under you. | 16:49 |
vkmc | akanksha, isn't this yours? https://review.openstack.org/#/c/164671/ | 16:51 |
akanksha | Vkmc, No, | 16:52 |
vkmc | akanksha, you were working on that, right? | 16:52 |
akanksha | And also I looked through this patch. It isnt what kgriffs wanted as far as I know. He discussed some of it with me. | 16:52 |
akanksha | Yeah I have. | 16:52 |
vkmc | I remember seeing that discussion | 16:53 |
vkmc | and considering that the patch was submitted one day after it, I thought it was yours | 16:53 |
akanksha | I worked on it and tried to submit but ran into issues and then I had my exams this week so I couldnt work further. | 16:54 |
vkmc | its ok | 16:54 |
vkmc | ok, submit it anyways | 16:54 |
vkmc | what blockers did you find? | 16:55 |
akanksha | https://usercontent.irccloud-cdn.com/file/kUM1LjJR/Screen+Shot+2015-03-18+at+10.31.19+pm.png | 16:58 |
*** openstackgerrit has quit IRC | 16:59 | |
vkmc | akanksha, did you add your affiliation? | 16:59 |
*** openstackgerrit has joined #openstack-zaqar | 16:59 | |
akanksha | No | 16:59 |
akanksha | vkmc, how do i do that? | 17:00 |
vkmc | akanksha, you have to do so when you register here https://www.openstack.org/join/ | 17:00 |
akanksha | vkmc, on it! | 17:01 |
*** achanda has joined #openstack-zaqar | 17:04 | |
akanksha | vkmc, I got it done. Thanks a lot. I'll submit my patch asap. | 17:08 |
akanksha | vkmc, meanwhile can we discuss the project? | 17:08 |
vkmc | akanksha, sure | 17:09 |
vkmc | which one you were interested in? | 17:09 |
akanksha | So my primary interest is in the adding v1.1 feature support in zaqar-python client | 17:09 |
vkmc | ok | 17:10 |
akanksha | While working on the redis bug I happened to look around the code a bit and I also looked up pythonclient code on github, | 17:10 |
vkmc | great | 17:10 |
vkmc | well, you may have noticed that we have three versions of the server currently | 17:11 |
vkmc | v1, already frozen | 17:11 |
vkmc | v1.1, current version | 17:11 |
vkmc | v2, next version, under development | 17:11 |
vkmc | there are some features missing from the client, and we would like to add support from them | 17:11 |
vkmc | those features are flavors (flaper87 add some support for it, but it requires some extension), capabilities, notifications and websockets | 17:12 |
vkmc | the timeline should be as follows | 17:13 |
akanksha | Okay. So I need to add a timeline in my project proposal. We can break all the tasks down (perhaps feature wise) and can you tell me exactly how much time and effort do you estimate will be required for each of the task. | 17:13 |
vkmc | sure | 17:14 |
*** bradjones has quit IRC | 17:14 | |
vkmc | weeks 1,2: time for you to get more involved with the code base and with the zaqar team | 17:14 |
vkmc | weeks 3,4: extend support for flavors, add the tests for it | 17:14 |
vkmc | weeks 5,6: add support for notifications, add the tests for it | 17:14 |
vkmc | weeks 7,8: add support for capabilities, add the tests for it | 17:15 |
vkmc | weeks 9, 10: add support for websockets, add the tests for it | 17:15 |
*** exploreshaifali has quit IRC | 17:15 | |
vkmc | week 11: polishing and documentation | 17:15 |
vkmc | week 12: backup week in case some task takes more time than expected | 17:16 |
vkmc | we hope you can also help us with bug fixing, bug triaging and reviewing tasks during the internship | 17:16 |
vkmc | its not mandatory but it generally is good if you have some other stuff to do if you find a blocker in your main task | 17:16 |
vkmc | how does that sound? | 17:16 |
akanksha | This sounds perfect. Thanks so much! :)I already worked on my proposal a bit lemme add this information. I'll send you the link to my propsal in a minute. Can you please review it. | 17:18 |
vkmc | sure thing | 17:19 |
vkmc | looking forward for it | 17:19 |
akanksha | vkmc, heres the rough draft of my proposal. | 17:53 |
akanksha | https://docs.google.com/document/d/1s4_FN5vhaQ_S8Nx8BH3PAZIAwVb_iCyuo_LMrT9nzRM/edit | 17:53 |
vkmc | akanksha, thx | 17:55 |
vkmc | akanksha, it looks really good | 17:58 |
*** exploreshaifali has joined #openstack-zaqar | 18:00 | |
akanksha | vkmc, Thanks :D I am going to update my github repository soon with my college classwork and projects soon and put in a link to that under Projects section. Apart from that do you think I need to work on the timeline or read up more about the project? | 18:05 |
vkmc | hmm you seem to have a good understanding of the project :) and the timeline looks fine as well | 18:11 |
vkmc | focus on submit your contribution | 18:11 |
vkmc | so you can upload the application | 18:11 |
akanksha | Yeah I will get the submission done by today hopefully. | 18:13 |
vkmc | cool | 18:13 |
exploreshaifali | vkmc, some thoughts on http://paste.openstack.org/show/193118/ please | 18:21 |
vkmc | exploreshaifali, sure :) | 18:23 |
exploreshaifali | :D | 18:23 |
openstackgerrit | Akanksha Srivastava proposed openstack/zaqar: Correcting Instruction For Mongodb URI in README.rst https://review.openstack.org/165547 | 18:26 |
akanksha | This was a test commit on one of the easier bugs just to test out whether I could submit patches. Uploading the next one soon. | 18:28 |
vkmc | akanksha, its really good, that could count as your contribution | 18:33 |
vkmc | akanksha, what we look in the first contributions is that you gain practice with the process | 18:33 |
vkmc | so a fix like that is good for us :) | 18:33 |
akanksha | vkmc, :) | 18:45 |
vkmc | akanksha, also, good catch! | 18:45 |
*** achanda has quit IRC | 18:48 | |
*** achanda has joined #openstack-zaqar | 19:01 | |
*** exploreshaifali has quit IRC | 19:13 | |
*** boris-42 has quit IRC | 19:37 | |
*** boris-42 has joined #openstack-zaqar | 19:41 | |
*** kgriffs|afk has quit IRC | 19:58 | |
*** kgriffs|afk has joined #openstack-zaqar | 19:59 | |
*** kgriffs|afk is now known as kgriffs | 19:59 | |
*** flwang has quit IRC | 19:59 | |
*** achanda has quit IRC | 20:00 | |
*** flwang has joined #openstack-zaqar | 20:01 | |
flwang | flaper87: ping | 20:02 |
*** openstackgerrit has quit IRC | 20:14 | |
*** openstackgerrit has joined #openstack-zaqar | 20:15 | |
*** exploreshaifali has joined #openstack-zaqar | 20:16 | |
*** achanda has joined #openstack-zaqar | 20:48 | |
*** exploreshaifali has quit IRC | 20:56 | |
openstackgerrit | Merged openstack/zaqar: Adds a status code field to the Response https://review.openstack.org/164007 | 21:22 |
*** flaper87 has quit IRC | 21:50 | |
*** flaper87 has joined #openstack-zaqar | 21:53 | |
*** csoukup has quit IRC | 21:59 | |
*** boris-42 has quit IRC | 22:02 | |
*** sriram has quit IRC | 22:10 | |
openstackgerrit | Akanksha Srivastava proposed openstack/zaqar: Decorator fuction to Validate UUIDs in Redis Driver https://review.openstack.org/165632 | 22:25 |
akanksha | vkmc, ping | 22:26 |
akanksha | ? | 22:26 |
vkmc | akanksha, hey | 22:26 |
akanksha | I submitted a patch but I am not sure if I ran all the tests properly. | 22:26 |
*** amitgandhinz has quit IRC | 22:27 | |
*** cpallares has quit IRC | 22:30 | |
*** echevemaster has joined #openstack-zaqar | 22:54 | |
*** boris-42 has joined #openstack-zaqar | 23:30 | |
vkmc | flwang, hi, around? | 23:45 |
vkmc | or kragniz maybe? | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!