*** kgriffs is now known as kgriffs|afk | 01:03 | |
*** zhenq has joined #openstack-zaqar | 02:02 | |
*** sriram has joined #openstack-zaqar | 02:30 | |
*** zhenq has quit IRC | 03:01 | |
*** sriram has quit IRC | 03:20 | |
*** reed has quit IRC | 03:56 | |
*** achanda has joined #openstack-zaqar | 03:56 | |
*** exploreshaifali has joined #openstack-zaqar | 05:18 | |
*** exploreshaifali has quit IRC | 05:29 | |
*** achanda has quit IRC | 05:43 | |
*** achanda has joined #openstack-zaqar | 05:46 | |
*** pcaruana has quit IRC | 05:47 | |
*** davideagnello has quit IRC | 05:53 | |
*** cpallares has quit IRC | 06:13 | |
*** achanda has quit IRC | 07:47 | |
*** achanda has joined #openstack-zaqar | 07:54 | |
*** fifieldt has joined #openstack-zaqar | 08:09 | |
*** achanda has quit IRC | 08:20 | |
*** achanda has joined #openstack-zaqar | 08:24 | |
*** achanda has quit IRC | 08:30 | |
flaper87 | flwang: ping | 08:37 |
---|---|---|
*** achanda has joined #openstack-zaqar | 08:37 | |
*** achanda has quit IRC | 08:47 | |
*** exploreshaifali has joined #openstack-zaqar | 08:54 | |
*** fifieldt has quit IRC | 08:56 | |
*** exploreshaifali has quit IRC | 11:03 | |
*** exploreshaifali has joined #openstack-zaqar | 11:32 | |
*** exploreshaifali has quit IRC | 11:50 | |
vkmc | heeeeeeello | 11:57 |
kragniz | ello | 11:58 |
*** exploreshaifali has joined #openstack-zaqar | 12:09 | |
*** zhenq has joined #openstack-zaqar | 12:34 | |
*** exploreshaifali has quit IRC | 13:43 | |
flaper87 | LOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOL https://twitter.com/kelseyhightower/status/567488210897350656 | 14:04 |
* flaper87 rofl | 14:04 | |
flaper87 | goooooood morning PEOPLE! | 14:05 |
kragniz | flaper87: lol | 14:05 |
*** csoukup has joined #openstack-zaqar | 14:06 | |
vkmc | lol | 14:07 |
*** sriram has joined #openstack-zaqar | 14:07 | |
*** JAHoagie has joined #openstack-zaqar | 14:31 | |
*** kgriffs|afk is now known as kgriffs | 14:52 | |
*** exploreshaifali has joined #openstack-zaqar | 14:57 | |
*** malini has joined #openstack-zaqar | 15:09 | |
*** amitgandhinz has joined #openstack-zaqar | 15:14 | |
*** JAHoagie has quit IRC | 15:16 | |
*** achanda has joined #openstack-zaqar | 15:32 | |
flaper87 | vkmc: is the websocket patch ready for review? | 15:35 |
vkmc | flaper87, yes | 15:39 |
* flaper87 does that | 15:40 | |
vkmc | wait | 15:40 |
vkmc | cross api transport or websocket? | 15:40 |
flaper87 | >.> | 15:40 |
vkmc | I'm rebasing according to the dependency chain | 15:41 |
vkmc | there is one to review | 15:41 |
flaper87 | I'll start from the bottom | 15:41 |
*** achanda has quit IRC | 15:41 | |
exploreshaifali | flaper87, morning :) | 15:42 |
exploreshaifali | vkmc, morning :) | 15:42 |
flaper87 | exploreshaifali: hey hey hey! | 15:42 |
flaper87 | how are you doing? | 15:42 |
flaper87 | I was reviewing your patch yday, btw | 15:42 |
flaper87 | looked for you but you weren't around | 15:42 |
flaper87 | I'll keep reviewing it today | 15:43 |
exploreshaifali | flaper87, Thanks :D | 15:43 |
flaper87 | What issues have you been hitting? | 15:43 |
exploreshaifali | flaper87, I have added MessageQueueHandler class inside mongodb/messages.py | 15:43 |
exploreshaifali | flaper87, now we need to add this to entry point | 15:43 |
exploreshaifali | flaper87, I am unable to figure out how to do that | 15:44 |
exploreshaifali | you gave hint - to hack inside setup.cfg | 15:44 |
exploreshaifali | so I have modified it a bit...... but what after that ? | 15:44 |
exploreshaifali | flaper87, and also i am not sure the changes in setup.cfg are correct or not | 15:45 |
exploreshaifali | flaper87, main files to review are these two - setup.cfg and mongodb/messages.py | 15:45 |
flaper87 | vkmc: am I crazy or you simply didn't use the `raise_conn_error` decorator anywhere https://review.openstack.org/#/c/141280/23/zaqar/api/v1_1/endpoints.py,cm ? | 15:47 |
flaper87 | I'm pretty sure I'm just crazy | 15:47 |
vkmc | lol | 15:47 |
flaper87 | exploreshaifali: ok, thanks for all the info, I'll review now | 15:47 |
exploreshaifali | flaper87, Thanks :) | 15:47 |
flaper87 | vkmc: you know what that means, right? TEST IT! | 15:48 |
flaper87 | :P | 15:48 |
vkmc | flaper87, sure... sorry | 15:48 |
flaper87 | vkmc: LOL, just kidding girl :D | 15:48 |
* flaper87 has done worse things | 15:49 | |
flaper87 | like I once submitted the same error in 2 different patch-sets | 15:49 |
flaper87 | T_T | 15:49 |
flaper87 | I swore I had fixed it by just moving the code from one place to another | 15:49 |
vkmc | hahaha I should add a test suite for it... I was waiting for it to merge and then add the tests for the websocket driver | 15:49 |
vkmc | flaper87, btw, you approve the generic generic exception? | 16:01 |
vkmc | I almost put the oops I did it again chorus... but I'm afraid we would get too popular and we would have to work harder | 16:01 |
flaper87 | yeah, I think that's fine | 16:03 |
*** achanda has joined #openstack-zaqar | 16:05 | |
*** achanda has quit IRC | 16:06 | |
*** reed has joined #openstack-zaqar | 16:11 | |
*** JAHoagie has joined #openstack-zaqar | 16:15 | |
*** amalagon has quit IRC | 16:20 | |
*** exploreshaifali has quit IRC | 16:32 | |
*** amalagon has joined #openstack-zaqar | 17:30 | |
*** miqui_ has quit IRC | 17:34 | |
*** amalagon has quit IRC | 17:35 | |
*** exploreshaifali has joined #openstack-zaqar | 17:36 | |
*** miqui has quit IRC | 17:37 | |
*** davideagnello has joined #openstack-zaqar | 18:09 | |
*** achanda has joined #openstack-zaqar | 18:18 | |
*** exploreshaifali has quit IRC | 18:34 | |
*** jasondotstar has joined #openstack-zaqar | 18:45 | |
*** malini has quit IRC | 19:05 | |
*** openstackgerrit has quit IRC | 19:20 | |
*** openstackgerrit has joined #openstack-zaqar | 19:20 | |
openstackgerrit | Victoria MartÃnez de la Cruz proposed openstack/zaqar: API handler and API v1.1 Queue endpoints https://review.openstack.org/141280 | 19:26 |
*** exploreshaifali has joined #openstack-zaqar | 19:39 | |
*** exploreshaifali has quit IRC | 20:23 | |
flwang | flaper87: ping | 20:29 |
*** achanda has quit IRC | 20:36 | |
flwang | vkmc: around? | 20:38 |
vkmc | flwang, here :) | 20:38 |
vkmc | flwang, how are you? | 20:38 |
*** csoukup has quit IRC | 20:42 | |
flwang | vkmc: good good | 20:45 |
flwang | vkmc: brb, sorry | 20:45 |
*** csoukup has joined #openstack-zaqar | 20:49 | |
*** malini has joined #openstack-zaqar | 20:54 | |
vkmc | np | 20:55 |
flaper87 | flwang: pong ? | 21:09 |
vkmc | flaper87, ping | 21:09 |
flaper87 | vkmc: pong ? | 21:10 |
flaper87 | :D | 21:10 |
vkmc | :) | 21:11 |
*** achanda has joined #openstack-zaqar | 21:11 | |
*** achanda has quit IRC | 21:11 | |
*** achanda has joined #openstack-zaqar | 21:12 | |
*** malini has left #openstack-zaqar | 21:14 | |
flwang | flaper87: still around? | 21:26 |
flaper87 | flwang: yes | 21:26 |
flwang | flaper87: as for the notification service status, the code is almost done, but I don't know why the redis gate is not happy for both my patches | 21:27 |
flaper87 | flwang: ok, I'll dig into that and check | 21:27 |
flaper87 | We need to get these patches merged | 21:27 |
flaper87 | all blueprints, asap. Like yday | 21:27 |
flaper87 | :) | 21:27 |
flwang | flaper87: agree | 21:28 |
flwang | I was very busy in last week | 21:28 |
flaper87 | flwang: I figured, np at all. | 21:28 |
flwang | I will focus on it this week | 21:28 |
flwang | 2015-02-11 02:07:47.278 | [ERROR] /opt/stack/new/devstack/lib/zaqar:204 Zaqar did not start | 21:28 |
flaper87 | I'm in a deep dive mode on my pending things for Zaqar | 21:29 |
flaper87 | flwang: I'll give that a go on a VM | 21:29 |
flwang | from the devstack log, I saw the zaqar server failed to start, but I haven't figure out why | 21:29 |
flaper87 | lets see | 21:29 |
vkmc | its the pooling thing with redis again IIRC | 21:29 |
flwang | vkmc: what's that mean? | 21:29 |
flaper87 | mmh, u sure? | 21:30 |
flaper87 | it sounds weird | 21:30 |
flaper87 | could you elaborate on why you think it's the pool thing? | 21:30 |
vkmc | let me go through that again | 21:30 |
vkmc | I reviewed it a while ago | 21:31 |
flwang | vkmc: did you mean there are something I need to enhance in my patches for pooling? | 21:31 |
vkmc | flwang, no, I was thinking in a different patch | 21:36 |
vkmc | there are not traces of pooling in the webhook one | 21:36 |
flwang | vkmc: yep, that's why it's weird | 21:41 |
flwang | it's hard to debug and most of the other gates work | 21:42 |
vkmc | yeah.. and it works for other patches | 21:42 |
vkmc | let's recheck | 21:44 |
*** flwang1 has joined #openstack-zaqar | 21:56 | |
*** achanda has quit IRC | 22:10 | |
*** achanda has joined #openstack-zaqar | 22:29 | |
*** amitgandhinz has quit IRC | 22:31 | |
flaper87 | flwang: vkmc http://paste.openstack.org/show/176334/ | 22:41 |
flaper87 | that's the exception | 22:41 |
vkmc | flaper87, you got that locally? | 22:43 |
*** amitgandhinz has joined #openstack-zaqar | 22:44 | |
flaper87 | vkmc: yes | 22:45 |
*** zhenq has quit IRC | 22:49 | |
flaper87 | it's the fucking ubuntu trusty redis version | 22:53 |
flaper87 | apparently it doesn't have sentinel anymore ?/ | 22:53 |
*** sriram has quit IRC | 22:55 | |
*** JAHoagie has quit IRC | 22:56 | |
flaper87 | so no, ubuntu python-redis package doesn't have sentinel. Question is: Why didn't this fail before and why patches like "storage capabilities" passed | 22:59 |
*** zhenq has joined #openstack-zaqar | 23:04 | |
*** csoukup has quit IRC | 23:11 | |
flwang1 | flaper87: yep | 23:16 |
flwang1 | i have the same question, why the other patches can pass | 23:16 |
flwang1 | flaper87: and are your sure that's the root cause why zaqar can't start? | 23:17 |
flaper87 | flwang1: I just chekced ubuntu's python-redis package | 23:18 |
flaper87 | it ships python-redis 2.7.2 | 23:18 |
flaper87 | according to git's tag, sentinel is definitely missing | 23:18 |
flaper87 | really no idea why it's failing for your patch, though. | 23:18 |
flwang1 | i see | 23:20 |
flwang1 | given all the other gates can pass, the only reason i can imagine is it must be related to redis | 23:21 |
flaper87 | yeah, but all the other patches had this gate enabled | 23:24 |
flaper87 | this is so weird | 23:24 |
flwang1 | flaper87: yep | 23:26 |
*** zhenq has quit IRC | 23:36 | |
*** amalagon has joined #openstack-zaqar | 23:53 | |
*** zhenq has joined #openstack-zaqar | 23:53 | |
*** amitgandhinz has quit IRC | 23:54 | |
*** flwang1 has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!