| *** viswanathsomanch has joined #openstack-zaqar | 01:38 | |
| *** viswanathsomanch has quit IRC | 02:40 | |
| *** jeffrey4l has joined #openstack-zaqar | 02:59 | |
| *** exploreshaifali has joined #openstack-zaqar | 03:47 | |
| exploreshaifali | jeffrey4l, hello | 03:54 |
|---|---|---|
| exploreshaifali | for bug https://bugs.launchpad.net/python-zaqarclient/+bug/1358889 | 03:54 |
| exploreshaifali | first I need to make a class for 504 error here https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/transport/errors.py | 03:55 |
| exploreshaifali | and then raise it in transport/response.py | 03:55 |
| exploreshaifali | right? | 03:55 |
| jeffrey4l | exploreshaifali, yep. | 03:57 |
| jeffrey4l | I think this is good. | 03:58 |
| exploreshaifali | jeffrey4l, when I cloned the zaqarclient repo I didn't found any test to run for it | 03:58 |
| jeffrey4l | it is impossible. | 03:58 |
| exploreshaifali | Is there any tests cases we need to run for zaqarclient | 03:59 |
| jeffrey4l | u can try `tox -e py27`, the tests can be ran. | 03:59 |
| exploreshaifali | jeffrey4l, cool, Thanks! | 04:00 |
| exploreshaifali | jeffrey4l, but `tox` is what? | 04:01 |
| exploreshaifali | I mean asking for knowledge | 04:01 |
| jeffrey4l | here it is https://pypi.python.org/pypi/tox | 04:01 |
| exploreshaifali | jeffrey4l, kk Thanks :) | 04:05 |
| jeffrey4l | ;p | 04:05 |
| *** viswanathsomanch has joined #openstack-zaqar | 04:07 | |
| *** jeffrey4l has quit IRC | 04:10 | |
| *** jeffrey4l has joined #openstack-zaqar | 04:22 | |
| *** exploreshaifali has quit IRC | 05:01 | |
| *** viswanathsomanch has quit IRC | 06:32 | |
| *** jeffrey4l has quit IRC | 07:19 | |
| *** jeffrey4l has joined #openstack-zaqar | 07:51 | |
| *** flaper87 has quit IRC | 08:05 | |
| *** flaper87 has joined #openstack-zaqar | 08:05 | |
| *** jeffrey4l has quit IRC | 08:06 | |
| *** jeffrey4l has joined #openstack-zaqar | 08:10 | |
| *** jeffrey4l has quit IRC | 08:52 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:59 | |
| *** exploreshaifali has quit IRC | 08:59 | |
| *** jeffrey4l has joined #openstack-zaqar | 09:13 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:50 | |
| *** exploreshaifali has quit IRC | 09:55 | |
| *** exploreshaifali has joined #openstack-zaqar | 10:15 | |
| *** yfujioka has quit IRC | 10:15 | |
| exploreshaifali | hi flaper87 I am working on bug https://bugs.launchpad.net/python-zaqarclient/+bug/1358889 | 11:12 |
| exploreshaifali | In file transport/response.py I should check if the response have 504 status_code or if itss content-types are not `application/JSON` | 11:13 |
| exploreshaifali | if not then exception should be raised | 11:14 |
| exploreshaifali | but self.header['Content-Type'] giving wrong key error | 11:15 |
| exploreshaifali | jeffrey4l, ^^^ | 11:15 |
| exploreshaifali | *headers['content-type'] | 11:16 |
| flaper87 | exploreshaifali: I'd say we should just check that the content-type is `application/json` | 11:46 |
| flaper87 | exploreshaifali: the question is, what should the client do if it's not? | 11:46 |
| flaper87 | let me comment on that bug | 11:47 |
| exploreshaifali | flaper87, in transport/response.py https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/transport/response.py I am making following changeshttp://pastebin.com/QXhTSU3C | 11:49 |
| exploreshaifali | and after saving the file if I run test cases using `tox -e py27` getting `KeyError` content-type | 11:51 |
| flaper87 | exploreshaifali: you might want to use self.headers.get('content-type', 'application/json') != ..... | 11:52 |
| exploreshaifali | the response object here getting inputs like content, headers etc from https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/transport/http.py | 11:52 |
| flaper87 | exploreshaifali: also, you probably need to fix the tests to always have a content-type header | 11:52 |
| exploreshaifali | fix the tests? | 11:53 |
| flaper87 | exploreshaifali: one more thing, please read my comment on that bug, I'm quite unsure about what the behavior should be if the content-type is not json | 11:53 |
| flaper87 | exploreshaifali: forget what I said about tests :P | 11:54 |
| flaper87 | exploreshaifali: just use `self.headers.get(.....)` | 11:54 |
| exploreshaifali | okay :) | 11:55 |
| exploreshaifali | flaper87, also here https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/errors.py#L26 --- exception message should be in i18n? | 11:55 |
| exploreshaifali | it is not at present | 11:56 |
| flaper87 | exploreshaifali: yes | 11:56 |
| exploreshaifali | should I file a bug for this | 11:56 |
| exploreshaifali | ? | 11:56 |
| exploreshaifali | flaper87, ^ | 11:57 |
| flaper87 | exploreshaifali: yeah, please tag it as low-hanging-fruit | 11:59 |
| flaper87 | exploreshaifali: lets keep it around for a bit for newcomers | 12:00 |
| exploreshaifali | flaper87, sure :) | 12:00 |
| *** malini has joined #openstack-zaqar | 12:08 | |
| *** malini has joined #openstack-zaqar | 12:09 | |
| *** malini has quit IRC | 12:09 | |
| *** sgotliv has joined #openstack-zaqar | 12:20 | |
| *** malini has joined #openstack-zaqar | 12:43 | |
| *** malini has quit IRC | 13:53 | |
| *** sgotliv has quit IRC | 13:57 | |
| *** openstackgerrit has joined #openstack-zaqar | 14:04 | |
| *** jeffrey4l has quit IRC | 14:06 | |
| *** sriram has joined #openstack-zaqar | 14:07 | |
| *** sgotliv has joined #openstack-zaqar | 14:07 | |
| *** exploreshaifali has quit IRC | 14:19 | |
| *** malini has joined #openstack-zaqar | 14:30 | |
| *** jchai has joined #openstack-zaqar | 14:33 | |
| *** ametts has joined #openstack-zaqar | 14:37 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:02 | |
| *** exploreshaifali has joined #openstack-zaqar | 15:36 | |
| *** D3f0 has joined #openstack-zaqar | 16:16 | |
| *** sgotliv has quit IRC | 16:31 | |
| exploreshaifali | any solution for `ERROR: InvocationError: '/opt/stack/python-zaqarclient/.tox/py27/bin/nosetests'` | 17:40 |
| exploreshaifali | it is coming even if I raise python in-built exceptions | 17:40 |
| exploreshaifali | like NameError('') | 17:40 |
| *** exploreshaifali has quit IRC | 18:23 | |
| *** malini has quit IRC | 18:47 | |
| *** malini has joined #openstack-zaqar | 18:49 | |
| *** sgotliv has joined #openstack-zaqar | 19:33 | |
| *** jchai is now known as jchai_afk | 19:55 | |
| *** jchai_afk is now known as jchai | 19:57 | |
| *** D3f0 has quit IRC | 20:00 | |
| *** jchai is now known as jchai_afk | 20:24 | |
| *** jchai_afk is now known as jchai | 20:25 | |
| *** malini has left #openstack-zaqar | 20:31 | |
| *** dagnello has joined #openstack-zaqar | 21:23 | |
| *** flwang has quit IRC | 21:45 | |
| *** flwang1 has joined #openstack-zaqar | 21:48 | |
| *** sriram has quit IRC | 22:32 | |
| *** amitgandhinz has quit IRC | 22:53 | |
| *** jchai has quit IRC | 23:13 | |
| *** sgotliv_ has joined #openstack-zaqar | 23:29 | |
| *** sgotliv has quit IRC | 23:32 | |
| *** sgotliv_ has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!