| opendevreview | chandan kumar proposed openstack/watcher master: [WIP] Replace dateutils usage with datetime and oslo.utils https://review.opendev.org/c/openstack/watcher/+/955809 | 06:50 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher master: [WIP] Replace dateutils usage with datetime and oslo.utils https://review.opendev.org/c/openstack/watcher/+/955809 | 06:51 |
| opendevreview | JaromÃr Wysoglad proposed openstack/watcher-specs master: Change Aetos's service type https://review.opendev.org/c/openstack/watcher-specs/+/955993 | 07:42 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add patch call validation based on allowed_attrs https://review.opendev.org/c/openstack/watcher/+/955999 | 10:20 |
| chandankumar | sean-k-mooney: Hello, I wanted to talk about python-dateutils cr. In this cr https://review.opendev.org/c/openstack/watcher/+/955809/3/watcher/api/controllers/v1/audit.py#b639, the start_time was assumed in local time zone. | 10:40 |
| chandankumar | As per the openstack optimize audit create --help doc, --start-time or --end-time needs to be in local. | 10:40 |
| chandankumar | Based on your comment, I tried to first check whether passtimezone is local or not, if not convert it to utc. | 10:41 |
| chandankumar | My question here is since CLI instruct user to pass it to local timezone, Do we need to convert it to utc? | 10:42 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Added tempest API tests for continous audit start/end time https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/956004 | 11:27 |
| sean-k-mooney | chandankumar: local time cant be know at the api level so you cna never use local time correctly | 11:42 |
| sean-k-mooney | also the spec sayx https://opendev.org/openstack/watcher-specs/src/branch/master/specs/stein/implemented/add-start-end-time-for-continuous-audit.rst The datetime format is ISO 8601, such as: YYYY-MM-DD hh:mm:ss | 11:43 |
| sean-k-mooney | if your following ISO 8601 its utc by default | 11:43 |
| sean-k-mooney | for the refactor we proably should just not change the behvior and i can add this to the list of things to include in a v3 api | 11:46 |
| chandankumar | sean-k-mooney: thank you for clearing the confusion. | 11:50 |
| sean-k-mooney | the api docs say "The local time after which audit can be executed in accordance with interval. It will be converted to UTC time by Watcher." | 11:51 |
| chandankumar | In the current patch, It does not change user input but it converts it to UTC. | 11:51 |
| chandankumar | sean-k-mooney: yes, correct, indeed it was a bug. | 11:53 |
| chandankumar | next question, Do we need a seperate bug for this? or I can use the existing dateutils bug? | 11:54 |
| chandankumar | in dateutil change, I have added a release note about the same. | 11:54 |
| sean-k-mooney | i think next cycle im going to propsoe a new major version for the rest api to fix all of the issue in one go. that a big step but it one i have been thinking about for a while to adress the api tech debt | 11:56 |
| sean-k-mooney | for not as part of the datautil removal lets keep the convergion form localtime to utc | 11:57 |
| sean-k-mooney | dont change the behavior in the refactoring process | 11:57 |
| chandankumar | sure, let me also open a bug for the same | 11:58 |
| sean-k-mooney | it will not be a bug | 11:59 |
| sean-k-mooney | it will be a spec | 11:59 |
| chandankumar | ok, But for now We need something for now to track it and later on we can move it to spec. | 12:01 |
| sean-k-mooney | no we dont | 12:05 |
| sean-k-mooney | if we were to do that i would file a blueprint | 12:06 |
| sean-k-mooney | we do not need tracker until we dicuss if we are goign to do it | 12:06 |
| chandankumar | ok | 12:06 |
| chandankumar | let me add it somewhere in my notes. | 12:06 |
| sean-k-mooney | if we are goign to create a v2 api for watcher it would be a complete rewrite using a differnt tech stack and having a differnt structure. for exampel actions woudl not be a top level api | 12:07 |
| sean-k-mooney | thre are a subset of things we coudl change in v1 before going to a v2 | 12:08 |
| sean-k-mooney | via microversion but we need to list and dicuss what we can and cant change before we make a desions | 12:08 |
| chandankumar | added notes in the review itself. | 12:16 |
| chandankumar | sean-k-mooney: thank you for sharing valuable input on this. | 12:16 |
| chandankumar | I will update my cr and mark it ready for review | 12:17 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!