| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Query by fqdn_label instead of instance for host metrics https://review.opendev.org/c/openstack/watcher/+/944795 | 07:47 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher master: Enable multiple exporters on compute node https://review.opendev.org/c/openstack/watcher/+/944839 | 09:06 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Query by fqdn_label instead of instance for host metrics https://review.opendev.org/c/openstack/watcher/+/944795 | 11:54 |
| amoralej | sean-k-mooney ^ when you have a while, please | 12:16 |
| sean-k-mooney | oh ya that sound like a bug | 12:17 |
| sean-k-mooney | we are past RC1 so this will have to be backported. we could do an RC2 but if this is the only change im wondering if we would be better off waiting till after the release | 12:19 |
| sean-k-mooney | we can dicuss that in the meeting | 12:19 |
| amoralej | you mean wait for merging the patch or to include it in a release? | 12:30 |
| amoralej | ah, to backport, i guess | 12:30 |
| chandankumar | sean-k-mooney: Hello, Please add following patches https://review.opendev.org/q/topic:%22bug/2100741%22 to move functional tests from watcher-tempest-plugin to watcherclient to your review queue, thank you!. | 13:07 |
| sean-k-mooney | amoralej: we have cut RC1 already so if we merge it in master now its technially part of 2025.2 | 13:17 |
| sean-k-mooney | so we would wait on merging the backport until after 2025.1 is release | 13:17 |
| sean-k-mooney | other wise we would need an RC2 which we can do but im unsure if we should | 13:18 |
| amoralej | yes, wait for the release to backport it to 2025.1 wfm too | 13:18 |
| sean-k-mooney | https://opendev.org/openstack/watcher/src/branch/stable/2025.1/ we have a stable branch so it will need a backport in anycase | 13:19 |
| amoralej | yep | 13:21 |
| sean-k-mooney | amoralej: i left some feedback in the review. the fqdn lable can store hostnames,fqdns and possibley ip adresses | 13:52 |
| sean-k-mooney | well the fqdn lable i think shoudl be one of the first tow but the scrape cofnig can map a target to a ip | 13:53 |
| amoralej | Thanks, reviewing it | 14:09 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Query by fqdn_label instead of instance for host metrics https://review.opendev.org/c/openstack/watcher/+/944795 | 16:36 |
| amoralej | sean-k-mooney, ^ i hope that fix your comments | 16:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!