| *** bryanfraschetti6098457514 is now known as bryanfraschetti609845751 | 01:20 | |
| *** bryanfraschetti6098457512 is now known as bryanfraschetti609845751 | 02:04 | |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: DNM: Testing switching to prometheus datasource with exceptions.EndpointNotFound https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938036 | 05:26 |
|---|---|---|
| rlandy | watcher weekly irc meeting starting here in 5 mins o/ add agenda items to https://etherpad.opendev.org/p/openstack-watcher-irc-meeting | 11:55 |
| rlandy | #startmeeting watcher | 12:01 |
| opendevmeet | Meeting started Thu Dec 19 12:01:04 2024 UTC and is due to finish in 60 minutes. The chair is rlandy. Information about MeetBot at http://wiki.debian.org/MeetBot. | 12:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 12:01 |
| opendevmeet | The meeting name has been set to 'watcher' | 12:01 |
| rlandy | hello all o/ who is around today? | 12:01 |
| dviroel | o/ | 12:01 |
| jgilaber | o/ | 12:01 |
| rlandy | #link https://etherpad.opendev.org/p/openstack-watcher-irc-meeting meeting agenda | 12:03 |
| rlandy | ok lets get going on the agenda items we will take them in order given | 12:03 |
| rlandy | #topic (rlandy) Patches requiring reviews / open reviews of note since last meeting | 12:04 |
| rlandy | note this is not a full list of reviews - some new and active ones since the last meeting ... feel free to add any more for discussion | 12:04 |
| rlandy | ok lets take them one at a time, give folks chance for any concerns or comments or status | 12:05 |
| rlandy | #link https://review.opendev.org/c/openstack/watcher/+/934423 Add prometheus data source for watcher decision engine | 12:05 |
| rlandy | marios: ^^ any comments or requests on that one? | 12:05 |
| rlandy | looks like amoralej_ +1'ed the last revision | 12:06 |
| amoralej_ | i'm half around :) | 12:07 |
| amoralej_ | i think current state is good | 12:07 |
| dviroel | this is also lgtm, as first version of prometheus datasource | 12:08 |
| rlandy | thank you amoralej_ dviroel | 12:08 |
| rlandy | ok, moving on to the next review ... | 12:09 |
| rlandy | #link https://review.opendev.org/c/openstack/watcher/+/937625 Remove ceilometer datasource | 12:09 |
| rlandy | looks like chandankumar and dviroel reviewed that | 12:10 |
| rlandy | noting marios comment: "thanks for working on that Takashi. from a quick review i don't think there will be any conflict with the new prometheus data source" | 12:10 |
| rlandy | any comments or concerns on that one? | 12:11 |
| dviroel | right, didn't check why CI is not happy with that | 12:12 |
| rlandy | ok, moving on to the next review ... | 12:13 |
| rlandy | the next two are backports | 12:13 |
| rlandy | #link https://review.opendev.org/c/openstack/watcher/+/937825 Backport Omnibus Fixes and Associated Tests | 12:13 |
| rlandy | #link https://review.opendev.org/c/openstack/watcher/+/937823 Backport Omnibus Fixes and Associated Tests | 12:13 |
| rlandy | marios added sean to those to review | 12:14 |
| rlandy | any comments or concerns on those? | 12:15 |
| dviroel | need to take a look but, commit message should at least specify which commits we are cherry picking there | 12:16 |
| rlandy | request to add comments to the review - thank you | 12:17 |
| rlandy | ok, moving on to the next review ... | 12:18 |
| rlandy | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/935043 Support multiple global_efficacy indicators in action plans table | 12:18 |
| rlandy | has +1's from 3 reviewers | 12:19 |
| rlandy | looks like awaiting cores | 12:19 |
| rlandy | any comments or concerns on that one? | 12:20 |
| rlandy | ok, moving on to the last review ... | 12:21 |
| rlandy | #link https://review.opendev.org/c/openstack/watcher/+/822559 Fix incorrect logging format | 12:22 |
| rlandy | this has a +1 from jgilaber | 12:22 |
| rlandy | thank you | 12:22 |
| rlandy | any comments or concerns on that one? | 12:23 |
| rlandy | ok - any more reviews to highlight for today? | 12:25 |
| rlandy | ok, moving on .. | 12:26 |
| rlandy | #topic (rlandy) plan for 2025 to change watcher-tempest-plugin cores | 12:26 |
| rlandy | kopecmartin sent a mailing list notification about changing focus in the new year | 12:27 |
| rlandy | chandankumar will be coming on as core - thank you chandankumar | 12:28 |
| rlandy | chandankumar has significant former tempest experience | 12:28 |
| rlandy | any questions or concerns here? | 12:29 |
| dviroel | +1 | 12:29 |
| jgilaber | no concerns, +1 | 12:29 |
| rlandy | thank you | 12:30 |
| rlandy | ok moving on ... | 12:30 |
| rlandy | #topic (rlandy) reminder this meeting is canceled over the next two weeks (happy holidays) - next meeting is 9th January 2025 | 12:31 |
| rlandy | thank you amoralej_ for volunteering to chair that meeting | 12:31 |
| rlandy | that is the end of the topics on the etherpad. is there any topic anyone else wants to raise? | 12:32 |
| rlandy | #topic open discussion | 12:32 |
| rlandy | anything anyone would like to bring up here before we close out today? | 12:33 |
| rlandy | ok then thanks all for participating o/ | 12:35 |
| rlandy | #endmeeting | 12:35 |
| opendevmeet | Meeting ended Thu Dec 19 12:35:38 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 12:35 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/watcher/2024/watcher.2024-12-19-12.01.html | 12:35 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/watcher/2024/watcher.2024-12-19-12.01.txt | 12:35 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/watcher/2024/watcher.2024-12-19-12.01.log.html | 12:35 |
| dviroel | thanks o/ | 12:35 |
| jgilaber | thanks! o/ | 12:35 |
| opendevreview | Ronelle Landy proposed openstack/watcher-tempest-plugin master: DNM: Testing switching to prometheus datasource https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/937898 | 14:37 |
| opendevreview | Marios Andreou proposed openstack/watcher master: Add prometheus data source for watcher decision engine https://review.opendev.org/c/openstack/watcher/+/934423 | 14:56 |
| *** bryanfraschetti60984575127 is now known as bryanfraschetti6098457512 | 15:38 | |
| opendevreview | Marios Andreou proposed openstack/watcher master: Add prometheus data source for watcher decision engine https://review.opendev.org/c/openstack/watcher/+/934423 | 15:44 |
| marios | omg rlandy i completely missed the irc meet :( | 15:51 |
| marios | sorry ! | 15:51 |
| rlandy | no worries ... I managed | 15:51 |
| rlandy | I though you were apologizing for updating the patch I am depending on | 15:51 |
| rlandy | :) | 15:51 |
| marios | ah sorry for that too then ;) i think i'm done now on v27 thanks :) | 15:52 |
| rlandy | np - | 15:52 |
| rlandy | one more time to test - hang on chandankumar | 15:52 |
| marios | i need to add this to my google calendar | 15:56 |
| marios | i had a call with amoralej this morning and thought that was it :( | 15:56 |
| marios | well since i'm here and on the off chance it is useful for any reviewers... in v26/27 I'm just adding some validation for the host:port required in the watcher.conf in order to initialise the prometheus data source | 15:57 |
| marios | the validation is that the host is in valid format ditto for port number | 15:57 |
| marios | and associated test cases | 15:58 |
| marios | DIFF v25..27 adding the validation https://review.opendev.org/c/openstack/watcher/+/934423/25..27/watcher/decision_engine/datasources/prometheus.py | 15:58 |
| marios | and testing it with https://review.opendev.org/c/openstack/watcher/+/934423/25..27/watcher/tests/decision_engine/datasources/test_prometheus_helper.py | 15:59 |
| *** bryanfraschetti609845751272 is now known as bryanfraschetti60984575127 | 21:34 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!