| amoralej | Hi!, may i get reviews on https://review.opendev.org/c/openstack/watcher-dashboard/+/932693 when you have a chance? thanks in advance | 12:21 |
|---|---|---|
| sean-k-mooney | amoralej: done, i dont see anything wrong code wise, ill see if i can quickly pull that in to my devstack and try and see it end to end. | 15:20 |
| amoralej | thanks! | 15:21 |
| sean-k-mooney | amoralej: my main concern is the repo as a whole does not seam to have any adiquite testing and that the patch does nto refernce a bug | 15:21 |
| sean-k-mooney | procedurlly i think the latter shoudl be fixed but the former (lack of test coverage) is more endmic and perhaps shoudl not be a blocker. | 15:22 |
| amoralej | agreed, lemme create the bug | 15:22 |
| sean-k-mooney | cool i think after i try it localy if you create teh bg and update it i would change form -1 to +1 | 15:22 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-dashboard master: Fix efficacy indicators in action plans https://review.opendev.org/c/openstack/watcher-dashboard/+/932693 | 15:34 |
| sean-k-mooney | amoralej: technicall question, with horizon plugins do i need to do anything other then checkout the review, pip install teh plugin to the venv and restart horizon? | 15:41 |
| sean-k-mooney | in generall i woudl not epect so give your modifying the python danjo code but i am wondering how you tested this locally | 15:41 |
| amoralej | i tested it in a rpmized installation, not good reference for testing it in devstack | 15:42 |
| sean-k-mooney | ack | 15:42 |
| sean-k-mooney | ill try the normall workflwo and see if that works | 15:42 |
| amoralej | gimme a while, iirc it's tricky where django look for plugins | 15:42 |
| sean-k-mooney | if you were modifyign the html i could see needeing to regenrate static data | 15:43 |
| sean-k-mooney | i could execute the same commadn the devstack plugin runs i guess | 15:43 |
| amoralej | sorry, i was wrong, it's installed in standard site-packges location | 15:43 |
| amoralej | so probably just pip installing the patched repo will work | 15:43 |
| sean-k-mooney | yep in the venv in devstacks case | 15:43 |
| amoralej | yep, in the horizon venv | 15:43 |
| sean-k-mooney | we use a single common one for all services | 15:44 |
| sean-k-mooney | to ensure co installablity | 15:44 |
| amoralej | right, so there :) | 15:44 |
| sean-k-mooney | we just use the venv to not require sudo and to avoid conflicting iwth system python packages | 15:44 |
| amoralej | well, you will also need to have the panel .py files in a specific location where django loads that, but i expect devstack is already doing it | 15:45 |
| amoralej | and the patch is not modifying those | 15:45 |
| sean-k-mooney | ack ill try and take screenshot before and after to show the fix works and ill upload them to imgur and link it in the review | 15:46 |
| amoralej | https://opendev.org/openstack/watcher-dashboard/src/branch/master/doc/source/install/installation.rst#devstack-setup that should enable the plugin | 15:50 |
| sean-k-mooney | its already enabeld so all that was requried was pip installing the updated version | 15:59 |
| amoralej | nice | 15:59 |
| sean-k-mooney | i am now +1 on the review and left a commet with https://imgur.com/a/hUlruos as evidance of the orginal bug and the fix | 15:59 |
| amoralej | thanks! | 16:12 |
| amoralej | btw, https://bugs.launchpad.net/watcher-dashboard/+bug/2028140 may be another good thing to work in | 16:26 |
| sean-k-mooney | amoralej: i think that is not a bug | 17:10 |
| amoralej | no, no, it's feature | 17:11 |
| sean-k-mooney | amoralej: it might be but i dont think other horion dashboard hide them selves | 17:11 |
| sean-k-mooney | i may be wrong about that | 17:11 |
| amoralej | it can do it, other plugins have it | 17:11 |
| sean-k-mooney | but is that done vai config or via detecting if the service is installed | 17:11 |
| amoralej | checking in the keystone services | 17:11 |
| sean-k-mooney | oh ok | 17:12 |
| sean-k-mooney | then makes sense | 17:12 |
| amoralej | there is an example of octavia linked in the bug | 17:12 |
| sean-k-mooney | amoralej: do you want to assign https://bugs.launchpad.net/watcher-dashboard/+bug/2086627 to yourself | 17:12 |
| amoralej | done | 17:13 |
| sean-k-mooney | oh that what the story board link is | 17:13 |
| sean-k-mooney | i see | 17:13 |
| amoralej | didn't check, but i assumed it's easy to implement (although didn't check in detail, tbh) | 17:13 |
| amoralej | and a very useful thing to avoid some config management | 17:14 |
| sean-k-mooney | https://review.opendev.org/c/openstack/octavia-dashboard/+/766878/6/octavia_dashboard/dashboards/project/load_balancer/panel.py | 17:14 |
| amoralej | btw, you added the link to the review to the bug manually, what i did wrong in my Closes-Bug comment in https://review.opendev.org/c/openstack/watcher-dashboard/+/932693 ? | 17:15 |
| amoralej | it didn't do it automatically ... | 17:15 |
| sean-k-mooney | it didnt do it automatically because we do not have an active developem serise for 2025.1 | 17:16 |
| amoralej | so launchpad config | 17:16 |
| sean-k-mooney | we can fix that once we have access to the watcher-drivers group | 17:17 |
| sean-k-mooney | yep | 17:17 |
| amoralej | yeah, np, i was just wondering if i miss something | 17:17 |
| amoralej | thanks for your help | 17:17 |
| sean-k-mooney | so without understanding the horizon code i think its a oneline chnage in each of these pannels | 17:17 |
| sean-k-mooney | adding permissions = whatever | 17:17 |
| amoralej | yep, apparently pannels in watcher inherit fromo horzon.Panel as in https://github.com/openstack/watcher-dashboard/blob/master/watcher_dashboard/content/strategies/panel.py | 17:19 |
| amoralej | If nobody else is taking care, i can try it | 17:20 |
| sean-k-mooney | oh i frogot to link https://github.com/search?q=repo%3Aopenstack%2Fwatcher-dashboard+horizon.Panel&type=code | 17:20 |
| sean-k-mooney | that what i was looking at | 17:21 |
| opendevreview | Merged openstack/puppet-watcher master: Add support for [cache] backend_expiration_time https://review.opendev.org/c/openstack/puppet-watcher/+/933994 | 20:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!