*** zhurong has quit IRC | 00:53 | |
*** zhurong has joined #openstack-watcher | 02:11 | |
openstackgerrit | Merged openstack/watcher master: check instance state for instance.update https://review.opendev.org/663489 | 03:54 |
---|---|---|
openstackgerrit | licanwei proposed openstack/watcher master: Add uWSGI support https://review.opendev.org/666779 | 04:45 |
*** irclogbot_1 has quit IRC | 06:18 | |
*** irclogbot_1 has joined #openstack-watcher | 06:20 | |
openstackgerrit | licanwei proposed openstack/watcher master: [WiP]Add uWSGI support https://review.opendev.org/666779 | 07:40 |
openstackgerrit | licanwei proposed openstack/watcher master: [WiP]Add uWSGI support https://review.opendev.org/666779 | 09:05 |
Dantalion | mriedem: Yes that makes sense, I'll take a look at the patch. | 12:15 |
Dantalion | mriedem: It makes sense to do this in a follow up patch and update test_list_opts to check for the presenence of all the objects instead of the strings | 12:20 |
*** mriedem has joined #openstack-watcher | 13:29 | |
mriedem | Dantalion: for https://bugs.launchpad.net/watcher/+bug/1833999 are you using the new enough python-novaclient version? | 13:31 |
openstack | Launchpad bug 1833999 in watcher "nova.hypervisors.search() got unexpected argument 'detailed'" [High,New] | 13:31 |
mriedem | you need at least 14.1.0 | 13:31 |
mriedem | Dantalion: that's what has this novaclient change that watcher needs to use https://review.opendev.org/#/c/659886/ | 13:33 |
mriedem | my guess is your downstream QA environment is using rocky or stein level novaclient | 13:33 |
mriedem | i forget if cern has upgraded to stein | 13:33 |
Dantalion | Nova is at rocky currently | 14:52 |
Dantalion | The api mentions that search is deprecated so is the new nova client using list under the hood? | 14:53 |
Dantalion | while the method is still called search | 14:53 |
Dantalion | mriedem: Sorry I completely missed that it explains a lot~ | 14:55 |
mriedem | Dantalion: the /search route was deleted in 2.53 but made available in the other GET routes with 2.53 | 14:55 |
mriedem | the missing piece was the novaclient functionality to support searching on hypervisor_hostname_pattern in the other GET routes with 2.53 | 14:56 |
mriedem | and yeah your rocky deployment won't have that newer novaclient change that was just released in train | 14:56 |
mriedem | you'd have to backport that novaclient patch to your downstream novaclient | 14:56 |
mriedem | unless you can run novaclient 14.1.0 against your rocky (it should be backward compatible but i don't know if things have been removed in novaclient since rocky) | 14:56 |
mriedem | *the /search route was *deprecated* in 2.53 | 14:57 |
Dantalion | Okaj so your patched introcuced hypervisor_hostname_pattern for the /list route | 14:58 |
Dantalion | mriedem: I got confused because the method is still called hypvervisors.search and the documented states /search is deprecated but I guess they don't have to map to one another ofcourse | 14:59 |
mriedem | correct the novaclient change just handles the microversion transparently for the user based on microversion | 15:03 |
Dantalion | mriedem: Thanks, I have closed the issue and will look at updating novaclient on the Watcher node tomorrow. I will do some performance measurements of before and after and ofcourse will share those once done :) | 15:05 |
mriedem | Dantalion: that would be great | 15:07 |
mriedem | i need to come back to https://review.opendev.org/#/c/663332/ - i still haven't gotten the grenade part working, so i think i'll probably just get the non-grenade part fixed so we can merge that and then work on the grenade piece separately | 16:44 |
openstackgerrit | Matt Riedemann proposed openstack/watcher master: Configure nova notification format in non-grenade CI jobs https://review.opendev.org/663332 | 17:10 |
openstackgerrit | Matt Riedemann proposed openstack/watcher master: Configure nova notification_format for grenade https://review.opendev.org/667161 | 17:10 |
openstackgerrit | Matt Riedemann proposed openstack/watcher master: Improve the configuration parameters for grafana https://review.opendev.org/666856 | 18:38 |
openstackgerrit | Matt Riedemann proposed openstack/watcher master: Fix placement_client group help docs generation https://review.opendev.org/666897 | 18:52 |
*** ianychoi_ has joined #openstack-watcher | 21:19 | |
*** ianychoi has quit IRC | 21:22 | |
*** ianychoi_ has quit IRC | 21:30 | |
*** ianychoi_ has joined #openstack-watcher | 21:31 | |
*** mriedem has quit IRC | 21:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!