| *** adisky_ has quit IRC | 00:49 | |
| *** zhurong has joined #openstack-watcher | 01:29 | |
| *** zhurong has quit IRC | 01:35 | |
| *** thorst_ has joined #openstack-watcher | 01:54 | |
| *** thorst_ has quit IRC | 01:58 | |
| *** Yumeng has joined #openstack-watcher | 02:06 | |
| *** yuanying has quit IRC | 03:05 | |
| *** yuanying has joined #openstack-watcher | 03:07 | |
| *** thorst_ has joined #openstack-watcher | 03:08 | |
| *** thorst_ has quit IRC | 03:08 | |
| *** yuanying has quit IRC | 03:11 | |
| *** thorst_ has joined #openstack-watcher | 03:38 | |
| *** thorst_ has quit IRC | 03:38 | |
| *** thorst_ has joined #openstack-watcher | 04:38 | |
| *** thorst_ has quit IRC | 04:44 | |
| *** adisky_ has joined #openstack-watcher | 05:10 | |
| openstackgerrit | Hidekazu Nakamura proposed openstack/watcher master: Add checking audit state https://review.openstack.org/429995 | 05:23 |
|---|---|---|
| *** hidekazu has joined #openstack-watcher | 05:48 | |
| openstackgerrit | Merged openstack/puppet-watcher master: Fix typo in api.pp https://review.openstack.org/423102 | 06:00 |
| *** yuanying has joined #openstack-watcher | 06:07 | |
| *** thorst_ has joined #openstack-watcher | 06:40 | |
| *** thorst_ has quit IRC | 06:45 | |
| *** diga has joined #openstack-watcher | 07:02 | |
| adisky_ | Hi can anybody tell me on which tool watcher state machine diagram are made?? I need to edit them to propose the specs for action plan stop | 07:07 |
| hidekazu | adisky_: i believe https://github.com/openstack/watcher/blob/master/doc/source/image_src/plantuml/audit_state_machine.txt | 07:14 |
| hidekazu | sorry, this is audit. action plan is here: https://github.com/openstack/watcher/blob/master/doc/source/image_src/plantuml/action_plan_state_machine.txt | 07:15 |
| adisky_ | hidekazu: | 07:15 |
| adisky_ | thanks :) | 07:15 |
| hidekazu | adisky_: how to build: https://github.com/openstack/watcher/blob/master/doc/source/image_src/plantuml/README.rst | 07:16 |
| *** diga has quit IRC | 07:16 | |
| hidekazu | adisky_: i don't know you should include uml in spec though. | 07:17 |
| adisky_ | hidekazu: I wont't include UML in stack, I will just upload it somwhere and give the links, is that fine?? | 07:18 |
| adisky_ | sorry *stack->specs | 07:18 |
| hidekazu | adisky_: it helps readers. | 07:19 |
| adisky_ | hidekazu: yes, it will be helpful to understand. | 07:29 |
| *** diga has joined #openstack-watcher | 07:54 | |
| hidekazu | licanwei: here? | 08:07 |
| *** alexchadin has joined #openstack-watcher | 08:20 | |
| licanwei | yes | 08:35 |
| *** vincentfrancoise has joined #openstack-watcher | 08:36 | |
| licanwei | hidekazu ? | 08:36 |
| alexchadin | vincentfrancoise: hi | 08:40 |
| *** thorst_ has joined #openstack-watcher | 08:40 | |
| *** thorst_ has quit IRC | 08:46 | |
| *** alexchadin has quit IRC | 08:47 | |
| *** alexchadin has joined #openstack-watcher | 08:47 | |
| *** alexchadin has quit IRC | 08:54 | |
| *** alexchadin has joined #openstack-watcher | 08:54 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| alexchadin | vincentfrancoise: acabot: ping | 09:18 |
| *** openstackgerrit has joined #openstack-watcher | 09:35 | |
| openstackgerrit | licanwei proposed openstack/watcher master: Optimize audit process https://review.openstack.org/431408 | 09:35 |
| vincentfrancoise | alexchadin: morning | 09:37 |
| *** alexchadin_ has joined #openstack-watcher | 09:38 | |
| *** alexchadin has quit IRC | 09:41 | |
| hidekazu | licanwei: sorry i was in meeting, now iam free. still here? | 09:41 |
| alexchadin_ | vincentfrancoise: could you please discuss action notifications with me? | 09:44 |
| vincentfrancoise | yup | 09:48 |
| vincentfrancoise | alexchadin_: did you understand my comments ? | 09:48 |
| vincentfrancoise | alexchadin_: on the review | 09:48 |
| alexchadin_ | vincentfrancoise: yeah, but if we flow_task already has execute method and it runs this only after pre_execute. | 09:51 |
| alexchadin_ | I mean, if we execute pre_execute in execute, we will have 2 calls for pre_execute | 09:51 |
| alexchadin_ | pre_execute->execute->pre_execute->do_execute->post_execute->post_execute | 09:52 |
| *** hidekazu has quit IRC | 09:52 | |
| vincentfrancoise | alexchadin_: I don't understand why you say there are 2 pre_execute | 09:53 |
| alexchadin_ | https://github.com/openstack/taskflow/blob/master/taskflow/atom.py#L310 | 09:54 |
| vincentfrancoise | alexchadin_: because execute is the "public" function and pre_execute/do_execute/post_execute are "private" and abstract | 09:54 |
| alexchadin_ | vincentfrancoise: ^ | 09:54 |
| alexchadin_ | vincentfrancoise: https://github.com/openstack/taskflow/blob/df10cb5acc7d38c7bbe6f06f42393969b40e31ac/taskflow/engines/action_engine/executor.py#L52 | 09:55 |
| vincentfrancoise | alexchadin_: oh ok I see, they already have that kind of separation | 09:56 |
| alexchadin_ | vincentfrancoise: yeap, that's why I just wrapped them | 09:56 |
| vincentfrancoise | alexchadin_: IMHO, our execute should still wrap taskflow's pre/do/post | 09:57 |
| vincentfrancoise | but because we have a naming issue | 09:57 |
| alexchadin_ | vincentfrancoise: we can call self.pre_execute in child's pre_execute | 09:58 |
| vincentfrancoise | alexchadin_: yeah we could do a super() | 09:58 |
| alexchadin_ | vincentfrancoise: that's the good way | 09:59 |
| vincentfrancoise | alexchadin_: should be working just fine :) | 10:03 |
| alexchadin_ | vincentfrancoise: then I need to get exception block up to child class | 10:27 |
| alexchadin_ | vincentfrancoise: cause there will be different workflow child.pre_execute -> base.pre_execute | 10:28 |
| alexchadin_ | vincentfrancoise: I had base.pre_execute -> child.pre_execute and child.pre_execute was wrapped by try/except block | 10:29 |
| vincentfrancoise | alexchadin_: base.pre_execute -> child.pre_execute sounds good to me | 10:31 |
| vincentfrancoise | alexchadin_: why do you want to make it the other way around? | 10:31 |
| alexchadin_ | cause call starts from plugin | 10:32 |
| vincentfrancoise | alexchadin_: capy paste you code on https://codeshare.io/ampvVw if that helps | 10:32 |
| vincentfrancoise | copy* | 10:33 |
| *** yuanying has quit IRC | 10:36 | |
| *** thorst_ has joined #openstack-watcher | 10:41 | |
| *** thorst_ has quit IRC | 10:46 | |
| *** danpawlik has joined #openstack-watcher | 11:36 | |
| *** diga has quit IRC | 12:26 | |
| *** thorst_ has joined #openstack-watcher | 12:41 | |
| *** thorst_ has quit IRC | 12:42 | |
| *** thorst_ has joined #openstack-watcher | 12:43 | |
| alexchadin_ | licanwei: hi | 13:07 |
| *** alexchadin_ has quit IRC | 13:29 | |
| *** brunograz1 has joined #openstack-watcher | 13:48 | |
| *** brunograz has quit IRC | 13:51 | |
| *** brunograz has joined #openstack-watcher | 13:53 | |
| *** brunograz has quit IRC | 14:14 | |
| *** brunograz1 has quit IRC | 14:22 | |
| *** brunograz has joined #openstack-watcher | 14:37 | |
| *** vincentfrancoise has quit IRC | 14:42 | |
| *** acabot has quit IRC | 14:42 | |
| *** vincentfrancoise has joined #openstack-watcher | 14:44 | |
| chrisspencer | o/ hi | 15:06 |
| vincentfrancoise | chrisspencer: hi | 15:07 |
| chrisspencer | vincentfrancoise: I updated the notification bug: https://review.openstack.org/#/c/422295 and was able to get it to print out both the event and the publisher id in the context. | 15:09 |
| vincentfrancoise | chrisspencer: ah nice! What did you do to make it work then? | 15:10 |
| chrisspencer | Just as you said, needed to update that context that is passed in. But in order to display both (on our gate check/devstack) I modified that devstack watcher initialization of logging_context_format_string | 15:12 |
| chrisspencer | so it currently only solves the issue (by default) for devstack envs, however, I think it just a conf setting for production envs | 15:13 |
| vincentfrancoise | ok so now I see it (http://logs.openstack.org/95/422295/7/check/gate-watcher-dsvm-multinode-ubuntu-xenial-nv/23251d6/logs/screen-watcher-decision-engine.txt.gz#_2017-02-07_21_29_43_612) | 15:13 |
| vincentfrancoise | but the information is not exactly the one I expected :p | 15:13 |
| vincentfrancoise | chrisspencer: [nova-compute:ubuntu-xenial-2-node-osic-cloud1-s3500-7167403 instance.update admin admin] => [publisher_id event_type XXX XXX] | 15:14 |
| chrisspencer | ah, ack, that info bit should be easier to change :P | 15:14 |
| vincentfrancoise | chrisspencer: wait | 15:14 |
| vincentfrancoise | chrisspencer: what I sent you is what is currently being displayed | 15:15 |
| vincentfrancoise | chrisspencer: but the pusblisher_id is not the same as request_id | 15:15 |
| vincentfrancoise | chrisspencer: in the context of notifications, request_id is the message_id | 15:18 |
| chrisspencer | vincentfrancoise: hm, where is that message_id generated? | 15:19 |
| chrisspencer | because it looks like we were already displaying request ID as part of that context, just needed to set it properly | 15:19 |
| vincentfrancoise | chrisspencer: actually yes | 15:20 |
| *** wootehfoot has joined #openstack-watcher | 15:21 | |
| vincentfrancoise | message_id is the rabbitmq message uuid I guess | 15:21 |
| vincentfrancoise | chrisspencer: but that's the only attribute that is actually unique to a particular notification | 15:22 |
| vincentfrancoise | chrisspencer: so that's why that's the attribute we need to track notifications in the logs | 15:22 |
| chrisspencer | ah, vincentfrancoise where is that attribute passed into watcher? is it part of the payload or metadata? | 15:27 |
| vincentfrancoise | chrisspencer: part of metadata --> you can see it in the log link from above | 15:28 |
| vincentfrancoise | http://logs.openstack.org/95/422295/7/check/gate-watcher-dsvm-multinode-ubuntu-xenial-nv/23251d6/logs/screen-watcher-decision-engine.txt.gz#_2017-02-07_21_29_43_612 | 15:28 |
| vincentfrancoise | chrisspencer: with metadata {'timestamp': u'2017-02-07 21:29:43.609934', 'message_id': u'495baf33-109f-470e-9aed-39472707b042'} | 15:29 |
| chrisspencer | vincentfrancoise:yes got it. cool. will make that change and push | 15:29 |
| vincentfrancoise | chrisspencer: wait | 15:29 |
| vincentfrancoise | chrisspencer: one more thing :p | 15:29 |
| vincentfrancoise | chrisspencer: now that we know that it's due to the context formatting | 15:29 |
| vincentfrancoise | chrisspencer: can we re-use the notation from https://review.openstack.org/#/c/422295/3/watcher/decision_engine/model/notification/nova.py@224 or https://review.openstack.org/#/c/422295/4/watcher/decision_engine/model/notification/nova.py@223 instead? | 15:30 |
| vincentfrancoise | chrisspencer: so that the whole thing gets more concise | 15:31 |
| chrisspencer | yup! | 15:31 |
| vincentfrancoise | chrisspencer: cool :) | 15:31 |
| *** adisky_ has quit IRC | 15:39 | |
| *** acabot has joined #openstack-watcher | 15:48 | |
| *** brunograz has quit IRC | 16:03 | |
| *** brunograz has joined #openstack-watcher | 16:09 | |
| *** vincentfrancoise has quit IRC | 17:29 | |
| openstackgerrit | Chris Spencer proposed openstack/watcher master: Adding additional details to notification logs https://review.openstack.org/422295 | 18:27 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/watcher master: Switch to use test_utils.call_until_true https://review.openstack.org/431712 | 18:50 |
| *** harlowja_ has joined #openstack-watcher | 20:35 | |
| *** harlowja has quit IRC | 20:37 | |
| *** thorst_ has quit IRC | 21:57 | |
| *** harlowja_ has quit IRC | 21:58 | |
| *** thorst_ has joined #openstack-watcher | 21:58 | |
| *** thorst_ has quit IRC | 22:02 | |
| *** harlowja has joined #openstack-watcher | 22:05 | |
| *** thorst_ has joined #openstack-watcher | 22:23 | |
| *** thorst_ has quit IRC | 22:28 | |
| *** gabor_antal has quit IRC | 23:05 | |
| *** gabor_antal has joined #openstack-watcher | 23:07 | |
| *** yuanying has joined #openstack-watcher | 23:12 | |
| *** gabor_antal has quit IRC | 23:15 | |
| *** gabor_antal has joined #openstack-watcher | 23:17 | |
| *** grumpycatt has quit IRC | 23:29 | |
| *** grumpycatt has joined #openstack-watcher | 23:30 | |
| *** wootehfoot has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!