| *** hidekazu has joined #openstack-watcher | 00:33 | |
| hidekazu | morning | 00:34 |
|---|---|---|
| *** hidekazu has quit IRC | 00:46 | |
| *** thorst_ has quit IRC | 01:20 | |
| *** thorst_ has joined #openstack-watcher | 01:21 | |
| *** thorst_ has quit IRC | 01:25 | |
| *** zhurong has joined #openstack-watcher | 01:52 | |
| *** thorst_ has joined #openstack-watcher | 02:00 | |
| *** thorst_ has quit IRC | 02:00 | |
| *** hidekazu has joined #openstack-watcher | 02:19 | |
| *** thorst_ has joined #openstack-watcher | 02:32 | |
| *** thorst_ has quit IRC | 02:32 | |
| *** zhurong_ has joined #openstack-watcher | 03:36 | |
| *** zhurong has quit IRC | 03:38 | |
| *** thorst_ has joined #openstack-watcher | 03:58 | |
| *** thorst_ has quit IRC | 03:58 | |
| *** zhurong_ has quit IRC | 04:11 | |
| *** thorst_ has joined #openstack-watcher | 04:21 | |
| *** thorst_ has quit IRC | 04:21 | |
| *** diga has joined #openstack-watcher | 04:40 | |
| *** gabor_antal_ has quit IRC | 06:10 | |
| *** thorst_ has joined #openstack-watcher | 06:22 | |
| *** thorst_ has quit IRC | 06:27 | |
| *** zhurong has joined #openstack-watcher | 06:45 | |
| openstackgerrit | Zeyu Zhu proposed openstack/python-watcherclient master: Using jsonutils instead of json https://review.openstack.org/428608 | 07:20 |
| openstackgerrit | Antoine Cabot proposed openstack/watcher master: Update release notes with Ocata branch https://review.openstack.org/428631 | 08:10 |
| openstackgerrit | Antoine Cabot proposed openstack/watcher-dashboard master: Add Ocata release notes https://review.openstack.org/428634 | 08:15 |
| *** alexchadin has joined #openstack-watcher | 08:20 | |
| *** thorst_ has joined #openstack-watcher | 08:23 | |
| *** vincentfrancoise has joined #openstack-watcher | 08:23 | |
| *** thorst_ has quit IRC | 08:28 | |
| openstackgerrit | Zeyu Zhu proposed openstack/watcher master: Using items() instead of six.iteritems() https://review.openstack.org/428638 | 08:33 |
| openstackgerrit | Merged openstack/watcher-dashboard master: Update reno for stable/ocata https://review.openstack.org/428336 | 08:46 |
| openstackgerrit | Merged openstack/python-watcherclient master: Using jsonutils instead of json https://review.openstack.org/428608 | 08:47 |
| openstackgerrit | Merged openstack/watcher master: Update reno for stable/ocata https://review.openstack.org/428339 | 08:48 |
| openstackgerrit | Merged openstack/watcher master: Use RPC cast() to be asynchronous https://review.openstack.org/421268 | 08:48 |
| openstackgerrit | Alexander Chadin proposed openstack/watcher master: Add Action Notification https://review.openstack.org/427646 | 09:23 |
| *** dtardivel has joined #openstack-watcher | 09:33 | |
| openstackgerrit | Merged openstack/watcher master: Using items() instead of six.iteritems() https://review.openstack.org/428638 | 09:33 |
| alexchadin | vincentfrancoise: hi | 09:54 |
| vincentfrancoise | alexchadin: morning | 09:54 |
| *** zhurong has quit IRC | 09:55 | |
| alexchadin | I am trying to rebase my action notification patch set and found out that ActionPlanPayload now requires action_plan, audit, strategy to initialize | 09:56 |
| alexchadin | vincentfrancoise: actually, I don't need strategy and audit to build action payload | 09:56 |
| vincentfrancoise | alexchadin: let me see your code (1sec) | 09:57 |
| vincentfrancoise | The way I solved this in audit was by creating a new payload type that was TerseAuditPayload (as opposed to AuditPayload) | 09:58 |
| vincentfrancoise | The problem is that you need to load the UUIDs in your payload even though you don't want all the rest | 09:59 |
| vincentfrancoise | so in your ActionPlanPayload, what you want is "strategy_uuid" and "audit_uuid" but not strategy and not "audit" | 10:00 |
| alexchadin | so, I need to get strategy_uuid and audit_uuid from action_plan to give it to __init__? | 10:01 |
| vincentfrancoise | yes, it's a pain because we have the ID for both but not the UUIDs | 10:01 |
| vincentfrancoise | so in my case I needed to do an extra query to get the UUID | 10:02 |
| vincentfrancoise | alexchadin: what you need to do should be similar to https://github.com/openstack/watcher/blob/master/watcher/notifications/audit.py#L66 | 10:02 |
| vincentfrancoise | alexchadin: and https://github.com/openstack/watcher/blob/master/watcher/notifications/audit.py#L96-L105 | 10:03 |
| alexchadin | I see | 10:03 |
| alexchadin | oh | 10:04 |
| alexchadin | Is there some notification agreements in OpenStack? Oslo.Messaging rules it? | 10:04 |
| vincentfrancoise | alexchadin: actually there was a bug in the audit notifications that missed the goal_uuid and strategy_uuid fields | 10:05 |
| vincentfrancoise | alexchadin: there is no real agreement per se, but implicitely everyone uses versioned notifications with oslo.versionedobjects and oslo.messaging | 10:06 |
| *** hidekazu has quit IRC | 10:15 | |
| *** thorst_ has joined #openstack-watcher | 10:24 | |
| *** thorst_ has quit IRC | 10:29 | |
| alexchadin | acabot: what is IRC Handle of Yumeng Bao? | 11:33 |
| *** alexchadin has quit IRC | 11:42 | |
| *** diga has quit IRC | 12:32 | |
| *** alexchadin has joined #openstack-watcher | 12:33 | |
| *** thorst_ has joined #openstack-watcher | 12:37 | |
| *** alexchad_ has joined #openstack-watcher | 12:44 | |
| *** alexchadin has quit IRC | 12:47 | |
| *** vmahe has joined #openstack-watcher | 12:53 | |
| *** vmahe has left #openstack-watcher | 12:56 | |
| *** zhurong has joined #openstack-watcher | 13:09 | |
| vincentfrancoise | alexchad_: it's YumengBao but he's not connected it seems | 13:09 |
| chrisspencer | o/ hi all | 13:18 |
| vincentfrancoise | chrisspencer: hi | 13:18 |
| *** alexchadin has joined #openstack-watcher | 13:18 | |
| *** alexchad_ has quit IRC | 13:20 | |
| *** Yumeng__ has joined #openstack-watcher | 13:38 | |
| *** edleafe is now known as figleaf | 14:07 | |
| *** alexchadin has quit IRC | 14:29 | |
| chrisspencer | vincentfrancoise: After reading through documentation for the last couple of days I noticed that there is a variable called logging_context_format_string that will need to change so we can display our context settings in our logging. Currently for devstack (how we gate test?) we have a setup file in watcher/devstack/lib/watcher. Do we want to change this | 14:29 |
| chrisspencer | init value here to include our variables or should I dynamically change it in the code? I feel like making the initialization change in the setup file makes it an easier change, and doing it dynamically probably requires me to figure out how to undo the modification (figure out what the initial value is in the conf file) | 14:29 |
| chrisspencer | sorry for the length of the message :) | 14:29 |
| vincentfrancoise | chrisspencer: good question :p | 14:35 |
| vincentfrancoise | chrisspencer: IMHO, we should do it the same way other projects handle it in their devstack plugin | 14:35 |
| chrisspencer | vincentfrancoise: meaning, leave the setup file like others have it, and just modify the setting when we need to? | 14:36 |
| vincentfrancoise | chrisspencer: so after looking at the nova devstack plugin I found this https://github.com/openstack-dev/devstack/blob/master/lib/nova#L525 which executes this function https://github.com/openstack-dev/devstack/blob/master/functions#L572-L583 | 14:36 |
| chrisspencer | so they are changing the logging_context_format_string: https://github.com/openstack-dev/devstack/blob/master/functions#L598 | 14:38 |
| chrisspencer | changing is the incorrect word. Setting the default* | 14:38 |
| vincentfrancoise | chrisspencer: yeah I understood you ;) | 14:39 |
| vincentfrancoise | chrisspencer: if I understand it correctly, setting the context like I proposed you should have affected logging_context_format_string set here: https://github.com/openstack-dev/devstack/blob/master/functions#L598 | 14:42 |
| vincentfrancoise | chrisspencer: and you have set request_id which is also mentioned in "%(request_id)s" | 14:43 |
| chrisspencer | vincentfrancoise: do we care about the event_type? I was attempting to add the publisher and event in addition to the already captured items of request, username, and project name. | 14:46 |
| vincentfrancoise | chrisspencer: the request ID is the least we need | 14:47 |
| vincentfrancoise | the rest is bonus | 14:48 |
| chrisspencer | ok sounds good. I'll work on getting at least that :) | 14:48 |
| vincentfrancoise | chrisspencer: this one https://github.com/openstack/watcher/blob/master/watcher/decision_engine/audit/continuous.py#L86 | 14:53 |
| vincentfrancoise | chrisspencer: it has its request ID logged (see http://logs.openstack.org/95/422295/6/check/gate-watcher-dsvm-multinode-ubuntu-xenial-nv/ca31bb8/logs/screen-watcher-decision-engine.txt.gz#_2017-02-02_17_55_07_513) | 14:54 |
| vincentfrancoise | chrisspencer: so maybe the is_admin plays a role, I don't know | 14:55 |
| chrisspencer | vincentfrancoise: good find! thanks. I'll try it out | 14:58 |
| *** gabor_antal has joined #openstack-watcher | 15:11 | |
| *** Yumeng__ has quit IRC | 16:01 | |
| *** zhurong has quit IRC | 16:34 | |
| *** vincentfrancoise has quit IRC | 17:08 | |
| pshedimb | heads up to guys using devstack multi node to develop watcher | 17:18 |
| pshedimb | Nova changed its work flow, and now introduced placement api as a mandatory companent | 17:19 |
| pshedimb | component* | 17:19 |
| pshedimb | So the latest devstack wouldn't work unless you include placement conf in nova.conf file | 17:20 |
| pshedimb | And need to run this command on controller after adding placement conf on compute nodes | 17:21 |
| pshedimb | nova-manage cell_v2 discover_hosts | 17:21 |
| *** d34dh0r53 has quit IRC | 17:56 | |
| *** d34dh0r53 has joined #openstack-watcher | 17:56 | |
| *** dtardivel has quit IRC | 19:14 | |
| *** wootehfoot has joined #openstack-watcher | 21:49 | |
| *** thorst_ has quit IRC | 22:25 | |
| *** figleaf is now known as edleafe | 23:17 | |
| openstackgerrit | Alex Schultz proposed openstack/puppet-watcher master: Prepare ocata-rc1 release https://review.openstack.org/429107 | 23:24 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!