*** thorst_ has quit IRC | 00:10 | |
*** absubram has quit IRC | 00:20 | |
*** jwcroppe has quit IRC | 00:27 | |
*** jwcroppe has joined #openstack-watcher | 00:40 | |
*** jwcroppe has quit IRC | 00:45 | |
*** thorst_ has joined #openstack-watcher | 00:54 | |
*** hidekazu has joined #openstack-watcher | 01:28 | |
*** openstackgerrit has joined #openstack-watcher | 01:40 | |
openstackgerrit | zhurong proposed openstack/watcher-dashboard: Add page title for some panel table https://review.openstack.org/416798 | 01:40 |
---|---|---|
*** jwcroppe has joined #openstack-watcher | 01:47 | |
*** jwcroppe has quit IRC | 02:14 | |
*** harlowja has quit IRC | 03:05 | |
*** thorst_ has quit IRC | 03:14 | |
*** thorst_ has joined #openstack-watcher | 03:15 | |
*** thorst_ has quit IRC | 03:19 | |
*** thorst_ has joined #openstack-watcher | 03:25 | |
*** thorst_ has quit IRC | 03:25 | |
*** jwcroppe has joined #openstack-watcher | 03:54 | |
*** thorst_ has joined #openstack-watcher | 04:01 | |
*** thorst_ has quit IRC | 04:01 | |
*** jwcroppe has quit IRC | 04:05 | |
*** jwcroppe has joined #openstack-watcher | 05:43 | |
*** jwcroppe has quit IRC | 05:54 | |
*** thorst_ has joined #openstack-watcher | 06:02 | |
*** thorst_ has quit IRC | 06:07 | |
*** pksingh has joined #openstack-watcher | 06:18 | |
*** pksingh has quit IRC | 06:19 | |
*** thorst_ has joined #openstack-watcher | 06:28 | |
*** thorst_ has quit IRC | 06:33 | |
*** diga has joined #openstack-watcher | 06:45 | |
*** jwcroppe has joined #openstack-watcher | 07:33 | |
*** jwcroppe has quit IRC | 07:44 | |
*** openstackgerrit has quit IRC | 07:50 | |
*** Yumeng has joined #openstack-watcher | 08:04 | |
*** zhurong has joined #openstack-watcher | 08:24 | |
*** jwcroppe has joined #openstack-watcher | 08:28 | |
*** thorst_ has joined #openstack-watcher | 08:29 | |
*** thorst_ has quit IRC | 08:34 | |
*** jwcroppe has quit IRC | 08:37 | |
*** jwcroppe has joined #openstack-watcher | 09:22 | |
*** jwcroppe has quit IRC | 09:33 | |
*** diga has quit IRC | 09:36 | |
*** zhurong has quit IRC | 09:40 | |
*** openstackgerrit has joined #openstack-watcher | 10:04 | |
openstackgerrit | Merged openstack/watcher-dashboard: Add reno for release notes management https://review.openstack.org/416419 | 10:04 |
*** openstack has joined #openstack-watcher | 10:14 | |
*** jwcroppe has joined #openstack-watcher | 10:17 | |
*** jwcroppe has quit IRC | 10:27 | |
*** thorst_ has joined #openstack-watcher | 10:30 | |
*** thorst_ has quit IRC | 10:35 | |
*** vincentfrancoise has quit IRC | 10:55 | |
*** diga has joined #openstack-watcher | 11:16 | |
*** diga has quit IRC | 11:37 | |
*** grumpycatt has quit IRC | 11:55 | |
*** diga has joined #openstack-watcher | 12:00 | |
*** jwcroppe has joined #openstack-watcher | 12:07 | |
*** jwcroppe has quit IRC | 12:15 | |
*** diga_ has joined #openstack-watcher | 12:21 | |
*** diga has quit IRC | 12:23 | |
*** thorst_ has joined #openstack-watcher | 12:46 | |
*** Yumeng has left #openstack-watcher | 12:52 | |
*** hidekazu has quit IRC | 12:55 | |
*** vincentfrancoise has joined #openstack-watcher | 13:06 | |
*** dtardivel has joined #openstack-watcher | 13:56 | |
*** jwcroppe has joined #openstack-watcher | 13:56 | |
*** jwcroppe has quit IRC | 14:08 | |
*** pkoniszewski has quit IRC | 14:15 | |
*** pkoniszewski has joined #openstack-watcher | 14:15 | |
*** lamt has joined #openstack-watcher | 14:43 | |
*** thorst_ is now known as thorst_afk | 14:50 | |
*** jwcroppe has joined #openstack-watcher | 14:51 | |
*** absubram has joined #openstack-watcher | 14:58 | |
*** jwcroppe has quit IRC | 15:03 | |
*** d34dh0r53 has quit IRC | 15:14 | |
*** d34dh0r53 has joined #openstack-watcher | 15:14 | |
*** lamt has quit IRC | 15:15 | |
*** lamt has joined #openstack-watcher | 15:16 | |
*** diga_ has quit IRC | 15:18 | |
*** jwcroppe has joined #openstack-watcher | 15:22 | |
*** Yumeng_ has joined #openstack-watcher | 15:31 | |
*** thorst_afk is now known as thorst_ | 15:53 | |
*** Yumeng_ has quit IRC | 15:59 | |
chrisspencer | sballe_: we are all setup on the systems | 16:00 |
sballe_ | chrisspencer: this is very cool! incluign collectd? | 16:01 |
sballe_ | can you check we are getting the right metrics like ll3_misses etc | 16:01 |
chrisspencer | unfortunately we are blocked on that right now. I have the request out to get access to the repo. | 16:01 |
chrisspencer | I'll send an email to those guys to try and expedite the request | 16:02 |
*** Yumeng__ has joined #openstack-watcher | 16:09 | |
vincentfrancoise | hi sballe_ | 16:49 |
vincentfrancoise | did you receive my bug suggestion last time? | 16:50 |
sballe_ | yes chrisspencer decided he wanted to work on it | 16:50 |
sballe_ | thx a lot for the suggesttion | 16:50 |
chrisspencer | vincentfrancoise: I just started looking into it | 16:50 |
vincentfrancoise | so just as an FYI | 16:51 |
vincentfrancoise | there's someone else that talked about this bug with me yesterday (let me find out who it was :p) | 16:51 |
chrisspencer | vincentfrancoise: ack. is that someone else working on it now? | 16:56 |
vincentfrancoise | I don't know, did you assign it to yourself on launchpad? | 16:57 |
vincentfrancoise | (can't find outwho it was) | 16:58 |
chrisspencer | not yet, still unassigned | 16:58 |
chrisspencer | now it is :) | 16:58 |
vincentfrancoise | can you send me the link pls? | 16:58 |
chrisspencer | https://bugs.launchpad.net/watcher/+bug/1642623 | 16:58 |
openstack | Launchpad bug 1642623 in watcher "Add resource ID in nova notification logs " [Wishlist,Triaged] - Assigned to Chris Spencer (christopher-m-spencer) | 16:58 |
vincentfrancoise | there you go that was atuly that was talking with me about it | 16:59 |
vincentfrancoise | he wrote a comment on the bug BTW | 16:59 |
vincentfrancoise | chrisspencer: do you understand what has to be done? | 17:02 |
vincentfrancoise | I'm about to leave so that would be the perfect moment to ask :) | 17:02 |
chrisspencer | yes, I saw that comment. Is his comment the fix? from the description it seemed like we wanted a more generic solution at a higher level. like for all NotificationEndpoints? | 17:02 |
vincentfrancoise | at the moment, we already have logs for the notifications | 17:02 |
vincentfrancoise | but since we receive the notifications concurrently | 17:03 |
chrisspencer | also notification IDs and messageIDs, in the code are the the publisher ID and instance ID? | 17:03 |
vincentfrancoise | the logs are unreadable because we don't know from which initial event/notification each line of log we see comes from | 17:03 |
chrisspencer | makes sense | 17:04 |
vincentfrancoise | so when you see this log https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/notification/nova.py#L346-L350 | 17:04 |
vincentfrancoise | you have the metadata and you can track the initial event | 17:05 |
vincentfrancoise | however when we handle the notification and get to https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/notification/nova.py#L48 | 17:05 |
vincentfrancoise | we can't tell the initial message ID anymore | 17:06 |
vincentfrancoise | so the logger should be somehow aware of the message ID it references | 17:06 |
chrisspencer | alright | 17:06 |
vincentfrancoise | and when I say generic | 17:07 |
vincentfrancoise | the idea is to make it the least intrusive we can | 17:07 |
vincentfrancoise | because if it's well made, we may as well reuse the mechanism to do the logging of all event handlers | 17:08 |
chrisspencer | +1 will start working on that | 17:09 |
chrisspencer | thanks vincentfrancoise | 17:09 |
vincentfrancoise | is that ok for you? It's not the easiest starting point, but at least you don't really add a new feature so can be sure you won't break anything and you probably won't need to write unit tests | 17:10 |
chrisspencer | yup that works, sounds like a good way to dig in! | 17:11 |
vincentfrancoise | email/ping me if needed ;) | 17:11 |
vincentfrancoise | bye all :) | 17:11 |
*** vincentfrancoise has quit IRC | 17:15 | |
*** dtardivel has quit IRC | 19:04 | |
*** harlowja has joined #openstack-watcher | 19:16 | |
*** Yumeng__ has quit IRC | 19:31 | |
*** thorst_ has quit IRC | 22:04 | |
*** absubram has quit IRC | 23:28 | |
*** jwcroppe has quit IRC | 23:58 | |
*** jwcroppe has joined #openstack-watcher | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!