*** thorst has joined #openstack-watcher | 00:42 | |
*** thorst has quit IRC | 01:21 | |
*** thorst has joined #openstack-watcher | 01:22 | |
*** gfhellma has quit IRC | 01:28 | |
*** thorst has quit IRC | 01:31 | |
*** aspiers has quit IRC | 01:34 | |
*** harlowja has quit IRC | 01:35 | |
*** thorst has joined #openstack-watcher | 01:36 | |
*** thorst has quit IRC | 01:37 | |
*** aspiers has joined #openstack-watcher | 01:39 | |
*** thorst has joined #openstack-watcher | 02:07 | |
*** thorst has quit IRC | 02:16 | |
*** yuanying has quit IRC | 02:47 | |
*** yuanying has joined #openstack-watcher | 02:50 | |
*** thorst has joined #openstack-watcher | 03:14 | |
*** thorst has quit IRC | 03:21 | |
*** yuanying has quit IRC | 03:37 | |
*** aswadr_ has joined #openstack-watcher | 03:45 | |
*** yuanying has joined #openstack-watcher | 03:50 | |
*** thorst has joined #openstack-watcher | 04:21 | |
*** thorst has quit IRC | 04:26 | |
*** diga has joined #openstack-watcher | 05:08 | |
*** thorst has joined #openstack-watcher | 05:23 | |
*** thorst has quit IRC | 05:32 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/watcher: Docstrings should not start with a space https://review.openstack.org/377257 | 06:04 |
---|---|---|
*** thorst has joined #openstack-watcher | 06:30 | |
openstackgerrit | zhangyanxian proposed openstack/watcher: Fix typo in hooks.py https://review.openstack.org/377269 | 06:32 |
openstackgerrit | zhangyanxian proposed openstack/watcher: Fix typo in hooks.py https://review.openstack.org/377269 | 06:33 |
*** thorst has quit IRC | 06:37 | |
*** alexchadin has joined #openstack-watcher | 07:28 | |
alexchadin | hi vincentfrancoise | 07:28 |
vincentfrancoise | alexchadin: hi | 07:28 |
alexchadin | if you have a free time, take a look at my latest PS https://review.openstack.org/#/c/371632/ | 07:29 |
vincentfrancoise | I'm actually looking at it right now | 07:29 |
vincentfrancoise | alexchadin: I've a couple of comments but appart from that LGTM | 07:33 |
alexchadin | vincentfrancoise: yeap, I see. Thank you:) | 07:33 |
vincentfrancoise | alexchadin: If by any chance you can review some of my code, that would be awesome :) | 07:34 |
alexchadin | vincentfrancoise: OVO patch? 2500+ lines of changes? 0_0 | 07:35 |
*** thorst has joined #openstack-watcher | 07:35 | |
vincentfrancoise | alexchadin: the smaller ones | 07:35 |
vincentfrancoise | https://review.openstack.org/#/c/371619/ | 07:36 |
alexchadin | vincentfrancoise: We need "Trust me, it works" tag on such big patches | 07:36 |
vincentfrancoise | https://review.openstack.org/#/c/375342/ | 07:36 |
vincentfrancoise | alexchadin: hahahaha | 07:36 |
vincentfrancoise | alexchadin: these are really hard to chop down into smaller reviews | 07:37 |
*** dtardivel has joined #openstack-watcher | 07:37 | |
alexchadin | I understand, it will take a lot of time to split it | 07:37 |
*** thorst has quit IRC | 07:41 | |
*** gzhai has quit IRC | 08:13 | |
alexchadin | vincentfrancoise: not every child class of Service should have service_name field | 08:19 |
vincentfrancoise | alexchadin: but the property will always exist isn't it? | 08:20 |
vincentfrancoise | alexchadin: but I understand that it might simply left empty | 08:20 |
alexchadin | vincentfrancoise: yes, we can set None to the property | 08:20 |
openstackgerrit | Merged openstack/watcher: Fixed issue on compute nodes iteration https://review.openstack.org/371521 | 08:20 |
vincentfrancoise | alexchadin: it's just that hasattr is something I tend to avoid | 08:21 |
openstackgerrit | Alexander Chadin proposed openstack/watcher: [WIP] Add service supervisor https://review.openstack.org/371632 | 08:45 |
openstackgerrit | Alexander Chadin proposed openstack/watcher: Add service supervisor https://review.openstack.org/371632 | 09:06 |
*** gzhai has joined #openstack-watcher | 09:20 | |
alexchadin | vincentfrancoise: Changes are made | 09:21 |
*** thorst has joined #openstack-watcher | 09:44 | |
*** thorst has quit IRC | 09:51 | |
*** alexchadin has quit IRC | 09:56 | |
*** alexchadin has joined #openstack-watcher | 09:56 | |
*** alexchadin has quit IRC | 09:57 | |
*** diga has quit IRC | 09:57 | |
*** alexchadin has joined #openstack-watcher | 09:57 | |
*** alexchadin has quit IRC | 09:57 | |
*** alexchadin has joined #openstack-watcher | 09:58 | |
*** alexchadin has quit IRC | 09:58 | |
*** diga has joined #openstack-watcher | 10:24 | |
*** alexchadin has joined #openstack-watcher | 10:42 | |
*** alexchadin has quit IRC | 10:43 | |
*** thorst has joined #openstack-watcher | 10:49 | |
*** thorst has quit IRC | 10:56 | |
*** alexchadin has joined #openstack-watcher | 11:48 | |
openstackgerrit | Alexander Chadin proposed openstack/watcher: Add service object to the watcher_db_schema https://review.openstack.org/377634 | 11:52 |
openstackgerrit | Alexander Chadin proposed openstack/watcher: Add service supervisor https://review.openstack.org/371632 | 11:53 |
*** thorst has joined #openstack-watcher | 11:53 | |
*** gzhai has quit IRC | 12:06 | |
*** diga has quit IRC | 13:08 | |
*** gzhai has joined #openstack-watcher | 13:19 | |
gzhai | dtardivel:hi | 13:23 |
*** gzhai has quit IRC | 13:31 | |
dtardivel | hi | 13:34 |
openstackgerrit | Vincent Françoise proposed openstack/watcher-dashboard: Added action details https://review.openstack.org/377699 | 13:35 |
*** michaelgugino has joined #openstack-watcher | 14:14 | |
*** _d34dh0r53_ is now known as d34dh0r53 | 14:34 | |
*** alexchadin has quit IRC | 14:53 | |
*** openstackgerrit has quit IRC | 15:18 | |
*** openstackgerrit has joined #openstack-watcher | 15:18 | |
openstackgerrit | Vincent Françoise proposed openstack/watcher-dashboard: Added action details https://review.openstack.org/377699 | 15:37 |
*** hvprash has joined #openstack-watcher | 16:05 | |
*** hvprash has quit IRC | 16:10 | |
*** diga has joined #openstack-watcher | 16:14 | |
*** vincentfrancoise has quit IRC | 16:14 | |
*** diga_ has joined #openstack-watcher | 16:36 | |
*** diga has quit IRC | 16:36 | |
*** diga_ is now known as diga | 16:36 | |
*** thorst has quit IRC | 16:37 | |
*** aswadr_ has quit IRC | 16:37 | |
*** jimbaker has quit IRC | 16:37 | |
*** jimbaker` has joined #openstack-watcher | 16:37 | |
*** pkoniszewski has quit IRC | 16:37 | |
*** hanrong has quit IRC | 16:37 | |
*** tkaczynski has quit IRC | 16:37 | |
*** acabot has quit IRC | 16:37 | |
*** umbSublime_ has quit IRC | 16:37 | |
*** umbSublime_ has joined #openstack-watcher | 16:37 | |
*** licanwei has quit IRC | 16:38 | |
*** pkoniszewski has joined #openstack-watcher | 16:38 | |
*** yuanying has quit IRC | 16:40 | |
*** yuanying has joined #openstack-watcher | 16:41 | |
*** yuanying_ has joined #openstack-watcher | 16:45 | |
*** grumpycatt has quit IRC | 16:46 | |
*** grumpycatt has joined #openstack-watcher | 16:46 | |
*** dtardivel has quit IRC | 16:47 | |
*** yuanying has quit IRC | 16:48 | |
*** logan- has quit IRC | 16:48 | |
*** hanrong has joined #openstack-watcher | 16:48 | |
*** acabot has joined #openstack-watcher | 16:49 | |
*** thorst has joined #openstack-watcher | 16:50 | |
*** gfhellma has joined #openstack-watcher | 16:52 | |
*** logan- has joined #openstack-watcher | 16:54 | |
*** acabot has quit IRC | 17:10 | |
*** acabot has joined #openstack-watcher | 17:11 | |
*** thorst_ has joined #openstack-watcher | 17:11 | |
*** logan- has quit IRC | 17:11 | |
*** thorst has quit IRC | 17:11 | |
*** logan- has joined #openstack-watcher | 17:12 | |
*** harlowja has joined #openstack-watcher | 17:17 | |
*** grumpycatt has quit IRC | 17:21 | |
*** grumpycatt has joined #openstack-watcher | 17:21 | |
*** harlowja_ has joined #openstack-watcher | 17:22 | |
*** harlowja has quit IRC | 17:22 | |
*** logan- has quit IRC | 17:22 | |
*** hanrong has quit IRC | 17:22 | |
*** hanrong has joined #openstack-watcher | 17:24 | |
*** jimbaker` has quit IRC | 17:28 | |
*** logan- has joined #openstack-watcher | 17:28 | |
*** hanrong has quit IRC | 17:32 | |
*** logan- has quit IRC | 17:33 | |
*** harlowja_ has quit IRC | 17:33 | |
*** harlowja has joined #openstack-watcher | 17:34 | |
*** hanrong has joined #openstack-watcher | 17:37 | |
*** logan- has joined #openstack-watcher | 17:38 | |
*** aswadr_ has joined #openstack-watcher | 17:39 | |
*** dtardivel has joined #openstack-watcher | 17:40 | |
*** harlowja has quit IRC | 17:42 | |
*** tkaczynski has joined #openstack-watcher | 17:42 | |
*** harlowja has joined #openstack-watcher | 17:47 | |
*** aswadr_ has quit IRC | 17:58 | |
*** thorst_ has quit IRC | 17:59 | |
*** thorst_ has joined #openstack-watcher | 18:03 | |
*** aspiers has quit IRC | 18:09 | |
*** grumpycatt has quit IRC | 18:10 | |
*** grumpycatt has joined #openstack-watcher | 18:10 | |
*** harlowja has quit IRC | 18:10 | |
*** tkaczynski has quit IRC | 18:10 | |
*** dtardivel has quit IRC | 18:10 | |
*** thorst_ has quit IRC | 18:11 | |
*** gfhellma has quit IRC | 18:11 | |
*** aspiers has joined #openstack-watcher | 18:15 | |
*** dtardivel has joined #openstack-watcher | 18:20 | |
*** harlowja has joined #openstack-watcher | 18:24 | |
*** thorst_ has joined #openstack-watcher | 18:25 | |
*** tkaczynski has joined #openstack-watcher | 18:28 | |
*** tkaczynski has quit IRC | 18:28 | |
*** tkaczynski has joined #openstack-watcher | 18:28 | |
*** gfhellma has joined #openstack-watcher | 18:32 | |
*** jimbaker` has joined #openstack-watcher | 18:32 | |
*** michaelgugino has quit IRC | 18:33 | |
*** michaelgugino has joined #openstack-watcher | 18:35 | |
*** thorst_ has quit IRC | 18:35 | |
*** thorst_ has joined #openstack-watcher | 18:36 | |
*** thorst_ has joined #openstack-watcher | 18:36 | |
*** dtardivel has quit IRC | 18:37 | |
*** logan- has quit IRC | 18:39 | |
*** logan- has joined #openstack-watcher | 18:42 | |
*** thorst_ has quit IRC | 18:50 | |
*** thorst_ has joined #openstack-watcher | 18:56 | |
*** jimbaker` has quit IRC | 18:57 | |
*** hanrong has quit IRC | 18:59 | |
*** hanrong has joined #openstack-watcher | 19:02 | |
*** wootehfoot has joined #openstack-watcher | 19:05 | |
*** michaelgugino has quit IRC | 19:24 | |
*** logan- has quit IRC | 19:26 | |
*** aspiers has quit IRC | 19:27 | |
*** hanrong has quit IRC | 19:27 | |
*** hanrong has joined #openstack-watcher | 19:28 | |
*** aspiers has joined #openstack-watcher | 19:29 | |
*** logan- has joined #openstack-watcher | 19:34 | |
*** aspiers has quit IRC | 19:35 | |
*** tkaczynski has quit IRC | 19:36 | |
*** aspiers has joined #openstack-watcher | 19:37 | |
*** edleafe has quit IRC | 19:44 | |
*** aspiers has quit IRC | 19:45 | |
*** edleafe has joined #openstack-watcher | 19:46 | |
*** aspiers has joined #openstack-watcher | 19:47 | |
*** diga has quit IRC | 19:48 | |
*** hvprash has joined #openstack-watcher | 19:51 | |
*** diga has joined #openstack-watcher | 19:55 | |
*** tkaczynski has joined #openstack-watcher | 19:57 | |
*** ossifrath has quit IRC | 20:00 | |
*** ossifrath has joined #openstack-watcher | 20:04 | |
*** logan- has quit IRC | 20:21 | |
*** pkoniszewski has quit IRC | 20:21 | |
*** ossifrath has quit IRC | 20:23 | |
*** diga has quit IRC | 20:23 | |
*** hvprash has quit IRC | 20:23 | |
*** aspiers has quit IRC | 20:24 | |
*** pkoniszewski has joined #openstack-watcher | 20:24 | |
*** aspiers has joined #openstack-watcher | 20:25 | |
*** logan- has joined #openstack-watcher | 20:26 | |
*** aspiers has quit IRC | 20:32 | |
*** hvprash has joined #openstack-watcher | 20:35 | |
*** aspiers has joined #openstack-watcher | 20:36 | |
*** ss4 has joined #openstack-watcher | 20:43 | |
*** diga has joined #openstack-watcher | 20:43 | |
*** wootehfoot has quit IRC | 20:46 | |
*** hvprash has quit IRC | 20:46 | |
*** jimbaker` has joined #openstack-watcher | 20:50 | |
*** ossifrath has joined #openstack-watcher | 20:55 | |
*** hvprash has joined #openstack-watcher | 20:57 | |
*** thorst_ has quit IRC | 21:23 | |
*** thorst_ has joined #openstack-watcher | 21:24 | |
*** thorst_ has quit IRC | 21:29 | |
*** hvprash has quit IRC | 21:35 | |
*** ss4 has quit IRC | 22:09 | |
*** hvprash has joined #openstack-watcher | 23:01 | |
*** edleafe has quit IRC | 23:39 | |
*** edleafe has joined #openstack-watcher | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!