| *** thorst has quit IRC | 00:02 | |
| *** thorst has joined #openstack-watcher | 00:25 | |
| *** vtech has quit IRC | 00:33 | |
| *** wootehfoot has quit IRC | 00:38 | |
| *** thorst has quit IRC | 00:45 | |
| *** thorst has joined #openstack-watcher | 00:46 | |
| *** wootehfoot has joined #openstack-watcher | 00:50 | |
| *** thorst has quit IRC | 00:54 | |
| *** harlowja has quit IRC | 01:00 | |
| *** harlowja has joined #openstack-watcher | 01:03 | |
| *** esberglu has quit IRC | 01:13 | |
| openstackgerrit | junjie.huang proposed openstack/watcher: Workload balance migration strategy implementation https://review.openstack.org/292188 | 01:31 |
|---|---|---|
| *** thorst has joined #openstack-watcher | 01:51 | |
| *** thorst has quit IRC | 01:59 | |
| *** wootehfoot has quit IRC | 02:35 | |
| *** thorst has joined #openstack-watcher | 02:56 | |
| *** thorst has quit IRC | 03:04 | |
| *** vtech has joined #openstack-watcher | 03:33 | |
| *** vtech has quit IRC | 03:41 | |
| *** thorst has joined #openstack-watcher | 04:01 | |
| *** thorst has quit IRC | 04:09 | |
| *** brunograz has quit IRC | 04:23 | |
| *** thorst has joined #openstack-watcher | 05:06 | |
| *** thorst has quit IRC | 05:13 | |
| *** jwcroppe has joined #openstack-watcher | 05:50 | |
| *** jwcroppe has quit IRC | 05:57 | |
| *** thorst has joined #openstack-watcher | 06:11 | |
| *** thorst has quit IRC | 06:18 | |
| *** apoorv has joined #openstack-watcher | 06:38 | |
| *** vtech has joined #openstack-watcher | 06:40 | |
| *** vtech has quit IRC | 06:40 | |
| *** apoorv_ has joined #openstack-watcher | 07:00 | |
| *** vtech has joined #openstack-watcher | 07:04 | |
| *** brunograz has joined #openstack-watcher | 07:07 | |
| *** thorst has joined #openstack-watcher | 07:16 | |
| openstackgerrit | Merged openstack/watcher: Remove unused logging import and LOG global var https://review.openstack.org/301994 | 07:20 |
| *** thorst has quit IRC | 07:24 | |
| *** vincentfrancoise has joined #openstack-watcher | 07:28 | |
| *** jwcroppe has joined #openstack-watcher | 07:54 | |
| *** jwcroppe has quit IRC | 07:58 | |
| *** apoorv_ has quit IRC | 08:08 | |
| *** apoorv has quit IRC | 08:08 | |
| *** thorst has joined #openstack-watcher | 08:21 | |
| openstackgerrit | Alexander Chadin proposed openstack/watcher: Fix for deleting audit template https://review.openstack.org/301190 | 08:28 |
| *** thorst has quit IRC | 08:30 | |
| *** apoorv_ has joined #openstack-watcher | 08:36 | |
| *** apoorv has joined #openstack-watcher | 08:36 | |
| *** alexchadin has joined #openstack-watcher | 08:39 | |
| *** alexchadin has quit IRC | 08:45 | |
| *** alexchadin has joined #openstack-watcher | 08:45 | |
| alexchadin | hi | 09:14 |
| vincentfrancoise | hi | 09:15 |
| alexchadin | made minor change here: https://review.openstack.org/#/c/301190/ | 09:15 |
| alexchadin | could you review it, pls? | 09:15 |
| vincentfrancoise | yeah will do ;) | 09:16 |
| alexchadin | oh, and i want to discuss with you about this patch:https://review.openstack.org/#/c/302293/ | 09:16 |
| vincentfrancoise | ah yes, did you have a look at the way i did it for audits? | 09:17 |
| alexchadin | yes, i did | 09:17 |
| alexchadin | look | 09:17 |
| vincentfrancoise | what do you think then? | 09:18 |
| alexchadin | as i see, in create_audit process we have 2 main part: writing to db and activate decision engine to run strategy | 09:18 |
| alexchadin | right? | 09:18 |
| vincentfrancoise | yes | 09:19 |
| alexchadin | i looked through it:https://review.openstack.org/#/c/282395/4/watcher/decision_engine/audit/default.py | 09:20 |
| alexchadin | "if audit.state != audit_objects.State.PENDING:" - here you have check of valid state | 09:21 |
| alexchadin | but i think, at this part we already have audit has been written to db | 09:22 |
| alexchadin | It seems that you validate the state after the audit is written to DB. I agree we should move all data validation logic outside of the post() method. Maybe, DB layer? | 09:23 |
| alexchadin | if i'm not right, correct me, pls | 09:24 |
| vincentfrancoise | well | 09:24 |
| vincentfrancoise | that's the point of me doing the validation using the AuditPostType (see https://review.openstack.org/#/c/282395/4/watcher/api/controllers/v1/audit.py) | 09:25 |
| vincentfrancoise | This is an actual intermediate object where the DB insert has not been done yet | 09:25 |
| alexchadin | okay, i got it | 09:26 |
| alexchadin | what does @wsme.validate(types.uuid, AuditPostType) do? | 09:26 |
| vincentfrancoise | basically | 09:26 |
| vincentfrancoise | it takes the wsexpose() body | 09:27 |
| vincentfrancoise | and runs the validate() method it implements | 09:27 |
| vincentfrancoise | which by default | 09:27 |
| vincentfrancoise | does a type verification | 09:27 |
| vincentfrancoise | so for AuditPostType | 09:27 |
| *** thorst has joined #openstack-watcher | 09:27 | |
| vincentfrancoise | it will check that the UUID is correctly formatted ans so on | 09:29 |
| vincentfrancoise | so that's why if you look at the comments on https://bugs.launchpad.net/watcher/+bug/1532843 | 09:31 |
| openstack | Launchpad bug 1532843 in watcher "Can create Audit with invalid parameters" [Low,Triaged] - Assigned to Alexander Chadin (joker946) | 09:31 |
| vincentfrancoise | I was already pointing at my PS when talking to Hristo (https://bugs.launchpad.net/watcher/+bug/1532843/comments/3) | 09:31 |
| alexchadin | i saw it, thx | 09:32 |
| alexchadin | good, i will think how my patch may be refactored | 09:32 |
| vincentfrancoise | 1 more thing | 09:32 |
| alexchadin | there is always one more thing... | 09:32 |
| vincentfrancoise | if you decide you want to use my changeset as a basis | 09:33 |
| vincentfrancoise | you can actually re-assign it to you since I currently don't have much time to work on it | 09:33 |
| alexchadin | to kill two bug at once? | 09:34 |
| *** thorst has quit IRC | 09:34 | |
| alexchadin | bugs* | 09:34 |
| vincentfrancoise | exactly | 09:35 |
| alexchadin | great;) | 09:35 |
| *** alexchadin has quit IRC | 09:41 | |
| apoorv_ | getting this error on running stack.sh http://pastebin.com/download/A2j1XFqy | 09:46 |
| vincentfrancoise | apoorv_: are you installing on a VM or directly on bare metal? | 09:48 |
| *** brunograz has quit IRC | 09:56 | |
| *** thorst has joined #openstack-watcher | 10:32 | |
| *** thorst has quit IRC | 10:39 | |
| apoorv_ | on a vm | 10:41 |
| vincentfrancoise | apoorv_: which version of devstack are you using? | 10:51 |
| apoorv_ | how do i check the version | 11:00 |
| vincentfrancoise | inside the devstack/ folder, just do a "git status" | 11:02 |
| vincentfrancoise | if you are on master then I would suggest you work with the stable/liberty or stable/mitaka branch | 11:03 |
| apoorv_ | how can i prevent installing watcher-dashboard | 11:06 |
| vincentfrancoise | apoorv_: watcher-dashboard is not enabled by default if I'm not mistaken | 11:09 |
| vincentfrancoise | apoorv_: Sorry for not being not so helpful, I do not have any spare VM to re-install Watcher at the moment | 11:10 |
| *** thorst has joined #openstack-watcher | 11:11 | |
| *** thorst_ has joined #openstack-watcher | 11:11 | |
| *** thorst has quit IRC | 11:15 | |
| vincentfrancoise | apoorv_: did you actually https://factory.b-com.com/www/watcher/doc/watcher/dev/devstack.html to build your devstack? | 11:23 |
| *** vtech has quit IRC | 11:34 | |
| *** vtech has joined #openstack-watcher | 11:35 | |
| apoorv_ | yes | 11:51 |
| apoorv_ | i dont know why its installing watcher-dashboard | 11:56 |
| vincentfrancoise | don't know either | 12:02 |
| *** apoorv_ has quit IRC | 12:27 | |
| *** apoorv has quit IRC | 12:27 | |
| *** vtech has quit IRC | 13:04 | |
| *** vtech has joined #openstack-watcher | 13:05 | |
| *** thorst_ has quit IRC | 14:21 | |
| *** thorst_ has joined #openstack-watcher | 14:22 | |
| *** thorst__ has joined #openstack-watcher | 14:26 | |
| *** thorst_ has quit IRC | 14:27 | |
| *** thorst__ has quit IRC | 14:37 | |
| *** thorst_ has joined #openstack-watcher | 14:41 | |
| *** thorst__ has joined #openstack-watcher | 14:54 | |
| *** thorst_ has quit IRC | 14:58 | |
| *** esberglu has joined #openstack-watcher | 14:59 | |
| *** thorst__ is now known as thorst________ | 15:00 | |
| *** jwcroppe has joined #openstack-watcher | 15:04 | |
| *** thorst________ is now known as thorst_ | 15:08 | |
| *** jwcroppe has quit IRC | 15:10 | |
| *** jwcroppe has joined #openstack-watcher | 15:23 | |
| *** jwcroppe has quit IRC | 15:31 | |
| *** vtech has quit IRC | 16:07 | |
| *** vtech has joined #openstack-watcher | 16:08 | |
| *** vtech has quit IRC | 16:10 | |
| *** vincentfrancoise has quit IRC | 16:50 | |
| *** jwcroppe has joined #openstack-watcher | 16:58 | |
| *** jwcroppe has quit IRC | 17:02 | |
| *** jwcroppe has joined #openstack-watcher | 17:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements https://review.openstack.org/302937 | 17:25 |
| *** vtech has joined #openstack-watcher | 17:41 | |
| *** vtech has quit IRC | 17:41 | |
| *** vtech has joined #openstack-watcher | 17:42 | |
| *** vtech has quit IRC | 18:51 | |
| *** wootehfoot has joined #openstack-watcher | 19:04 | |
| *** vtech has joined #openstack-watcher | 19:14 | |
| *** jed56 has quit IRC | 20:13 | |
| *** vtech has quit IRC | 20:36 | |
| *** vtech has joined #openstack-watcher | 20:38 | |
| *** thorst_ has quit IRC | 21:12 | |
| *** thorst_ has joined #openstack-watcher | 21:18 | |
| *** thorst__ has joined #openstack-watcher | 21:21 | |
| *** thorst_ has quit IRC | 21:22 | |
| *** thorst__ has quit IRC | 21:25 | |
| *** thorst_ has joined #openstack-watcher | 21:44 | |
| *** thorst_ has quit IRC | 21:48 | |
| *** tpeoplesvacation has left #openstack-watcher | 22:19 | |
| *** tpeoplesvacation has joined #openstack-watcher | 22:19 | |
| *** jwcroppe has quit IRC | 22:30 | |
| *** esberglu has quit IRC | 23:20 | |
| *** vtech has quit IRC | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!