| *** e0ne has joined #openstack-vitrage | 05:15 | |
| *** e0ne has quit IRC | 05:42 | |
| *** eyalb1 has joined #openstack-vitrage | 06:31 | |
| openstackgerrit | Eyal proposed openstack/python-vitrageclient master: Add release notes for the wait flag https://review.opendev.org/664204 | 06:55 |
|---|---|---|
| openstackgerrit | Merged openstack/vitrage master: Update Devstack plugin README https://review.opendev.org/663663 | 07:07 |
| *** e0ne has joined #openstack-vitrage | 07:20 | |
| *** eyalb has joined #openstack-vitrage | 07:35 | |
| *** eyalb1 has quit IRC | 07:37 | |
| e0ne | eyalb: hi. are you around? let's discuss https://review.opendev.org/#/c/577388/20/vitrage/notifier/plugins/mistral/mistral_notifier.py here | 08:29 |
| eyalb | i am here | 08:30 |
| e0ne | line #30 (self._client = None) is inside __init__ method, that's why I don't understand your comment | 08:31 |
| eyalb | after you removed the conf parameter from NotifierBase __init__ method the __init__ of NotifierBase does nothing am I right ? | 08:33 |
| e0ne | you're right | 08:34 |
| eyalb | so why calling it ? | 08:34 |
| e0ne | oh.. I understood what you mean | 08:34 |
| e0ne | it's to be consistent with the code and in case if we add __ini__ to the NotifierBase we won't be required to change base classes | 08:35 |
| eyalb | ok | 08:36 |
| e0ne | thanks for the reviews! I'll update my patches today | 08:37 |
| openstackgerrit | Merged openstack/python-vitrageclient master: Add new api to list template versions supported https://review.opendev.org/664250 | 08:53 |
| openstackgerrit | Merged openstack/python-vitrageclient master: Add release notes for the wait flag https://review.opendev.org/664204 | 09:24 |
| *** eyalb has quit IRC | 12:11 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Refactor vitrage to use global CONF instead of local one https://review.opendev.org/577388 | 14:51 |
| *** e0ne has quit IRC | 15:36 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!