*** bobh has quit IRC | 02:10 | |
*** e0ne has joined #openstack-vitrage | 05:35 | |
*** e0ne has quit IRC | 05:36 | |
*** eyalb has joined #openstack-vitrage | 06:25 | |
*** eyalb1 has joined #openstack-vitrage | 07:18 | |
*** ifat_afek has joined #openstack-vitrage | 07:21 | |
*** brault has quit IRC | 07:30 | |
*** brault has joined #openstack-vitrage | 07:30 | |
*** eyalb has quit IRC | 07:39 | |
*** eyalb has joined #openstack-vitrage | 07:40 | |
*** eyalb has quit IRC | 07:40 | |
*** eyalb has joined #openstack-vitrage | 07:41 | |
*** e0ne has joined #openstack-vitrage | 07:53 | |
*** pava_ has quit IRC | 07:57 | |
*** pava_ has joined #openstack-vitrage | 07:58 | |
openstackgerrit | Merged openstack/vitrage master: Add upgrade support for Vitrage https://review.openstack.org/575115 | 07:58 |
---|---|---|
*** e0ne has quit IRC | 08:46 | |
*** ifat_afek has quit IRC | 09:23 | |
*** ifat_afek has joined #openstack-vitrage | 10:03 | |
openstackgerrit | Yuval Adar proposed openstack/vitrage-dashboard master: Add templates panel to admin section https://review.openstack.org/578350 | 10:16 |
*** e0ne has joined #openstack-vitrage | 10:41 | |
openstackgerrit | Muhamad Najjar proposed openstack/vitrage-dashboard master: fix time format to show in 24h https://review.openstack.org/578358 | 11:27 |
*** e0ne has quit IRC | 11:29 | |
openstackgerrit | Muhamad Najjar proposed openstack/vitrage-dashboard master: fix time format to show in 24h https://review.openstack.org/578358 | 11:34 |
openstackgerrit | Yuval Adar proposed openstack/vitrage-dashboard master: Add templates panel to admin section https://review.openstack.org/578360 | 11:34 |
openstackgerrit | Yuval Adar proposed openstack/vitrage-dashboard master: Add templates panel to admin section https://review.openstack.org/578360 | 11:36 |
*** e0ne has joined #openstack-vitrage | 11:42 | |
*** ifat_afek has quit IRC | 12:00 | |
openstackgerrit | Oleksiy Petrenko proposed openstack/vitrage master: Refactor vitrage to use global CONF instead of local one https://review.openstack.org/577388 | 12:01 |
openstackgerrit | Merged openstack/vitrage-dashboard master: fix time format to show in 24h https://review.openstack.org/578358 | 12:18 |
*** e0ne has quit IRC | 13:26 | |
*** e0ne has joined #openstack-vitrage | 13:38 | |
e0ne | eyalb: hi. are you around? I've got few questions about vitrage tempest plugin | 13:42 |
*** bobh has joined #openstack-vitrage | 13:55 | |
eyalb | i am here | 13:56 |
e0ne | we discussed a bit last week on the meeting that tempest plugin imports some things from vitrage directly | 14:02 |
e0ne | do you know about any plans on fixing ?i | 14:03 |
e0ne | *fixing it | 14:03 |
eyalb | it is on our road map but nopthing concreate | 14:10 |
eyalb | some fixes are easy some are more complicated | 14:10 |
eyalb | you have all the constants that are taken from vitrage this is easy to fix | 14:11 |
eyalb | either duplicate of create a common library | 14:11 |
eyalb | the complicated is that there are some tests that use vitrage inner implementations which is wrong and should be refactored | 14:12 |
e0ne | yea, I see | 14:14 |
e0ne | we tried to re-factore conf object usage | 14:15 |
e0ne | and now tempest plugin fails because of it | 14:15 |
e0ne | I'm trying to figure out the best way to fix it without huge refactoring if possible | 14:16 |
eyalb | I have no problem with huge refactoring better now then later | 14:18 |
e0ne | fair enough :) | 14:19 |
eyalb | this something that should have been done before but we simply didn't have enough resources | 14:19 |
eyalb | or even the knowledge of how things should be done the "OpenStack" way | 14:19 |
e0ne | I totally understand the reasons why it didn't happen | 14:20 |
e0ne | eyalb: honestly, 'openstack way' is not always the best way | 14:20 |
eyalb | I agree | 14:20 |
*** ifat_afek has joined #openstack-vitrage | 14:21 | |
eyalb | but sometimes you have no choice :-( | 14:21 |
e0ne | +1 | 14:21 |
e0ne | :( | 14:21 |
eyalb | so if you have the to refactor then go ahead ... | 14:22 |
eyalb | *time* | 14:22 |
e0ne | it's a hard question | 14:23 |
e0ne | I'll try to find some resources after rocky-3 milestone | 14:23 |
eyalb | yes this can be good | 14:24 |
eyalb | maybe for now we can just have the upgrade without tests and work on it after rocky-3 milestone | 14:25 |
e0ne | not a bad plan | 14:30 |
*** eyalb has quit IRC | 14:31 | |
e0ne | I'll try to have a fast fix: disable tests (patch #1) => implement conf changes (patch #2) => implement tempest changes (patch #3) => enable tests (patch #4) => implement db migrations (patch #5) == have a chain with 5 patches:(. after it we can start refactoring tempest plugin without rush | 14:32 |
ifat_afek | e0ne: Hi :-) eyalb just left, but I followed part of the discussion | 14:33 |
ifat_afek | What do you mean by ‘disable tests’? the new upgrade tests? | 14:33 |
ifat_afek | And what are the parts that you plan to do after rocky-3? | 14:34 |
e0ne | ifat_afek: hi. I mean move current jobs in non-voting mode to get tempest fix landed | 14:40 |
e0ne | I'm not sure that it's a good solution, TBH :( | 14:40 |
e0ne | ifat_afek: I'll try to find some resources to refactor tempest plugin as discussed above after rocky-3 | 14:41 |
ifat_afek | e0ne: this would be great. We know this is something we must fix… and we understand if it’s currently blocking you | 14:56 |
e0ne | ifat_afek: thanks for supporting my efforts! I appreciate it | 14:57 |
ifat_afek | Thanks for helping :-) we have a common interest | 14:59 |
e0ne | :) | 14:59 |
*** e0ne has quit IRC | 16:13 | |
*** ifat_afek has quit IRC | 17:06 | |
*** e0ne has joined #openstack-vitrage | 18:16 | |
*** bobh has quit IRC | 18:22 | |
*** bobh has joined #openstack-vitrage | 18:23 | |
*** e0ne has quit IRC | 18:32 | |
*** e0ne has joined #openstack-vitrage | 18:44 | |
*** ifat_afek has joined #openstack-vitrage | 19:45 | |
*** ifat_afek has quit IRC | 19:56 | |
*** e0ne has quit IRC | 20:42 | |
*** ifat_afek has joined #openstack-vitrage | 21:13 | |
*** ifat_afek has quit IRC | 21:14 | |
*** bobh has quit IRC | 22:00 | |
*** brault has quit IRC | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!