*** bobh has joined #openstack-vitrage | 00:39 | |
*** yujunz has joined #openstack-vitrage | 00:47 | |
*** yujunz has quit IRC | 00:50 | |
*** bobh has quit IRC | 01:14 | |
*** bobh has joined #openstack-vitrage | 01:14 | |
*** yujunz has joined #openstack-vitrage | 01:18 | |
*** openstackgerrit has joined #openstack-vitrage | 01:47 | |
*** yujunz has quit IRC | 02:08 | |
*** bobh has quit IRC | 02:20 | |
*** bobh has joined #openstack-vitrage | 02:21 | |
*** bobh has quit IRC | 02:24 | |
*** bobh has joined #openstack-vitrage | 02:24 | |
*** bobh has quit IRC | 02:52 | |
*** bobh has joined #openstack-vitrage | 02:53 | |
*** bobh has quit IRC | 03:17 | |
*** bobh has joined #openstack-vitrage | 04:00 | |
*** bobh has quit IRC | 04:04 | |
openstackgerrit | Yujun Zhang proposed openstack/vitrage-specs master: Add proposal "suspect alarm" https://review.openstack.org/519250 | 04:55 |
---|---|---|
openstackgerrit | Yujun Zhang proposed openstack/vitrage-specs master: Fix bug that autobuild not working properly https://review.openstack.org/528951 | 04:58 |
openstackgerrit | Yujun Zhang proposed openstack/vitrage-specs master: Re-order Queens specification to keep consistency with Pike https://review.openstack.org/528952 | 05:20 |
openstackgerrit | Ifat Afek proposed openstack/vitrage-tempest-plugin master: Fixed README links https://review.openstack.org/528975 | 07:20 |
*** ifat_afek has joined #openstack-vitrage | 07:43 | |
openstackgerrit | Merged openstack/python-vitrageclient master: Updated from global requirements https://review.openstack.org/528920 | 08:06 |
*** chandankumar has joined #openstack-vitrage | 08:11 | |
chandankumar | ifat_afek: hello | 08:11 |
chandankumar | ifat_afek: i think we can sync the code in a single commit | 08:11 |
ifat_afek | chandankumar: Hi | 08:11 |
chandankumar | ifat_afek: this is what i had done for neutron tempest plugin https://review.openstack.org/#/c/519310/ | 08:12 |
ifat_afek | You mean wait for the changes to merge, and then sync all tempest changes? | 08:12 |
ifat_afek | Makes sense | 08:12 |
openstackgerrit | Merged openstack/vitrage-tempest-plugin master: Code sync for support json field in db https://review.openstack.org/528525 | 08:20 |
*** eyalb has joined #openstack-vitrage | 08:27 | |
*** brault has joined #openstack-vitrage | 08:59 | |
*** pava__ has quit IRC | 09:16 | |
openstackgerrit | Chandan Kumar proposed openstack/vitrage master: Removed Bundled intree vitrage-tempest-plugin from vitrage project https://review.openstack.org/528528 | 09:37 |
*** ifat_afek has quit IRC | 10:07 | |
*** brault has quit IRC | 10:44 | |
*** brault has joined #openstack-vitrage | 10:45 | |
*** brault has quit IRC | 10:50 | |
*** brault has joined #openstack-vitrage | 10:51 | |
*** ifat_afek has joined #openstack-vitrage | 11:15 | |
*** eyalb has quit IRC | 11:20 | |
*** eyalb has joined #openstack-vitrage | 11:33 | |
*** brault has quit IRC | 11:39 | |
*** brault has joined #openstack-vitrage | 11:45 | |
*** brault has quit IRC | 11:50 | |
openstackgerrit | Eyal proposed openstack/vitrage-tempest-plugin master: update requirements https://review.openstack.org/529049 | 12:24 |
*** brault has joined #openstack-vitrage | 12:30 | |
openstackgerrit | Merged openstack/vitrage-tempest-plugin master: update requirements https://review.openstack.org/529049 | 12:38 |
*** ifat_afek_ has joined #openstack-vitrage | 12:38 | |
*** ifat_afek has quit IRC | 12:39 | |
*** ifat_afek_ is now known as ifat_afek | 12:39 | |
*** bobh has joined #openstack-vitrage | 12:52 | |
*** bobh has quit IRC | 12:53 | |
openstackgerrit | Eyal proposed openstack/vitrage-tempest-plugin master: update requirements https://review.openstack.org/529058 | 12:59 |
*** zhurong has joined #openstack-vitrage | 12:59 | |
*** zhurong has quit IRC | 13:02 | |
*** zhurong has joined #openstack-vitrage | 13:03 | |
openstackgerrit | Merged openstack/vitrage-tempest-plugin master: update requirements https://review.openstack.org/529058 | 13:14 |
chandankumar | ifat_afek: hello | 13:18 |
ifat_afek | Hi | 13:18 |
chandankumar | ifat_afek: currently vitrage tempest plugin is dependent on vitrage project and in practicallity it should be non-dependent | 13:18 |
ifat_afek | I didn’t understand, sorry. What do you mean by dependent? | 13:19 |
chandankumar | ifat_afek: for example this one https://github.com/openstack/vitrage-tempest-plugin/blob/master/vitrage_tempest_tests/tests/database/test_persistor.py#L19 | 13:19 |
chandankumar | ifat_afek: it should not depend on vitrage direct imports | 13:20 |
ifat_afek | Why is it a problem? | 13:20 |
chandankumar | ifat_afek: the tempest tests should run from anywhere | 13:21 |
chandankumar | ifat_afek: that's why currently for running vitrage tests, we need to make vitrage installed | 13:22 |
ifat_afek | Ok. We’ll have to check it. I have to go to a meeting now, are you available in two hours? | 13:22 |
chandankumar | ifat_afek: nope | 13:22 |
chandankumar | ifat_afek: currently all tempest tests are failing i need to fix that part | 13:23 |
ifat_afek | Ok, thanks for letting me know | 13:23 |
chandankumar | may be i will check tomorrow | 13:23 |
ifat_afek | Thanks! | 13:23 |
ifat_afek | So let’s talk tomorrow | 13:23 |
*** zhurong has quit IRC | 13:25 | |
*** ifat_afek has quit IRC | 13:30 | |
*** ifat_afek has joined #openstack-vitrage | 13:32 | |
openstackgerrit | Eyal proposed openstack/vitrage-tempest-plugin master: update requirements https://review.openstack.org/529073 | 13:59 |
*** ifat_afek has quit IRC | 14:00 | |
openstackgerrit | Merged openstack/vitrage-tempest-plugin master: update requirements https://review.openstack.org/529073 | 14:19 |
*** efoley has joined #openstack-vitrage | 15:08 | |
eyalb | @chandankumar are you here ? | 15:15 |
*** ifat_afek has joined #openstack-vitrage | 15:18 | |
*** bobh has joined #openstack-vitrage | 15:26 | |
*** liusheng has quit IRC | 15:45 | |
*** liusheng has joined #openstack-vitrage | 15:45 | |
*** brault has quit IRC | 16:20 | |
*** brault has joined #openstack-vitrage | 16:21 | |
*** brault_ has joined #openstack-vitrage | 16:25 | |
*** brault has quit IRC | 16:26 | |
chandankumar | eyalb: yup | 16:36 |
eyalb | Hi | 16:37 |
eyalb | it seems that the vitrage-tempest-plugin repo is old | 16:37 |
eyalb | I can see the errors they were fixed a long time ago | 16:38 |
chandankumar | eyalb: https://github.com/openstack/vitrage-tempest-plugin/commit/eeab1c591e310e3d22efb249e946948c06c86e19https://github.com/openstack/vitrage-tempest-plugin/commit/eeab1c591e310e3d22efb249e946948c06c86e19 | 16:38 |
eyalb | but when I look at the git repo its looks like its new | 16:38 |
chandankumar | eyalb: i have seperated the plugin from this commit | 16:38 |
chandankumar | i.e on 8th Dec | 16:38 |
eyalb | for some reason the repo that is cloned is old | 16:38 |
eyalb | e.g the error in the py35 devstack was fixed | 16:39 |
chandankumar | eyalb: but the py35 error is not related to tempest plugin na/ | 16:40 |
eyalb | look at this http://logs.openstack.org/28/528528/3/check/vitrage-dsvm-api-py35/6fefc8c/logs/devstack-gate-post_test_hook.txt.gz#_2017-12-19_15_01_28_362 | 16:40 |
eyalb | if you go the source code you will see it was fixed | 16:40 |
eyalb | https://github.com/openstack/vitrage-tempest-plugin/blob/master/vitrage_tempest_tests/tests/utils.py#L130 | 16:41 |
eyalb | it was changed to __name__ | 16:42 |
chandankumar | eyalb: yup | 16:42 |
eyalb | how come ? | 16:42 |
eyalb | maybe it is based on your github repo which is old | 16:43 |
chandankumar | eyalb: https://github.com/openstack/vitrage/blob/master/vitrage_tempest_tests/tests/utils.py#L130 | 16:43 |
chandankumar | eyalb: https://github.com/openstack/vitrage-tempest-plugin/blob/master/vitrage_tempest_tests/tests/utils.py#L130 | 16:44 |
chandankumar | both are same | 16:44 |
chandankumar | eyalb: i have used the same repo for split | 16:44 |
eyalb | yes but in the tempest test it says AttributeError: 'function' object has no attribute 'func_name' | 16:45 |
eyalb | File "/opt/stack/new/tempest/.tox/tempest/lib/python3.5/site-packages/vitrage_tempest_tests/tests/utils.py", line 123, in tempest_logger | 16:46 |
eyalb | 2017-12-19 15:01:28.362 | func_name = func.func_name | 16:46 |
eyalb | 2017-12-19 15:01:28.367 | AttributeError: 'function' object has no attribute 'func_name | 16:46 |
eyalb | zuul has cloned a different version of the source | 16:46 |
chandankumar | eyalb: yes no idea, i am not sure on py35 why it is behaving like that | 16:46 |
eyalb | no the problem also on py27 | 16:47 |
eyalb | some of the errors where fixed by me | 16:47 |
eyalb | in a later version | 16:47 |
eyalb | this error for example | 16:48 |
eyalb | http://logs.openstack.org/28/528528/3/check/vitrage-dsvm-api-py27/20ad8bb/logs/devstack-gate-post_test_hook.txt.gz#_2017-12-19_15_09_05_891 | 16:48 |
eyalb | if you look at the source code you will see it was changed later | 16:49 |
eyalb | this is the latest code | 16:50 |
eyalb | https://github.com/openstack/vitrage/blob/master/vitrage_tempest_tests/tests/api/resources/test_resources.py#L153 | 16:50 |
eyalb | its not even the same line | 16:50 |
chandankumar | eyalb: https://github.com/chkumar246/vitrage-tempest-plugin is the existing repo where i had done the seperation | 16:52 |
chandankumar | and the same repo got imported | 16:53 |
eyalb | maybe it has to do with this https://review.openstack.org/#/c/526836/ | 16:54 |
eyalb | in projects.yaml it has a refrence to your git hub as upstream | 16:54 |
eyalb | https://review.openstack.org/#/c/526836/2/gerrit/projects.yaml | 16:55 |
chandankumar | eyalb: upstream is used to migrate a temprory repo to here | 16:55 |
chandankumar | eyalb: let me remove the gerrit reference from commit message | 16:55 |
chandankumar | and see what happends | 16:55 |
eyalb | ye maybe it has a dependency on it | 16:55 |
openstackgerrit | Chandan Kumar proposed openstack/vitrage master: Removed Bundled intree vitrage-tempest-plugin from vitrage project https://review.openstack.org/528528 | 16:56 |
chandankumar | but we use depends-on keyword for that | 16:56 |
chandankumar | let'see what is the issue now | 16:56 |
eyalb | I know | 16:56 |
eyalb | I have to go I will check it later | 16:57 |
chandankumar | eyalb: thanks for looking into the issue. | 16:57 |
chandankumar | same here | 16:57 |
eyalb | thanks for the effort | 16:57 |
chandankumar | see ya tomorrow :-) | 16:57 |
*** eyalb has quit IRC | 17:03 | |
*** ifat_afek has quit IRC | 17:30 | |
*** brault_ has quit IRC | 17:38 | |
*** brault has joined #openstack-vitrage | 17:38 | |
*** brault has quit IRC | 17:43 | |
*** efoley has quit IRC | 18:04 | |
*** bobh has quit IRC | 18:32 | |
*** brault has joined #openstack-vitrage | 18:52 | |
*** brault has quit IRC | 18:53 | |
*** brault has joined #openstack-vitrage | 18:54 | |
*** openstack has joined #openstack-vitrage | 19:43 | |
*** ChanServ sets mode: +o openstack | 19:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!