*** tovin07 has joined #openstack-vitrage | 01:44 | |
*** yujunz has joined #openstack-vitrage | 02:07 | |
*** yujunz is now known as yujunz[away] | 02:28 | |
*** yujunz[away] is now known as yujunz | 02:42 | |
*** yujunz is now known as yujunz[away] | 02:42 | |
*** yujunz[away] is now known as yujunz | 02:42 | |
*** yujunz is now known as yujunz[away] | 02:43 | |
*** yujunz[away] is now known as yujunz | 02:43 | |
*** yujunz has quit IRC | 03:29 | |
*** yujunz has joined #openstack-vitrage | 03:30 | |
*** yujunz is now known as yujunz[away] | 03:47 | |
*** yujunz[away] is now known as yujunz | 03:47 | |
*** yujunz is now known as yujunz[away] | 03:48 | |
*** yujunz[away] is now known as yujunz | 04:14 | |
*** yujunz is now known as yujunz[away] | 04:15 | |
*** yujunz[away] has quit IRC | 04:18 | |
*** yujunz has joined #openstack-vitrage | 05:34 | |
*** yujunz is now known as yujunz[away] | 06:19 | |
*** yujunz[away] is now known as yujunz | 06:32 | |
*** yujunz is now known as yujunz[away] | 06:43 | |
*** yujunz[away] is now known as yujunz | 06:43 | |
*** yujunz is now known as yujunz[away] | 08:20 | |
*** yujunz[away] is now known as yujunz | 08:23 | |
*** yujunz is now known as yujunz[away] | 09:00 | |
*** yujunz[away] is now known as yujunz | 09:17 | |
*** yujunz is now known as yujunz[away] | 09:41 | |
*** yujunz[away] is now known as yujunz | 10:02 | |
*** tovin07 has quit IRC | 10:06 | |
*** yujunz has quit IRC | 10:06 | |
*** yujunz has joined #openstack-vitrage | 10:06 | |
*** yujunz has quit IRC | 10:14 | |
*** yujunz has joined #openstack-vitrage | 10:18 | |
*** yujunz has quit IRC | 10:24 | |
openstackgerrit | Noam Bloom proposed openstack/vitrage-dashboard: Generify template show view https://review.openstack.org/391663 | 10:28 |
---|---|---|
openstackgerrit | Merged openstack/vitrage-dashboard: Generify template show view https://review.openstack.org/391663 | 10:43 |
*** yujunz has joined #openstack-vitrage | 10:46 | |
*** yujunz has quit IRC | 10:47 | |
*** yujunz has joined #openstack-vitrage | 11:03 | |
*** yujunz has quit IRC | 11:06 | |
*** yujunz has joined #openstack-vitrage | 11:15 | |
*** yujunz has quit IRC | 11:18 | |
*** yujunz has joined #openstack-vitrage | 11:31 | |
*** yujunz has quit IRC | 11:33 | |
*** yujunz has joined #openstack-vitrage | 11:34 | |
*** yujunz has quit IRC | 11:34 | |
*** yujunz has joined #openstack-vitrage | 11:35 | |
*** yujunz has quit IRC | 11:36 | |
*** yujunz has joined #openstack-vitrage | 11:42 | |
*** yujunz has quit IRC | 12:22 | |
*** yujunz has joined #openstack-vitrage | 13:32 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-vitrageclient: Updated from global requirements https://review.openstack.org/386382 | 13:35 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/vitrage: Updated from global requirements https://review.openstack.org/387147 | 13:37 |
*** elisha_r has joined #openstack-vitrage | 13:40 | |
*** eyalb has joined #openstack-vitrage | 13:41 | |
*** yujunz has quit IRC | 14:01 | |
mrunge | eyalb, hey, following up on https://bugzilla.redhat.com/show_bug.cgi?id=1342987 | 15:42 |
openstack | bugzilla.redhat.com bug 1342987 in Package Review "Review Request: openstack-vitrage - OpenStack RCA (Root Cause Analysis) Engine" [Unspecified,Assigned] - Assigned to mrunge | 15:42 |
mrunge | it looks like I missed keystoneauth1 indeed | 15:42 |
mrunge | nevertheless, it builds with my changes in a mock environment | 15:43 |
mrunge | eyalb, but for tests there is the vitrageclient required | 15:43 |
eyalb | but its for packging not for building am I right ? | 15:50 |
eyalb | we use the client in tempest | 15:51 |
mrunge | uhm, I'd love to execute the unit tests during package build | 15:51 |
mrunge | actually at the end of build process, just to make sure, the build passes the tests | 15:51 |
mrunge | eyalb, there is no real difference between packaging and building | 15:52 |
mrunge | does that make any sense to you? | 15:53 |
eyalb | well there is BuildRequires and there is Requires | 15:53 |
mrunge | right. | 15:54 |
mrunge | buildrequires is everything required during build | 15:54 |
eyalb | for example for generating the the conf file we need some moudles | 15:54 |
eyalb | so you must have it in buildrequires | 15:54 |
mrunge | then it's missing in build requires | 15:54 |
mrunge | yes | 15:54 |
eyalb | but we dont need the client for the build process | 15:55 |
mrunge | I didn't say my spec is complete | 15:55 |
eyalb | just when installing the tests packages | 15:55 |
mrunge | don't you use the client for running tests? | 15:55 |
eyalb | yes but only if you install the tests rpm | 15:55 |
mrunge | in my spec, tests are being executed as part of the build | 15:56 |
eyalb | then you need the dependency for the client | 15:56 |
mrunge | right | 15:56 |
eyalb | but usually in production you will install the client rpm and the vitrage rpm | 15:56 |
mrunge | since the client is not available as rpm yet, we're currently blocked by it | 15:56 |
mrunge | right | 15:56 |
eyalb | I dont think that we are blocked | 15:57 |
mrunge | see: https://github.com/mrunge/openstack-vitrage/blob/master/openstack-vitrage.spec#L200-L202 | 15:57 |
eyalb | because you can build the rpm no ? | 15:57 |
mrunge | well... | 15:57 |
mrunge | yes you can | 15:57 |
mrunge | eyalb, from looking at your spec file, it looks like you packaged it for 0.2.0, right? | 15:58 |
eyalb | yes | 15:59 |
mrunge | but now vitrage had a bit progress since then | 15:59 |
eyalb | well I can change the version of the dependencies | 15:59 |
eyalb | it should be align with the master no ? | 15:59 |
mrunge | that's why I was trying it a bit more and found more additional dependencies | 15:59 |
mrunge | ideally yes | 16:00 |
eyalb | ok | 16:00 |
eyalb | but it changes all the time | 16:00 |
eyalb | sometimes every week | 16:00 |
mrunge | I would try it with latest release for now | 16:00 |
eyalb | ok thanks | 16:00 |
mrunge | and then we'll adjust for delorean | 16:00 |
mrunge | and yes, it's expected to break from time to time, that happens to other projects as well | 16:00 |
mrunge | every time when a new dependency was added | 16:01 |
eyalb | I also added a package review for the dashboard | 16:01 |
mrunge | oh, I missed that so far | 16:01 |
eyalb | if you can look at it it will be great | 16:01 |
mrunge | yes sure | 16:01 |
mrunge | do you have a bz for it? | 16:01 |
eyalb | yes | 16:02 |
mrunge | or is it not that ready yet? | 16:02 |
eyalb | https://bugzilla.redhat.com/show_bug.cgi?id=1390608 | 16:02 |
openstack | bugzilla.redhat.com bug 1390608 in Package Review "Review Request: vitrage-dashboard Horizon plugin for vitrage" [Unspecified,New] - Assigned to hguemar | 16:02 |
mrunge | ok, thanks, will have a look asap | 16:03 |
eyalb | cool thanks | 16:03 |
mrunge | for reference, the client is under review here: https://bugzilla.redhat.com/show_bug.cgi?id=1379786 | 16:04 |
openstack | bugzilla.redhat.com bug 1379786 in Package Review "Review Request: python-vitrageclient - Python bindings to the Vitrage API" [Unspecified,Assigned] - Assigned to mrunge | 16:04 |
mrunge | maybe I should ping the submitter to look at the changes | 16:04 |
eyalb | that would be great | 16:09 |
*** elisha_r has quit IRC | 16:15 | |
*** eyalb has quit IRC | 16:19 | |
*** pava has quit IRC | 23:07 | |
*** pava has joined #openstack-vitrage | 23:07 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!