| *** openstackgerrit has joined #openstack-valence | 00:02 | |
| openstackgerrit | Nate Potter proposed openstack/valence master: Install and configure etcd in install script https://review.openstack.org/439245 | 00:02 |
|---|---|---|
| openstackgerrit | hubian proposed openstack/valence master: implement simulator for valence https://review.openstack.org/422453 | 01:34 |
| openstackgerrit | Andy Yan proposed openstack/valence master: Clean up css styles for each components. https://review.openstack.org/429578 | 01:34 |
| openstackgerrit | hubian proposed openstack/valence master: implement simulator for valence https://review.openstack.org/422453 | 01:48 |
| openstackgerrit | hubian proposed openstack/valence master: implement simulator for valence https://review.openstack.org/422453 | 02:33 |
| openstackgerrit | hubian proposed openstack/valence master: implement simulator for valence https://review.openstack.org/422453 | 07:55 |
| *** dulek has left #openstack-valence | 08:43 | |
| *** tanyuyua_ has joined #openstack-valence | 14:02 | |
| *** tanyuyua_ has quit IRC | 14:29 | |
| *** shuquan has joined #openstack-valence | 14:48 | |
| *** HuBian has joined #openstack-valence | 14:57 | |
| *** Jinxing has joined #openstack-valence | 14:57 | |
| ntpttr | o/ meeting today? | 15:00 |
| Jinxing | hi | 15:01 |
| HuBian | hello ~ | 15:01 |
| shuquan | hi guys | 15:01 |
| lin_yang | Hello everyone | 15:01 |
| ntpttr | hi all | 15:01 |
| ntpttr | first up, here's the etherpad from our meeting we had at the PTG https://etherpad.openstack.org/p/Valence-Pike-PTG | 15:01 |
| ntpttr | I went through and gave reviews to all the patches I hadn't put comments on yet now that I'm back from the PTG I believe | 15:03 |
| ntpttr | ah Jinxing I got to one of your client patches, I'll do the execution function today | 15:04 |
| Jinxing | ok,thanks | 15:05 |
| ntpttr | I also went ahead and pushed up a patch that installs and configures etcd when you run install_valence, I don't think we should have to install it and add the database entries manually https://review.openstack.org/#/c/439245/ | 15:05 |
| ntpttr | still WIP, looks like it's failing jenkins | 15:06 |
| Jinxing | I plan to submit the base file this week and next week in most of my time. | 15:06 |
| Jinxing | The exception patch is WIP | 15:06 |
| ntpttr | but that failure seems to be a failure to connect to the valence git repo.. | 15:06 |
| ntpttr | maybe I'll recheck | 15:06 |
| ntpttr | Jinxing: ah good to know, can you mark it with workflow -1? | 15:06 |
| Jinxing | I will update this patch later | 15:06 |
| *** tanyuyuan has joined #openstack-valence | 15:06 | |
| ntpttr | that's how we can distinguish WIP so we don't end up merging them or spending too much time on reviewing | 15:07 |
| HuBian | There is a BP for Valence UI : https://blueprints.launchpad.net/openstack-valence/+spec/web-ui-functions I wish yours could take a look on that ~ | 15:07 |
| ntpttr | HuBian: Thanks, | 15:07 |
| Jinxing | Add unittest for exception is still WIP | 15:07 |
| *** yufei has joined #openstack-valence | 15:07 | |
| ntpttr | I'll open that up in a tab for today | 15:07 |
| lin_yang | HuBian: thanks , will do it today | 15:08 |
| *** ramineni_ has joined #openstack-valence | 15:08 | |
| ntpttr | HuBian: That link doesn't seem to work | 15:08 |
| ntpttr | says page doesn't exist | 15:08 |
| Jinxing | ok, | 15:08 |
| HuBian | en ? let me do a check ~ | 15:08 |
| HuBian | https://blueprints.launchpad.net/openstack-valence/+spec/web-ui-functionality | 15:09 |
| lin_yang | Works now thanks | 15:09 |
| ntpttr | HuBian: I see in that BP it says the UI should be able to compose a node and list resources? | 15:10 |
| ntpttr | it's already set up to do those things | 15:10 |
| ntpttr | what redesign do you have in mind | 15:10 |
| *** ananth_n has joined #openstack-valence | 15:10 | |
| HuBian | This one is the right one , and Andy will focus on the Valence UI in comming weeks ~ | 15:10 |
| lin_yang | Basically super welcome to improve ui part | 15:11 |
| ntpttr | yeah they could definitely use improvement | 15:11 |
| ananth_n | hi folks. sorry, am late to join | 15:11 |
| ntpttr | hey ananth_n | 15:11 |
| ntpttr | np | 15:11 |
| lin_yang | Hi Ana thanks | 15:11 |
| HuBian | yeah ~ he will improve the UI | 15:12 |
| lin_yang | Hi ananth | 15:12 |
| shuquan | hi ananth | 15:12 |
| ntpttr | HuBian: okay, I'd like to see some more details in the BP before code is submitted | 15:12 |
| ntpttr | like what does a redesign of node composition mean, are you going to totally redo it? | 15:12 |
| HuBian | OK , maybe he would sumbit a Spec to give details description what he would do on the Valence UI | 15:13 |
| HuBian | And I'll work with him on this part ~ | 15:13 |
| ntpttr | that would be great, it'd be cool to improve on those things a bunch, I'd just like to get the details hashed out in a spec first | 15:14 |
| ntpttr | thank you | 15:14 |
| ntpttr | ananth_n: one thing I mentioned earlier is I pushed up a patch for setting up the database at install time https://review.openstack.org/#/c/439245/ | 15:14 |
| ntpttr | if you wouldn't mind giving it a look sometime | 15:14 |
| lin_yang | Wired this patch should not impact python27/35 unit test | 15:16 |
| ntpttr | yeah it failed those before running any tests | 15:16 |
| ntpttr | I guess the host running the tests couldn't reach the github | 15:16 |
| ntpttr | I did a recheck we'll see if it was a one time fluke | 15:16 |
| ananth_n | @ntpttr sure, will take a look first thing tomorrow | 15:17 |
| ntpttr | thanks ananth_n | 15:17 |
| ntpttr | I guess if nobody has any other topics, I wonder lin_yang would you like to discuss the swagger API? | 15:17 |
| ntpttr | something we've been looking into to improve API spec consistency and ease of development | 15:18 |
| ntpttr | +documentation | 15:18 |
| ananth_n | + coding convention :) | 15:18 |
| ananth_n | underscore vs camelcase | 15:18 |
| lin_yang | Sure | 15:19 |
| ntpttr | ananth_n: ah yeah, good to mention that | 15:19 |
| lin_yang | Swagger/open api is standard and toolset | 15:19 |
| lin_yang | User can define api with all details in yaml format | 15:20 |
| HuBian | http://swagger.io/ seems very cool ~ first time here this ~ | 15:20 |
| ntpttr | we think if we're going to try it out, now is the time while the API is still growing and young | 15:21 |
| HuBian | :) | 15:21 |
| shuquan | agree | 15:21 |
| HuBian | yeah ~ | 15:21 |
| HuBian | the earlier the better ~ | 15:21 |
| lin_yang | So we only need to maintain yaml file and easily to make api part is consistent | 15:22 |
| ntpttr | lin_yang: do you have the cycles to look into it? Would you like some help? I'd be willing to spend some time on it as well | 15:22 |
| *** tanyuyuan has quit IRC | 15:22 | |
| lin_yang | It will be easier we start this effort from beginning valence is new project | 15:23 |
| lin_yang | Absolutely yes | 15:23 |
| ntpttr | sounds good | 15:24 |
| lin_yang | I will creat bp and list all tasks in launchpad | 15:24 |
| ntpttr | thank you! | 15:24 |
| lin_yang | Thank you | 15:25 |
| ntpttr | okay, that's that looks like | 15:26 |
| ntpttr | the other thing ananth_n mentioned | 15:26 |
| ntpttr | underscores vs camelcase | 15:26 |
| ntpttr | the openstack convention is to use variable_name rather than variableName | 15:26 |
| ntpttr | just wanted to make everyone aware, so when you're submitting code let's stick to using underscores | 15:27 |
| ananth_n | +1 | 15:27 |
| HuBian | ++++1 | 15:27 |
| shuquan | +1 | 15:28 |
| lin_yang | +1 | 15:28 |
| ananth_n | how do we address the existing code that are in camel case | 15:28 |
| ananth_n | open a bug and fix I guess | 15:28 |
| ntpttr | probably just with one big patch that attempts to change it all at once | 15:28 |
| ntpttr | yep should track on launchpad | 15:28 |
| lin_yang | Existing code have many camel case variable? | 15:28 |
| ntpttr | it's not fun work but it's got to be done hah | 15:28 |
| ntpttr | I'll look into it | 15:29 |
| ntpttr | anything else people want to talk about? | 15:30 |
| ntpttr | looks like it's time to wrap up | 15:30 |
| ananth_n | @lin_yang I don't know if there is a lot, but there are both conventions used and they show up in the same file too | 15:30 |
| ananth_n | @ntpttr nope, i have nothing else to discuss | 15:30 |
| ntpttr | the one exception to using camel case is redfish requests | 15:30 |
| lin_yang | Okay got it ananth_n | 15:30 |
| ntpttr | redfish does use camel case | 15:30 |
| ntpttr | okay cool, thank you everyone | 15:31 |
| lin_yang | Thanks everyone | 15:32 |
| shuquan | thanks | 15:32 |
| ananth_n | bye everyone | 15:33 |
| HuBian | thanks | 15:33 |
| HuBian | see you ~ | 15:33 |
| *** ananth_n has left #openstack-valence | 15:33 | |
| *** shuquan has quit IRC | 15:33 | |
| *** HuBian has quit IRC | 15:34 | |
| *** Jinxing has left #openstack-valence | 15:37 | |
| *** tanyuyuan has joined #openstack-valence | 16:05 | |
| *** tanyuyuan has quit IRC | 16:17 | |
| *** yufei has quit IRC | 16:33 | |
| *** ramineni_ has quit IRC | 17:20 | |
| openstackgerrit | Nate Potter proposed openstack/valence master: Install and configure etcd in install script https://review.openstack.org/439245 | 18:37 |
| openstackgerrit | Nate Potter proposed openstack/valence master: Allow for composition via flavor https://review.openstack.org/433983 | 19:25 |
| *** openstackgerrit has quit IRC | 20:03 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!