*** ramineni_ has joined #openstack-valence | 03:42 | |
*** ramineni_ has quit IRC | 05:59 | |
openstackgerrit | Anusha Ramineni proposed openstack/valence: Enable release notes translation https://review.openstack.org/422395 | 11:15 |
---|---|---|
openstackgerrit | Anusha Ramineni proposed openstack/valence: Fix modindex link https://review.openstack.org/426721 | 11:36 |
openstackgerrit | Nate Potter proposed openstack/valence: Enable release notes translation https://review.openstack.org/422395 | 18:24 |
openstackgerrit | Merged openstack/valence: Enable release notes translation https://review.openstack.org/422395 | 20:56 |
ntpttr | hey lin_yang, did you see my comment on https://review.openstack.org/#/c/418657/? | 23:16 |
ntpttr | I'm just wondering if returning the redfish UUID with the response might be confusing if we're also generating our own | 23:16 |
lin_yang | sorry, didn't notice that. The UUID we generated will overwrite the redfish one | 23:30 |
lin_yang | just for redfish module, I think it is okay to return uuid, because it's lower module and is not aware how the upper module will handle these data | 23:37 |
lin_yang | how do you think? | 23:38 |
lin_yang | ntpttr: after reconsider, I can not find any cases will need the redfish uuid, will remove it. Thanks a lot, Nate. | 23:45 |
ntpttr | lin_yang: ah okay, sounds good! | 23:45 |
ntpttr | I'll approve the patch when it's up, it looked good to me other than that I think | 23:46 |
ntpttr | thanks :) | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!