*** paken has joined #openstack-upstream-institute | 06:03 | |
*** paken has quit IRC | 06:34 | |
*** paken has joined #openstack-upstream-institute | 07:44 | |
*** gkadam has joined #openstack-upstream-institute | 08:16 | |
*** paken_ has joined #openstack-upstream-institute | 09:01 | |
*** paken has quit IRC | 09:02 | |
*** paken_ is now known as paken | 09:02 | |
*** diablo_rojo has joined #openstack-upstream-institute | 09:14 | |
*** diablo_rojo has quit IRC | 10:51 | |
*** diablo_rojo has joined #openstack-upstream-institute | 10:57 | |
csatari | diablo_rojo, jungleboyj: One attept to add the IRC data to the contributor guide: https://review.openstack.org/#/c/547974/ | 12:19 |
---|---|---|
csatari | Should I port the actual list from the Wiki? That will need continous maintenance, but it preserves one click for the just first contacters. | 12:20 |
*** diablo_rojo has quit IRC | 12:28 | |
paken | Hi, I have a question about changes in a patch to Gerrit (I asked it last week, but I had to disconnect, so I don’t know if anybody answered it). | 12:30 |
paken | For the second patch, I made changes in other files, so if I wanted to do ‘commit —amend’ it seems that the new files wouldn’t be included | 12:31 |
paken | what is the right procedure if in the second patch of a change I have new files to include? | 12:31 |
paken | so that Gerrit knows that it’s for the same change? | 12:31 |
paken | Thanks! | 12:32 |
*** ianychoi has quit IRC | 13:18 | |
gmann_ | paken: it should work, makeing sure you are running all command correctly. 1. checkout the patch 2. change you file(new file also) 3. git add -A 4. git commit --amend (here new window for commit msg should show the all files changed and new file you added after PS1) 5. git review | 13:48 |
paken | Thanks, I’ll try that | 14:25 |
*** paken has quit IRC | 15:45 | |
*** diablo_rojo has joined #openstack-upstream-institute | 16:22 | |
*** diablo_rojo has quit IRC | 16:42 | |
*** gkadam has quit IRC | 16:47 | |
*** paken has joined #openstack-upstream-institute | 19:50 | |
*** paken has quit IRC | 21:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!