| *** rcernin has quit IRC | 03:00 | |
| *** jmlowe has quit IRC | 03:01 | |
| *** rcernin has joined #openstack-trove | 03:03 | |
| *** congnt96 has joined #openstack-trove | 04:12 | |
| *** lxkong has joined #openstack-trove | 05:27 | |
| *** congnt96 has quit IRC | 07:10 | |
| *** tosky has joined #openstack-trove | 09:10 | |
| *** rcernin has quit IRC | 09:23 | |
| *** jmlowe has joined #openstack-trove | 10:03 | |
| *** jmlowe has quit IRC | 10:24 | |
| *** jmlowe has joined #openstack-trove | 10:25 | |
| congnt95 | lxkong: Hi lxkong, please review all my commits and tell me what wrong in my code. thanks! | 10:25 |
|---|---|---|
| congnt95 | https://review.opendev.org/#/c/735498/ | 10:25 |
| congnt95 | https://review.opendev.org/#/c/735290/ | 10:25 |
| congnt95 | https://review.opendev.org/#/c/733759/ | 10:25 |
| lxkong | congnt95: thanks for the patches, they are all on my todo list. I've been busy with family issues recently but will try my best to keep up with the review | 10:49 |
| lxkong | thanks for your patience | 10:49 |
| *** __ministry has quit IRC | 14:13 | |
| *** jamesmcarthur has joined #openstack-trove | 14:39 | |
| *** congnt96 has joined #openstack-trove | 14:39 | |
| *** congnt96 has quit IRC | 14:41 | |
| *** coreycb has joined #openstack-trove | 14:49 | |
| coreycb | hi, was it intended to remove trove-guestagent.conf and is that needed anymore? | 14:50 |
| *** jamesmcarthur has quit IRC | 14:52 | |
| coreycb | the commit message is pretty cryptic and the documentation in the master branch still refers to the trove-guestagent.conf | 14:52 |
| *** icey has joined #openstack-trove | 14:53 | |
| *** jamesmcarthur has joined #openstack-trove | 15:11 | |
| *** jamesmcarthur has quit IRC | 15:14 | |
| *** jamesmcarthur has joined #openstack-trove | 15:15 | |
| *** jamesmcarthur has quit IRC | 15:19 | |
| *** jamesmcarthur has joined #openstack-trove | 15:25 | |
| *** jamesmcarthur has quit IRC | 15:39 | |
| *** jamesmcarthur has joined #openstack-trove | 15:40 | |
| *** jamesmcarthur has quit IRC | 15:41 | |
| *** jamesmcarthur has joined #openstack-trove | 15:42 | |
| *** jamesmcarthur has quit IRC | 15:48 | |
| *** jamesmcarthur has joined #openstack-trove | 16:02 | |
| *** jamesmcarthur has quit IRC | 16:26 | |
| *** jamesmcarthur has joined #openstack-trove | 16:42 | |
| *** coreycb has quit IRC | 16:55 | |
| *** coreycb has joined #openstack-trove | 16:58 | |
| *** jamesmcarthur has quit IRC | 17:29 | |
| *** jamesmcarthur has joined #openstack-trove | 17:31 | |
| *** jamesmcarthur has quit IRC | 17:41 | |
| *** jamesmcarthur has joined #openstack-trove | 17:43 | |
| *** jamesmcarthur has quit IRC | 17:54 | |
| *** jamesmcarthur has joined #openstack-trove | 18:00 | |
| *** jamesmcarthur has quit IRC | 18:03 | |
| *** jamesmcarthur has joined #openstack-trove | 18:10 | |
| *** jamesmcarthur has quit IRC | 18:16 | |
| *** jamesmcarthur has joined #openstack-trove | 18:20 | |
| *** jamesmcarthur has quit IRC | 19:07 | |
| *** jamesmcarthur has joined #openstack-trove | 19:14 | |
| *** jamesmcarthur has quit IRC | 19:14 | |
| *** jamesmcarthur has joined #openstack-trove | 19:14 | |
| *** tosky has quit IRC | 19:26 | |
| *** jamesmcarthur has quit IRC | 19:47 | |
| *** jamesmcarthur has joined #openstack-trove | 19:47 | |
| *** damien_r has quit IRC | 19:50 | |
| *** damien_r has joined #openstack-trove | 19:50 | |
| *** damien_r has quit IRC | 20:24 | |
| *** jamesmcarthur has quit IRC | 20:34 | |
| *** jamesmcarthur has joined #openstack-trove | 20:35 | |
| *** jamesmcarthur has quit IRC | 20:37 | |
| *** jamesmcarthur has joined #openstack-trove | 20:37 | |
| *** jamesmcarthur has quit IRC | 20:57 | |
| *** jamesmcarthur has joined #openstack-trove | 20:58 | |
| *** jamesmcarthur has quit IRC | 21:06 | |
| *** jamesmcarthur has joined #openstack-trove | 21:07 | |
| lxkong | coreycb: the default config file for trove-guestagent is still trove-guestagent.conf. We just removed the file sample from the repo | 21:07 |
| *** jamesmcarthur has quit IRC | 21:11 | |
| *** jamesmcarthur has joined #openstack-trove | 21:11 | |
| *** damien_r has joined #openstack-trove | 21:11 | |
| *** damien_r has quit IRC | 22:33 | |
| *** damien_r has joined #openstack-trove | 22:44 | |
| *** damien_r has quit IRC | 23:11 | |
| coreycb | lxkong: thanks for the reply. seems odd to remove if it's still used. but maybe it is documented well, I'm afk right now or I'd check. | 23:14 |
| *** damien_r has joined #openstack-trove | 23:17 | |
| lxkong | coreycb: it's the example file that was removed, because you can generate the config file using `oslo-config-generator `\ | 23:20 |
| lxkong | coreycb: if you really want to see an example, see https://docs.openstack.org/trove/latest/install/install-ubuntu.html#install-and-configure-components | 23:21 |
| lxkong | for how to use oslo-config-generator to generate trove config file, please see https://docs.openstack.org/trove/latest/admin/run_trove_in_production.html#configuring-trove | 23:21 |
| *** damien_r has quit IRC | 23:22 | |
| lxkong | coreycb: btw, since you are here, did you see my comment in https://review.opendev.org/#/c/725672/? | 23:22 |
| coreycb | Can you generate the trove-guestagent.conf with oslo-config-generator? | 23:23 |
| lxkong | `Unable to import '__original_module_threading'` is that expected? | 23:23 |
| lxkong | coreycb: you can | 23:23 |
| lxkong | coreycb: the output is a config file with default values, you need to change the options that trove-guestagent needs | 23:23 |
| coreycb | Ok will look into that. I saw that was documented for trove.conf but not guest agent. | 23:24 |
| lxkong | guest agent config file is not special, it's using the same template as trove.conf | 23:25 |
| coreycb | I can look at that patch next week. On pto for the weekend. | 23:25 |
| lxkong | coreycb: cool, thanks | 23:25 |
| coreycb | Ok thanks | 23:25 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!