| *** mingdang1 has joined #openstack-trove | 00:04 | |
| *** kuthurium has joined #openstack-trove | 00:27 | |
| *** mingdang1 has quit IRC | 01:00 | |
| *** pmackinn has joined #openstack-trove | 01:25 | |
| *** pmackinn has quit IRC | 01:37 | |
| *** raginbaji is now known as raginbajin | 03:28 | |
| *** links has joined #openstack-trove | 04:07 | |
| *** itisha has joined #openstack-trove | 04:27 | |
| *** rcernin has joined #openstack-trove | 05:05 | |
| *** mingdang1 has joined #openstack-trove | 05:12 | |
| *** robcresswell has joined #openstack-trove | 05:52 | |
| robcresswell | amrith: I responded to your email on the mailer. Let me know if I can clarify further :) | 05:54 |
|---|---|---|
| robcresswell | It's not a specific thing I am asking for, just better communication from horizon plugins. | 05:54 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove-dashboard: Imported Translations from Zanata https://review.openstack.org/309654 | 06:16 |
| *** itisha has quit IRC | 07:09 | |
| *** tesseract has joined #openstack-trove | 07:33 | |
| *** tesseract is now known as Guest37590 | 07:34 | |
| *** dmk0202 has joined #openstack-trove | 08:06 | |
| *** itisha has joined #openstack-trove | 09:10 | |
| *** tosky has joined #openstack-trove | 09:28 | |
| *** vipul- has joined #openstack-trove | 10:35 | |
| *** vipuls has quit IRC | 10:37 | |
| *** chlong has joined #openstack-trove | 10:38 | |
| *** mingdang1 has quit IRC | 10:55 | |
| openstackgerrit | Merged openstack/trove-dashboard: Imported Translations from Zanata https://review.openstack.org/309654 | 11:04 |
| *** mingdang1 has joined #openstack-trove | 11:10 | |
| openstackgerrit | amrith proposed openstack/trove: Fixed error message logging https://review.openstack.org/272120 | 11:19 |
| openstackgerrit | Deepak Jon proposed openstack/trove: Update Trove's README https://review.openstack.org/311720 | 11:30 |
| *** raginbajin has quit IRC | 11:50 | |
| *** amrith is now known as _amrith_ | 11:59 | |
| openstackgerrit | Merged openstack/trove: Updated from global requirements https://review.openstack.org/311416 | 12:13 |
| openstackgerrit | Merged openstack/trove: Updated from global requirements https://review.openstack.org/311561 | 12:14 |
| *** miqui has joined #openstack-trove | 12:46 | |
| *** pmackinn has joined #openstack-trove | 12:57 | |
| *** _amrith_ is now known as amrith | 13:09 | |
| *** pmackinn has quit IRC | 13:15 | |
| *** arist has quit IRC | 13:17 | |
| *** arist has joined #openstack-trove | 13:18 | |
| openstackgerrit | Merged openstack/python-troveclient: Updated from global requirements https://review.openstack.org/311413 | 13:35 |
| *** links has quit IRC | 13:35 | |
| *** mingdang1 has quit IRC | 13:44 | |
| *** links has joined #openstack-trove | 15:14 | |
| *** links has quit IRC | 15:14 | |
| *** itisha_ has joined #openstack-trove | 15:16 | |
| *** itisha has quit IRC | 15:21 | |
| *** kuthurium has quit IRC | 15:21 | |
| *** rcernin has quit IRC | 15:21 | |
| *** _mattf` has quit IRC | 15:21 | |
| *** _mattf has joined #openstack-trove | 15:21 | |
| *** rcernin has joined #openstack-trove | 15:22 | |
| *** _mattf has quit IRC | 15:22 | |
| *** _mattf has joined #openstack-trove | 15:22 | |
| *** rcernin has quit IRC | 15:22 | |
| *** rcernin has joined #openstack-trove | 15:22 | |
| *** itisha_ is now known as itisha | 15:23 | |
| *** kuthurium_ has joined #openstack-trove | 15:23 | |
| *** rcernin has quit IRC | 15:30 | |
| *** pmackinn has joined #openstack-trove | 15:34 | |
| *** chlong has quit IRC | 15:38 | |
| *** pmackinn has quit IRC | 15:42 | |
| *** ozialien10 has joined #openstack-trove | 15:58 | |
| *** dmk0202 has quit IRC | 15:59 | |
| *** Guest37590 has quit IRC | 15:59 | |
| *** links has joined #openstack-trove | 16:12 | |
| *** tqtran has joined #openstack-trove | 16:15 | |
| *** twm2016 has joined #openstack-trove | 16:16 | |
| *** stewie925 has joined #openstack-trove | 16:26 | |
| stewie925 | hi amrith - I am abandoning https://review.openstack.org/#/c/308693/ per your input | 16:27 |
| stewie925 | in the meantime, could you check if https://bugs.launchpad.net/sahara/+bug/1544522 is still a valid bug? I planning to tackle this bug. | 16:29 |
| openstack | Launchpad bug 1544522 in OpenStack DBaaS (Trove) "Don't use Mock.called_once_with that does not exist" [Undecided,Confirmed] - Assigned to STEW TY (stewie925) | 16:29 |
| stewie925 | the gerrit link is https://review.openstack.org/#/c/281232/ | 16:29 |
| *** amrith is now known as _amrith_ | 16:39 | |
| openstackgerrit | Merged openstack/trove: Port crypto_utils to Python 3 https://review.openstack.org/297888 | 16:42 |
| openstackgerrit | Merged openstack/trove: Python3: Add support for unicode, basestring, long https://review.openstack.org/274419 | 16:42 |
| openstackgerrit | Merged openstack/trove: Python 3: fix relative imports https://review.openstack.org/308328 | 16:49 |
| *** stewie925 has quit IRC | 17:02 | |
| *** stewie925 has joined #openstack-trove | 17:09 | |
| *** tosky has quit IRC | 17:26 | |
| *** david-lyle has joined #openstack-trove | 17:28 | |
| *** david-lyle has quit IRC | 17:29 | |
| *** david-lyle has joined #openstack-trove | 17:30 | |
| *** links has quit IRC | 17:33 | |
| *** _amrith_ is now known as amrith | 17:35 | |
| openstackgerrit | Merged openstack/trove: Simplify guestagent.pkg: don't use metaclass https://review.openstack.org/308343 | 17:53 |
| openstackgerrit | Merged openstack/trove: [Trivial] Remove unnecessary executable flag for files https://review.openstack.org/310982 | 17:54 |
| peterstac | stewie925, looks like https://review.openstack.org/#/c/281232 still needs fixing | 18:34 |
| peterstac | just click the 'restore' button and do a recheck | 18:35 |
| stewie925 | hey peterstac | 18:37 |
| stewie925 | per conversation with amrith he indicated that that bug is an invalid bug | 18:37 |
| stewie925 | based on what you've brought up regarding the checking on the exact value of clusters instead of mininum # of cluster | 18:38 |
| stewie925 | so peterstac - you brought it to his attention :) | 18:38 |
| stewie925 | I've already abandoned the fix - unless you think oherwise | 18:39 |
| peterstac | stewie925, no, not that one, the one about mocks | 18:39 |
| stewie925 | oh oops | 18:39 |
| peterstac | wrt the Vertica one, I tried doing some research over the weekend, but didn't come to any conclusive results | 18:41 |
| stewie925 | oh yes, I am working on that fix at the moment - amrith that it is a simpler fix, and I start fresh with a new one | 18:41 |
| stewie925 | here's amrith's comments in https://bugs.launchpad.net/trove/+bug/1544522 | 18:42 |
| openstack | Launchpad bug 1544522 in OpenStack DBaaS (Trove) "Don't use Mock.called_once_with that does not exist" [Undecided,Confirmed] - Assigned to STEW TY (stewie925) | 18:42 |
| amrith | peterstac, I cleared up the vertica thing | 18:43 |
| amrith | that's the way the code was intended to work | 18:43 |
| peterstac | amrith, ok - it wasn't clear in my quick google search if there has to be a minimum for *all* cluster calls (including cluster-grow) | 18:44 |
| peterstac | (well, minimum vs set number) | 18:44 |
| amrith | peterstac, see line 44 of https://review.openstack.org/#/c/151279/10/specs/kilo/vertica-cluster.rst | 18:46 |
| amrith | the idea was (I believe) to get a cluster up with exactly 3 instances and later add grow-shrink support. | 18:47 |
| amrith | now that's what the code does | 18:47 |
| peterstac | sure, but that was kilo - the current code *does* implement grow | 18:48 |
| peterstac | https://github.com/openstack/trove/blob/master/trove/common/strategies/cluster/experimental/vertica/api.py#l187 | 18:48 |
| amrith | now it does | 18:50 |
| amrith | correct | 18:50 |
| amrith | so I'm not sure that we want to just treat it as a deprecation | 18:50 |
| amrith | I'd rather make sure from someone with Vertica experience whether it is a valid use case to initialize a cluster with (say 6) instances using the same logic that we had for 3 | 18:51 |
| amrith | hence I didn't think this was simply a matter of deprecation. | 18:51 |
| amrith | and certainly your point about changing the name of the variable to min_cluster... and then having the logic of != was wrong as well. | 18:51 |
| amrith | so in fact what we need to do is figure out what it'll take to allow Vertica to launch an cluster with some arbitrary number of instances > k_size | 18:52 |
| amrith | and support that | 18:52 |
| amrith | and if it means that we want to also deprecate cluster_count, so be it. | 18:52 |
| amrith | does that make sense? or should we still deal with this as a deprection? | 18:52 |
| openstackgerrit | amrith proposed openstack/trove: Fixed error message logging https://review.openstack.org/272120 | 18:53 |
| peterstac | right, imo what it boils down to is better input from a Vertica *expert* before we arbitrarily change something | 18:53 |
| amrith | yes, and that I was not able to get at summit | 18:53 |
| amrith | so I'm going to see if we can find one | 18:54 |
| amrith | they are (literally) across the street from me :) | 18:54 |
| amrith | hey peterstac some of your locality supprot changes are in merge conflict :) | 18:54 |
| peterstac | yeah, I saw | 18:55 |
| peterstac | doing the rebase now | 18:55 |
| *** alejandrito has joined #openstack-trove | 18:55 | |
| *** alejandrito has quit IRC | 18:56 | |
| amrith | vgnbkr, I found the old denism change for backup volume size checking. it went to 46 reviews before we could get floor, ceil, int, modulo, and abs figured out :) remember that party? | 18:56 |
| *** alejandrito has joined #openstack-trove | 18:57 | |
| *** alejandrito has quit IRC | 18:57 | |
| vgnbkr | amrith, no, maybe I wasn't there. More of an issue for snapshots, though, I think, as the snapshot can become invalid over time as the original volume changes. | 19:01 |
| amrith | vgnbkr, say more | 19:05 |
| amrith | who would the snapshot become any more invalid than a backup | 19:06 |
| *** zacksh_ has quit IRC | 19:06 | |
| *** zacksh has joined #openstack-trove | 19:07 | |
| vgnbkr | amrith, my understanding is that a snapshot is a copy of the metadata for the volume (i.e., a listing of the blocks) and that as blocks change on the original volume new blocks are added to the snapshot to capture the old state. | 19:11 |
| openstackgerrit | Matthew Van Dijk proposed openstack/trove: Backup to swift using wrong large object type https://review.openstack.org/222752 | 19:11 |
| vgnbkr | The blocks are on the same physical volume as the original, so there's really no new spaced added to the volume. When the volume fills, the snapshot is automatically deleted. | 19:12 |
| vgnbkr | Also, since the snapshot is on the same physical disk as the volume, it isn't really a "backup" - it doesn't protect against drive failure. I believe some backend storage appliances address this - netapp, for example, has a "snapshot mirror" feature that copies a snapshot to a different physical volume. | 19:13 |
| amrith | so ... I think the snapshot isn't on the same volume, no? | 19:33 |
| vgnbkr | Sorry, I was a bit loose with terminology. The "snapshot" isn't in the "volume", but AFAIK it does exist on the same physical disk, and probably partition (or "logical volume" or some such). Anyways, it's fast because it shares the physical storage of the original volume, either "actually" or "akin to" copy-on-write. Either way, space is shared and there is no actual "backup". | 19:36 |
| vgnbkr | Well, I guess a snapshot is really the same volume, just a different view into it. | 19:37 |
| vgnbkr | In summary, snapshot != backup | 19:39 |
| *** itisha has quit IRC | 19:39 | |
| vgnbkr | Don't get me wrong - snapshots are TOTALLY AWESOME and we need them, but they aren't by themselves backups. | 19:41 |
| stewie925 | hi amrith and peterstac - sorry was at a meeting | 20:03 |
| peterstac | hi stewie925, what's up? | 20:04 |
| stewie925 | not much , just scrolling back to see what I missed | 20:08 |
| stewie925 | lol | 20:08 |
| stewie925 | so I figured you and amrith were at the summit | 20:08 |
| peterstac | stewie925, yep, made it hard to respond in real-time ;P | 20:09 |
| *** imandhan has joined #openstack-trove | 20:11 | |
| stewie925 | I can tell its busier today than last week - just tumbleweeds all over the place | 20:19 |
| *** cguadall__ has joined #openstack-trove | 20:20 | |
| *** dalees`_ has joined #openstack-trove | 20:25 | |
| *** serverascode_ has joined #openstack-trove | 20:26 | |
| *** bapalm_ has joined #openstack-trove | 20:28 | |
| *** bapalm has quit IRC | 20:29 | |
| *** dalees` has quit IRC | 20:29 | |
| *** cguadall_ has quit IRC | 20:29 | |
| *** serverascode has quit IRC | 20:29 | |
| *** serverascode_ is now known as serverascode | 20:34 | |
| openstackgerrit | Victor Stinner proposed openstack/trove: Port designate code to Python 3 https://review.openstack.org/311845 | 20:41 |
| openstackgerrit | Victor Stinner proposed openstack/trove: Port more API unit tests to Python 3 https://review.openstack.org/311846 | 20:41 |
| openstackgerrit | Victor Stinner proposed openstack/trove: Port instance unit tests to Python 3 https://review.openstack.org/311847 | 20:41 |
| openstackgerrit | Victor Stinner proposed openstack/trove: Enable more unit tests on Python 3 https://review.openstack.org/311848 | 20:41 |
| *** dmk0202 has joined #openstack-trove | 21:00 | |
| *** mingdang1 has joined #openstack-trove | 21:08 | |
| *** amrith has quit IRC | 21:09 | |
| *** amrith has joined #openstack-trove | 21:10 | |
| *** ByPasS has quit IRC | 21:10 | |
| *** ByPasS has joined #openstack-trove | 21:12 | |
| *** dmk0202 has quit IRC | 21:12 | |
| *** amrith is now known as _amrith_ | 21:14 | |
| *** mingdang1 has quit IRC | 21:21 | |
| *** miqui has quit IRC | 21:38 | |
| *** mordred has joined #openstack-trove | 22:05 | |
| openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Locality support for clusters https://review.openstack.org/301342 | 22:15 |
| openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Locality support for replication https://review.openstack.org/300659 | 22:15 |
| openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Locality support for replication https://review.openstack.org/300659 | 22:16 |
| openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Locality support for clusters https://review.openstack.org/301342 | 22:17 |
| openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Locality support for replication https://review.openstack.org/300659 | 22:18 |
| openstackgerrit | Peter Stachowski proposed openstack/trove: Locality support for replication https://review.openstack.org/300669 | 22:20 |
| *** stewie925 has quit IRC | 22:24 | |
| *** stewie925 has joined #openstack-trove | 22:26 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove: Locality support for replication https://review.openstack.org/300669 | 22:27 |
| openstackgerrit | Peter Stachowski proposed openstack/trove: Locality support for clusters https://review.openstack.org/301936 | 22:27 |
| stewie925 | hello peterstac and amrith | 22:27 |
| *** david-lyle has quit IRC | 22:28 | |
| peterstac | stewie925, hi | 22:28 |
| stewie925 | so I am working on that mock bug | 22:29 |
| peterstac | (gotta be quick, I'm leaving the office soon ... ;) ) | 22:29 |
| *** twm2016 has quit IRC | 22:29 | |
| stewie925 | https://review.openstack.org/#/c/281232 | 22:30 |
| stewie925 | I understand that we need to change the ".called_once_with" to ".assert_called_once_with" | 22:31 |
| peterstac | right | 22:31 |
| stewie925 | here's the grep I'd like to share with all instances of that method: http://paste.openstack.org/show/495710/ | 22:32 |
| stewie925 | I see files under .tox - but found that .tox directory is under .gitignore so I'll just leave them alone, right? | 22:33 |
| peterstac | right | 22:33 |
| stewie925 | thank you peter... I tried to fix the other one - the test_backupagent.py (in that paste URL) - and when I ran tox -e py27 - I am getting a bunch of this error: | 22:35 |
| stewie925 | FAIL: backup.test_backupagent.BackupAgentTest.test_execute_backup | 22:35 |
| stewie925 | AssertionError: Expected 'mock' to be called once. Called 2 times. | 22:36 |
| stewie925 | this is after I changed the ".called_once_with" to ".assert_called_once_with" in the trove/tests/unittests/backup/test_backupagent.py file | 22:38 |
| stewie925 | oh we can continue tomorrow peterstac - if you have to leave :) | 22:39 |
| peterstac | Well, there might be more issues with the tests | 22:39 |
| peterstac | since the check was being ignored in the past | 22:39 |
| stewie925 | oh I see... well I did run right before I rename those methods and it was successful | 22:40 |
| peterstac | or it might actually be called twice legitimately - in which case you can't use assert_called_once_with ;) | 22:40 |
| stewie925 | yeah exactly what I was thinking hehe | 22:40 |
| peterstac | sure, because mock will let you call anything on an object, even if it doesn't exist | 22:41 |
| peterstac | so that call was a no-op before (i.e. wasn't testing anything) | 22:41 |
| stewie925 | should I keep the change or back it out? | 22:42 |
| peterstac | there could also be a problen in that the same mock object is being called from two tests | 22:42 |
| peterstac | (we've had issues before with things not being 'unmocked' correctly) | 22:42 |
| peterstac | (but I thought we had code in now to detect that case) | 22:42 |
| peterstac | well, we need to fix the tests = but it might be a bit more work than originally thought | 22:43 |
| peterstac | :( | 22:43 |
| peterstac | ok, gotta run - I'll see if I can spend a few cycles on this tomorrow | 22:43 |
| stewie925 | sure, thank you peterstac | 22:43 |
| stewie925 | good night | 22:43 |
| peterstac | np - later | 22:43 |
| *** imandhan has quit IRC | 23:07 | |
| *** chlong has joined #openstack-trove | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!