| *** haomaiwang has joined #openstack-trove | 00:01 | |
| *** ThunderEmperor has joined #openstack-trove | 00:02 | |
| *** chlong has joined #openstack-trove | 00:05 | |
| *** hogepodge has quit IRC | 00:16 | |
| *** hogepodge has joined #openstack-trove | 00:22 | |
| *** ianbrown has quit IRC | 00:23 | |
| *** ianbrown has joined #openstack-trove | 00:24 | |
| *** hogepodge has quit IRC | 00:27 | |
| *** tiny-hands has joined #openstack-trove | 00:28 | |
| *** mingdang1 has joined #openstack-trove | 00:29 | |
| *** hogepodge has joined #openstack-trove | 00:43 | |
| *** ThunderEmperor has quit IRC | 00:46 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-trove | 01:01 | |
| *** tiny-hands has quit IRC | 01:06 | |
| *** haomaiwang has quit IRC | 01:07 | |
| *** ianbrown has quit IRC | 01:11 | |
| *** ianbrown has joined #openstack-trove | 01:12 | |
| *** mingdang1 has quit IRC | 01:16 | |
| *** ianbrown has quit IRC | 01:57 | |
| *** ianbrown has joined #openstack-trove | 01:58 | |
| *** haomaiwang has joined #openstack-trove | 01:59 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** haomaiwa_ has joined #openstack-trove | 02:01 | |
| *** mingdang1 has joined #openstack-trove | 02:19 | |
| *** mingdang1 has quit IRC | 02:19 | |
| *** mingdang1 has joined #openstack-trove | 02:19 | |
| *** caishan has joined #openstack-trove | 02:22 | |
| *** caishan has quit IRC | 02:32 | |
| *** caishan has joined #openstack-trove | 02:33 | |
| *** ianbrown has quit IRC | 02:39 | |
| *** ianbrown has joined #openstack-trove | 02:43 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-trove | 03:01 | |
| *** coolsvap|away is now known as coolsvap | 03:23 | |
| *** ianbrown has quit IRC | 03:26 | |
| *** links has joined #openstack-trove | 03:26 | |
| *** ianbrown has joined #openstack-trove | 03:26 | |
| *** coolsvap is now known as coolsvap|away | 03:33 | |
| *** coolsvap|away is now known as coolsvap | 03:40 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-trove | 04:01 | |
| *** ianbrown has quit IRC | 04:10 | |
| *** ianbrown_ has joined #openstack-trove | 04:10 | |
| *** haomaiwang has quit IRC | 04:33 | |
| *** haomaiwa_ has joined #openstack-trove | 05:02 | |
| *** ianbrown_ has quit IRC | 05:12 | |
| *** ianbrown_ has joined #openstack-trove | 05:12 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-trove | 06:01 | |
| *** caishan_ has joined #openstack-trove | 06:47 | |
| *** caishan has quit IRC | 06:50 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-trove | 07:01 | |
| *** chlong has quit IRC | 07:13 | |
| *** imandhan has joined #openstack-trove | 07:31 | |
| *** imandhan has quit IRC | 07:33 | |
| *** dmitryme has left #openstack-trove | 07:55 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-trove | 08:01 | |
| *** chlong has joined #openstack-trove | 08:30 | |
| *** sgotliv has joined #openstack-trove | 08:49 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-trove | 09:01 | |
| *** caishan has joined #openstack-trove | 09:21 | |
| *** caishan_ has quit IRC | 09:21 | |
| *** openstack has joined #openstack-trove | 15:35 | |
| *** openstackstatus has joined #openstack-trove | 15:36 | |
| *** ChanServ sets mode: +v openstackstatus | 15:36 | |
| openstackgerrit | alex proposed openstack/trove: There is an error 'MongoDbTaskManagerAPI' object has no attribute 'get_key' when add shard for mongodb cluster https://review.openstack.org/260052 | 15:37 |
|---|---|---|
| *** vkmc is now known as vkmc-afk | 15:54 | |
| openstackgerrit | alex proposed openstack/trove: There is an error "NoSuchMethod: Endpoint does not support RPC method add_shard_cluster" when add a shard to mongodb cluster https://review.openstack.org/260065 | 15:56 |
| *** sriram_tesora has joined #openstack-trove | 15:57 | |
| *** admin0 has quit IRC | 16:15 | |
| *** ThunderEmperor has quit IRC | 16:19 | |
| *** pmackinn has quit IRC | 16:32 | |
| *** pmackinn has joined #openstack-trove | 16:34 | |
| *** vkmc-afk is now known as vkmc | 16:34 | |
| *** crobertsrh has joined #openstack-trove | 16:48 | |
| *** ThunderEmperor has joined #openstack-trove | 16:55 | |
| openstackgerrit | Craig Vyvial proposed openstack/trove: pxc shrink cluster support https://review.openstack.org/258705 | 17:04 |
| *** ThunderEmperor has quit IRC | 17:08 | |
| *** sgotliv has quit IRC | 17:09 | |
| *** lgreg1 has left #openstack-trove | 17:28 | |
| *** imandhan has joined #openstack-trove | 17:38 | |
| *** admin0 has joined #openstack-trove | 17:43 | |
| *** _amrith_ is now known as amrith | 17:43 | |
| *** admin0 has quit IRC | 17:46 | |
| cp16net | howdy | 17:49 |
| cp16net | amrith: i think i'm getting [trove] ml emails now... | 17:50 |
| cp16net | i dont think it was my rules in my email | 17:51 |
| cp16net | apparently you can subscribe to individual tags on the ML | 17:51 |
| cp16net | and i wasnt subscribed to the [trove] list | 17:51 |
| cp16net | go figure... | 17:51 |
| cp16net | i guess they added that feature and i didnt update my preferences and was subscribed to the main lists | 17:52 |
| *** tellesnobrega_af is now known as tellesnobrega | 17:52 | |
| amrith | cp16net, how do you do that? | 17:54 |
| amrith | subscribe to the trove tag? | 17:54 |
| cp16net | http://lists.openstack.org/cgi-bin/mailman/options/openstack-dev/ | 17:55 |
| cp16net | login | 17:55 |
| cp16net | long list of "Which topic categories would you like to subscribe to?" | 17:55 |
| cp16net | there were a bunch i wasnt subscribed to | 17:56 |
| cp16net | so i added them | 17:56 |
| openstackgerrit | Craig Vyvial proposed openstack/trove: move the cluster tests to scenario tests. https://review.openstack.org/260139 | 18:12 |
| cp16net | amrith: whoa | 18:12 |
| cp16net | weird... i dont think i meant to make that new commit | 18:12 |
| cp16net | so the follow-up button automatically creates a new patchset with the message you put in the field. | 18:13 |
| amrith | checking | 18:13 |
| cp16net | lol | 18:13 |
| cp16net | vgnbkr: amrith mind if i just combine the grow and shrink in a single patch instead of separate? | 18:15 |
| cp16net | for pxc | 18:15 |
| amrith | that should be fine, I think. | 18:15 |
| cp16net | some of the changes need to be made to grow and its below the shrink commit and its just going to be a pain in the arse to keep rebasing to keep them in sync | 18:16 |
| openstackgerrit | Craig Vyvial proposed openstack/trove: pxc grow/shrink cluster implementation https://review.openstack.org/252090 | 18:19 |
| cp16net | ^^ merged the patches but still a WIP to fix the tests vgnbkr mentioned | 18:21 |
| amrith | vkmc, yt? | 18:39 |
| *** crobertsrh has left #openstack-trove | 18:44 | |
| cp16net | amrith: i looked over your review for removing the slave_of in the client | 18:50 |
| amrith | and | 18:50 |
| cp16net | i didnt see comments related to the variable changes you mentioned in the meeting | 18:50 |
| amrith | you threw up ... | 18:50 |
| cp16net | looks good to me and i +2 it | 18:51 |
| amrith | you may have looked at the client side change. take a look at https://review.openstack.org/#/c/245845/ | 18:51 |
| amrith | that one needs a rebase now | 18:51 |
| cp16net | ahh ok | 18:51 |
| amrith | i wasn't going to spend the time on that till I knew what the outcome on this renaming thing was going to be. my concern is that it appears to be a "just do it here, what's the big deal". the point is that it is the pointy end of a rather large and painful spear. | 18:52 |
| amrith | and where I left it with vkmc was that if she felt strongly about the renaming she should go ahead and submit a fix for it. | 18:53 |
| cp16net | k i'll look over it now and give me opinion | 18:53 |
| cp16net | amrith: so i want to let you and everyone know that edmondk left hpe last week | 18:54 |
| cp16net | i dont think he mentioned it on to the trove guys | 18:54 |
| cp16net | amrith: btw there are only 65 matches across 15 files | 19:01 |
| cp16net | for slave_of :-P | 19:01 |
| amrith | cp16net, do you like bbq? | 19:02 |
| dougshelley66 | cp16net oh, i'm sorry to hear about edmondk | 19:02 |
| cp16net | dougshelley66: its all good he's moving on to other fun things | 19:03 |
| tosky | cp16net: question about the new scenario tests; apart from the future plan hopefully already for Mitaka (replace the existing tests), should they also work on liberty? | 19:10 |
| *** sriram_tesora has quit IRC | 19:10 | |
| cp16net | tosky: if all the features are available yes | 19:13 |
| cp16net | tosky: but since many of the feature tested with the scenarios i dont think its ideal to expect them to work for liberty or other stable branches | 19:14 |
| cp16net | scenario tests should work for the current working branch | 19:15 |
| cp16net | and in the future i'd say the scenario tests should continue to work for those following stable branches | 19:16 |
| cp16net | this is because the tests are part of the release stable branch as well | 19:16 |
| openstackgerrit | Merged openstack/trove-specs: Percona XtraDB Cluster Grow and Shrink Spec https://review.openstack.org/245356 | 19:17 |
| cp16net | OMG my spec merged! :-D | 19:18 |
| tosky | cp16net: sure, why wouldn't they don't work for the same branch? Or do you mean that scenario tests from master should work with stable branches as well? | 19:18 |
| tosky | I'm asking because we just approved a spec in Sahara to move the high level scenario integration tests (which do no need access to sahara internals) to a separate repositories and have them work on the supported stable releases | 19:19 |
| cp16net | tosky: so the tests all work across stable branches? | 19:20 |
| cp16net | or would be expected to i assume? | 19:20 |
| tosky | cp16net: they are not working on all stable branches right now (well, mostly working to be honest), but the plan is make this working in an official way | 19:22 |
| tosky | this is the spec: http://specs.openstack.org/openstack/sahara-specs/specs/mitaka/move-scenario-tests-to-separate-repository.html | 19:22 |
| * tosky bbl | 19:22 | |
| cp16net | tosky: ok | 19:22 |
| vkmc | amrith, here | 19:25 |
| vgnbkr | cp16net, Yes, merging pxc grow and shrink makes sense. | 19:26 |
| *** sriram_tesora has joined #openstack-trove | 19:31 | |
| cp16net | vgnbkr: i think i mistook your name but cool :-P | 19:38 |
| cp16net | tosky: so since the existing integration tests we run are in the trove repo those tests should work for the cut stable release given the stable/branch | 19:46 |
| *** sgotliv has joined #openstack-trove | 19:46 | |
| cp16net | tosky: the new scenario tests have been worked on in liberty and mitaka but not run against a gate yet so i'd concider them not stable yet... | 19:46 |
| cp16net | but should pass per the release they were merged in. | 19:47 |
| cp16net | way back in time for trove (i.e. reddwarf) we had all the int-tests in the trove-integration project and it was a pain to make sure that the tests were available and working for a patchset to the code | 19:50 |
| cp16net | we merged all the tests into the trove repo which made it MUCH easier to manage | 19:50 |
| cp16net | i'm not keen on moving the tests out because of the experince in the past | 19:51 |
| tosky | I see | 19:57 |
| tosky | I agree that stabilizing the tests first is the most important thing | 19:58 |
| cp16net | yea | 19:58 |
| cp16net | maybe now that you can depend on other repo changes this may make that better than i've seen in the past tho | 19:59 |
| cp16net | pmalik: i aprroved the mysql int-test helper patch | 20:24 |
| cp16net | pmalik: will probably need to rebase the cluster int-tests patch and i'd like to see the other change i mentioned as well | 20:24 |
| tellesnobrega | pmackinn, pmalik, vkmc, amrith, cp16net do we have deprecated decorator already in trove? | 20:25 |
| tellesnobrega | since we are going in the direction of first marking downgrades with deprecation than removing | 20:25 |
| cp16net | tellesnobrega: i dont think we do for migration stuff | 20:30 |
| cp16net | there might be something in the oslo_db code we migrated to tho | 20:31 |
| tellesnobrega | cp16net, did a git grep on deprecated and didn't find any implementation of that | 20:38 |
| cp16net | tellesnobrega: yea maybe not then | 20:38 |
| cp16net | might need something to write a warning | 20:39 |
| cp16net | the message can be passed in or something like that | 20:39 |
| tellesnobrega | sounds good, can be reused anywhere on trove | 20:39 |
| cp16net | for a deprecation wrapper or something | 20:39 |
| cp16net | yeah | 20:39 |
| tellesnobrega | trove/common/utils.py sounds like a good place for that? | 20:40 |
| cp16net | sounds good | 20:41 |
| tellesnobrega | awesome | 20:42 |
| tellesnobrega | thanks | 20:42 |
| cp16net | np | 20:42 |
| pmalik | cp16net ok, will do. | 20:42 |
| cp16net | pmalik: thanks | 20:43 |
| cp16net | i'm heading out to run some errands | 20:44 |
| *** sriram_tesora has quit IRC | 20:59 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Finish cluster int-tests https://review.openstack.org/244176 | 21:01 |
| *** amrith is now known as _amrith_ | 21:10 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/trove: Implementing deprecation decorator https://review.openstack.org/260221 | 21:27 |
| *** sriram_tesora has joined #openstack-trove | 21:44 | |
| tellesnobrega | pmalik, hey, where is the trove-manage code so i can set the downgrade as deprecated there as well? | 22:07 |
| openstackgerrit | Petr Malik proposed openstack/trove: Register additional datastores for int-tests https://review.openstack.org/260234 | 22:26 |
| *** _amrith_ is now known as amrith | 22:27 | |
| pmalik | cp16net amrith peterstac vkmc : A quick one - added missing int/scenario test groups. Thx. https://review.openstack.org/#/c/260234 | 22:28 |
| pmalik | tellesnobrega Not sure, maybe you want to ask peterstac ? | 22:29 |
| tellesnobrega | sure | 22:30 |
| tellesnobrega | thanks | 22:30 |
| *** admin0 has joined #openstack-trove | 22:37 | |
| *** sgotliv has quit IRC | 23:21 | |
| *** sabeen has joined #openstack-trove | 23:32 | |
| *** ianbrown_ has quit IRC | 23:35 | |
| *** ianbrown_ has joined #openstack-trove | 23:35 | |
| *** sriram_tesora has quit IRC | 23:36 | |
| *** tosky has quit IRC | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!