Thursday, 2015-05-07

« Wednesday, 2015-05-06 Index Friday, 2015-05-08 »
*** DCWillia_ has quit IRC00:02
openstackgerritSaurabh Surana proposed openstack/trove: accepting network and availability zone for instances in cluster  https://review.openstack.org/17944300:08
*** setmason has joined #openstack-trove00:27
setmasonHow can I prevent the Trove network from conflicting with the tenant’s private network?00:29
*** eghobo_ has quit IRC00:30
*** eghobo has joined #openstack-trove00:33
*** bhunter71 has joined #openstack-trove00:37
*** DCWilliams_VA has joined #openstack-trove00:40
*** setmason has quit IRC00:40
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'secgroups'  https://review.openstack.org/18080600:40
*** saurabhs has left #openstack-trove00:41
*** shayneburgess has quit IRC00:42
edmondkpmalik, why so many separate commits for the dangling mock? Would be easier to put them in one patch set for reviewability and for got history.00:44
edmondkgot history*00:44
edmondkgit history* lol00:45
*** ashleighfarnham has quit IRC00:47
*** IanGovett1 has joined #openstack-trove00:49
*** IanGovett has quit IRC00:49
*** shakamunyi has quit IRC01:02
*** DCWilliams_VA has quit IRC01:12
*** setmason has joined #openstack-trove01:27
setmasonHow can I prevent the Trove network from conflicting with the tenant’s private network?01:27
pmalikedmondk: It was agreed that we would clean them up module-by-module, so that smaller patch sets can merge ASAP.01:31
*** erkules_ has joined #openstack-trove01:38
*** erkules has quit IRC01:41
*** ashleighfarnham has joined #openstack-trove01:47
*** ashleighfarnham has quit IRC01:51
*** eghobo has quit IRC01:55
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'guestagent'  https://review.openstack.org/18082501:57
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'taskmanager'  https://review.openstack.org/18079802:01
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'conductor'  https://review.openstack.org/18082802:06
*** shakamunyi has joined #openstack-trove02:09
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'guestagent' (3)  https://review.openstack.org/18082502:13
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'mgmt' module  https://review.openstack.org/18083102:22
openstackgerritOpenStack Proposal Bot proposed openstack/trove: Updated from global requirements  https://review.openstack.org/17987902:22
openstackgerritPeter Stachowski proposed openstack/trove: Added dangling mock detection to 'network' module  https://review.openstack.org/18083202:24
SlickNikpmalik: I thought we had agreed to only fix the ones that actually have dangling mock issues, and not bother spending time on converting every single module?02:24
SlickNikrelevant discussion at: http://eavesdrop.openstack.org/meetings/trove/2015/trove.2015-04-22-18.01.log.html02:26
peterstacSlickNik: I believe that's all we did - I only unmocked ones that weren't done02:36
peterstac(unless it was easier to move the mock to setUp, then I did that)02:36
SlickNikpeterstac: I don't see any dangling mock issues with a lot of changes pushed up eg. https://review.openstack.org/#/c/180730/1/trove/tests/unittests/router/test_router.py,cm, https://review.openstack.org/#/c/180773/1/trove/tests/unittests/datastore/base.py,cm, and https://review.openstack.org/#/c/180832/1/trove/tests/unittests/network/test_neutron_driver.py,cm02:37
SlickNikThose just seem to be changing the base class and re-ordering imports, for one single module at a time.02:39
SlickNikAnd that would just be a whole lot of noise in our commit logs.02:40
peterstacwell, until you add in the base class and run the unittests, you don't know if there are any dangling mocks02:40
peterstacunless you wanted this to be a one-off (just fix the mocks now, but don't add in the base class)02:41
SlickNikIsn't that an argument then for doing this all as part of one patchset, then? (if you're so inclined — I still think we should stick with what we discussed during the meeting and enforce this for new code going ahead).02:44
openstackgerritzouyee proposed openstack/trove-integration: code:line 17:apt-key adv --keyserver hkp://keys.gnupg.net --recv-keys 1C4CBDCDCD2EFD2A It could not get valid OpenPGP data  https://review.openstack.org/18083602:45
*** danritchie has quit IRC02:48
peterstacI'm confused - you only want to check new code, and not fix the old tests?02:48
*** setmason has quit IRC02:58
*** setmason has joined #openstack-trove03:01
openstackgerritzouyee proposed openstack/trove-integration: "dbaas_datastore_version": "5.5",-----> need to update--- 5.6  https://review.openstack.org/18084403:08
*** setmason has quit IRC03:19
*** bhunter71 has quit IRC03:20
*** setmason has joined #openstack-trove03:31
*** sgotliv has joined #openstack-trove03:31
*** setmason has quit IRC03:38
*** IanGovett1 has quit IRC03:40
*** links has joined #openstack-trove03:45
*** setmason has joined #openstack-trove03:58
*** masco has joined #openstack-trove04:01
openstackgerritSaurabh Surana proposed openstack/trove: accepting network and availability zone for instances in cluster  https://review.openstack.org/17944304:09
*** setmason_ has joined #openstack-trove04:12
*** setmason has quit IRC04:13
*** setmason_ is now known as setmason04:13
openstackgerritzouyee proposed openstack/trove-integration: code:line 17:apt-key adv --keyserver hkp://keys.gnupg.net --recv-keys 1C4CBDCDCD2EFD2A It could not get valid OpenPGP data  https://review.openstack.org/18085104:17
*** mattgriffin has joined #openstack-trove04:20
*** mat-lowery has quit IRC04:25
*** mat-lowery has joined #openstack-trove04:30
*** danritchie has joined #openstack-trove04:37
*** sgotliv has quit IRC04:40
*** sgotliv has joined #openstack-trove04:40
*** danritchie has quit IRC04:41
*** setmason has quit IRC04:53
*** setmason has joined #openstack-trove04:54
*** masco has quit IRC04:55
*** setmason has quit IRC05:00
*** mattgriffin has quit IRC05:01
*** coolsvap|afk is now known as coolsvap05:03
*** mattgriffin has joined #openstack-trove05:07
openstackgerritzouyee proposed openstack/trove-integration: "dbaas_datastore_version" outdate  https://review.openstack.org/18086405:08
*** ashleighfarnham has joined #openstack-trove05:13
*** ashleighfarnham has quit IRC05:13
*** Longgeek has joined #openstack-trove05:33
*** sgotliv has quit IRC05:39
*** eghobo has joined #openstack-trove05:40
*** ashleighfarnham has joined #openstack-trove05:52
*** Longgeek has quit IRC06:06
*** masco has joined #openstack-trove06:09
*** ashleighfarnham has quit IRC06:10
*** ashleighfarnham has joined #openstack-trove06:17
*** ashleighfarnham has quit IRC06:18
*** erkules_ is now known as erkules06:24
*** erkules has joined #openstack-trove06:24
openstackgerritSushil Kumar proposed openstack/trove: Added unit-tests for mgmt-cluster-service  https://review.openstack.org/18074906:26
*** exploreshaifali has joined #openstack-trove06:29
*** exploreshaifali has quit IRC06:40
*** exploreshaifali has joined #openstack-trove06:40
*** mattgriffin has quit IRC06:58
*** Longgeek has joined #openstack-trove07:07
sushilkmregarding the dangling mocks story, there is no point in putting such a number of commits which only have the import changed without any bug-fixes for any dangling mocks07:13
sushilkmalso this would increase the time taken to execute the existing tests without any value add07:13
*** exploreshaifali has quit IRC07:18
*** Longgeek has quit IRC07:21
*** Longgeek has joined #openstack-trove07:21
*** sgotliv has joined #openstack-trove07:40
*** eghobo has quit IRC08:00
*** chlong has quit IRC08:23
*** kodoku has joined #openstack-trove08:42
kodokuHi, I have pb with trove. I conf trove.conf with auth_host=juno001.domain.com in [keystone_authtoken] but when trove-api start I have ==> DEBUG keystoneclient.session [-] REQ: curl -i -X GET http://127.0.0.1:35357/08:43
kodokuHow I can force URL ?08:44
kodokuapi-paste.conf is obligatory ?08:48
*** ashleighfarnham has joined #openstack-trove09:18
*** ashleighfarnham has quit IRC09:23
*** tosky has joined #openstack-trove09:25
*** IanGovett has joined #openstack-trove09:48
*** jeraldv has quit IRC09:51
*** jeraldv has joined #openstack-trove09:52
*** jeraldv has joined #openstack-trove09:52
*** johnma has quit IRC09:56
*** IanGovett1 has joined #openstack-trove10:02
*** IanGovett has quit IRC10:05
*** johnma has joined #openstack-trove10:31
*** coolsvap is now known as coolsvap|afk10:43
*** sgotliv has quit IRC10:43
*** sgotliv has joined #openstack-trove10:50
*** johnma has quit IRC10:52
*** Longgeek has quit IRC10:58
*** Longgeek has joined #openstack-trove10:58
*** links has quit IRC11:31
*** links has joined #openstack-trove11:32
*** _crobertsrh is now known as crobertsrh11:39
*** danritchie has joined #openstack-trove11:52
*** openstackgerrit has quit IRC11:52
*** openstackgerrit has joined #openstack-trove11:52
vkmcguys, I have a question regarding auth11:56
*** danritchie has quit IRC11:56
vkmcin all our docs we specify keystone_authtoken with the tenant info11:57
vkmcand in the rest of the tenants I'm getting a 40111:58
vkmcwhat am I missing?11:58
*** hogepodge has quit IRC12:02
*** hogepodge has joined #openstack-trove12:05
*** kodoku has quit IRC12:11
*** kodoku has joined #openstack-trove12:12
kodokuWhere we can find doc for configuration of trove ?? Or any configuration for guest agent ?12:13
*** sgotliv has quit IRC12:20
vkmckodoku, you have the samples in https://github.com/openstack/trove/tree/master/etc/trove12:21
kodokuvkmc ok thx. This is possible to use postgresql on instance with juno ?12:24
*** bhunter71 has joined #openstack-trove12:24
*** amrith is now known as _amrith_12:25
kodokuvkmc It's hard to understand how trove works with sample. How I configure guest image ? Why trove need cinder ? Why need cloud-init ? How works the guest ? many questions .... :(12:29
vkmcso... first things first12:33
vkmchow did you deploy trove?12:33
vkmcwith distro? did you use an installer?12:33
kodokuvkmc I use RDO juno with packstack. I have full openstack plateform with designate but without swift. Now I want to add trove. But with postgresql backend for DB.12:35
kodokuI have a guest image RHEL7.1 with cloud-init and trove guest agent.12:35
vkmcso... unfortunately RDO Juno needs some hacks to get it going12:35
kodokuarf12:36
vkmcI'd totally advise you to upgrade to Kilo... if you can12:36
kodokuI have 2014.2.212:36
vkmcI can help you with those hacks though, but it will be painful heh12:36
kodokuOk but with mysql is easy ?12:36
vkmcmysql yes, postgresql... no12:36
*** vlbB1v has joined #openstack-trove12:36
*** zal-handler has joined #openstack-trove12:37
kodokuok I'll try with mysql on juno for understand trove, then when I migrate to kilo I'll try postgresql12:37
vkmcsure12:37
vkmcif you are trying to deploy it just to try it... I'd advise you to spin up a VM with Ubuntu 14.04 and use Redstack12:37
vkmcand you can use postgresql there12:37
kodokuI'am in POC now12:38
kodokuBut I have 30 users12:38
vkmcoh, so its not just to try it... you have a real deployment there12:39
kodokuPoc on JUNO, I migrate KILO soon (3-4 month)12:39
vkmck k12:39
kodokuyes12:39
vlbB1vkokoku how many user for trove?12:40
kodokuand I use a rhel system12:40
kodoku30 now and 100 in fex month12:40
kodokufew*12:40
kodokuI have 150-300 instances12:40
vlbB1vdokoku ok nice12:41
zal-handlerI also trying to provide postegresl with juno rdo12:41
kodokuzal-handler :)12:41
kodokuAnd I forget an important detail12:42
kodokuI use vmware backend for nova and cinder12:42
vlbB1vno kvm ??12:42
kodokuno :s12:42
*** kodoku_ has joined #openstack-trove12:44
kodoku_Can we use trove without KVM ?12:44
*** dencaval has joined #openstack-trove12:45
john_f_yes12:46
*** kodoku has quit IRC12:46
kodoku_ok12:47
*** john_f_ has quit IRC12:47
kodoku_I guess trove use cinder for make volume, so with Vmware backend, disk is no auto mount in instance. So trove can works if the volume is not auto mount ?12:48
*** sgotliv has joined #openstack-trove12:49
vlbB1vkokkudo ?12:49
*** john_f_ has joined #openstack-trove12:50
kodoku_that not me ^^12:51
*** masco has quit IRC12:52
kodoku_vkmc I guess I need to install mysql on my guest image ?12:57
vlbB1vkokodu girl?12:58
*** IanGovett1 has quit IRC12:58
*** IanGovett has joined #openstack-trove13:00
kodoku_vlbB1v why ?13:01
*** vlbB1v has quit IRC13:03
kodoku_ok ...13:03
*** IanGovett has quit IRC13:10
*** IanGovett has joined #openstack-trove13:13
vkmckodoku_, sorry13:14
vkmckodoku_, so, you have to ways to create an image13:14
vkmckodoku_, our you build an image manually, with the guestagent installed there and the database you want13:14
vkmckodoku_, or your use a cloudinit script13:15
vkmcsometimes cloudinit takes too much time and it fails to launch the instance, so the former is the most advisable13:15
vkmcits harder, though13:15
*** kodoku_ has quit IRC13:18
*** kodoku has joined #openstack-trove13:18
kodokuvkmc So When you say "the database you want" ==> yum install mysql-server13:19
*** david-lyle has quit IRC13:19
vkmckodoku, yeah13:19
vkmckodoku, and yum install openstack-trove-guestagent13:19
vkmckodoku, I have an script that uses diskimage-builder to build images13:20
kodokuvkmc ok. I have that. So I have conf guest with rabbitmq conf13:20
vkmckodoku, it currently supports centos, fedora and rhel13:20
vkmckodoku, check it out, maybe it eases the tasks a little13:20
kodokuvkmc I use .vmdk13:20
vkmchttps://github.com/vkmc/trove-image-elements13:20
vkmcoh I see13:20
vkmcyeah, that script will make qcow213:21
*** kodoku_ has joined #openstack-trove13:22
kodoku_vkmc ok So  I have image. When I try to start guest service it fail. Normal ?13:22
vkmcwell.. no13:23
vkmckodoku_, could you paste the logs?13:23
kodoku_Is not yet an openstack instance13:23
kodoku_ok13:23
kodoku_oslo.config.cfg.ConfigFilesNotFoundError: Failed to read some config files: /etc/guest_info13:23
kodoku_When I start in openstack, cloud-init (with user-data) create this file ?13:24
*** kodoku has quit IRC13:24
kodoku_because I have this file in /etc/trove13:24
*** openstackstatus has quit IRC13:25
vkmckodoku_, yeah, that's one of the hacks you have to do13:25
kodoku_And guest service search in /etc/.  And I don't find in guest.conf where I can conf this path13:25
vkmckodoku_, guestagent in Juno will expect to find guest_info and trove-guestagent.conf under /etc13:25
vkmckodoku_, and in RHEL they are under /etc/trove13:25
vkmcin Kilo that is configurable13:26
vkmckodoku_, a workaround is to place those files under /etc in the server13:26
kodoku_ok, need to copy file  or I can change path in trove conf ?13:26
kodoku_ok I copy13:26
vkmcand fix the .service file for the openstack-guestagent in the guest13:26
*** openstackstatus has joined #openstack-trove13:26
*** ChanServ sets mode: +v openstackstatus13:26
*** kodokuu has joined #openstack-trove13:27
kodokuuvkmc Ok but when service start ==> Process: 2885 ExecStart=/usr/bin/trove-guestagent --config-file /usr/share/trove/trove-dist.conf --config-file /etc/trove/trove-guestagent.conf --config-file /etc/guest_info13:28
kodokuujust change path of guest_info13:28
vkmcguest_info and trove-guestagent.conf13:28
kodokuuwhy ?13:29
kodokuu--config-file /etc/trove/trove-guestagent.conf is good ?13:29
vkmcbecause server code will look under /etc both files13:29
vkmcand will inject those files in the same location in the guest13:29
vkmcso if the service looks for the trove-guestagent.conf in the guest under /etc/trove, it will find the sample file and not the one injected by the server13:30
kodokuuI need to change /etc/systemd/system/multi-user.target.wants/openstack-trove-guestagent.service13:30
kodokuuthe server inject file in guest instance O_o13:30
*** kodoku_ has quit IRC13:30
kodokuuso no need to configure trove-guestagent.conf because trove change this file ?13:31
kodokuuok So I change ExecStart=/usr/bin/trove-guestagent --config-file /usr/share/trove/trove-dist.conf --config-file /etc/trove/trove-guestagent.conf --config-file /etc/guest_info   IN    ExecStart=/usr/bin/trove-guestagent --config-file /usr/share/trove/trove-dist.conf --config-file /etc/trove-guestagent.conf --config-file /etc/guest_info13:32
kodokuuvkmc and  ===>   cp /etc/trove/* /etc/13:32
vkmcsure, that would work too13:34
kodokuuvkmc And when I create instance in trove, with cloud-init , it change /etc/guest_info13:34
vkmcs/would/should13:34
kodokuuneed to "chkconfig mysqld on"  ?13:35
vkmcehm, cloud_init should be located somewhere else, if you are using cloud_init scripts for that13:35
vkmcif you are prebuilding the image you don't need cloud_init13:35
kodokuuok13:35
kodokuuHow trove change guest_info ?13:35
kodokuuwith rabbit ?13:36
*** chlong has joined #openstack-trove13:39
vkmckodokuu, yes :)13:39
kodokuuok new issue13:41
kodokuuvkmc but service start13:42
kodokuuvkmc http://pastebin.com/6uSxzb1913:42
kodokuuI think is normal13:42
vkmckodokuu, you are missing a conf in the taskmanager probably13:44
kodokuuI copy my conf13:44
vkmckodokuu, sure13:45
kodokuuhttp://paste.openstack.org/show/216179/13:45
kodokuuis my conf of guest13:46
vkmckodokuu, https://github.com/openstack/trove/blob/master/etc/trove/trove-taskmanager.conf.sample#L10313:46
kodokuuI copy my task manager conf13:49
kodokuuvkmc http://paste.openstack.org/show/216182/13:50
*** setmason has joined #openstack-trove13:52
kodokuuvkmc Before add my image in glance ==> guest-agent install, mysql-server install, Conf Of guest agent OK, chkconfig on for guest agent and mysqld13:54
kodokuuit's ok ?13:54
*** links has quit IRC13:54
*** IanGovett1 has joined #openstack-trove13:55
*** _amrith_ is now known as amrith13:56
*** IanGovett has quit IRC13:57
vkmckodokuu, is is yes13:58
vkmcit*13:58
*** zal-handler has quit IRC13:59
setmasonAny ideas how to prevent network overlaps/collisions between the trove network and the guest networks?14:10
kodokuuvkmc Is posible to disable volume support with trove ? My image have already space for base14:14
*** setmason has quit IRC14:16
*** masco has joined #openstack-trove14:29
*** johnma has joined #openstack-trove14:37
*** setmason has joined #openstack-trove14:39
*** masco has quit IRC14:40
kodokuuvkmc It's normal if flavor have generated ID, Trove can't read this ID ?14:42
kodokuu ValueError: invalid literal for int() with base 10: '62fa0dd3-1a6c-4fa6-89f6-c64e04c4dfb8'14:42
kodokuuok https://bugs.launchpad.net/trove/+bug/133385214:44
openstackLaunchpad bug 1333852 in Trove "Trove does not support flavor UUIDs" [Medium,Fix released] - Assigned to Adam Gandelman (gandelman-a)14:44
kodokuuno backport in juno...14:44
toskyit requires a db change, I guess it's the reason for the lack of backport14:45
*** radez_g0n3 is now known as radez14:45
*** sriram_tesora has joined #openstack-trove14:48
vkmckodokuu, yeah, that's another problem14:53
vkmckodokuu, you need to use int, not uuids for flavors14:53
vkmckodokuu, that fix haven't been backported to juno14:53
*** johnma has quit IRC14:57
*** mattgriffin has joined #openstack-trove14:59
*** pboros has joined #openstack-trove15:05
*** johnma has joined #openstack-trove15:07
*** jeraldv has quit IRC15:09
*** ashleighfarnham has joined #openstack-trove15:15
*** danritchie has joined #openstack-trove15:26
*** radez is now known as radez_g0n315:26
*** pboros has quit IRC15:42
*** kodokuu has quit IRC15:45
*** pboros has joined #openstack-trove15:49
*** shayneburgess has joined #openstack-trove15:58
*** amrith is now known as _amrith_16:13
*** shakamunyi has quit IRC16:29
*** IanGovett1 has quit IRC16:46
*** IanGovett has joined #openstack-trove16:48
*** eghobo has joined #openstack-trove16:51
*** sgotliv has quit IRC16:59
*** exploreshaifali has joined #openstack-trove17:00
pmalikOn the dangling mock project. I think we are having some misunderstanding here. The base class, of course, has to be changed on all test cases irrespective of if there are any additional changes or not. Only that way we can ensure no more leaked mocks are introduced in the future. We all agreed to approach the test suite module-by-module in the meeting. The Etherpad page where anybody could sign up for individual modules17:01
pmalik was set up and referenced in the original review, in other reviews (https://review.openstack.org/#/c/179372/) and finally in IRC. It did not receive much attention though... The modules without any additional changes should be easy quick merges accelerating adoption of the tool and minimizing delays due to merge conflicts with other incoming patch sets. I don't think this should be something git history would not handle.17:01
pmalik^^^^^^^ <SlickNik>, <edmondk>, <peterstac>, <sushilkm>, <vkmc>, <amrith>17:01
SlickNikpmalik: I'm not sure which discussion you're talking about but looking at the meeting notes from http://eavesdrop.openstack.org/meetings/trove/2015/trove.2015-04-22-18.01.log.html we agreed to do this for new unit tests, and that we don't need to concentrate on older unit tests unless something was actually broken.17:05
SlickNikrelevant discussion:17:06
SlickNik"18:34:08 <SlickNik> Frankly, I'm less excited about going back and fixing all of the 'orig=method  method=mock  method=orig' style used in the past.17:06
SlickNik18:34:26 <pmalik> https://pypi.python.org/pypi/mock17:06
SlickNik18:35:57 <SlickNik> Because it's unit tests that already work, and there is a lot of other feature work in Trove that could use effort.17:06
SlickNik18:36:36 <sushilkm> +117:06
SlickNik18:36:51 <sushilkm> there are better areas to use the effort17:06
SlickNik18:37:03 <pmalik> ok, so, you suggest using the proposed guideline for new ones only?17:06
SlickNik18:37:40 <dougshelley66> I tend to agree with SlickNik and sushilkm - we should fix the broken ones and move on. Establish the new standard going forward"17:06
sushilkmAlso, even if u want to fix the bugs why not do them in a one-off patch and why is it needed to push tons of reviews for the purpose, so that even if think to go ahead with them then also it would be lesser effort in terms of reviews+followups+conflicts(if any)17:12
edmondkall the reviews with just changing the base class could easily be a single review and it would also be easy to review because it's just mechanical17:13
*** eghobo_ has joined #openstack-trove17:15
*** eghobo has quit IRC17:16
*** IanGovett has quit IRC17:19
*** IanGovett has joined #openstack-trove17:23
*** radez_g0n3 is now known as radez17:24
peterstacedmondk: The only problem is that until you add the base class, you don't know the extent of the fix17:34
peterstacso there was no way to group all the modules that didn't need fixing together17:34
vgnbkrMy understanding is that the mock detector came out of the fact that we kept having to search for improperly mocked objects because they caused other tests to fail.  Petr's mock detector was to detect all such occurances so that they could be fixed.17:35
vgnbkrIn addition to that, there was discussion that there mere many cases where objects were being mocked improperly, but not dangling.  My understanding was that we agreed not to fix those cases.17:35
pmalik<SlickNik> AFAIK we agreed not to change the mocking style on existing mocks that are not reported as problems by the detector.17:35
edmondkI get after adding the base class you will see the issues. Still feel like the work is small enough to do many modules in one patch.17:37
*** _amrith_ is now known as amrith17:38
vgnbkredmondk, I assumed the point was that smaller patches allowed people to review a few and collectively get the changes through.  I know I don't want to go looking through 10's or 100's of modules, but I don't mind doing my share by reviewing a few.17:40
edmondkIf we all agree on this approach we can sign off on them quickly then17:40
edmondkI do prefer small patches most of the time but most of these seemed so mechanical that it could have been batched17:41
edmondkEither way we might as well just review through them because it takes longer to have this discussion17:41
*** anteaya has quit IRC17:45
*** cweid has joined #openstack-trove17:52
edmondkreviewing them all now17:52
SlickNikpmalik: Yes, however I don't see any dangling mock issues with a lot of changes pushed up eg. https://review.openstack.org/#/c/180730/1/trove/tests/unittests/router/test_router.py,cm, https://review.openstack.org/#/c/180773/1/trove/tests/unittests/datastore/base.py,cm, and https://review.openstack.org/#/c/180832/1/trove/tests/unittests/network/test_neutron_driver.py,cm 17:52
SlickNikThose just seem to be changing the base class and re-ordering imports, for one single module at a time. That just seems like a be a whole lot of noise in our commit logs. If we really want to do that, let's combine those into a single patchset, please?17:52
sushilkm+1 SlickNik, why would we want to have so many patches doing the same thing for different files, those can be easily clubbed to make the commit queue smaller17:55
edmondkon the flip side it's taking longer for us to discuss this trivial stuff then just go and review them :)17:56
edmondkthe work is done we should just review and move on17:56
edmondkefficiency is king17:57
*** masco has joined #openstack-trove18:03
*** dencaval has quit IRC18:10
*** saurabhs has joined #openstack-trove18:27
openstackgerritMerged openstack/trove-integration: Adds conf modifications for Vertica  https://review.openstack.org/17036218:39
*** masco has quit IRC18:40
*** exploreshaifali_ has joined #openstack-trove18:44
*** exploreshaifali has quit IRC18:46
*** dencaval has joined #openstack-trove18:54
*** johnma has quit IRC19:24
*** johnma has joined #openstack-trove19:24
*** nshah has left #openstack-trove19:37
*** dencaval has quit IRC20:03
*** ajutras has joined #openstack-trove20:03
*** Longgeek has quit IRC20:18
*** amrith is now known as _amrith_20:23
*** exploreshaifali_ has quit IRC20:26
*** pboros has quit IRC20:53
*** crobertsrh is now known as _crobertsrh20:57
*** exploreshaifali_ has joined #openstack-trove21:06
openstackgerritMerged openstack/trove: Added dangling mock detection to 'secgroups'  https://review.openstack.org/18080621:29
openstackgerritMerged openstack/trove: Added dangling mock detection to 'conductor'  https://review.openstack.org/18082821:30
openstackgerritMerged openstack/trove: Added dangling mock detection to 'taskmanager'  https://review.openstack.org/18079821:30
openstackgerritMerged openstack/trove: Added dangling mock detection to 'mgmt' module  https://review.openstack.org/18083121:30
*** IanGovett has quit IRC21:33
*** exploreshaifali_ has quit IRC21:35
openstackgerritMerged openstack/trove: Added dangling mock detection to 'cluster' module  https://review.openstack.org/18072021:36
*** ajutras has quit IRC21:36
*** david-lyle has joined #openstack-trove21:56
*** chlong has quit IRC21:59
*** johnma has quit IRC22:02
*** sriram_tesora has quit IRC22:10
*** mayurig has joined #openstack-trove22:25
*** eghobo_ has quit IRC22:27
*** mayurig has quit IRC22:27
*** sharikapongubala has joined #openstack-trove22:29
*** mayurig has joined #openstack-trove22:35
*** mayurig has quit IRC22:35
sharikapongubalahello, I can't update my contact information in review.openstack.org. Does anyone have any idea why it is not allowing me to change my info?22:35
*** david-lyle has quit IRC22:38
*** IanGovett has joined #openstack-trove22:39
*** tosky has quit IRC22:40
openstackgerritSharika Pongubala proposed openstack/trove-integration: Changes made to install additional debian packages for vertica management console  https://review.openstack.org/18118622:46
*** sharikapongubala has quit IRC22:52
setmasonIs there a way to prevent conflicts between the private TroveNetwork and a GuestNetwork?22:57
*** _amrith_ is now known as amrith23:10
*** chlong has joined #openstack-trove23:24
*** mattgriffin has quit IRC23:28
openstackgerritSharika Pongubala proposed openstack/trove-integration: To install additional debian packages  https://review.openstack.org/18118623:32
openstackgerritOpenStack Proposal Bot proposed openstack/python-troveclient: Updated from global requirements  https://review.openstack.org/18124123:37
openstackgerritOpenStack Proposal Bot proposed openstack/trove: Updated from global requirements  https://review.openstack.org/17987923:38
openstackgerritSharika Pongubala proposed openstack/trove-integration: To install additional debian packages  https://review.openstack.org/18118623:38
*** mattgriffin has joined #openstack-trove23:41
*** eghobo has joined #openstack-trove23:50
« Wednesday, 2015-05-06 Index Friday, 2015-05-08 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!